Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observe SDK: limit spans sent to sink #41

Open
3 tasks
nilslice opened this issue Jul 17, 2023 · 1 comment
Open
3 tasks

Observe SDK: limit spans sent to sink #41

nilslice opened this issue Jul 17, 2023 · 1 comment
Assignees

Comments

@nilslice
Copy link
Member

  • Go SDK
  • Rust SDK
  • JS SDK

The default should be applied similarly to each SDK, but have a method for configuring this at the SDK level.

For example, a possible approach is:

let mut trace_ctx = adapter.start(&mut linker, &data)?;
trace_ctx.set_trace_depth(4);

// OR.. avoiding mutability and any additional method surface area:

let config = TraceConfig {
   trace_depth: 4,
   ..default::Default(),
};
let trace_ctx = adapter.start(&mut linker, &data, &config)?;
@nilslice nilslice self-assigned this Jul 17, 2023
@neuronicnobody
Copy link

Goal is to reduce the depth of profiling. Solution may vary from what's defined here.

@wikiwong wikiwong changed the title Observe SDK: limit default recursion depth for spans Observe SDK: limit spans Aug 11, 2023
@wikiwong wikiwong changed the title Observe SDK: limit spans Observe SDK: limit spans sent to sink Aug 11, 2023
@wikiwong wikiwong assigned wikiwong and unassigned nilslice Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants