-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable non-blocking reads for streaming outputs #4755
Conversation
@branfosj do not merge yet, there is a minor issue to fix. Now the output looks like:
|
@branfosj if all test pas, this is ready. Now the debug logs are properly formatted:
|
badd1f6
to
95a41d6
Compare
On a side note, this PR also removes the following print message:
AFAICT this is a leftover from 4.9 that does not align with the behavior of |
…reads on input/output channels
This fixes an issue with EB5 on our cluster, running installs with
--logtostdout
hangs after executing/usr/share/lmod/lmod/libexec/lmod python --terse --show-hidden avail
in the early stages. However, same installs without--logtostdout
go fine. An manually executing thatlmod
command also works fine.Issue seems to be with long/slow commands in streaming mode. The reading action on the output hinders the completion of the command. This PR enables read in non-blocking mode to avoid this issue.
Changelog:
readline
: this does not change functionality as 128 bytes is a (longish) line and this improves readability of logs