-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Venafi CodeSign Protect #286
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Ivan Wallis <iwallis@gmail.com>
Thank you very much for the PR, I'll review it |
jsign-crypto/src/main/java/net/jsign/jca/VenafiCredentials.java
Outdated
Show resolved
Hide resolved
jsign-crypto/src/main/java/net/jsign/jca/VenafiSigningService.java
Outdated
Show resolved
Hide resolved
jsign-crypto/src/main/java/net/jsign/jca/VenafiSigningService.java
Outdated
Show resolved
Hide resolved
jsign-crypto/src/main/java/net/jsign/jca/VenafiSigningService.java
Outdated
Show resolved
Hide resolved
jsign-crypto/src/main/java/net/jsign/jca/VenafiSigningService.java
Outdated
Show resolved
Hide resolved
jsign-crypto/src/main/java/net/jsign/jca/VenafiSigningService.java
Outdated
Show resolved
Hide resolved
jsign-crypto/src/main/java/net/jsign/jca/VenafiSigningService.java
Outdated
Show resolved
Hide resolved
jsign-crypto/src/test/java/net/jsign/jca/VenafiSigningServiceTest.java
Outdated
Show resolved
Hide resolved
jsign-crypto/src/main/java/net/jsign/jca/VenafiSigningService.java
Outdated
Show resolved
Hide resolved
jsign-crypto/src/main/java/net/jsign/jca/VenafiSigningService.java
Outdated
Show resolved
Hide resolved
jsign-crypto/src/main/java/net/jsign/jca/VenafiSigningService.java
Outdated
Show resolved
Hide resolved
jsign-crypto/src/main/java/net/jsign/jca/VenafiSigningService.java
Outdated
Show resolved
Hide resolved
jsign-crypto/src/main/java/net/jsign/jca/VenafiSigningService.java
Outdated
Show resolved
Hide resolved
Thank you for the quick fixes, but I'm a bit concerned that it doesn't compile. Did you really test it against a real instance of Venafi CodeSign Protect? |
I just compiled and packaged and didn't run into any issues, and yes I'm testing in a local development environment against a test instance of Venafi. |
jsign-crypto/src/main/java/net/jsign/jca/VenafiSigningService.java
Outdated
Show resolved
Hide resolved
jsign-crypto/src/main/java/net/jsign/jca/VenafiSigningService.java
Outdated
Show resolved
Hide resolved
jsign-crypto/src/main/java/net/jsign/jca/VenafiSigningService.java
Outdated
Show resolved
Hide resolved
jsign-crypto/src/test/java/net/jsign/jca/VenafiSigningServiceTest.java
Outdated
Show resolved
Hide resolved
jsign-crypto/src/main/java/net/jsign/jca/VenafiSigningService.java
Outdated
Show resolved
Hide resolved
jsign-crypto/src/main/java/net/jsign/jca/VenafiSigningService.java
Outdated
Show resolved
Hide resolved
Thank you, there are still some changes necessary but I'll take care of them. Could you please provide the JSON response to the Ideally, if you could import the Jsign test keys and certificates in Venafi and use them to capture the API responses that would be awesome. The keys are in the test resources directory: RSA: https://github.com/ebourg/jsign/blob/master/jsign-core/src/test/resources/keystores/keystore.p12 The password is "password". |
Alternatively, do you think I could access a Venafi test environment? |
Here is the |
Let me know what else is missing or any other tests that need to be added and I'll get it done 😃 |
@ebourg just curious if there was anything missing or requires an update. |
This PR adds support for Venafi CodeSign Protect.