-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/authentication screens #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me ! Very clean code. Maybe a quick overview of testing would be beneficial to the team (mockK and compose tests)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, nice tests, the coverage is a bit weird but that's fine
This configures jacoco and sonar such that sonar finds the coverage reports from jacoco.
Those were issues raised by sonar cloud.
ee58187
to
d6b14d7
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good
This is based on the email-authentication feature. So, we need to make sure that the email-authentication feature is reviewed first and merged into main before this pull request. This closes #3