Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/authentication screens #10

Merged
merged 27 commits into from
Mar 28, 2024
Merged

Conversation

octogradiste
Copy link
Contributor

This is based on the email-authentication feature. So, we need to make sure that the email-authentication feature is reviewed first and merged into main before this pull request. This closes #3

@octogradiste octogradiste marked this pull request as ready for review March 26, 2024 22:20
@octogradiste octogradiste requested a review from Greenade March 26, 2024 22:20
Greenade
Greenade previously approved these changes Mar 27, 2024
Copy link
Contributor

@Greenade Greenade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! Very clean code. Maybe a quick overview of testing would be beneficial to the team (mockK and compose tests)

Greenade
Greenade previously approved these changes Mar 28, 2024
Copy link
Contributor

@Greenade Greenade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, nice tests, the coverage is a bit weird but that's fine

@octogradiste octogradiste force-pushed the feature/authentication-screens branch from ee58187 to d6b14d7 Compare March 28, 2024 19:52
Copy link

@octogradiste octogradiste requested a review from Greenade March 28, 2024 20:15
Copy link
Contributor

@Greenade Greenade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@violoncelloCH violoncelloCH merged commit 50a8c18 into main Mar 28, 2024
2 checks passed
@violoncelloCH violoncelloCH deleted the feature/authentication-screens branch March 28, 2024 21:19
@violoncelloCH violoncelloCH added this to the Milestone 1 milestone Apr 19, 2024
@octogradiste octogradiste self-assigned this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

authentication
3 participants