-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repository implementation #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b05670
to
a3ec094
Compare
Closed
b71db31
to
acf1b77
Compare
ab0a6cd
to
b389f44
Compare
5cbcf08
to
f61ecfe
Compare
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
1bb4af1
to
ed82023
Compare
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
User is a supabase auth entity and not in our custom table. For the UI all we need is UserProfile. To get the uuid of the currently logged in user, use the supabase library. Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
ed82023
to
9a9d2c6
Compare
unglazedstamp
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is very clean !
Thank you for implementing the repository !
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires #30 to be merged firstdoneThis implements a first version of the repository and a supabase connector.
In this first version, data is directly fetched from supabase. Caching will be implemented later, see #31 and #50.
There are also other changes we need to do to improve the datamodel and how to access data. For instance, getting an event is not yet working since we need to correctly fetch the associated tags: #68; or also: #67