Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repository implementation #32

Merged
merged 5 commits into from
Apr 12, 2024
Merged

Conversation

violoncelloCH
Copy link
Member

@violoncelloCH violoncelloCH commented Apr 2, 2024

requires #30 to be merged first done

This implements a first version of the repository and a supabase connector.
In this first version, data is directly fetched from supabase. Caching will be implemented later, see #31 and #50.
There are also other changes we need to do to improve the datamodel and how to access data. For instance, getting an event is not yet working since we need to correctly fetch the associated tags: #68; or also: #67

@violoncelloCH violoncelloCH self-assigned this Apr 2, 2024
@violoncelloCH violoncelloCH force-pushed the feature/repository-implementation branch from 3b05670 to a3ec094 Compare April 2, 2024 20:11
@violoncelloCH violoncelloCH mentioned this pull request Apr 2, 2024
@violoncelloCH violoncelloCH force-pushed the feature/repository-implementation branch 3 times, most recently from b71db31 to acf1b77 Compare April 10, 2024 13:58
@violoncelloCH violoncelloCH force-pushed the feature/repository-implementation branch 3 times, most recently from ab0a6cd to b389f44 Compare April 12, 2024 09:34
@violoncelloCH violoncelloCH force-pushed the feature/repository-implementation branch 3 times, most recently from 5cbcf08 to f61ecfe Compare April 12, 2024 10:19
@violoncelloCH violoncelloCH marked this pull request as ready for review April 12, 2024 10:20
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
@violoncelloCH violoncelloCH force-pushed the feature/repository-implementation branch 4 times, most recently from 1bb4af1 to ed82023 Compare April 12, 2024 11:37
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
User is a supabase auth entity and not in our custom table.
For the UI all we need is UserProfile.
To get the uuid of the currently logged in user, use the supabase library.

Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
@violoncelloCH violoncelloCH force-pushed the feature/repository-implementation branch from ed82023 to 9a9d2c6 Compare April 12, 2024 11:52
Copy link

@unglazedstamp unglazedstamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is very clean !
Thank you for implementing the repository !

Copy link

@violoncelloCH violoncelloCH merged commit 293f787 into main Apr 12, 2024
2 checks passed
@violoncelloCH violoncelloCH deleted the feature/repository-implementation branch April 12, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants