-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/search tag #41
Conversation
I think we need to discuss more in details how we will implement the tag hierarchy, and follow it for the implementation of this feature. Like if there is more than a number of tags from the same category, we could group them and display the parent tag. When the user click on this parent tag, the children would appear. I will clarify it with you tomorrow if it's not clear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's not a good idea to name the file Tags.kt, we already have a file named Tag to define the data class and moreover it's not truly indicative of what it encodes. MainscreenTagsFilter would be better for example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to remove everything that is commented. In order to merge the code into the main, the code should be clean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preview doesn't work because of the TagScreen which is not define. It's easier to review the code if we have a visualisation of the feature, if some modifications concerning the UI is necessary
f1e2a8e
to
fe2f56e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to remove the padding on the top of the items, it will be done after when we add the search tag to the scaffold
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect !
d8df06f
to
350117b
Compare
350117b
to
688f62c
Compare
|
This is the code for the UI of the tags. The tags will be rather personalized for each users depending on what activities they do.