Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created empty project with Android Studio #6

Merged
merged 10 commits into from
Mar 19, 2024
Merged

Created empty project with Android Studio #6

merged 10 commits into from
Mar 19, 2024

Conversation

octogradiste
Copy link
Contributor

No description provided.

@violoncelloCH violoncelloCH linked an issue Mar 18, 2024 that may be closed by this pull request
setup android project #2
Closed
@octogradiste octogradiste marked this pull request as ready for review March 19, 2024 08:25
@octogradiste
Copy link
Contributor Author

Note that the Sonar analysis fails because we have 0% code coverage. We will fix this (i.e. add tests) once we start coding new features...

@octogradiste
Copy link
Contributor Author

Note that this will fix #2

violoncelloCH
violoncelloCH previously approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@violoncelloCH violoncelloCH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me otherwise.
Only remark: this was quite huge to go through, so in my opinion it would have made sense to split it up in multiple PRs (basing the further ones on top of the first which creates the base structure).

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@octogradiste octogradiste merged commit 9fdb14e into main Mar 19, 2024
1 of 2 checks passed
@octogradiste octogradiste deleted the feature/project-setup branch March 19, 2024 10:53
@violoncelloCH violoncelloCH added this to the Milestone 1 milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@violoncelloCH violoncelloCH violoncelloCH approved these changes

Assignees

@octogradiste octogradiste

Labels
None yet
Projects
echo
Status: Done in sprint 1
Milestone
Milestone 1
Development

Successfully merging this pull request may close these issues.

setup android project
2 participants
@octogradiste @violoncelloCH