Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added StartTransientUnit API to BlueChi #1034

Merged

Conversation

engelmi
Copy link
Member

@engelmi engelmi commented Jan 29, 2025

Relates to: #1033

In order to provide a more complete set of systemd APIs through BlueChi the StartTransientUnit is being added. It also added a new integration test for the new API method.

@engelmi engelmi force-pushed the add-start-transient-unit-method branch 5 times, most recently from 12cd04f to f013f70 Compare January 29, 2025 08:52
Copy link
Contributor

@ArtiomDivak ArtiomDivak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Jan 29, 2025

Coverage Status

coverage: 82.251%. remained the same
when pulling 6009b80 on engelmi:add-start-transient-unit-method
into 76b3da6 on eclipse-bluechi:main.

@mkemel
Copy link
Member

mkemel commented Jan 29, 2025

Should we add this to bluechictl too?

@engelmi
Copy link
Member Author

engelmi commented Jan 29, 2025

Should we add this to bluechictl too?

Would be nice, but I skipped in on purpose as I think that it would be too complex to use.

Relates to: eclipse-bluechi#1033

In order to provide a more complete set of systemd APIs through BlueChi
the StartTransientUnit is being added. It also added a new integration
test for the new API method.

Signed-off-by: Michael Engel <mengel@redhat.com>
@engelmi engelmi force-pushed the add-start-transient-unit-method branch from f013f70 to 6009b80 Compare January 29, 2025 12:19
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelmi engelmi merged commit d394690 into eclipse-bluechi:main Jan 29, 2025
22 checks passed
@engelmi engelmi mentioned this pull request Jan 29, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants