Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added integration test for internal hello method #815

Merged

Conversation

engelmi
Copy link
Member

@engelmi engelmi commented Mar 8, 2024

Fixes: #798

Adding an integration test that verifies the internal API method 'Hello' works as expected.

@engelmi engelmi requested a review from mwperina March 8, 2024 15:47
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Mar 8, 2024

Coverage Status

Changes unknown
when pulling c477498 on engelmi:add-method-hello-integration-test
into ** on eclipse-bluechi:main**.

@mwperina mwperina force-pushed the add-method-hello-integration-test branch 3 times, most recently from a689239 to f0faa4a Compare March 8, 2024 20:36
Fixes: eclipse-bluechi#798

Adding an integration test that verifies the internal API
method 'Hello' works as expected.

Signed-off-by: Michael Engel <mengel@redhat.com>
@engelmi engelmi force-pushed the add-method-hello-integration-test branch from f0faa4a to c477498 Compare March 11, 2024 07:56
@mwperina
Copy link
Member

/packit retest-failed

@engelmi engelmi merged commit 49db3ae into eclipse-bluechi:main Mar 11, 2024
20 checks passed
@engelmi engelmi deleted the add-method-hello-integration-test branch June 17, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cover function method_peer_hello from libbluechi/bus/bus.c by tests
3 participants