Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context param attributes to @FacesConfig #5344

Merged

Conversation

BalusC
Copy link
Contributor

@BalusC BalusC commented Oct 28, 2023

Copy link
Contributor

@mnriem mnriem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

faces_issue_1416_add_context_param_attributes_to_FacesConfig
faces_issue_1416_add_context_param_attributes_to_FacesConfig
@BalusC
Copy link
Contributor Author

BalusC commented Feb 10, 2024

API part of original PR is split into jakartaee/faces#1879

Hmm ok and now build is failing because the dependent changes are still in a separate feature branch ...

Copy link
Contributor

@mnriem mnriem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BalusC added 3 commits March 2, 2024 09:54
faces_issue_1416_add_context_param_attributes_to_FacesConfig
faces_issue_1416_add_context_param_attributes_to_FacesConfig
faces_issue_1416_add_context_param_attributes_to_FacesConfig
@BalusC BalusC merged commit 6490bfe into master Mar 24, 2024
3 checks passed
@BalusC BalusC deleted the faces_issue_1416_add_context_param_attributes_to_FacesConfig branch April 11, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants