Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for invalid encoding when loading Aspect Model files #690

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

atextor
Copy link
Contributor

@atextor atextor commented Dec 10, 2024


Description

Check for correct encoding when loading Aspect Model files and indicate wrongly
encoded input

Fixes #689

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [-] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@atextor atextor merged commit aa29771 into eclipse-esmf:main Dec 11, 2024
4 checks passed
@atextor atextor deleted the 689-check-for-invalid-encoding branch December 11, 2024 06:45
Copy link

Release v2.9.9 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Validation of model with non-utf8 does not fail
2 participants