Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fluent builder API and custom AssertJ assertions #703

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Add fluent builder API and custom AssertJ assertions #703

merged 2 commits into from
Jan 31, 2025

Conversation

atextor
Copy link
Contributor

@atextor atextor commented Jan 29, 2025

Description

Adds fluent Aspect Model builder and custom AssertJ assertions.

Fixes #702

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Yauhenikapl
Yauhenikapl approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@Yauhenikapl Yauhenikapl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atextor atextor merged commit ec24c50 into eclipse-esmf:main Jan 31, 2025
4 checks passed
@atextor atextor deleted the 702-add-fluent-builder branch January 31, 2025 07:20
@atextor atextor mentioned this pull request Feb 5, 2025
Merged
7 tasks
@github-actions GitHub Actions
Copy link

Release v2.9.10 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yauhenikapl Yauhenikapl Yauhenikapl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Add fluent builder for Aspect Models and convenient tests
2 participants
@atextor @Yauhenikapl