-
Notifications
You must be signed in to change notification settings - Fork 5
Add the step5 text for new and noteworthy #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this.
Could you please add a line-break after each sentence as this reduces the git-diffs on future changes.
Also the very first sentence, currently seems to imply that, if one is not ask to create a N&N entry, that the change is not relevant. I think that should be formulated a bit differently.
Furthermore, at least for the TLPs there is no schema yet, how to add a contributors GH-profile, so I would not yet mention that.
Ok, I will do the changes. One question before : we have now markdown to write the N&N in TLP .. So why adding the link to the ghprofile would be complicated ? Do you mean there is no "field" for that in the template ? May be I can change the sentence to say that the goal is also to promote the contribution by adding a link to the GH profile ? |
It's not complicated. There is simply no template respectively no discussion and agreement about it. But I'll focus on getting that done in the next days so we hopefully have that soon. |
Reword Step 5 for clarity, add line breaks, and remove GitHub profile mention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the update.
But I think, the first sentence should still be adjusted to not give those a bad feeling that are not asked.
Relevant meant : if it has a value to mention the change .. it doesn't mean that the change was stupid :). this is a title change in a window, there will be probably no N&N ... I will change it to : In some cases, the committer may invite you to write a short description of your work for a New and Noteworthy entry. |
Change "relevan"t to "in some cases" to remove value judgement
Added a general sentence to remind to write a new and noteworthy