Skip to content

Update dev container image #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kaisalmen
Copy link
Contributor

@kaisalmen kaisalmen commented Apr 22, 2025

Fixes #119 The image was never build after the repo moved to eclipse-oct. I changed the name to oct-server-dev as well.

@kaisalmen kaisalmen force-pushed the kaisalmen/fix-dev-container branch from 13c2ab4 to 93dac91 Compare April 22, 2025 19:18
@kaisalmen kaisalmen changed the title WIP: Update dev container image Update dev container image Apr 22, 2025
@kaisalmen kaisalmen marked this pull request as ready for review April 22, 2025 19:20
@kaisalmen kaisalmen requested a review from Copilot April 22, 2025 19:21
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the container image configuration to use the new dev image "oct-server-dev" after the repository move to eclipse-oct.

  • Renamed the service, image, and container_name in docker-compose.yml.
  • Updated the container reference in the README.md documentation.
  • Modified the GitHub Actions workflow to use the new image name and updated action versions for improved stability.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
docker-compose.yml Updated service name, image, and container name to reflect the new dev container image.
README.md Revised documentation to reference "oct-server-dev" instead of "oct-server".
.github/workflows/images.yml Changed the IMAGE_NAME environment variable, job name, and updated/pinned action versions to align with the new image.

@kaisalmen
Copy link
Contributor Author

kaisalmen commented Apr 22, 2025

⬇️ there is something wrong with the eca infra. I can't login right now.

@kaisalmen kaisalmen requested a review from msujew April 22, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link in readme for oct-server image
1 participant