Help search: Make the number of max hits before filtering configurable #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the search of the help system, make the number of topics to be searched for before the filtering is applied configurable, so that it can be set in the "plugin_customization.ini" file. If the number is too small, hits may be missed, e.g. when searching in a topic and its subtopics. The higher the number, the slightly worse the performance. The default is 1,000 and the maximum number of hits displayed to the user is 500, which means that if more than 500 of the hits before filtering are outside of the search scope, some hits will be missed. See also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=357857
iloveeclipse
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the search of the help system, make the number of topics to be searched for before the filtering is applied configurable, so that it can be set in the
plugin_customization.inifile.If the number is too small, hits may be missed, e.g. when searching in a topic and its subtopics. The higher the number, the slightly worse the performance. The default is 1,000 and the maximum number of hits displayed to the user is 500, which means that if more than 500 of the hits before filtering are outside of the search scope, some hits will be missed.
See also: Eclipse Bug 357857 - [Help][Search] "Search selected topic and subtopics" sometimes shows "Nothing found" by mistake