Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build block user action (#472) #1743

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

haideryaqoob720
Copy link

@haideryaqoob720 haideryaqoob720 commented Feb 18, 2025

Problem

The Eclipse IDE has a bug where certain user actions (such as saving edits or interacting with version management) are blocked during the build process in the Eclipse IDE, even though they are not dependent on the ongoing compilation. The blocking behavior should be limited to actions that explicitly rely on the build process, such as Run and Debug.

Solution

To refine the selectivity of the blocking behavior, implementations have been made to the identifyThreadAction method within ThreadJob.java. The updated logic ensures that only jobs explicitly related to User actions (such as edit, save, rename or interacting with VCS and so on) are not blocked during the build process.

Changes Implemented

Implemented identifyThreadAction() to distinguish between build-dependent jobs and UI-related threads.
Make sure that user actions aren’t blocked by the build.
For more details, refer to the related bug report:
Eclipse Bug Report #329657
GitHub Eclipse Discussion

Demonstration

A short demo video showcasing the changes in action is available here: demo

Copy link
Member

@iloveeclipse iloveeclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please explain the problem and solution strategy in the PR description & commit message.
  2. Using job or thread names is a "NO GO", sorry. We can't make assumptions about job names. Either you use known job families or something else, but matching / guessing names is not acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants