Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use initialization-on-demand holder instead of double-checked locking #1746

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

howlger
Copy link
Contributor

@howlger howlger commented Feb 18, 2025

Use the initialization-on-demand holder idiom instead of the double-checked locking idiom as the first one is a bit faster and better to read.

See https://en.wikipedia.org/wiki/Initialization-on-demand_holder_idiom

Use the initialization-on-demand holder idiom instead of the
double-checked locking idiom as the first one is a bit faster and better
to read.

See https://en.wikipedia.org/wiki/Initialization-on-demand_holder_idiom
Copy link
Contributor

Test Results

1 214 files  +1 214  1 214 suites  +1 214   1h 4m 27s ⏱️ + 1h 4m 27s
4 174 tests +4 174  4 128 ✅ +4 128   46 💤 + 46  0 ❌ ±0 
9 541 runs  +9 541  9 420 ✅ +9 420  121 💤 +121  0 ❌ ±0 

Results for commit 5e7323d. ± Comparison against base commit 083f7af.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants