support workspace configurations #2701
Conversation
| @@ -0,0 +1,107 @@ | |||
| /******************************************************************************** | |||
| * Copyright (C) 2017 Ericsson and others. | |||
akosyakov
force-pushed
the
GH-1575
branch
3 times, most recently
from
266a16c to
c22cd84
Compare
akosyakov
changed the title
akosyakov
force-pushed
the
GH-1575
branch
4 times, most recently
from
93976fe to
dba4394
Compare
|
Please review, you can test it with JSON language, try to disable/enabled formatting via the preference widget and see whether you can format or not. Please consider the case with defaults settings, it should work as well. |
| if (this.toDispose.disposed) { | ||
| return; | ||
| } | ||
| this.providers.push(...providers); |
There was a problem hiding this comment.
Shouldn't we rather set a new array instead of mutating an existing one?
There was a problem hiding this comment.
when we will miss a schema based provider which is registered in postConstruct callback to provide default values
|
|
||
| @inject(PreferenceSchemaProvider) | ||
| protected readonly schema: PreferenceSchemaProvider; | ||
|
|
||
| @inject(PreferenceProviders) | ||
| protected readonly getPreferenceProvider: PreferenceProviders; |
There was a problem hiding this comment.
we should use the targetName annotation instead of the PreferenceProviders function.
There was a problem hiding this comment.
it is to overcome: inversify/InversifyJS#853
One cannot rebind named bindings.
There was a problem hiding this comment.
we cannot remove it also because we need to load providers lazily, injecting them breaks DI, i've added a comment
akosyakov
force-pushed
the
GH-1575
branch
3 times, most recently
from
9e303c7 to
33fd479
Compare
|
@svenefftinge I've addressed your comments, good to merge if green? |
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
|
Yes, please do. |
|
About the JSON preferences to control the language server setting, is there some documentation about what options are available? In particular, I'm interested about #1674, to see what happens with clangd in a gitpod container. |
| 'verbose' | ||
| ], | ||
| 'default': 'off', | ||
| 'description': 'Enable/disable default JSON formatter' |
There was a problem hiding this comment.
There is a copy paste error here.
There was a problem hiding this comment.
thanks for spotting, I've fixed it here: #2742
Fix #1575, fix #1674
TODO: