Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing Thing Model Helper #1254

Closed
danielpeintner opened this issue Mar 18, 2024 · 2 comments · Fixed by #1255
Closed

Failing Thing Model Helper #1254

danielpeintner opened this issue Mar 18, 2024 · 2 comments · Fixed by #1255

Comments

@danielpeintner
Copy link
Member

coming from #1253 but seems to be a general issue with the CI.

Somehow on the CI servers it reports 500 error instead of 404


   2 failing

  1) tests to verify the Thing Model Helper
       should fail on unavailable linked ThingModel - http:

      AssertionError: expected promise to be rejected with an error including 'http status code not 200 but 404 for …' but got 'http status code not 200 but 500 for …'
      + expected - actual

      -http status code not 200 but 500 for http://example.com/models/colored-lamp-1.0.0.tm.jsonld
      +http status code not 200 but 404 for http://example.com/models/colored-lamp-1.0.0.tm.jsonld
      
  

  2) tests to verify the Thing Model Helper
       should fail on unavailable linked ThingModel - https:

      AssertionError: expected promise to be rejected with an error including 'https status code not 200 but 404 for…' but got 'https status code not 200 but 500 for…'
      + expected - actual

      -https status code not 200 but 500 for https://example.com/models/colored-lamp-1.0.0.tm.jsonld
      +https status code not 200 but 404 for https://example.com/models/colored-lamp-1.0.0.tm.jsonld
@relu91
Copy link
Member

relu91 commented Mar 18, 2024

It seems that somebody registered the example.com domain and put a real server behind it. It could be that previously it would correctly answer 404 now for an unknown reason it fires a 500.

@danielpeintner
Copy link
Member Author

I tried with a REST client and it still fires 404 on my machine.. but it seems the CI setup does differently. Hence I would soften a bit the check as done in #1255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants