Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change test to accept any error code besides 404 #1255

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

danielpeintner
Copy link
Member

fixes #1254

@danielpeintner danielpeintner requested a review from relu91 as a code owner March 18, 2024 15:55
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.81%. Comparing base (0b7b108) to head (7f50687).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1255   +/-   ##
=======================================
  Coverage   77.81%   77.81%           
=======================================
  Files          84       84           
  Lines       17523    17523           
  Branches     1781     1781           
=======================================
  Hits        13635    13635           
  Misses       3853     3853           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable solid 👍🏻 .

@egekorkan egekorkan merged commit 1d2e67e into eclipse-thingweb:master Mar 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing Thing Model Helper
3 participants