-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix API documentation for readProperty #1345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would accept this small fix even if most of the content needs to be moved and fixed it is still correct and valuable.
It is fine by me also even if more work is needed. @BinkertR can you look into the Eclipse ECA issue.. you need to register and accept the Eclipse rules once |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1345 +/- ##
==========================================
- Coverage 78.58% 77.59% -0.99%
==========================================
Files 83 83
Lines 16588 16588
Branches 1612 1606 -6
==========================================
- Hits 13035 12872 -163
- Misses 3529 3686 +157
- Partials 24 30 +6 ☔ View full report in Codecov by Sentry. |
@danielpeintner @relu91 Roman has done the Eclipse account linking and I have revalidated that check. The macOS test is failing due to a pending test and I cannot restart it somehow? It should be still ok to merge this as it is just a readme fix. |
Strange, I cannot restart the CI pipeline either, but the change looks fine --> merging. Thanks @BinkertR |
fix the API description of how to read a property value.
As described in #1344