Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix API documentation for readProperty #1345

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

BinkertR
Copy link
Contributor

fix the API description of how to read a property value.
As described in #1344

@danielpeintner
Copy link
Member

Thanks @BinkertR for your work 👍

I would like to wait a bit since there are more things that are no longer correct and I suggest to clarify first what to do with this MD document as mentioned here.

Your opinion is welcome too!

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would accept this small fix even if most of the content needs to be moved and fixed it is still correct and valuable.

@danielpeintner
Copy link
Member

It is fine by me also even if more work is needed.

@BinkertR can you look into the Eclipse ECA issue.. you need to register and accept the Eclipse rules once
At the moment, your GitHub user isn't known to Eclipse
https://api.eclipse.org/git/eca/status/gh/eclipse-thingweb/node-wot/1345

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.59%. Comparing base (2b1e766) to head (4ef0143).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1345      +/-   ##
==========================================
- Coverage   78.58%   77.59%   -0.99%     
==========================================
  Files          83       83              
  Lines       16588    16588              
  Branches     1612     1606       -6     
==========================================
- Hits        13035    12872     -163     
- Misses       3529     3686     +157     
- Partials       24       30       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@egekorkan
Copy link
Member

@danielpeintner @relu91 Roman has done the Eclipse account linking and I have revalidated that check. The macOS test is failing due to a pending test and I cannot restart it somehow? It should be still ok to merge this as it is just a readme fix.

@danielpeintner
Copy link
Member

Strange, I cannot restart the CI pipeline either, but the change looks fine --> merging.

Thanks @BinkertR

@danielpeintner danielpeintner merged commit 39508bd into eclipse-thingweb:master Mar 5, 2025
9 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants