-
Notifications
You must be signed in to change notification settings - Fork 98
fix(Changelog.md): Fixed broken links #1246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, i think we missed some IDs and therefore the links look strange. We should definitely adapt this before merging this PR @jSchuetz88
src/pages/CHANGELOG.md
Outdated
@@ -137,7 +137,7 @@ Implemented features can be found [here](https://github.com/orgs/eclipse-tractus | |||
| [Identity and Access Management (IAM)](https://github.com/eclipse-tractusx/portal-iam) | centralidp: [4.0.0](https://github.com/eclipse-tractusx/portal-iam/releases/tag/centralidp-4.0.0)<br/>sharedidp: [4.0.0](https://github.com/eclipse-tractusx/portal-iam/releases/tag/sharedidp-4.0.0) | keycloak: [25.0.6](https://www.keycloak.org/docs/latest/release_notes/index.html#keycloak-25-0-0) | | |||
| [Industry Core KIT](https://eclipse-tractusx.github.io/docs-kits/category/industry-core-kit) | n/a | [1.3.0](https://eclipse-tractusx.github.io/docs-kits/kits/industry-core-kit/changelog) | | |||
| [Knowledge Agents](https://github.com/eclipse-tractusx/knowledge-agents) | remoting-agent: [1.14.24](https://github.com/eclipse-tractusx/knowledge-agents/releases/tag/remoting-agent-1.14.24)<br/>provisioning-agent: [1.14.24](https://github.com/eclipse-tractusx/knowledge-agents/releases/tag/provisioning-agent-1.14.24)<br/>conforming-agent: [1.14.24](https://github.com/eclipse-tractusx/knowledge-agents/releases/tag/conforming-agent-1.14.24)<br/>matchmaking-agent: [1.14.24](https://github.com/eclipse-tractusx/knowledge-agents/releases/tag/matchmaking-agent-1.14.24) | remoting-agent: [1.14.24](https://github.com/eclipse-tractusx/knowledge-agents/releases/tag/v1.14.24)<br/>provisioning-agent: [1.14.24](https://github.com/eclipse-tractusx/knowledge-agents/releases/tag/v1.14.24)<br/>conforming-agent: [1.14.24](https://github.com/eclipse-tractusx/knowledge-agents/releases/tag/v1.14.24)<br/>matchmaking-agent: [1.14.24](https://github.com/eclipse-tractusx/knowledge-agents/releases/tag/v1.14.24) | | |||
| [(Knowledge) Agents KIT](https://eclipse-tractusx.github.io/docs-kits/category/agents-kit) | n/a | [1.2.0](https://eclipse-tractusx.github.io/docs-kits/kits/knowledge-agents/Knowledge%20Agent%20Changelog) | | |||
| [(Knowledge) Agents KIT](https://eclipse-tractusx.github.io/docs-kits/next/category/knowledge-agents-kit) | n/a | [1.2.0](https://eclipse-tractusx.github.io/docs-kits/next/kits/knowledge-agents/Knowledge%20Agent%20Changelog#120---2024-07-29) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi think this is not correct. Even if @jSchuetz88 switched to the correct changelog id in #1247 , i think the kit foldername is still not knowledge-agents-kit. and in this case this link cant work.
@jSchuetz88 should we spend the time and also rename the kit.? Effort... yes ... but consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment should be resolved, we fixed the agents KIT name. Its knowledge-agents-kit now
src/pages/CHANGELOG.md
Outdated
| [Digital Product Pass (DPP)](https://github.com/eclipse-tractusx/digital-product-pass) | digital-product-pass: [3.0.0](https://github.com/eclipse-tractusx/digital-product-pass/releases/tag/digital-product-pass-3.0.0) | [v3.0.0](https://github.com/eclipse-tractusx/digital-product-pass/releases/tag/v3.0.0) | | ||
| [Digital Twin KIT](https://eclipse-tractusx.github.io/docs-kits/category/digital-twin-kit) | n/a | [2.0.0](https://eclipse-tractusx.github.io/docs-kits/kits/digital-twin-kit/changelog) | | ||
| [Digital Twin Registry](https://github.com/eclipse-tractusx/sldt-digital-twin-registry) | digital-twin-registry: [0.4.11](https://github.com/eclipse-tractusx/sldt-digital-twin-registry/releases/tag/digital-twin-registry-0.4.11) | [v0.4.3](https://github.com/eclipse-tractusx/sldt-digital-twin-registry/releases/tag/v0.4.3) | | ||
| [Discovery Finder](https://github.com/eclipse-tractusx/sldt-discovery-finder) | discoveryfinder: [0.2.5](https://github.com/eclipse-tractusx/sldt-discovery-finder/releases/tag/discoveryfinder-0.2.5) | [v0.3.1](https://github.com/eclipse-tractusx/sldt-discovery-finder/releases/tag/v0.3.1) | | ||
| [Discovery Service (BPN Finder)](https://github.com/eclipse-tractusx/sldt-bpn-discovery) | bpndiscovery: [0.2.6](https://github.com/eclipse-tractusx/sldt-bpn-discovery/releases/tag/bpndiscovery-0.2.6) | [0.3.1](https://github.com/eclipse-tractusx/sldt-bpn-discovery/releases/tag/v0.3.1) | | ||
| [Eclipse Data Space Connector (Tractus-X EDC)](https://github.com/eclipse-tractusx/tractusx-edc) | tractusx-connector: [0.7.1](https://github.com/eclipse-tractusx/tractusx-edc/releases/tag/0.7.1) | [0.7.1](https://github.com/eclipse-tractusx/tractusx-edc/releases/tag/0.7.1) | | ||
| [Eco Pass KIT](https://eclipse-tractusx.github.io/docs-kits/category/eco-pass-kit) | n/a | [1.4.0](https://eclipse-tractusx.github.io/docs-kits/kits/Eco_Pass_KIT/changelog) | | ||
| [Environmental and Social Standards (ESS) KIT](https://eclipse-tractusx.github.io/docs-kits/category/ess-kit) | n/a | [0.2.0](https://eclipse-tractusx.github.io/docs-kits/kits/ESS-Kit/ESS%20Kit%20Changelog) | | ||
| [Environmental and Social Standards (ESS) KIT](https://eclipse-tractusx.github.io/docs-kits/next/category/environmental-and-social-standards-kit) | n/a | [0.2.0](https://eclipse-tractusx.github.io/docs-kits/next/kits/environmental-and-social-standards-kit/ESS%20Kit%20Changelog#020---2024-05-23) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks not correct /ESS%20Kit%20Changelog
|
||
| [OSim KIT](https://eclipse-tractusx.github.io/docs-kits/next/category/online-simulation-kit) | n/a | [1.0.0](https://eclipse-tractusx.github.io/docs-kits/next/kits/online-simulation-kit/changelog#100---2023-08-18) | | ||
| [Product Carbon Footprint (PCF) KIT](https://eclipse-tractusx.github.io/docs-kits/next/category/product-carbon-footprint-exchange-kit) | n/a | [0.1.0](https://eclipse-tractusx.github.io/docs-kits/next/kits/product-carbon-footprint-exchange-kit/changelog#100---2024-03-08) | | ||
| [Behavioral Twin: Remaining useful Life (RUL) KIT](https://eclipse-tractusx.github.io/docs-kits/next/kits/behaviour-twin-kit/use-cases/rul/overview) | n/a | [0.1.1](https://eclipse-tractusx.github.io/docs-kits/kits/Behaviour%20Twin%20RuL%20Kit/Changelog%20Remaining%20Useful%20Life%20Kit) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks not correct
@@ -597,16 +586,15 @@ Tractus-X has switched to YY.0M.MICRO [Calendar Versioning](https://calver.org/) | |||
|
|||
| Component | Helm Chart (s) | App Version (s) | | |||
|:----------------------------------------------------------------------------------------------------------------------------------------|:------------------------------------------------------------------------------------------------------------------------:|:-----------------------------------------------------------------------------------------------------------------------------------:| | |||
| [Behavioral Twin: Remaining useful Life (RUL) KIT](https://eclipse-tractusx.github.io/docs-kits/category/remaining-useful-life-rul-kit) | n/a | [0.1.1](https://eclipse-tractusx.github.io/docs-kits/kits/Behaviour%20Twin%20RuL%20Kit/Changelog%20Remaining%20Useful%20Life%20Kit) | | |||
| [Behavioral Twin: Remaining useful Life (RUL) KIT](https://eclipse-tractusx.github.io/docs-kits/next/kits/behaviour-twin-kit/use-cases/rul/overview) | n/a | [0.1.1](https://eclipse-tractusx.github.io/docs-kits/kits/Behaviour%20Twin%20RuL%20Kit/Changelog%20Remaining%20Useful%20Life%20Kit) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks not correct
Co-authored-by: Johann Schütz <147107265+jSchuetz88@users.noreply.github.com>
Co-authored-by: Johann Schütz <147107265+jSchuetz88@users.noreply.github.com>
Co-authored-by: Johann Schütz <147107265+jSchuetz88@users.noreply.github.com>
Co-authored-by: Johann Schütz <147107265+jSchuetz88@users.noreply.github.com>
Co-authored-by: Johann Schütz <147107265+jSchuetz88@users.noreply.github.com>
Co-authored-by: Johann Schütz <147107265+jSchuetz88@users.noreply.github.com>
Co-authored-by: Johann Schütz <147107265+jSchuetz88@users.noreply.github.com>
Co-authored-by: Johann Schütz <147107265+jSchuetz88@users.noreply.github.com>
Co-authored-by: Johann Schütz <147107265+jSchuetz88@users.noreply.github.com>
Co-authored-by: Johann Schütz <147107265+jSchuetz88@users.noreply.github.com>
Co-authored-by: Johann Schütz <147107265+jSchuetz88@users.noreply.github.com>
@jSchuetz88 , @ther3sa is there a need to adapt something? |
What about the changelog in tractusx-release repository ⇾ I assume after the PR here is merged, we also have to adapt it? @ther3sa |
Description
Fixed broken links in the changelog, due to the update and renaming.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: