feat:filtering shells based on timestamp #506
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… based on timestamp
… based on timestamp
… based on timestamp
… based on timestamp
… based on timestamp
… based on timestamp
agg3fe
reviewed
Apr 23, 2025
...rc/main/java/org/eclipse/tractusx/semantics/registry/service/GranularShellAccessHandler.java
Show resolved
Hide resolved
agg3fe
reviewed
Apr 23, 2025
| shellRepository.getCreatedDateByIdExternal( cursorValue ).orElse( MINIMUM_SQL_DATETIME ) : | ||
| // If cursor is not available, use createdAfter date or fetch from repository | ||
| Optional.ofNullable( createdAfter ).map( OffsetDateTime::toInstant ) | ||
| .orElseGet( () -> shellRepository.getCreatedDateByIdExternal( cursorValue ).orElse( MINIMUM_SQL_DATETIME ) ); |
There was a problem hiding this comment.
The getCreatedDate() method will revert to the existing logic if the createdAfter parameter is null. This behavior aligns with the implementation that was in place prior to this change.
The getShellSearchCursor() method includes a fallback mechanism: if no cursor is provided (i.e., nextPageCursor is null or empty), it returns a default timestamp set to five years before the current date and time. This ensures that the search begins from a sufficiently early point when no cursor is available.
thomas-henn
reviewed
May 14, 2025
thomas-henn
reviewed
May 14, 2025
thomas-henn
reviewed
May 14, 2025
thomas-henn
reviewed
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to add timestamp-based filtering for shells and updates across multiple files to support this new feature. The most important changes include modifications to the
AssetAdministrationShellApiDelegate,ShellMapper,ShellAccessHandler, andShellServiceclasses.Timestamp-based filtering:
CHANGELOG.md: Added a note about filtering shells based on timestamp.backend/src/main/java/org/eclipse/tractusx/semantics/registry/controller/AssetAdministrationShellApiDelegate.java: AddedOffsetDateTimeparameter to methods for filtering shells based on creation time. [1] [2]Code updates for timestamp handling:
backend/src/main/java/org/eclipse/tractusx/semantics/registry/mapper/ShellMapper.java: Added methods to mapOffsetDateTimetoInstantand vice versa.backend/src/main/java/org/eclipse/tractusx/semantics/registry/service/ShellService.java: Updated methods to includecreatedAfterparameter for filtering shells and submodels. [1] [2]Specification updates:
backend/src/main/java/org/eclipse/tractusx/semantics/registry/service/DefaultShellAccessHandler.java: ModifiedshellFilterSpecificationto includecreatedAfterparameter.backend/src/main/java/org/eclipse/tractusx/semantics/registry/service/GranularShellAccessHandler.java: Added method to retrieve the created date for filtering and updatedshellFilterSpecificationto use this date.## Descriptionfiltering shells based on timestamp
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: