Fix up-cpp and add up-rust protection rules

[stevenhartley]

No description provided.

[eclipse-otterdog]

This is your friendly self-service bot. The author (stevenhartley) of this PR is associated with this organization in the role of MEMBER.

Additionally, stevenhartley is a member of the following teams:

• automotive-uprotocol-committers

• automotive-uprotocol-project-leads

[eclipse-otterdog]

This is your friendly self-service bot.
Please find below the validation of the requested configuration changes:

Diff for 14e3e9d

Organization automotive.uprotocol[id=eclipse-uprotocol]

  
!   branch_protection_rule[pattern="main", repository="up-cpp"] {
!     required_approving_review_count   = "2" -> "0"
!   }

+  add branch_protection_rule[pattern="main", repository="up-rust"] {
+    allows_deletions                  = false
+    allows_force_pushes               = false
+    blocks_creations                  = false
+    bypass_force_push_allowances      = []
+    bypass_pull_request_allowances    = []
+    dismisses_stale_reviews           = false
+    is_admin_enforced                 = false
+    lock_allows_fetch_and_merge       = false
+    lock_branch                       = false
+    pattern                           = "main"
+    require_last_push_approval        = false
+    required_approving_review_count   = "0"
+    required_status_checks            = [
+      "eclipse-eca-validation:eclipsefdn/eca"
+      "Lint"
+      "Test"
+      "Build documentation"
+    ],
+    requires_code_owner_reviews       = false
+    requires_commit_signatures        = false
+    requires_conversation_resolution  = false
+    requires_deployments              = false
+    requires_linear_history           = false
+    requires_pull_request             = true
+    requires_status_checks            = true
+    requires_strict_status_checks     = false
+    restricts_pushes                  = false
+    restricts_review_dismissals       = false
+  }
  
  Plan: 1 to add, 1 to change, 0 to delete.

Add a comment /help to get a list of available commands.

[eclipse-otterdog]

This is your friendly self-service bot. The current configuration is in-sync with the live settings. 🚀

[netomi]

I fixed the status checks by verifying it via the web ui.

For up-cpp I misses that you have a second job "ci" in the workflow, so the original name was correct.
For up-rust, I used the names of the jobs rather their id as names have precedence.

[eclipse-otterdog]

This is your friendly self-service bot.

The following changes have been successfully applied:

Organization automotive.uprotocol[id=eclipse-uprotocol]

  
!   branch_protection_rule[pattern="main", repository="up-cpp"] {
!     required_approving_review_count   = "2" -> "0"
!   }

+  add branch_protection_rule[pattern="main", repository="up-rust"] {
+    allows_deletions                  = false
+    allows_force_pushes               = false
+    blocks_creations                  = false
+    bypass_force_push_allowances      = []
+    bypass_pull_request_allowances    = []
+    dismisses_stale_reviews           = false
+    is_admin_enforced                 = false
+    lock_allows_fetch_and_merge       = false
+    lock_branch                       = false
+    pattern                           = "main"
+    require_last_push_approval        = false
+    required_approving_review_count   = "0"
+    required_status_checks            = [
+      "eclipse-eca-validation:eclipsefdn/eca"
+      "Lint"
+      "Test"
+      "Build documentation"
+    ],
+    requires_code_owner_reviews       = false
+    requires_commit_signatures        = false
+    requires_conversation_resolution  = false
+    requires_deployments              = false
+    requires_linear_history           = false
+    requires_pull_request             = true
+    requires_status_checks            = true
+    requires_strict_status_checks     = false
+    restricts_pushes                  = false
+    restricts_review_dismissals       = false
+  }

  
  Applying changes:


  Done.
  
  Executed plan: 1 added, 1 changed, 0 deleted.

[stevenhartley]

@netomi it doesn't seem to be working still, it is waiting for ci output but not able to get it: eclipse-uprotocol/up-cpp#57

[stevenhartley]

@netomi is the issue the name "ci" vs "CI"?

[netomi]

omg, its late, and I missed that the job has a name:

ci:
    name: CI status checks

will fix it.

[netomi]

when a job has been given a name, you have to use that, blame GitHub not me :-D

[netomi]

btw. there is now a more dynamic dashboard at https://otterdog.eclipse.org/index where you can see your current configuration.

[stevenhartley]

@netomi interesting that 2fa is not turned on. I'll have to dig through my emails to check why not.

[netomi]

there are still 2 people in your organization that have not enabled 2FA yet. So if 2FA would be enforced, they would be removed from the org. My colleague Mikael sent out an email to the committers mailinglist outlining the schedule to enforce 2FA: https://www.eclipse.org/lists/eclipse.org-committers/msg01412.html