Skip to content

Commit

Permalink
Update include/up-cpp/utils/CallbackConnection.h
Browse files Browse the repository at this point in the history
Co-authored-by: Pete LeVasseur <plevasseur@gmail.com>
  • Loading branch information
lukas-he and PLeVasseur authored Feb 13, 2025
1 parent 2fcb07f commit 2f81310
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion include/up-cpp/utils/CallbackConnection.h
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ struct BadConnection : public std::runtime_error {
/// A std::function can be empty. When an empty function is invoked, it will
/// throw std::bad_function_call. We can check earlier by casting the function
/// to a boolean. If the check fails, EmptyFunctionObject is thrown. This makes
/// the error appear earlier without waiting for invokation to occur.
/// the error appear earlier without waiting for invocation to occur.
struct EmptyFunctionObject : public std::invalid_argument {
template <typename... Args>
EmptyFunctionObject(Args&&... args)

Check warning on line 245 in include/up-cpp/utils/CallbackConnection.h

View workflow job for this annotation

GitHub Actions / Lint C++ sources

include/up-cpp/utils/CallbackConnection.h:245:2 [google-explicit-constructor]

constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions
Expand Down

0 comments on commit 2f81310

Please sign in to comment.