Skip to content

Commit

Permalink
Remove --file flag from CI mvn commands
Browse files Browse the repository at this point in the history
Applying suggestions from review.

This parameter should not be needed when pom.xml is in the current directory.

Co-authored-by: Steven Hartley <steven@orangepeel.ca>
  • Loading branch information
gregmedd and stevenhartley authored May 24, 2024
1 parent 25731fa commit 8321686
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-github-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
run: mvn -B package --file up-core-api/pom.xml

- name: Publish maven package to GitHub Packages
run: mvn deploy -s $GITHUB_WORKSPACE/settings.xml --file pom.xml
run: mvn deploy -s $GITHUB_WORKSPACE/settings.xml
env:
# GITHUB_TOKEN: ${{ github.token }}
GITHUB_TOKEN: ${{ secrets.PKG_PUSH_TOKEN }}
2 changes: 1 addition & 1 deletion .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ jobs:
distribution: 'temurin'
cache: maven
- name: Build and Test with Maven
run: mvn -B package --file pom.xml
run: mvn -B package
2 changes: 1 addition & 1 deletion .github/workflows/build_deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
gpg-passphrase: GPG_PASSPHRASE

- name: Build and Publish to Apache Maven Central
run: mvn clean deploy --file pom.xml
run: mvn clean deploy
env:
OSSRH_USER: ${{ secrets.ORG_OSSRH_USERNAME }}
OSSRH_PASSWORD: ${{ secrets.ORG_OSSRH_PASSWORD }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:

- name: Stage to Nexus and Release to Maven central
run: |
mvn -B release:clean release:prepare -P release release:perform --file pom.xml
mvn -B release:clean release:prepare -P release release:perform
env:
OSSRH_USER: ${{ secrets.ORG_OSSRH_USERNAME }}
OSSRH_PASSWORD: ${{ secrets.ORG_OSSRH_PASSWORD }}
Expand All @@ -44,7 +44,7 @@ jobs:

- if: cancelled() || failure()
run: |
mvn -B release:rollback --file pom.xml
mvn -B release:rollback
env:
GH_TOKEN: ${{ secrets.BOT_GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.BOT_GITHUB_TOKEN }}

0 comments on commit 8321686

Please sign in to comment.