-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First rewrite of the uSubscription spec #238
Conversation
@AnotherDaniel are you still working on this? IMHO it would be great, if these changes could make it into 1.6.0 ... |
Yes, still on it, or rather back on it after many weeks of "distractions"... let me see where I've left this... |
d1f4216
to
01fb8ff
Compare
@AnotherDaniel it is very, very hard to keep track of the changes when you force push changes, because it removes all of my original comments from the diff view :-( |
Sorry for that - I rebased on current main, didn't realise that would break the diff view. Won't do that again. Essentially, I accepted all your suggestions, plus I pulled in new requirements to cover all methods from the usubscription.proto definition, new ones to be found in the "Subscription" and "Reset" sections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made some comments on the Subscribe
operation which should also apply to the other operations accordingly.
In general, the spec item IDs should probably better contain usubscription
instead of usubscribe
, e.g. dsn~usubscription-...
instead of dsn~usubscribe-...
.
Let me know if you're reasonably happy with this iteration, then I'll squash the commits to prep for merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still do not see any value in splitting up the different types of invalid topic UUris ... my proposal could be applied to all operation specs.
But if you feel that this is necessary, then please go ahead and merge.
424e762
to
6b8c38b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A number of comments.
Many small and medium changes to address review feedback. Pls have another look @stevenhartley and @sophokles73 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@stevenhartley would you mind taking another look? Your approval is required before we can merge this PR ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnotherDaniel , I don't understand why the sequence diagrams shows another lifeline for the SubscriptionChange, this notification is sent to the uApp so it is clearer if you show a different line type to mean notification vs RPC as it is a message sent to uApp (per the old diagrams). Also the colors are hard to see in dark mode (the lines are grey), I think you can set the line color to be black.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also rebase as you seem to have accidentally pulled in other things on main on this PR
Pull notification fixes into every diagram
5672d47
to
0e3f4f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last comment @AnotherDaniel , can you add a legend that explains the arrows (ex. this is a RPC request vs response, vs publish, vs notification)? Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your patience @AnotherDaniel
Yay, this was a long time coming! ;-) |
Restructuring and partial rewrite of this spec; specific focus on: