Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align CI with up-cpp CI #113

Merged

Conversation

lukas-he
Copy link
Contributor

Aligning the CI with that from up-cpp. Inlude the Valgrind checks, conan profile and pinning of the version. Issue 80

@PLeVasseur
Copy link

This looks to pass! I'll defer to @gregmedd to see if he has any feedback this week. If not, I'll go ahead and review and merge later in the week.

@PLeVasseur
Copy link

If not, I'll go ahead and review and merge later in the week.

I will go ahead and review when this is updated like mentioned in here.

I suggest we go with your suggestion of pinning the Ubuntu 22.04 image in CI and using clang-tidy-12 for now.

@lukas-he
Copy link
Contributor Author

lukas-he commented Feb 27, 2025

I will go ahead and review when this is updated like mentioned in here.

Did that and it passed here.

Copy link

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks to pass. Thanks for your help aligning!

@PLeVasseur PLeVasseur merged commit 85a57d7 into eclipse-uprotocol:main Mar 3, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants