Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove k3d and dapr #122

Merged
merged 15 commits into from
Mar 22, 2024
Merged

Remove k3d and dapr #122

merged 15 commits into from
Mar 22, 2024

Conversation

BjoernAtBosch
Copy link
Member

Describe your changes

Issue ticket number and link

#121

Checklist - Manual tasks

  • Examples are executing successfully
  • Created/updated unit tests. Code Coverage percentage on new code shall be >= 80%.
  • Created/updated integration tests.
  • Devcontainer can be opened successfully
  • Devcontainer can be opened successfully behind a corporate proxy
  • Devcontainer can be re-built successfully
  • Extended the documentation (e.g. README.md, CONTRIBUTING.md, Velocitas)

@BjoernAtBosch BjoernAtBosch marked this pull request as ready for review March 22, 2024 10:49
MP91
MP91 approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@MP91 MP91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BjoernAtBosch BjoernAtBosch merged commit ffc8b95 into main Mar 22, 2024
8 checks passed
@BjoernAtBosch BjoernAtBosch deleted the remove_k3d_and_dapr branch March 22, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MP91 MP91 MP91 approved these changes

@doosuu doosuu Awaiting requested review from doosuu

@dennismeister93 dennismeister93 Awaiting requested review from dennismeister93

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BjoernAtBosch @MP91