From df4e60f84c040ec66985f0a40355739ff4c61ed4 Mon Sep 17 00:00:00 2001
From: Fredrik <fohlsso2@gmail.com>
Date: Wed, 20 Jun 2018 21:37:33 +0200
Subject: [PATCH 001/160] finally merged my local hack with the real thing

---
 README.md |  8 +++++++
 report.sh | 66 +++++++++++++++++++++++++++++++++++++++++++++----------
 2 files changed, 62 insertions(+), 12 deletions(-)

diff --git a/README.md b/README.md
index b2a81ab..ca82743 100644
--- a/README.md
+++ b/README.md
@@ -2,6 +2,8 @@
 Original script by joeschmuck, modified by Bidelu0hm, then by melp
 
 Preview of the output here: http://i.imgur.com/t9Mtqyt.png
+or when a resilver is in progress: https://i.imgur.com/CUNUZ7r.png
+
 
 **At a minimum, you will need to enter your email address in user-definable parameter section.** Feel free to edit other user parameters as needed.
 
@@ -9,6 +11,12 @@ Preview of the output here: http://i.imgur.com/t9Mtqyt.png
 
 **Changelog:**
 
+- fixed the broken border on zpool status summary header
+- in statusOutput changed grep to scrub: instead of scrub
+- added elif for resilvered/resilver in progress and scrub in progress with (hopefully) som useful info fields
+- changed the email subject to include hostname and date & time
+
+
 *v1.3:*
 - Added scrub duration column
 - Fixed for FreeNAS 11.1 (thanks reven!)
diff --git a/report.sh b/report.sh
index f25c490..1266d93 100644
--- a/report.sh
+++ b/report.sh
@@ -8,6 +8,14 @@
 
 ### Version: v1.3
 ### Changelog:
+# v1.?
+#   - fixed the broken border on zpool status summary header
+#   - in statusOutput changed grep to scrub: instead of scrub
+#   - added elif for resilvered/resilver in progress and scrub in progress with (hopefully) som useful info fields
+#   - changed the email subject to include hostname and date & time
+#   - 
+#   - 
+#   - 
 # v1.3:
 #   - Added scrub duration column
 #   - Fixed for FreeNAS 11.1 (thanks reven!)
@@ -70,7 +78,7 @@ backupLocation="/path/to/config/backup"   # Directory in which to save FreeNAS c
 ###### Auto-generated Parameters
 host=$(hostname -s)
 logfile="/tmp/smart_report.tmp"
-subject="Status Report and Configuration Backup for ${host}"
+subject="[${host}] Status Report and Configuration Backup $(date "+%Y-%m-%d %H:%M")"
 boundary="gc0p4Jq0M2Yt08jU534c0p"
 if [ "$includeSSD" == "true" ]; then
     drives=$(for drive in $(sysctl -n kern.disks); do
@@ -158,7 +166,7 @@ fi
     # Write HTML table headers to log file; HTML in an email requires 100% in-line styling (no CSS or <style> section), hence the massive tags
     echo "<br><br>"
     echo "<table style=\"border: 1px solid black; border-collapse: collapse;\">"
-    echo "<tr><th colspan=\"9\" style=\"text-align:center; font-size:20px; height:40px; font-family:courier;\">ZPool Status Report Summary</th></tr>"
+    echo "<tr><th colspan=\"10\" style=\"text-align:center; font-size:20px; height:40px; font-family:courier;\">ZPool Status Report Summary</th></tr>"
     echo "<tr>"
     echo "  <th style=\"text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Pool<br>Name</th>"
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Status</th>"
@@ -213,26 +221,60 @@ for pool in $pools; do
     scrubErrors="N/A"
     scrubAge="N/A"
     scrubTime="N/A"
+    resilver=""
+
     statusOutput="$(zpool status "$pool")"
-    if [ "$(echo "$statusOutput" | grep "scan" | awk '{print $2}')" = "scrub" ]; then
-        scrubRepBytes="$(echo "$statusOutput" | grep "scan" | awk '{print $4}')"
-        scrubErrors="$(echo "$statusOutput" | grep "scan" | awk '{print $10}')"
+    # normal status i.e. scrub
+    if [ "$(echo "$statusOutput" | grep "scan:" | awk '{print $2}')" = "scrub" ]; then
+        scrubRepBytes="$(echo "$statusOutput" | grep "scan:" | awk '{print $4}')"
+        scrubErrors="$(echo "$statusOutput" | grep "scan:" | awk '{print $10}')"
         # Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
-        scrubDate="$(echo "$statusOutput" | grep "scan" | awk '{print $17"-"$14"-"$15"_"$16}')"
+        scrubDate="$(echo "$statusOutput" | grep "scan:" | awk '{print $17"-"$14"-"$15"_"$16}')"
         scrubTS="$(date -j -f "%Y-%b-%e_%H:%M:%S" "$scrubDate" "+%s")"
         currentTS="$(date "+%s")"
         scrubAge=$((((currentTS - scrubTS) + 43200) / 86400))
-        scrubTime="$(echo "$statusOutput" | grep "scan" | awk '{print $8}')"
-    fi
+        scrubTime="$(echo "$statusOutput" | grep "scan:" | awk '{print $8}')"
+
+    # if status is resilvered
+    elif [ "$(echo "$statusOutput" | grep "scan:" | awk '{print $2}')" = "resilvered" ]; then
+            resilver="<BR>Resilvered"
+            scrubRepBytes="$(echo "$statusOutput" | grep "scan:" | awk '{print $3}')"
+            scrubErrors="$(echo "$statusOutput" | grep "scan:" | awk '{print $9}')"
+            # Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
+            scrubDate="$(echo "$statusOutput" | grep "scan:" | awk '{print $16"-"$13"-"$14"_"$15}')"
+            scrubTS="$(date -j -f "%Y-%b-%e_%H:%M:%S" "$scrubDate" "+%s")"
+            currentTS="$(date "+%s")"
+            scrubAge=$((((currentTS - scrubTS) + 43200) / 86400))
+            scrubTime="$(echo "$statusOutput" | grep "scan:" | awk '{print $7}')"
+
+    # Check if resilver is in progress
+    elif [ "$(echo "$statusOutput"| grep "scan:" | awk '{print $2}')" = "resilver" ]; then
+        scrubRepBytes="Resilver In Progress"
+        scrubAge="$(echo "$statusOutput" | grep "resilvered," | awk '{print $3" done"}')"
+        if [ "$(echo "$statusOutput" | grep "resilvered," | awk '{print $5}')" = "0" ]; then
+            scrubTime="$(echo "$statusOutput" | grep "resilvered," | awk '{print $7"<br>to go"}')"
+        else
+            scrubTime="$(echo "$statusOutput" | grep "resilvered," | awk '{print $5" "$6" "$7"<br>to go"}')"
+        fi
+
     # Check if scrub is in progress
-    if [ "$(echo "$statusOutput"| grep "scan" | awk '{print $4}')" = "progress" ]; then
-        scrubAge="In Progress"
-    fi
-    # Set row's background color; alternates between white and $altColor (light gray)
+    elif [ "$(echo "$statusOutput"| grep "scan:" | awk '{print $4}')" = "progress" ]; then
+        scrubRepBytes="Scrub In Progress"
+        scrubErrors="$(echo "$statusOutput" | grep "repaired," | awk '{print $1" repaired"}')"
+        scrubAge="$(echo "$statusOutput" | grep "repaired," | awk '{print $3" done"}')"
+     #   if [ "$(echo "$statusOutput" | grep "scanned out of" | awk '{print $8}')" = "0" ]; then
+            scrubTime="$(echo "$statusOutput" | grep "scanned out of" | awk '{print $8"<br>to go"}')"
+    #    else
+     #       scrubTime="$(echo "$statusOutput" | grep "scanned out of" | awk '{print $5" "$6" "$7"<br>to go"}')"
+      #  fi
+fi
+
+   # Set row's background color; alternates between white and $altColor (light gray)
     if [ $((poolNum % 2)) == 1 ]; then bgColor="#ffffff"; else bgColor="$altColor"; fi
     poolNum=$((poolNum + 1))
     # Set up conditions for warning or critical colors to be used in place of standard background colors
     if [ "$status" != "ONLINE" ]; then statusColor="$warnColor"; else statusColor="$bgColor"; fi
+    status+="$resilver"
     if [ "$readErrors" != "0" ]; then readErrorsColor="$warnColor"; else readErrorsColor="$bgColor"; fi
     if [ "$writeErrors" != "0" ]; then writeErrorsColor="$warnColor"; else writeErrorsColor="$bgColor"; fi
     if [ "$cksumErrors" != "0" ]; then cksumErrorsColor="$warnColor"; else cksumErrorsColor="$bgColor"; fi

From edf38189d64a925294f8761603ddef3135ca6b5f Mon Sep 17 00:00:00 2001
From: Fredrik <fohlsso2@gmail.com>
Date: Wed, 20 Jun 2018 21:37:33 +0200
Subject: [PATCH 002/160] finally merged my local hack with the real thing

---
 README.md |  9 ++++++++
 report.sh | 66 +++++++++++++++++++++++++++++++++++++++++++++----------
 2 files changed, 63 insertions(+), 12 deletions(-)

diff --git a/README.md b/README.md
index b2a81ab..0fa32d5 100644
--- a/README.md
+++ b/README.md
@@ -2,6 +2,8 @@
 Original script by joeschmuck, modified by Bidelu0hm, then by melp
 
 Preview of the output here: http://i.imgur.com/t9Mtqyt.png
+or when a resilver is in progress: https://i.imgur.com/CUNUZ7r.png
+
 
 **At a minimum, you will need to enter your email address in user-definable parameter section.** Feel free to edit other user parameters as needed.
 
@@ -9,6 +11,13 @@ Preview of the output here: http://i.imgur.com/t9Mtqyt.png
 
 **Changelog:**
 
+v1.3b
+- fixed the broken border on zpool status summary header
+- in statusOutput changed grep to scrub: instead of scrub
+- added elif for resilvered/resilver in progress and scrub in progress with (hopefully) som useful info fields
+- changed the email subject to include hostname and date & time
+
+
 *v1.3:*
 - Added scrub duration column
 - Fixed for FreeNAS 11.1 (thanks reven!)
diff --git a/report.sh b/report.sh
index f25c490..1266d93 100644
--- a/report.sh
+++ b/report.sh
@@ -8,6 +8,14 @@
 
 ### Version: v1.3
 ### Changelog:
+# v1.?
+#   - fixed the broken border on zpool status summary header
+#   - in statusOutput changed grep to scrub: instead of scrub
+#   - added elif for resilvered/resilver in progress and scrub in progress with (hopefully) som useful info fields
+#   - changed the email subject to include hostname and date & time
+#   - 
+#   - 
+#   - 
 # v1.3:
 #   - Added scrub duration column
 #   - Fixed for FreeNAS 11.1 (thanks reven!)
@@ -70,7 +78,7 @@ backupLocation="/path/to/config/backup"   # Directory in which to save FreeNAS c
 ###### Auto-generated Parameters
 host=$(hostname -s)
 logfile="/tmp/smart_report.tmp"
-subject="Status Report and Configuration Backup for ${host}"
+subject="[${host}] Status Report and Configuration Backup $(date "+%Y-%m-%d %H:%M")"
 boundary="gc0p4Jq0M2Yt08jU534c0p"
 if [ "$includeSSD" == "true" ]; then
     drives=$(for drive in $(sysctl -n kern.disks); do
@@ -158,7 +166,7 @@ fi
     # Write HTML table headers to log file; HTML in an email requires 100% in-line styling (no CSS or <style> section), hence the massive tags
     echo "<br><br>"
     echo "<table style=\"border: 1px solid black; border-collapse: collapse;\">"
-    echo "<tr><th colspan=\"9\" style=\"text-align:center; font-size:20px; height:40px; font-family:courier;\">ZPool Status Report Summary</th></tr>"
+    echo "<tr><th colspan=\"10\" style=\"text-align:center; font-size:20px; height:40px; font-family:courier;\">ZPool Status Report Summary</th></tr>"
     echo "<tr>"
     echo "  <th style=\"text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Pool<br>Name</th>"
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Status</th>"
@@ -213,26 +221,60 @@ for pool in $pools; do
     scrubErrors="N/A"
     scrubAge="N/A"
     scrubTime="N/A"
+    resilver=""
+
     statusOutput="$(zpool status "$pool")"
-    if [ "$(echo "$statusOutput" | grep "scan" | awk '{print $2}')" = "scrub" ]; then
-        scrubRepBytes="$(echo "$statusOutput" | grep "scan" | awk '{print $4}')"
-        scrubErrors="$(echo "$statusOutput" | grep "scan" | awk '{print $10}')"
+    # normal status i.e. scrub
+    if [ "$(echo "$statusOutput" | grep "scan:" | awk '{print $2}')" = "scrub" ]; then
+        scrubRepBytes="$(echo "$statusOutput" | grep "scan:" | awk '{print $4}')"
+        scrubErrors="$(echo "$statusOutput" | grep "scan:" | awk '{print $10}')"
         # Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
-        scrubDate="$(echo "$statusOutput" | grep "scan" | awk '{print $17"-"$14"-"$15"_"$16}')"
+        scrubDate="$(echo "$statusOutput" | grep "scan:" | awk '{print $17"-"$14"-"$15"_"$16}')"
         scrubTS="$(date -j -f "%Y-%b-%e_%H:%M:%S" "$scrubDate" "+%s")"
         currentTS="$(date "+%s")"
         scrubAge=$((((currentTS - scrubTS) + 43200) / 86400))
-        scrubTime="$(echo "$statusOutput" | grep "scan" | awk '{print $8}')"
-    fi
+        scrubTime="$(echo "$statusOutput" | grep "scan:" | awk '{print $8}')"
+
+    # if status is resilvered
+    elif [ "$(echo "$statusOutput" | grep "scan:" | awk '{print $2}')" = "resilvered" ]; then
+            resilver="<BR>Resilvered"
+            scrubRepBytes="$(echo "$statusOutput" | grep "scan:" | awk '{print $3}')"
+            scrubErrors="$(echo "$statusOutput" | grep "scan:" | awk '{print $9}')"
+            # Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
+            scrubDate="$(echo "$statusOutput" | grep "scan:" | awk '{print $16"-"$13"-"$14"_"$15}')"
+            scrubTS="$(date -j -f "%Y-%b-%e_%H:%M:%S" "$scrubDate" "+%s")"
+            currentTS="$(date "+%s")"
+            scrubAge=$((((currentTS - scrubTS) + 43200) / 86400))
+            scrubTime="$(echo "$statusOutput" | grep "scan:" | awk '{print $7}')"
+
+    # Check if resilver is in progress
+    elif [ "$(echo "$statusOutput"| grep "scan:" | awk '{print $2}')" = "resilver" ]; then
+        scrubRepBytes="Resilver In Progress"
+        scrubAge="$(echo "$statusOutput" | grep "resilvered," | awk '{print $3" done"}')"
+        if [ "$(echo "$statusOutput" | grep "resilvered," | awk '{print $5}')" = "0" ]; then
+            scrubTime="$(echo "$statusOutput" | grep "resilvered," | awk '{print $7"<br>to go"}')"
+        else
+            scrubTime="$(echo "$statusOutput" | grep "resilvered," | awk '{print $5" "$6" "$7"<br>to go"}')"
+        fi
+
     # Check if scrub is in progress
-    if [ "$(echo "$statusOutput"| grep "scan" | awk '{print $4}')" = "progress" ]; then
-        scrubAge="In Progress"
-    fi
-    # Set row's background color; alternates between white and $altColor (light gray)
+    elif [ "$(echo "$statusOutput"| grep "scan:" | awk '{print $4}')" = "progress" ]; then
+        scrubRepBytes="Scrub In Progress"
+        scrubErrors="$(echo "$statusOutput" | grep "repaired," | awk '{print $1" repaired"}')"
+        scrubAge="$(echo "$statusOutput" | grep "repaired," | awk '{print $3" done"}')"
+     #   if [ "$(echo "$statusOutput" | grep "scanned out of" | awk '{print $8}')" = "0" ]; then
+            scrubTime="$(echo "$statusOutput" | grep "scanned out of" | awk '{print $8"<br>to go"}')"
+    #    else
+     #       scrubTime="$(echo "$statusOutput" | grep "scanned out of" | awk '{print $5" "$6" "$7"<br>to go"}')"
+      #  fi
+fi
+
+   # Set row's background color; alternates between white and $altColor (light gray)
     if [ $((poolNum % 2)) == 1 ]; then bgColor="#ffffff"; else bgColor="$altColor"; fi
     poolNum=$((poolNum + 1))
     # Set up conditions for warning or critical colors to be used in place of standard background colors
     if [ "$status" != "ONLINE" ]; then statusColor="$warnColor"; else statusColor="$bgColor"; fi
+    status+="$resilver"
     if [ "$readErrors" != "0" ]; then readErrorsColor="$warnColor"; else readErrorsColor="$bgColor"; fi
     if [ "$writeErrors" != "0" ]; then writeErrorsColor="$warnColor"; else writeErrorsColor="$bgColor"; fi
     if [ "$cksumErrors" != "0" ]; then cksumErrorsColor="$warnColor"; else cksumErrorsColor="$bgColor"; fi

From 6edf6dd80e966f26188c10252e6262bc66fd1a28 Mon Sep 17 00:00:00 2001
From: Fredrik <fohlsso2@gmail.com>
Date: Wed, 20 Jun 2018 21:46:41 +0200
Subject: [PATCH 003/160] cleanup

---
 README.md |  3 +--
 report.sh | 11 ++---------
 2 files changed, 3 insertions(+), 11 deletions(-)

diff --git a/README.md b/README.md
index 0fa32d5..f4c02e8 100644
--- a/README.md
+++ b/README.md
@@ -11,13 +11,12 @@ or when a resilver is in progress: https://i.imgur.com/CUNUZ7r.png
 
 **Changelog:**
 
-v1.3b
+and my mods are:
 - fixed the broken border on zpool status summary header
 - in statusOutput changed grep to scrub: instead of scrub
 - added elif for resilvered/resilver in progress and scrub in progress with (hopefully) som useful info fields
 - changed the email subject to include hostname and date & time
 
-
 *v1.3:*
 - Added scrub duration column
 - Fixed for FreeNAS 11.1 (thanks reven!)
diff --git a/report.sh b/report.sh
index 1266d93..d76fa75 100644
--- a/report.sh
+++ b/report.sh
@@ -13,9 +13,6 @@
 #   - in statusOutput changed grep to scrub: instead of scrub
 #   - added elif for resilvered/resilver in progress and scrub in progress with (hopefully) som useful info fields
 #   - changed the email subject to include hostname and date & time
-#   - 
-#   - 
-#   - 
 # v1.3:
 #   - Added scrub duration column
 #   - Fixed for FreeNAS 11.1 (thanks reven!)
@@ -262,12 +259,8 @@ for pool in $pools; do
         scrubRepBytes="Scrub In Progress"
         scrubErrors="$(echo "$statusOutput" | grep "repaired," | awk '{print $1" repaired"}')"
         scrubAge="$(echo "$statusOutput" | grep "repaired," | awk '{print $3" done"}')"
-     #   if [ "$(echo "$statusOutput" | grep "scanned out of" | awk '{print $8}')" = "0" ]; then
-            scrubTime="$(echo "$statusOutput" | grep "scanned out of" | awk '{print $8"<br>to go"}')"
-    #    else
-     #       scrubTime="$(echo "$statusOutput" | grep "scanned out of" | awk '{print $5" "$6" "$7"<br>to go"}')"
-      #  fi
-fi
+        scrubTime="$(echo "$statusOutput" | grep "scanned out of" | awk '{print $8"<br>to go"}')"
+    fi
 
    # Set row's background color; alternates between white and $altColor (light gray)
     if [ $((poolNum % 2)) == 1 ]; then bgColor="#ffffff"; else bgColor="$altColor"; fi

From 7cfb3b5599b0a9b49032272e78b6d1ee1cb99e77 Mon Sep 17 00:00:00 2001
From: Fredrik <fohlsso2@gmail.com>
Date: Wed, 20 Jun 2018 22:46:04 +0200
Subject: [PATCH 004/160] fixed scrub in progress too

---
 report.sh | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/report.sh b/report.sh
index d76fa75..5eb5dbf 100644
--- a/report.sh
+++ b/report.sh
@@ -222,7 +222,7 @@ for pool in $pools; do
 
     statusOutput="$(zpool status "$pool")"
     # normal status i.e. scrub
-    if [ "$(echo "$statusOutput" | grep "scan:" | awk '{print $2}')" = "scrub" ]; then
+    if [ "$(echo "$statusOutput" | grep "scan:" | awk '{print $2}')" = "scrub repaired" ]; then
         scrubRepBytes="$(echo "$statusOutput" | grep "scan:" | awk '{print $4}')"
         scrubErrors="$(echo "$statusOutput" | grep "scan:" | awk '{print $10}')"
         # Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
@@ -259,7 +259,11 @@ for pool in $pools; do
         scrubRepBytes="Scrub In Progress"
         scrubErrors="$(echo "$statusOutput" | grep "repaired," | awk '{print $1" repaired"}')"
         scrubAge="$(echo "$statusOutput" | grep "repaired," | awk '{print $3" done"}')"
-        scrubTime="$(echo "$statusOutput" | grep "scanned out of" | awk '{print $8"<br>to go"}')"
+        if [ "$(echo "$statusOutput" | grep "repaired," | awk '{print $5}')" = "0" ]; then
+            scrubTime="$(echo "$statusOutput" | grep "repaired," | awk '{print $7"<br>to go"}')"
+        else
+            scrubTime="$(echo "$statusOutput" | grep "repaired," | awk '{print $5" "$6" "$7"<br>to go"}')"
+        fi
     fi
 
    # Set row's background color; alternates between white and $altColor (light gray)
@@ -440,4 +444,4 @@ sed -i '' -e '/SMART Error Log Version/d' "$logfile"
 
 ### Send report
 sendmail -t -oi < "$logfile"
-rm "$logfile"
+rm "$logfile"
\ No newline at end of file

From e4621174c080579786540f722f11c5802a657a95 Mon Sep 17 00:00:00 2001
From: Fredrik <944065+fohlsso2@users.noreply.github.com>
Date: Wed, 20 Jun 2018 22:49:27 +0200
Subject: [PATCH 005/160] Update README.md

added more picture links
---
 README.md | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/README.md b/README.md
index f4c02e8..15eacd0 100644
--- a/README.md
+++ b/README.md
@@ -2,7 +2,10 @@
 Original script by joeschmuck, modified by Bidelu0hm, then by melp
 
 Preview of the output here: http://i.imgur.com/t9Mtqyt.png
-or when a resilver is in progress: https://i.imgur.com/CUNUZ7r.png
+  When a resilver is in progress: https://i.imgur.com/CUNUZ7r.png
+  After the resilver is done: https://i.imgur.com/I43MLLf.png
+  When a scrub is in progess: https://i.imgur.com/YGmvZT4.png
+  
 
 
 **At a minimum, you will need to enter your email address in user-definable parameter section.** Feel free to edit other user parameters as needed.

From 398c88d8f75cada1f31da212246967fdd2556d8a Mon Sep 17 00:00:00 2001
From: Fredrik <944065+fohlsso2@users.noreply.github.com>
Date: Wed, 20 Jun 2018 22:51:07 +0200
Subject: [PATCH 006/160] Update README.md

added more picture links
---
 README.md | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index 15eacd0..0893f1d 100644
--- a/README.md
+++ b/README.md
@@ -2,12 +2,16 @@
 Original script by joeschmuck, modified by Bidelu0hm, then by melp
 
 Preview of the output here: http://i.imgur.com/t9Mtqyt.png
-  When a resilver is in progress: https://i.imgur.com/CUNUZ7r.png
-  After the resilver is done: https://i.imgur.com/I43MLLf.png
-  When a scrub is in progess: https://i.imgur.com/YGmvZT4.png
+
+When a resilver is in progress: https://i.imgur.com/CUNUZ7r.png
+
+After the resilver is done: https://i.imgur.com/I43MLLf.png
+
+When a scrub is in progess: https://i.imgur.com/YGmvZT4.png
   
 
 
+
 **At a minimum, you will need to enter your email address in user-definable parameter section.** Feel free to edit other user parameters as needed.
 
 **Version: v1.3**

From f79c25563195a4642254e96a5547a746de342597 Mon Sep 17 00:00:00 2001
From: Fredrik <944065+fohlsso2@users.noreply.github.com>
Date: Thu, 21 Jun 2018 16:56:00 +0200
Subject: [PATCH 007/160] Update report.sh

fixed the parser for normal scrub
---
 report.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/report.sh b/report.sh
index 5eb5dbf..c8d7ba4 100644
--- a/report.sh
+++ b/report.sh
@@ -222,7 +222,7 @@ for pool in $pools; do
 
     statusOutput="$(zpool status "$pool")"
     # normal status i.e. scrub
-    if [ "$(echo "$statusOutput" | grep "scan:" | awk '{print $2}')" = "scrub repaired" ]; then
+    if [ "$(echo "$statusOutput" | grep "scan:" | awk '{print $2" "$3}')" = "scrub repaired" ]; then
         scrubRepBytes="$(echo "$statusOutput" | grep "scan:" | awk '{print $4}')"
         scrubErrors="$(echo "$statusOutput" | grep "scan:" | awk '{print $10}')"
         # Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
@@ -444,4 +444,4 @@ sed -i '' -e '/SMART Error Log Version/d' "$logfile"
 
 ### Send report
 sendmail -t -oi < "$logfile"
-rm "$logfile"
\ No newline at end of file
+rm "$logfile"

From 413c7822bdb409cff834377c5d227ff2ef109132 Mon Sep 17 00:00:00 2001
From: Fredrik <944065+fohlsso2@users.noreply.github.com>
Date: Thu, 21 Jun 2018 16:56:45 +0200
Subject: [PATCH 008/160] Update README.md

---
 README.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/README.md b/README.md
index 0893f1d..fd395c1 100644
--- a/README.md
+++ b/README.md
@@ -23,6 +23,7 @@ and my mods are:
 - in statusOutput changed grep to scrub: instead of scrub
 - added elif for resilvered/resilver in progress and scrub in progress with (hopefully) som useful info fields
 - changed the email subject to include hostname and date & time
+- aaand fixed the parser
 
 *v1.3:*
 - Added scrub duration column

From 800f027860b3e3a9a9841c2547fae386e7544b1e Mon Sep 17 00:00:00 2001
From: Fredrik <944065+fohlsso2@users.noreply.github.com>
Date: Thu, 11 Oct 2018 17:21:55 +0200
Subject: [PATCH 009/160] Update README.md

---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index fd395c1..18b843f 100644
--- a/README.md
+++ b/README.md
@@ -1,5 +1,5 @@
 # ZPool & SMART status report with FreeNAS config backup
-Original script by joeschmuck, modified by Bidelu0hm, then by melp
+Original script by joeschmuck, modified by Bidelu0hm, then by melp, and then by me too
 
 Preview of the output here: http://i.imgur.com/t9Mtqyt.png
 

From c633625969ddeb96f35279dcaf26987672a06e02 Mon Sep 17 00:00:00 2001
From: ninpucho <tbaker78@gmail.com>
Date: Sun, 3 Feb 2019 05:48:29 -0500
Subject: [PATCH 010/160] Update report.sh

#   - Added Frag%, Size, Allocated, Free for ZPool status report summary.
#   - Added Disk Size, RPM, Model to the Smart Report
#   - Added if statment so that if "Model Family" is not present script will use "Device Model"
#       for brand in the SMART Satus report details.
#   - Added Glabel Status Report (RAW)
#   - Removed Power-On time labels and added ":" as a separator.
#   - Added Power-On format to the Power-On time Header.
#   - Changed Backup deafult to false.
---
 report.sh | 75 ++++++++++++++++++++++++++++++++++++++++++-------------
 1 file changed, 58 insertions(+), 17 deletions(-)

diff --git a/report.sh b/report.sh
index c8d7ba4..1407fb0 100644
--- a/report.sh
+++ b/report.sh
@@ -6,10 +6,18 @@
 ### At a minimum, enter email address in user-definable parameter section. Feel free to edit other user parameters as needed.
 ### If you find any errors, feel free to contact me on the FreeNAS forums (username melp) or email me at jason at jro dot io.
 
-### Version: v1.3
+### Version: v1.5
 ### Changelog:
-# v1.?
-#   - fixed the broken border on zpool status summary header
+# v1.5
+#   - Added Frag%, Size, Allocated, Free for ZPool status report summary.
+#   - Added Disk Size, RPM, Model to the Smart Report
+#   - Added if statment so that if "Model Family" is not present script will use "Device Model" 
+#       for brand in the SMART Satus report details.
+#   - Added Glabel Status Report
+#   - Removed Power-On time labels and added ":" as a separator.
+#   - Added Power-On format to the Power-On time Header.
+#   - Changed Backup deafult to false.
+# v1.4
 #   - in statusOutput changed grep to scrub: instead of scrub
 #   - added elif for resilvered/resilver in progress and scrub in progress with (hopefully) som useful info fields
 #   - changed the email subject to include hostname and date & time
@@ -67,7 +75,7 @@ testAgeWarn=5           # Maximum age (in days) of last SMART test before CRITIC
 powerTimeFormat="ymdh"  # Format for power-on hours string, valid options are "ymdh", "ymd", "ym", or "y" (year month day hour)
 
 ### FreeNAS config backup settings
-configBackup="true"     # Change to "false" to skip config backup (which renders next two options meaningless); "true" to keep config backups enabled
+configBackup="false"     # Change to "false" to skip config backup (which renders next two options meaningless); "true" to keep config backups enabled
 saveBackup="true"       # Change to "false" to delete FreeNAS config backup after mail is sent; "true" to keep it in dir below
 backupLocation="/path/to/config/backup"   # Directory in which to save FreeNAS config backups
 
@@ -167,10 +175,14 @@ fi
     echo "<tr>"
     echo "  <th style=\"text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Pool<br>Name</th>"
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Status</th>"
+    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Size</th>"
+    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Allocated</th>"
+    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Free</th>"
+    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Frag %</th>"
+    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Used %</th>"    
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Read<br>Errors</th>"
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Write<br>Errors</th>"
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Cksum<br>Errors</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Used %</th>"
     echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Scrub<br>Repaired<br>Bytes</th>"
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Scrub<br>Errors</th>"
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Last<br>Scrub<br>Age</th>"
@@ -181,6 +193,15 @@ poolNum=0
 for pool in $pools; do
     # zpool health summary
     status="$(zpool list -H -o health "$pool")"
+    # zpool fragment summary
+    frag="$(zpool list -H -p -o frag "$pool" | tr -d %% | awk '{print $0 + 0}')"
+
+    size="$(zpool list -H -o size "$pool")"
+
+    allocated="$(zpool list -H -o allocated "$pool")"
+
+    free="$(zpool list -H -o free "$pool")"
+
     # Total all read, write, and checksum errors per pool
     errors="$(zpool status "$pool" | grep -E "(ONLINE|DEGRADED|FAULTED|UNAVAIL|REMOVED)[ \\t]+[0-9]+")"
     readErrors=0
@@ -284,16 +305,20 @@ for pool in $pools; do
         printf "<tr style=\"background-color:%s;\">
             <td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
             <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
+            <td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
+            <td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
+            <td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
+            <td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s%%</td>
+            <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s%%</td>
             <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
             <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
             <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
-            <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s%%</td>
             <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
             <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
             <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
             <td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
-        </tr>\\n" "$bgColor" "$pool" "$statusColor" "$status" "$readErrorsColor" "$readErrors" "$writeErrorsColor" "$writeErrors" "$cksumErrorsColor" \
-        "$cksumErrors" "$usedColor" "$used" "$scrubRepBytesColor" "$scrubRepBytes" "$scrubErrorsColor" "$scrubErrors" "$scrubAgeColor" "$scrubAge" "$scrubTime"
+        </tr>\\n" "$bgColor" "$pool" "$statusColor" "$status" "$size" "$allocated" "$free" "$frag" "$usedColor" "$used" "$readErrorsColor" "$readErrors" "$writeErrorsColor" "$writeErrors" "$cksumErrorsColor" \
+        "$cksumErrors" "$scrubRepBytesColor" "$scrubRepBytes" "$scrubErrorsColor" "$scrubErrors" "$scrubAgeColor" "$scrubAge" "$scrubTime"
     ) >> "$logfile"
 done
 # End of zpool status table
@@ -307,10 +332,13 @@ echo "</table>" >> "$logfile"
     echo "<tr><th colspan=\"15\" style=\"text-align:center; font-size:20px; height:40px; font-family:courier;\">SMART Status Report Summary</th></tr>"
     echo "<tr>"
     echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Device</th>"
+    echo "  <th style=\"text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Model</th>"
     echo "  <th style=\"text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Serial<br>Number</th>"
+    echo "  <th style=\"text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">RPM</th>"
+    echo "  <th style=\"text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Capacity</th>"
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">SMART<br>Status</th>"
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Temp</th>"
-    echo "  <th style=\"text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Power-On<br>Time</th>"
+    echo "  <th style=\"text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Power-On<br>Time<br>($powerTimeFormat)</th>"
     echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Start/Stop<br>Count</th>"
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Spin<br>Retry<br>Count</th>"
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Realloc'd<br>Sectors</th>"
@@ -320,7 +348,7 @@ echo "</table>" >> "$logfile"
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">UltraDMA<br>CRC<br>Errors</th>"
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Seek<br>Error<br>Health</th>"
     echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Last Test<br>Age (days)</th>"
-    echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Last Test<br>Type</th></tr>"
+    echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Last Test<br>Type</th></tr>"    
     echo "</tr>"
 ) >> "$logfile"
 for drive in $drives; do
@@ -337,7 +365,10 @@ for drive in $drives; do
         -v lastTestHours="$(smartctl -l selftest /dev/"$drive" | grep "# 1" | awk '{print $9}')" \
         -v lastTestType="$(smartctl -l selftest /dev/"$drive" | grep "# 1" | awk '{print $3}')" \
         -v smartStatus="$(smartctl -H /dev/"$drive" | grep "SMART overall-health" | awk '{print $6}')" ' \
+        /Device Model:/{$1="";$2=""; model=$0} \
         /Serial Number:/{serial=$3} \
+        /User Capacity:/{capacity=$5 $6} \
+        /Rotation Rate:/{rpm=$3} \
         /Temperature_Celsius/{temp=($10 + 0)} \
         /Power_On_Hours/{onHours=$10} \
         /Start_Stop_Count/{startStop=$10} \
@@ -354,11 +385,11 @@ for drive in $drives; do
             mos=int((onHours % 8760) / 730);
             dys=int(((onHours % 8760) % 730) / 24);
             hrs=((onHours % 8760) % 730) % 24;
-            if (powerTimeFormat == "ymdh") onTime=yrs "y " mos "m " dys "d " hrs "h";
-            else if (powerTimeFormat == "ymd") onTime=yrs "y " mos "m " dys "d";
-            else if (powerTimeFormat == "ym") onTime=yrs "y " mos "m";
-            else if (powerTimeFormat == "y") onTime=yrs "y";
-            else onTime=yrs "y " mos "m " dys "d " hrs "h ";
+            if (powerTimeFormat == "ymdh") onTime=yrs ":" mos ":" dys ":" hrs;
+            else if (powerTimeFormat == "ymd") onTime=yrs ":" mos ":" dys;
+            else if (powerTimeFormat == "ym") onTime=yrs ":" mos;
+            else if (powerTimeFormat == "y") onTime=yrs;
+            else onTime=yrs ":" mos ":" dys ":" hrs;
             if ((substr(device,3) + 0) % 2 == 1) bgColor = "#ffffff"; else bgColor = altColor;
             if (smartStatus != "PASSED") smartStatusColor = critColor; else smartStatusColor = okColor;
             if (temp >= tempCrit) tempColor = critColor; else if (temp >= tempWarn) tempColor = warnColor; else tempColor = bgColor;
@@ -373,6 +404,9 @@ for drive in $drives; do
             printf "<tr style=\"background-color:%s;\">" \
                 "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">/dev/%s</td>" \
                 "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
                 "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
                 "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%d*C</td>" \
                 "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
@@ -386,7 +420,7 @@ for drive in $drives; do
                 "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s%%</td>" \
                 "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%d</td>" \
                 "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-            "</tr>\n", bgColor, device, serial, smartStatusColor, smartStatus, tempColor, temp, onTime, startStop, spinRetryColor, spinRetry, reAllocColor, reAlloc, \
+            "</tr>\n", bgColor, device, model, serial, rpm, capacity, smartStatusColor, smartStatus, tempColor, temp, onTime, startStop, spinRetryColor, spinRetry, reAllocColor, reAlloc, \
             reAllocEventColor, reAllocEvent, pendingColor, pending, offlineUncColor, offlineUnc, crcErrorsColor, crcErrors, seekErrorHealthColor, seekErrorHealth, \
             testAgeColor, testAge, lastTestType;
         }'
@@ -402,12 +436,18 @@ done
 ###### Detailed Report Section (monospace text)
 echo "<pre style=\"font-size:14px\">" >> "$logfile"
 
+### Print Glabel Status
+(
+    echo "<b>########## Glabel Status ##########</b>"
+    glabel status
+    echo "<br>"
+) >> "$logfile"
+
 ### zpool status for each pool
 for pool in $pools; do
     (
         # Create a simple header and drop the output of zpool status -v
         echo "<b>########## ZPool status report for ${pool} ##########</b>"
-        echo "<br>"
         zpool status -v "$pool"
         echo "<br><br>"
     ) >> "$logfile"
@@ -417,6 +457,7 @@ done
 for drive in $drives; do
     # Gather brand and serial number of each drive
     brand="$(smartctl -i /dev/"$drive" | grep "Model Family" | awk '{print $3, $4, $5}')"
+    if [ "$brand" == "" ]; then  brand="$(smartctl -i /dev/"$drive" | grep "Device Model" | awk '{print $3, $4, $5}')"; fi
     serial="$(smartctl -i /dev/"$drive" | grep "Serial Number" | awk '{print $3}')"
     (
         # Create a simple header and drop the output of some basic smartctl commands

From 9465090d27ee5dad5dc9848ac63c9a8e5cfdf52d Mon Sep 17 00:00:00 2001
From: ninpucho <tbaker78@gmail.com>
Date: Sun, 3 Feb 2019 05:53:49 -0500
Subject: [PATCH 011/160] Update README.md

---
 README.md | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/README.md b/README.md
index 18b843f..eb87adc 100644
--- a/README.md
+++ b/README.md
@@ -1,5 +1,6 @@
 # ZPool & SMART status report with FreeNAS config backup
-Original script by joeschmuck, modified by Bidelu0hm, then by melp, and then by me too
+Original Script By: joeschmuck
+Modified By: Bidelu0hm, melp, onlinepcwizard, Ninpucho
 
 Preview of the output here: http://i.imgur.com/t9Mtqyt.png
 
@@ -10,15 +11,24 @@ After the resilver is done: https://i.imgur.com/I43MLLf.png
 When a scrub is in progess: https://i.imgur.com/YGmvZT4.png
   
 
-
-
 **At a minimum, you will need to enter your email address in user-definable parameter section.** Feel free to edit other user parameters as needed.
+**NOTE: Backup has been disabled by default so if required please set to true.**
 
-**Version: v1.3**
+**Version: v1.5**
 
 **Changelog:**
 
-and my mods are:
+*v1.5* (ninpucho)
+ - Added Frag%, Size, Allocated, Free for ZPool status report summary.
+ - Added Disk Size, RPM, Model to the Smart Report
+ - Added if statment so that if "Model Family" is not present script will use "Device Model" 
+      for brand in the SMART Satus report details.
+ - Added Glabel Status Report
+ - Removed Power-On time labels and added ":" as a separator.
+ - Added Power-On format to the Power-On time Header.
+ - Changed Backup deafult to false.
+
+*v1.4:* (onlinepcwizard/FreeNAS-Report)
 - fixed the broken border on zpool status summary header
 - in statusOutput changed grep to scrub: instead of scrub
 - added elif for resilvered/resilver in progress and scrub in progress with (hopefully) som useful info fields

From 1443a13f67093dc16b3e00c917dda1494190c81a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Albert=20Serrall=C3=A9=20R=C3=ADos?=
 <aserrallerios@gmail.com>
Date: Wed, 9 Dec 2020 19:54:03 +0100
Subject: [PATCH 012/160] Rebase v1.6 to main repo

---
 README.md |  51 ++++-
 report.sh | 593 +++++++++++++++++++++++++++++++++++++++++-------------
 2 files changed, 498 insertions(+), 146 deletions(-)
 mode change 100644 => 100755 report.sh

diff --git a/README.md b/README.md
index b2a81ab..2432c18 100644
--- a/README.md
+++ b/README.md
@@ -1,28 +1,58 @@
-# ZPool & SMART status report with FreeNAS config backup
-Original script by joeschmuck, modified by Bidelu0hm, then by melp
+# ZPool, SMART, and UPS Status Report with FreeNAS Config Backup
+Original Script By: joeschmuck<br>
+Modified By: bidelu0hm, melp, fohlsso2, onlinepcwizard, ninpucho, isentropik<br>
+Last Edited By: aserrallerios
 
-Preview of the output here: http://i.imgur.com/t9Mtqyt.png
+Preview of the output here: https://i.imgur.com/K38T1u8.png<br>
+When a resilver is in progress: https://i.imgur.com/CUNUZ7r.png<br>
+After the resilver is done: https://i.imgur.com/I43MLLf.png<br>
+When a scrub is in progess: https://i.imgur.com/YGmvZT4.png<br><br>
 
-**At a minimum, you will need to enter your email address in user-definable parameter section.** Feel free to edit other user parameters as needed.
+**At a minimum, enter email address in user-definable parameter section. The default is set to 'root' as I assume that the root email was set in FreeNAS. Feel free to edit other user parameters as needed. Backup has been enabled by default so if it's not required please set to false.**<br><br>
 
-**Version: v1.3**
+**Current Version: v1.6**
 
 **Changelog:**
 
-*v1.3:*
+*v1.6* (isentropik)
+ - Actually fixed the broken borders in the tables.
+ - Split the SMART table into two tables, one for SSDs and one for HDDs.
+ - Added several options for SSD reporting.
+ - Modified the SSD table in order to capture relevant (seemingly) SSD data.
+ - Changed 'include SSD' default to true.
+ - Cleaned up minor formatting and error handling issues (tried to have the cell fill with "N/A" instead of non-sensical values).
+
+*v1.5* (ninpucho)
+ - Added Frag%, Size, Allocated, Free for ZPool status report summary.
+ - Added Disk Size, RPM, Model to the Smart Report
+ - Added if statment so that if "Model Family" is not present script will use "Device Model"
+      for brand in the SMART Satus report details.
+ - Added Glabel Status Report
+ - Removed Power-On time labels and added ":" as a separator.
+ - Added Power-On format to the Power-On time Header.
+ - Changed Backup deafult to false.
+
+*v1.4* (onlinepcwizard)
+- fixed the broken border on zpool status summary header
+- in statusOutput changed grep to scrub: instead of scrub
+- added elif for resilvered/resilver in progress and scrub in progress with (hopefully) som useful info fields
+- changed the email subject to include hostname and date & time
+- aaand fixed the parser
+
+*v1.3*
 - Added scrub duration column
 - Fixed for FreeNAS 11.1 (thanks reven!)
 - Fixed fields parsed out of zpool status
 - Buffered zpool status to reduce calls to script
 
-*v1.2:*
+*v1.2*
 - Added switch for power-on time format
 - Slimmed down table columns
 - Fixed some shellcheck errors & other misc stuff
 - Added .tar.gz to backup file attached to email
 - (Still coming) Better SSD SMART support
 
-*v1.1:*
+*v1.1*
 - Config backup now attached to report email
 - Added option to turn off config backup
 - Added option to save backup configs in a specified directory
@@ -35,9 +65,8 @@ Preview of the output here: http://i.imgur.com/t9Mtqyt.png
 - Reformatted user-definable parameters section
 - Added more general comments to code
 
-*v1.0:*
+*v1.0*
 - Initial release
 
-**TODO:**
-- Fix SSD SMART reporting
+**TODO**
 - Add support for conveyance test
diff --git a/report.sh b/report.sh
old mode 100644
new mode 100755
index 17c6065..096897c
--- a/report.sh
+++ b/report.sh
@@ -1,25 +1,50 @@
 #!/bin/bash
 
-###### ZPool & SMART status report with FreeNAS config backup
-### Original script by joeschmuck, modified by Bidelu0hm, then by melp (me)
+#set -euxo pipefail
 
-### At a minimum, enter email address in user-definable parameter section. Feel free to edit other user parameters as needed.
-### If you find any errors, feel free to contact me on the FreeNAS forums (username melp) or email me at jason at jro dot io.
+###### ZPool, SMART, and UPS Status Report with FreeNAS Config Backup
+### Original Script By: joeschmuck
+### Modified By: bidelu0hm, melp, fohlsso2, onlinepcwizard, ninpucho
+### Last Edited By: isentropik
+
+### At a minimum, enter email address in user-definable parameter section. The default is set to 'root' as I assume that the root email was set in FreeNAS.
+### Feel free to edit other user parameters as needed.
+
+### Current Version: v1.6
+### https://github.com/isentropik/FreeNAS-Report
 
-### Version: v1.3
 ### Changelog:
-# v1.3:
+# v1.6
+#   - Actually fixed the broken borders in the tables.
+#   - Split the SMART table into two tables, one for SSDs and one for HDDs.
+#   - Added several options for SSD reporting.
+#   - Modified the SSD table in order to capture relevant (seemingly) SSD data.
+#   - Changed 'include SSD' default to true.
+#   - Cleaned up minor formatting and error handling issues (tried to have the cell fill with "N/A" instead of non-sensical values).
+# v1.5
+#   - Added Frag%, Size, Allocated, Free for ZPool status report summary.
+#   - Added Disk Size, RPM, Model to the Smart Report
+#   - Added if statment so that if "Model Family" is not present script will use "Device Model" for brand in the SMART Satus report details.
+#   - Added Glabel Status Report
+#   - Removed Power-On time labels and added ":" as a separator.
+#   - Added Power-On format to the Power-On time Header.
+#   - Changed Backup deafult to false.
+# v1.4
+#   - in statusOutput changed grep to scrub: instead of scrub
+#   - added elif for resilvered/resilver in progress and scrub in progress with (hopefully) som useful info fields
+#   - changed the email subject to include hostname and date & time
+# v1.3
 #   - Added scrub duration column
 #   - Fixed for FreeNAS 11.1 (thanks reven!)
 #   - Fixed fields parsed out of zpool status
 #   - Buffered zpool status to reduce calls to script
-# v1.2:
+# v1.2
 #   - Added switch for power-on time format
 #   - Slimmed down table columns
 #   - Fixed some shellcheck errors & other misc stuff
 #   - Added .tar.gz to backup file attached to email
 #   - (Still coming) Better SSD SMART support
-# v1.1:
+# v1.1
 #   - Config backup now attached to report email
 #   - Added option to turn off config backup
 #   - Added option to save backup configs in a specified directory
@@ -31,12 +56,9 @@
 #   - Added most recent Extended & Short SMART tests in drive details section (only listed one before, whichever was more recent)
 #   - Reformatted user-definable parameters section
 #   - Added more general comments to code
-# v1.0:
+# v1.0
 #   - Initial release
 
-### TODO:
-# - Fix SSD SMART reporting
-# - Add support for conveyance test
 
 
 ###### User-definable Parameters
@@ -54,38 +76,57 @@ usedWarn=90             # Pool used percentage for CRITICAL color to be used
 scrubAgeWarn=30         # Maximum age (in days) of last pool scrub before CRITICAL color will be used
 
 ### SMART status summary table settings
-includeSSD="false"      # [NOTE: Currently this is pretty much useless] Change to "true" to include SSDs in SMART status summary table; "false" to disable
+includeSSD="true"       # Change to "true" to include SSDs in SMART status summary table; "false" to disable
+lifeRemainWarn=75       # Life remaining in the SSD at which WARNING color will be used
+lifeRemainCrit=50       # Life remaining in the SSD at which CRITICAL color will be used
+totalBWWarn=100         # Total bytes written (in TB) to the SSD at which WARNING color will be used
+totalBWCrit=200         # Total bytes written (in TB) to the SSD at which CRITICAL color will be used
 tempWarn=40             # Drive temp (in C) at which WARNING color will be used
 tempCrit=45             # Drive temp (in C) at which CRITICAL color will be used
 sectorsCrit=10          # Number of sectors per drive with errors before CRITICAL color will be used
 testAgeWarn=5           # Maximum age (in days) of last SMART test before CRITICAL color will be used
-powerTimeFormat="ymdh"  # Format for power-on hours string, valid options are "ymdh", "ymd", "ym", or "y" (year month day hour)
+powerTimeFormat="ymd"   # Format for power-on hours string, valid options are "ymdh", "ymd", "ym", or "y" (year month day hour)
 
 ### FreeNAS config backup settings
 configBackup="true"     # Change to "false" to skip config backup (which renders next two options meaningless); "true" to keep config backups enabled
+emailBackup="true"     # Change to "true" to email FreeNAS config backup
 saveBackup="true"       # Change to "false" to delete FreeNAS config backup after mail is sent; "true" to keep it in dir below
-backupLocation="/path/to/config/backup"   # Directory in which to save FreeNAS config backups
+backupLocation="/root/backup"    # Directory in which to save FreeNAS config backups
+
+### UPS status summary settings
+reportUPS="false"        # Change to "false" to skip reporting the status of the UPS
+
+### General script settings
+logfileLocation="/tmp"      # Directory in which to save FreeNAS log file. Can be set to /tmp.
+logfileName="logfilename"                  # Log file name
+saveLogfile="true"                         # Change to "false" to delete the log file after creation
+
 
 
 ###### Auto-generated Parameters
 host=$(hostname -s)
-logfile="/tmp/smart_report.tmp"
-subject="Status Report and Configuration Backup for ${host}"
+logfile="${logfileLocation}/$(date +%Y%m%d%H%M%S)_${logfileName}.tmp"
+subject="Status Report and Configuration Backup for ${host} - $(date "+%Y-%m-%d %H:%M")"
 boundary="gc0p4Jq0M2Yt08jU534c0p"
+
+# Reorders the drives in ascending order
+drives=$(for drive in $(sysctl -n kern.disks); do
+    if [ "$(smartctl -i /dev/"${drive}" | grep "SMART support is: Enabled")" ]; then
+        printf "%s " "${drive}"
+    fi
+done | awk '{for (i=NF; i!=0 ; i--) print $i }')
+
+# Toggles the 'ssdExist' flag to true if SSDs are detected in order to add the summary table
 if [ "$includeSSD" == "true" ]; then
-    drives=$(for drive in $(sysctl -n kern.disks); do
-        if [ "$(smartctl -i /dev/"${drive}" | grep "SMART support is: Enabled")" ]; then
-            printf "%s " "${drive}"
-        fi
-    done | awk '{for (i=NF; i!=0 ; i--) print $i }')
-else
-    drives=$(for drive in $(sysctl -n kern.disks); do
-        if [ "$(smartctl -i /dev/"${drive}" | grep "SMART support is: Enabled")" ] && ! [ "$(smartctl -i /dev/"${drive}" | grep "Solid State Device")" ]; then
-            printf "%s " "${drive}"
+    for drive in $drives; do
+        if [ "$(smartctl -i /dev/"${drive}" | grep "Solid State Device")" ]; then
+            ssdExist="true"
+        else
+            ssdExist="false"
         fi
-    done | awk '{for (i=NF; i!=0 ; i--) print $i }')
+    done
 fi
-pools=$(zpool list -H -o name)
+
 
 
 ###### Email pre-formatting
@@ -99,13 +140,19 @@ pools=$(zpool list -H -o name)
 ) > "$logfile"
 
 
+
 ###### Config backup (if enabled)
 if [ "$configBackup" == "true" ]; then
+
     # Set up file names, etc for later
     tarfile="/tmp/config_backup.tar.gz"
-    filename="$(date "+FreeNAS_Config_%Y-%m-%d")"
+    fnconfigdest_version=$(< /etc/version sed -e 's/)//;s/(//;s/ /-/' | tr -d '\n')
+    fnconfigdest_date=$(date +%Y%m%d%H%M%S)
+    filename="${fnconfigdest_date}"_"${fnconfigdest_version}"
+
     ### Test config integrity
     if ! [ "$(sqlite3 /data/freenas-v1.db "pragma integrity_check;")" == "ok" ]; then
+
         # Config integrity check failed, set MIME content type to html and print warning
         (
             echo "--${boundary}"
@@ -124,16 +171,20 @@ if [ "$configBackup" == "true" ]; then
             tar -czf "${tarfile}" "./${filename}.db" ./config_backup.md5 ./config_backup.sha256;
         )
         (
+        if [ "$emailBackup" == "true" ]; then
             # Write MIME section header for file attachment (encoded with base64)
             echo "--${boundary}"
             echo "Content-Type: application/tar+gzip"
             echo "Content-Transfer-Encoding: base64"
             echo "Content-Disposition: attachment; filename=${filename}.tar.gz"
             base64 "$tarfile"
-            # Write MIME section header for html content to come below
-            echo "--${boundary}"
-            echo "Content-Type: text/html"
+    fi
+
+        # Write MIME section header for html content to come below
+        echo "--${boundary}"
+        echo "Content-Type: text/html"
         ) >> "$logfile"
+
         # If logfile saving is enabled, copy .tar.gz file to specified location before it (and everything else) is removed below
         if [ "$saveBackup" == "true" ]; then
             cp "${tarfile}" "${backupLocation}/${filename}.tar.gz"
@@ -158,24 +209,38 @@ fi
     # Write HTML table headers to log file; HTML in an email requires 100% in-line styling (no CSS or <style> section), hence the massive tags
     echo "<br><br>"
     echo "<table style=\"border: 1px solid black; border-collapse: collapse;\">"
-    echo "<tr><th colspan=\"9\" style=\"text-align:center; font-size:20px; height:40px; font-family:courier;\">ZPool Status Report Summary</th></tr>"
+    echo "<tr><th colspan=\"14\" style=\"text-align:center; font-size:20px; height:40px; font-family:courier;\">ZPool Status Report Summary</th></tr>"
     echo "<tr>"
     echo "  <th style=\"text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Pool<br>Name</th>"
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Status</th>"
+    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Size</th>"
+    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Allocated</th>"
+    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Free</th>"
+    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Frag %</th>"
+    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Used %</th>"
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Read<br>Errors</th>"
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Write<br>Errors</th>"
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Cksum<br>Errors</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Used %</th>"
     echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Scrub<br>Repaired<br>Bytes</th>"
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Scrub<br>Errors</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Last<br>Scrub<br>Age</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Last<br>Scrub<br>Time</th>"
+    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Last<br>Scrub<br>Age (days)</th>"
+    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Last<br>Scrub<br>Duration</th>"
     echo "</tr>"
 ) >> "$logfile"
+
 poolNum=0
+pools=$(zpool list -H -o name)
 for pool in $pools; do
+
     # zpool health summary
     status="$(zpool list -H -o health "$pool")"
+
+    # zpool fragment summary
+    frag="$(zpool list -H -p -o frag "$pool" | tr -d %% | awk '{print $0 + 0}')"
+    size="$(zpool list -H -o size "$pool")"
+    allocated="$(zpool list -H -o allocated "$pool")"
+    free="$(zpool list -H -o free "$pool")"
+
     # Total all read, write, and checksum errors per pool
     errors="$(zpool status "$pool" | grep -E "(ONLINE|DEGRADED|FAULTED|UNAVAIL|REMOVED)[ \\t]+[0-9]+")"
     readErrors=0
@@ -206,33 +271,72 @@ for pool in $pools; do
     if [ "$readErrors" -gt 999 ]; then readErrors=">1K"; fi
     if [ "$writeErrors" -gt 999 ]; then writeErrors=">1K"; fi
     if [ "$cksumErrors" -gt 999 ]; then cksumErrors=">1K"; fi
+
     # Get used capacity percentage of the zpool
     used="$(zpool list -H -p -o capacity "$pool")"
+
     # Gather info from most recent scrub; values set to "N/A" initially and overwritten when (and if) it gathers scrub info
     scrubRepBytes="N/A"
     scrubErrors="N/A"
     scrubAge="N/A"
     scrubTime="N/A"
+    resilver=""
+
     statusOutput="$(zpool status "$pool")"
-    if [ "$(echo "$statusOutput" | grep "scan" | awk '{print $2}')" = "scrub" ]; then
-        scrubRepBytes="$(echo "$statusOutput" | grep "scan" | awk '{gsub(/B/,"",$4); print $4}')"
-        scrubErrors="$(echo "$statusOutput" | grep "scan" | awk '{print $8}')"
+    # normal status i.e. scrub
+    if [ "$(echo "$statusOutput" | grep "scan:" | awk '{print $2" "$3}')" = "scrub repaired" ]; then
+        scrubRepBytes="$(echo "$statusOutput" | grep "scan:" | awk '{gsub(/B/,"",$4); print $4}')"
+        scrubErrors="$(echo "$statusOutput" | grep "scan:" | awk '{print $8}')"
+
         # Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
-        scrubDate="$(echo "$statusOutput" | grep "scan" | awk '{print $15"-"$12"-"$13"_"$14}')"
+        scrubDate="$(echo "$statusOutput" | grep "scan:" | awk '{print $15"-"$12"-"$13"_"$14}')"
         scrubTS="$(date -j -f "%Y-%b-%e_%H:%M:%S" "$scrubDate" "+%s")"
         currentTS="$(date "+%s")"
         scrubAge=$((((currentTS - scrubTS) + 43200) / 86400))
         scrubTime="$(echo "$statusOutput" | grep "scan" | awk '{print $6}')"
-    fi
+
+    # if status is resilvered
+    elif [ "$(echo "$statusOutput" | grep "scan:" | awk '{print $2}')" = "resilvered" ]; then
+            resilver="<BR>Resilvered"
+            scrubRepBytes="$(echo "$statusOutput" | grep "scan:" | awk '{print $3}')"
+            scrubErrors="$(echo "$statusOutput" | grep "scan:" | awk '{print $9}')"
+
+            # Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
+            scrubDate="$(echo "$statusOutput" | grep "scan:" | awk '{print $16"-"$13"-"$14"_"$15}')"
+            scrubTS="$(date -j -f "%Y-%b-%e_%H:%M:%S" "$scrubDate" "+%s")"
+            currentTS="$(date "+%s")"
+            scrubAge=$((((currentTS - scrubTS) + 43200) / 86400))
+            scrubTime="$(echo "$statusOutput" | grep "scan:" | awk '{print $7}')"
+
+    # Check if resilver is in progress
+    elif [ "$(echo "$statusOutput"| grep "scan:" | awk '{print $2}')" = "resilver" ]; then
+        scrubRepBytes="Resilver In Progress"
+        scrubAge="$(echo "$statusOutput" | grep "resilvered," | awk '{print $3" done"}')"
+        if [ "$(echo "$statusOutput" | grep "resilvered," | awk '{print $5}')" = "0" ]; then
+            scrubTime="$(echo "$statusOutput" | grep "resilvered," | awk '{print $7"<br>to go"}')"
+        else
+            scrubTime="$(echo "$statusOutput" | grep "resilvered," | awk '{print $5" "$6" "$7"<br>to go"}')"
+        fi
+
     # Check if scrub is in progress
-    if [ "$(echo "$statusOutput"| grep "scan" | awk '{print $4}')" = "progress" ]; then
-        scrubAge="In Progress"
+    elif [ "$(echo "$statusOutput"| grep "scan:" | awk '{print $4}')" = "progress" ]; then
+        scrubRepBytes="Scrub In Progress"
+        scrubErrors="$(echo "$statusOutput" | grep "repaired," | awk '{print $1" repaired"}')"
+        scrubAge="$(echo "$statusOutput" | grep "repaired," | awk '{print $3" done"}')"
+        if [ "$(echo "$statusOutput" | grep "repaired," | awk '{print $5}')" = "0" ]; then
+            scrubTime="$(echo "$statusOutput" | grep "repaired," | awk '{print $7"<br>to go"}')"
+        else
+            scrubTime="$(echo "$statusOutput" | grep "repaired," | awk '{print $5" "$6" "$7"<br>to go"}')"
+        fi
     fi
-    # Set row's background color; alternates between white and $altColor (light gray)
+
+   # Set row's background color; alternates between white and $altColor (light gray)
     if [ $((poolNum % 2)) == 1 ]; then bgColor="#ffffff"; else bgColor="$altColor"; fi
     poolNum=$((poolNum + 1))
+
     # Set up conditions for warning or critical colors to be used in place of standard background colors
     if [ "$status" != "ONLINE" ]; then statusColor="$warnColor"; else statusColor="$bgColor"; fi
+    status+="$resilver"
     if [ "$readErrors" != "0" ]; then readErrorsColor="$warnColor"; else readErrorsColor="$bgColor"; fi
     if [ "$writeErrors" != "0" ]; then writeErrorsColor="$warnColor"; else writeErrorsColor="$bgColor"; fi
     if [ "$cksumErrors" != "0" ]; then cksumErrorsColor="$warnColor"; else cksumErrorsColor="$bgColor"; fi
@@ -245,114 +349,257 @@ for pool in $pools; do
         printf "<tr style=\"background-color:%s;\">
             <td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
             <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
+            <td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
+            <td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
+            <td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
+            <td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s%%</td>
+            <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s%%</td>
             <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
             <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
             <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
-            <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s%%</td>
             <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
             <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
             <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
             <td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
-        </tr>\\n" "$bgColor" "$pool" "$statusColor" "$status" "$readErrorsColor" "$readErrors" "$writeErrorsColor" "$writeErrors" "$cksumErrorsColor" \
-        "$cksumErrors" "$usedColor" "$used" "$scrubRepBytesColor" "$scrubRepBytes" "$scrubErrorsColor" "$scrubErrors" "$scrubAgeColor" "$scrubAge" "$scrubTime"
+        </tr>\\n" "$bgColor" "$pool" "$statusColor" "$status" "$size" "$allocated" "$free" "$frag" "$usedColor" "$used" "$readErrorsColor" "$readErrors" "$writeErrorsColor" "$writeErrors" "$cksumErrorsColor" \
+        "$cksumErrors" "$scrubRepBytesColor" "$scrubRepBytes" "$scrubErrorsColor" "$scrubErrors" "$scrubAgeColor" "$scrubAge" "$scrubTime"
     ) >> "$logfile"
 done
+
 # End of zpool status table
 echo "</table>" >> "$logfile"
 
-### SMART status summary table
+
+
+###### SSD SMART status summary table
+if [ "$ssdExist" == "true" ]; then
+    (
+        # Write HTML table headers to log file
+        echo "<br><br>"
+        echo "<table style=\"border: 1px solid black; border-collapse: collapse;\">"
+        echo "<tr><th colspan=\"18\" style=\"text-align:center; font-size:20px; height:40px; font-family:courier;\">SSD SMART Status Report Summary</th></tr>"
+        echo "<tr>"
+        echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Device</th>"
+        echo "  <th style=\"text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Model</th>"
+        echo "  <th style=\"text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Serial<br>Number</th>"
+        echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Capacity</th>"
+        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">SMART<br>Status</th>"
+        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Temp</th>"
+        echo "  <th style=\"text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Power-On<br>Time<br>($powerTimeFormat)</th>"
+        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Power<br>Cycle<br>Count</th>"
+        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Realloc<br>Sectors</th>"
+        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Program<br>Fail<br>Count</th>"
+        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Erase<br>Fail<br>Count</th>"
+        echo "  <th style=\"text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Offline<br>Uncorrectable<br>Sectors</th>"
+        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">CRC<br>Errors</th>"
+        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Wear<br>Leveling<br>Count</th>"
+        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Total<br>Bytes<br>Written</th>"
+        echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Bytes Written<br>(per Day)</th>"
+        echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Last Test<br>Age (days)</th>"
+        echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Last Test<br>Type</th></tr>"
+        echo "</tr>"
+    ) >> "$logfile"
+
+    for drive in $drives; do
+        if [ "$(smartctl -i /dev/"${drive}" | grep "Solid State Device")" ]; then
+            (
+                # For each drive detected, run "smartctl -A -i" and parse its output. This whole section is a single, long statement, so I'll make all comments here.
+                # Start by passing awk variables (all the -v's) used in other parts of the script. Other variables are calculated in-line with other smartctl calls.
+                # Next, pull values out of the original "smartctl -A -i" statement by searching for the text between the //'s.
+                # After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).
+                # After these computations, determine the row's background color (alternating as above, subbing in other colors from the palate as needed).
+                # Finally, print the HTML code for the current row of the table with all the gathered data.
+                smartctl -A -i /dev/"$drive" | \
+                awk -v device="$drive" -v tempWarn="$tempWarn" -v tempCrit="$tempCrit" -v sectorsCrit="$sectorsCrit" -v testAgeWarn="$testAgeWarn" \
+                -v okColor="$okColor" -v warnColor="$warnColor" -v critColor="$critColor" -v altColor="$altColor" -v powerTimeFormat="$powerTimeFormat" \
+                -v totalBWWarn="$totalBWWarn" -v totalBWCrit="$totalBWCrit" -v lifeRemainWarn="$lifeRemainWarn" -v lifeRemainCrit="$lifeRemainCrit" \
+                -v lastTestHours="$(smartctl -l selftest /dev/"$drive" | grep "# 1" | awk '{print $9}')" \
+                -v lastTestType="$(smartctl -l selftest /dev/"$drive" | grep "# 1" | awk '{print $3}')" \
+                -v smartStatus="$(smartctl -H /dev/"$drive" | grep "SMART overall-health" | awk '{print $6}')" ' \
+                /Device Model:/{$1="";$2=""; model=$0} \
+                /Serial Number:/{serial=$3} \
+                /User Capacity:/{capacity=$5 $6} \
+                /Temperature_Cel/{temp=($10 + 0)} \
+                /Power_On_Hours/{onHours=$10} \
+                /Power_Cycle_Count/{startStop=$10} \
+                /Reallocated_Sector/{reAlloc=$10} \
+                /Program_Fail/{progFail=$10} \
+                /Erase_Fail/{eraseFail=$10} \
+                /187 /{offlineUnc=$10} \
+                /CRC_Error_Count/{crcErrors=$10} \
+                /Wear_Leveling_Count/{wearLeveling=$4} \
+                /Sector Size/{sectorSize=$3} \
+                /LBAs_Written/{totalLBA=$10} \
+                END {
+                    testAge=int((onHours - lastTestHours) / 24);
+                    yrs=int(onHours / 8760);
+                    mos=int((onHours % 8760) / 730);
+                    dys=int(((onHours % 8760) % 730) / 24);
+                    hrs=((onHours % 8760) % 730) % 24;
+                    if (powerTimeFormat == "ymdh") onTime=yrs "y " mos "m " dys "d " hrs "h ";
+                    else if (powerTimeFormat == "ymd") onTime=yrs "y " mos "m " dys "d ";
+                    else if (powerTimeFormat == "ym") onTime=yrs "y " mos "m ";
+                    else if (powerTimeFormat == "y") onTime=yrs "y ";
+                    else onTime=yrs "y " mos "m " dys "d " hrs "h ";
+                    if ((substr(device, length(device), 1) + 0) % 2 == 1) bgColor = "#ffffff"; else bgColor = altColor;
+                    if (smartStatus != "PASSED") smartStatusColor = critColor; else smartStatusColor = okColor;
+                    if (temp >= tempCrit) tempColor = critColor; else if (temp >= tempWarn) tempColor = warnColor; else tempColor = bgColor;
+                    if (temp == 0) temp = "N/A"; else temp = temp "*C";
+                    if ((reAlloc + 0) > sectorsCrit) reAllocColor = critColor; else if (reAlloc != 0) reAllocColor = warnColor; else reAllocColor = bgColor;
+                    if ((progFail + 0) > sectorsCrit) progFailColor = critColor; else if (progFail != 0) progFailColor = warnColor; else progFailColor = bgColor;
+                    if ((eraseFail + 0) > sectorsCrit) eraseFailColor = critColor; else if (eraseFail != 0) eraseFailColor = warnColor; else eraseFailColor = bgColor;
+                    if ((offlineUnc + 0) > sectorsCrit) offlineUncColor = critColor; else if (offlineUnc != 0) offlineUncColor = warnColor; else offlineUncColor = bgColor;
+                    if (crcErrors != "0") crcErrorsColor = warnColor; else crcErrorsColor = bgColor;
+                    if (wearLeveling <= lifeRemainCrit) wearLevelingColor = critColor; else if (wearLeveling <= lifeRemainWarn) wearLevelingColor = warnColor; else wearLevelingColor = bgColor;
+                    totalBW=(((totalLBA * sectorSize) / 1048576) / 1048576);
+                    if (totalBW >= totalBWCrit) totalBWColor = critColor; else if (totalBW >= totalBWWarn) totalBWColor = warnColor; else totalBWColor = bgColor;
+                    if (totalBW == 0) totalBW = "N/A"; else totalBW = (int(totalBW) + int(((totalBW - int(totalBW)) * 10) + 0.501) / 10) "TB";
+                    bwPerDay=((totalBW * 1024)/ (onHours / 24));
+                    if (totalBW == "N/A") bwPerDay = "N/A"; else bwPerDay = (int(bwPerDay) + int(((bwPerDay - int(bwPerDay)) * 10) + 0.501) / 10) "GB";
+                    if (testAge > testAgeWarn) testAgeColor = critColor; else testAgeColor = bgColor;
+                    printf "<tr style=\"background-color:%s;\">" \
+                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">/dev/%s</td>" \
+                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%d%%</td>" \
+                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%d</td>" \
+                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                    "</tr>\n", bgColor, device, model, serial, capacity, smartStatusColor, smartStatus, tempColor, temp, onTime, startStop, reAllocColor, reAlloc, \
+                    progFailColor, progFail, eraseFailColor, eraseFail, offlineUncColor, offlineUnc, crcErrorsColor, crcErrors, wearLevelingColor, wearLeveling, totalBWColor, totalBW, \
+                    bwPerDay, testAgeColor, testAge, lastTestType;
+                }'
+            ) >> "$logfile"
+        fi
+    done
+
+    # End SMART summary table and summary section
+    (
+        echo "</table>"
+    ) >> "$logfile"
+fi
+
+
+
+###### HDD SMART status summary table
 (
     # Write HTML table headers to log file
     echo "<br><br>"
     echo "<table style=\"border: 1px solid black; border-collapse: collapse;\">"
-    echo "<tr><th colspan=\"15\" style=\"text-align:center; font-size:20px; height:40px; font-family:courier;\">SMART Status Report Summary</th></tr>"
+    echo "<tr><th colspan=\"18\" style=\"text-align:center; font-size:20px; height:40px; font-family:courier;\">HDD SMART Status Report Summary</th></tr>"
     echo "<tr>"
     echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Device</th>"
+    echo "  <th style=\"text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Model</th>"
     echo "  <th style=\"text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Serial<br>Number</th>"
+    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">RPM</th>"
+    echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Capacity</th>"
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">SMART<br>Status</th>"
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Temp</th>"
-    echo "  <th style=\"text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Power-On<br>Time</th>"
-    echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Start/Stop<br>Count</th>"
+    echo "  <th style=\"text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Power-On<br>Time<br>($powerTimeFormat)</th>"
+    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Start<br>Stop<br>Count</th>"
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Spin<br>Retry<br>Count</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Realloc'd<br>Sectors</th>"
+    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Realloc<br>Sectors</th>"
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Realloc<br>Events</th>"
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Current<br>Pending<br>Sectors</th>"
     echo "  <th style=\"text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Offline<br>Uncorrectable<br>Sectors</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">UltraDMA<br>CRC<br>Errors</th>"
+    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">CRC<br>Errors</th>"
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Seek<br>Error<br>Health</th>"
     echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Last Test<br>Age (days)</th>"
     echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Last Test<br>Type</th></tr>"
     echo "</tr>"
 ) >> "$logfile"
+
 for drive in $drives; do
-    (
-        # For each drive detected, run "smartctl -A -i" and parse its output. This whole section is a single, long statement, so I'll make all comments here.
-        # Start by passing awk variables (all the -v's) used in other parts of the script. Other variables are calculated in-line with other smartctl calls.
-        # Next, pull values out of the original "smartctl -A -i" statement by searching for the text between the //'s.
-        # After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).
-        # After these computations, determine the row's background color (alternating as above, subbing in other colors from the palate as needed).
-        # Finally, print the HTML code for the current row of the table with all the gathered data.
-        smartctl -A -i /dev/"$drive" | \
-        awk -v device="$drive" -v tempWarn="$tempWarn" -v tempCrit="$tempCrit" -v sectorsCrit="$sectorsCrit" -v testAgeWarn="$testAgeWarn" \
-        -v okColor="$okColor" -v warnColor="$warnColor" -v critColor="$critColor" -v altColor="$altColor" -v powerTimeFormat="$powerTimeFormat" \
-        -v lastTestHours="$(smartctl -l selftest /dev/"$drive" | grep "# 1" | awk '{print $9}')" \
-        -v lastTestType="$(smartctl -l selftest /dev/"$drive" | grep "# 1" | awk '{print $3}')" \
-        -v smartStatus="$(smartctl -H /dev/"$drive" | grep "SMART overall-health" | awk '{print $6}')" ' \
-        /Serial Number:/{serial=$3} \
-        /Temperature_Celsius/{temp=($10 + 0)} \
-        /Power_On_Hours/{onHours=$10} \
-        /Start_Stop_Count/{startStop=$10} \
-        /Spin_Retry_Count/{spinRetry=$10} \
-        /Reallocated_Sector/{reAlloc=$10} \
-        /Reallocated_Event_Count/{reAllocEvent=$10} \
-        /Current_Pending_Sector/{pending=$10} \
-        /Offline_Uncorrectable/{offlineUnc=$10} \
-        /UDMA_CRC_Error_Count/{crcErrors=$10} \
-        /Seek_Error_Rate/{seekErrorHealth=$4} \
-        END {
-            testAge=int((onHours - lastTestHours) / 24);
-            yrs=int(onHours / 8760);
-            mos=int((onHours % 8760) / 730);
-            dys=int(((onHours % 8760) % 730) / 24);
-            hrs=((onHours % 8760) % 730) % 24;
-            if (powerTimeFormat == "ymdh") onTime=yrs "y " mos "m " dys "d " hrs "h";
-            else if (powerTimeFormat == "ymd") onTime=yrs "y " mos "m " dys "d";
-            else if (powerTimeFormat == "ym") onTime=yrs "y " mos "m";
-            else if (powerTimeFormat == "y") onTime=yrs "y";
-            else onTime=yrs "y " mos "m " dys "d " hrs "h ";
-            if ((substr(device,3) + 0) % 2 == 1) bgColor = "#ffffff"; else bgColor = altColor;
-            if (smartStatus != "PASSED") smartStatusColor = critColor; else smartStatusColor = okColor;
-            if (temp >= tempCrit) tempColor = critColor; else if (temp >= tempWarn) tempColor = warnColor; else tempColor = bgColor;
-            if (spinRetry != "0") spinRetryColor = warnColor; else spinRetryColor = bgColor;
-            if ((reAlloc + 0) > sectorsCrit) reAllocColor = critColor; else if (reAlloc != 0) reAllocColor = warnColor; else reAllocColor = bgColor;
-            if (reAllocEvent != "0") reAllocEventColor = warnColor; else reAllocEventColor = bgColor;
-            if ((pending + 0) > sectorsCrit) pendingColor = critColor; else if (pending != 0) pendingColor = warnColor; else pendingColor = bgColor;
-            if ((offlineUnc + 0) > sectorsCrit) offlineUncColor = critColor; else if (offlineUnc != 0) offlineUncColor = warnColor; else offlineUncColor = bgColor;
-            if (crcErrors != "0") crcErrorsColor = warnColor; else crcErrorsColor = bgColor;
-            if ((seekErrorHealth + 0) < 100) seekErrorHealthColor = warnColor; else seekErrorHealthColor = bgColor;
-            if (testAge > testAgeWarn) testAgeColor = warnColor; else testAgeColor = bgColor;
-            printf "<tr style=\"background-color:%s;\">\n" \
-                "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">/dev/%s</td>\n" \
-                "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>\n" \
-                "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>\n" \
-                "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%d*C</td>\n" \
-                "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>\n" \
-                "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>\n" \
-                "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>\n" \
-                "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>\n" \
-                "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>\n" \
-                "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>\n" \
-                "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>\n" \
-                "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>\n" \
-                "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s%%</td>\n" \
-                "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%d</td>\n" \
-                "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>\n" \
-            "</tr>\n", bgColor, device, serial, smartStatusColor, smartStatus, tempColor, temp, onTime, startStop, spinRetryColor, spinRetry, reAllocColor, reAlloc, \
-            reAllocEventColor, reAllocEvent, pendingColor, pending, offlineUncColor, offlineUnc, crcErrorsColor, crcErrors, seekErrorHealthColor, seekErrorHealth, \
-            testAgeColor, testAge, lastTestType;
-        }'
-    ) >> "$logfile"
+    if [ "$(smartctl -i /dev/"${drive}" | grep "SMART support is: Enabled")" ]; then
+        if ! [ "$(smartctl -i /dev/"${drive}" | grep "Solid State Device")" ]; then
+        (
+            # For each drive detected, run "smartctl -A -i" and parse its output. This whole section is a single, long statement, so I'll make all comments here.
+            # Start by passing awk variables (all the -v's) used in other parts of the script. Other variables are calculated in-line with other smartctl calls.
+            # Next, pull values out of the original "smartctl -A -i" statement by searching for the text between the //'s.
+            # After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).
+            # After these computations, determine the row's background color (alternating as above, subbing in other colors from the palate as needed).
+            # Finally, print the HTML code for the current row of the table with all the gathered data.
+            smartctl -A -i /dev/"$drive" | \
+            awk -v device="$drive" -v tempWarn="$tempWarn" -v tempCrit="$tempCrit" -v sectorsCrit="$sectorsCrit" -v testAgeWarn="$testAgeWarn" \
+            -v okColor="$okColor" -v warnColor="$warnColor" -v critColor="$critColor" -v altColor="$altColor" -v powerTimeFormat="$powerTimeFormat" \
+            -v lastTestHours="$(smartctl -l selftest /dev/"$drive" | grep "# 1" | awk '{print $9}')" \
+            -v lastTestType="$(smartctl -l selftest /dev/"$drive" | grep "# 1" | awk '{print $3}')" \
+            -v smartStatus="$(smartctl -H /dev/"$drive" | grep "SMART overall-health" | awk '{print $6}')" ' \
+            /Device Model:/{$1="";$2=""; model=$0} \
+            /Serial Number:/{serial=$3} \
+            /User Capacity:/{capacity=$5 $6} \
+            /Rotation Rate:/{rpm=$3} \
+            /Temperature_Cel/{temp=($10 + 0)} \
+            /Power_On_Hours/{onHours=$10} \
+            /Start_Stop_Count/{startStop=$10} \
+            /Spin_Retry_Count/{spinRetry=$10} \
+            /Reallocated_Sector/{reAlloc=$10} \
+            /Reallocated_Event_Count/{reAllocEvent=$10} \
+            /Current_Pending_Sector/{pending=$10} \
+            /Offline_Uncorrectable/{offlineUnc=$10} \
+            /UDMA_CRC_Error_Count/{crcErrors=$10} \
+            /Seek_Error_Rate/{seekErrorHealth=$4} \
+            END {
+                testAge=int((onHours - lastTestHours) / 24);
+                yrs=int(onHours / 8760);
+                mos=int((onHours % 8760) / 730);
+                dys=int(((onHours % 8760) % 730) / 24);
+                hrs=((onHours % 8760) % 730) % 24;
+                if (powerTimeFormat == "ymdh") onTime=yrs "y " mos "m " dys "d " hrs "h ";
+                else if (powerTimeFormat == "ymd") onTime=yrs "y " mos "m " dys "d ";
+                else if (powerTimeFormat == "ym") onTime=yrs "y " mos "m ";
+                else if (powerTimeFormat == "y") onTime=yrs "y ";
+                else onTime=yrs "y " mos "m " dys "d " hrs "h ";
+                if ((substr(device, length(device), 1) + 0) % 2 == 1) bgColor = "#ffffff"; else bgColor = altColor;
+                if (smartStatus != "PASSED") smartStatusColor = critColor; else smartStatusColor = okColor;
+                if (temp >= tempCrit) tempColor = critColor; else if (temp >= tempWarn) tempColor = warnColor; else tempColor = bgColor;
+                if (spinRetry != "0") spinRetryColor = warnColor; else spinRetryColor = bgColor;
+                if ((reAlloc + 0) > sectorsCrit) reAllocColor = critColor; else if (reAlloc != 0) reAllocColor = warnColor; else reAllocColor = bgColor;
+                if (reAllocEvent != "0") reAllocEventColor = warnColor; else reAllocEventColor = bgColor;
+                if ((pending + 0) > sectorsCrit) pendingColor = critColor; else if (pending != 0) pendingColor = warnColor; else pendingColor = bgColor;
+                if ((offlineUnc + 0) > sectorsCrit) offlineUncColor = critColor; else if (offlineUnc != 0) offlineUncColor = warnColor; else offlineUncColor = bgColor;
+                if (crcErrors != "0") crcErrorsColor = warnColor; else crcErrorsColor = bgColor;
+                if ((seekErrorHealth + 0) < 100) seekErrorHealthColor = warnColor; else seekErrorHealthColor = bgColor;
+                if (testAge > testAgeWarn) testAgeColor = critColor; else testAgeColor = bgColor;
+                printf "<tr style=\"background-color:%s;\">" \
+                    "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">/dev/%s</td>" \
+                    "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                    "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                    "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                    "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                    "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                    "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%d*C</td>" \
+                    "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                    "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                    "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                    "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                    "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                    "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                    "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                    "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                    "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%d%%</td>" \
+                    "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%d</td>" \
+                    "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
+                "</tr>\n", bgColor, device, model, serial, rpm, capacity, smartStatusColor, smartStatus, tempColor, temp, onTime, startStop, spinRetryColor, spinRetry, reAllocColor, reAlloc, \
+                reAllocEventColor, reAllocEvent, pendingColor, pending, offlineUncColor, offlineUnc, crcErrorsColor, crcErrors, seekErrorHealthColor, seekErrorHealth, \
+                testAgeColor, testAge, lastTestType;
+            }'
+        ) >> "$logfile"
+        fi
+    fi
 done
+
 # End SMART summary table and summary section
 (
     echo "</table>"
@@ -360,35 +607,109 @@ done
 ) >> "$logfile"
 
 
+
 ###### Detailed Report Section (monospace text)
 echo "<pre style=\"font-size:14px\">" >> "$logfile"
 
-### zpool status for each pool
+
+### UPS status report
+if [ "$reportUPS" == "true" ]; then
+
+    # Set to a value greater than zero to include all available UPSC
+    # variables in the report:
+    senddetail=0
+
+    # Get a list of all ups devices installed on the system:
+    upslist=$(upsc -l "${host}")
+
+    (
+    echo "<pre style=\"font-size:14px\">"
+    echo "<b>########## UPS status report ##########</b>"
+        for ups in $upslist; do
+        ups_type=$(upsc "${ups}" device.type 2> /dev/null | tr '[:lower:]' '[:upper:]')
+        ups_mfr=$(upsc "${ups}" ups.mfr 2> /dev/null)
+        ups_model=$(upsc "${ups}" ups.model 2> /dev/null)
+        ups_serial=$(upsc "${ups}" ups.serial 2> /dev/null)
+        ups_status=$(upsc "${ups}" ups.status 2> /dev/null)
+        ups_load=$(upsc "${ups}" ups.load 2> /dev/null)
+        ups_realpower=$(upsc "${ups}" ups.realpower 2> /dev/null)
+        ups_realpowernominal=$(upsc "${ups}" ups.realpower.nominal 2> /dev/null)
+        ups_batterycharge=$(upsc "${ups}" battery.charge 2> /dev/null)
+        ups_batteryruntime=$(upsc "${ups}" battery.runtime 2> /dev/null)
+        ups_batteryvoltage=$(upsc "${ups}" battery.voltage 2> /dev/null)
+        ups_inputvoltage=$(upsc "${ups}" input.voltage 2> /dev/null)
+        ups_outputvoltage=$(upsc "${ups}" output.voltage 2> /dev/null)
+        printf "=== %s %s, model %s, serial number %s\n\n" "${ups_mfr}" "${ups_type}" "${ups_model}" "${ups_serial} ==="
+        echo "Name: ${ups}"
+        echo "Status: ${ups_status}"
+        echo "Output Load: ${ups_load}%"
+        if [ ! -z "${ups_realpower}" ]; then
+            echo "Real Power: ${ups_realpower}W"
+        fi
+        if [ ! -z "${ups_realpowernominal}" ]; then
+            echo "Real Power: ${ups_realpowernominal}W (nominal)"
+        fi
+        if [ ! -z "${ups_inputvoltage}" ]; then
+            echo "Input Voltage: ${ups_inputvoltage}V"
+        fi
+        if [ ! -z "${ups_outputvoltage}" ]; then
+            echo "Output Voltage: ${ups_outputvoltage}V"
+        fi
+        echo "Battery Runtime: ${ups_batteryruntime}s"
+        echo "Battery Charge: ${ups_batterycharge}%"
+        echo "Battery Voltage: ${ups_batteryvoltage}V"
+        echo ""
+        if [ $senddetail -gt 0 ]; then
+            echo "=== ALL AVAILABLE UPS VARIABLES ==="
+            upsc "${ups}"
+            echo ""
+        fi
+    done
+    ) >> ${logfile}
+
+    echo "</pre>" >> ${logfile}
+fi
+
+
+### Print Glabel Status
+(
+    echo "<b>########## Glabel Status ##########</b>"
+    glabel status
+    echo "<br><br>"
+) >> "$logfile"
+
+
+### Zpool status for each pool
 for pool in $pools; do
     (
         # Create a simple header and drop the output of zpool status -v
         echo "<b>########## ZPool status report for ${pool} ##########</b>"
-        echo "<br>"
         zpool status -v "$pool"
         echo "<br><br>"
     ) >> "$logfile"
 done
 
+
 ### SMART status for each drive
 for drive in $drives; do
-    # Gather brand and serial number of each drive
-    brand="$(smartctl -i /dev/"$drive" | grep "Model Family" | awk '{print $3, $4, $5}')"
-    serial="$(smartctl -i /dev/"$drive" | grep "Serial Number" | awk '{print $3}')"
-    (
-        # Create a simple header and drop the output of some basic smartctl commands
-        echo "<br>"
-        echo "<b>########## SMART status report for ${drive} drive (${brand}: ${serial}) ##########</b>"
-        smartctl -H -A -l error /dev/"$drive"
-        smartctl -l selftest /dev/"$drive" | grep "Extended \\|Num" | cut -c6- | head -2
-        smartctl -l selftest /dev/"$drive" | grep "Short \\|Num" | cut -c6- | head -2 | tail -n -1
-        echo "<br><br>"
-    ) >> "$logfile"
+    if [ "$(smartctl -i /dev/"${drive}" | grep "SMART support is: Enabled")" ]; then
+        # Gather brand and serial number of each drive
+        brand="$(smartctl -i /dev/"$drive" | grep "Model Family" | awk '{print $3, $4, $5}')"
+        if [ "$brand" == "" ]; then
+            brand="$(smartctl -i /dev/"$drive" | grep "Device Model" | awk '{print $3, $4, $5}')";
+        fi
+        serial="$(smartctl -i /dev/"$drive" | grep "Serial Number" | awk '{print $3}')"
+        (
+            # Create a simple header and drop the output of some basic smartctl commands
+            echo "<b>########## SMART status report for ${drive} drive (${brand}: ${serial}) ##########</b>"
+            smartctl -H -A -l error /dev/"$drive"
+            smartctl -l selftest /dev/"$drive" | grep "Extended \\|Num" | cut -c6- | head -2
+            smartctl -l selftest /dev/"$drive" | grep "Short \\|Num" | cut -c6- | head -2 | tail -n -1
+            echo "<br><br>"
+        ) >> "$logfile"
+    fi
 done
+
 # Remove some un-needed junk from the output
 sed -i '' -e '/smartctl 6.3/d' "$logfile"
 sed -i '' -e '/Copyright/d' "$logfile"
@@ -405,4 +726,6 @@ sed -i '' -e '/SMART Error Log Version/d' "$logfile"
 
 ### Send report
 sendmail -t -oi < "$logfile"
-rm "$logfile"
+if [ "$saveLogfile" == "false" ]; then
+    rm "$logfile"
+fi

From 431f38a2a97d2a976153ea2b939018c656f7e66e Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 11 Apr 2021 10:36:05 -0400
Subject: [PATCH 013/160] Use smart id instead of name.

Ids are standardized (mostly) but names are not.

Fixes #3.
---
 report.sh | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)
 mode change 100644 => 100755 report.sh

diff --git a/report.sh b/report.sh
old mode 100644
new mode 100755
index 1407fb0..b594188
--- a/report.sh
+++ b/report.sh
@@ -369,16 +369,16 @@ for drive in $drives; do
         /Serial Number:/{serial=$3} \
         /User Capacity:/{capacity=$5 $6} \
         /Rotation Rate:/{rpm=$3} \
-        /Temperature_Celsius/{temp=($10 + 0)} \
-        /Power_On_Hours/{onHours=$10} \
-        /Start_Stop_Count/{startStop=$10} \
-        /Spin_Retry_Count/{spinRetry=$10} \
-        /Reallocated_Sector/{reAlloc=$10} \
-        /Reallocated_Event_Count/{reAllocEvent=$10} \
-        /Current_Pending_Sector/{pending=$10} \
-        /Offline_Uncorrectable/{offlineUnc=$10} \
-        /UDMA_CRC_Error_Count/{crcErrors=$10} \
-        /Seek_Error_Rate/{seekErrorHealth=$4} \
+        $1 ~ /^194$/{temp=($10 + 0)} \
+        $1 ~ /^9$/{onHours=$10} \
+        $1 ~ /^4$/{startStop=$10} \
+        $1 ~ /^10$/{spinRetry=$10} \
+        $1 ~ /^5$/{reAlloc=$10} \
+        $1 ~ /^196$/{reAllocEvent=$10} \
+        $1 ~ /^197$/{pending=$10} \
+        $1 ~ /^198$/{offlineUnc=$10} \
+        $1 ~ /^199$/{crcErrors=$10} \
+        $1 ~ /^7$/{seekErrorHealth=$4} \
         END {
             testAge=int((onHours - lastTestHours) / 24);
             yrs=int(onHours / 8760);

From 67ea149aebbf7627d6aa52b3a1253476608cacc9 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 11 Apr 2021 10:58:05 -0400
Subject: [PATCH 014/160] Use a config file.

---
 .gitignore |  4 +++-
 report.sh  | 47 +++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 50 insertions(+), 1 deletion(-)

diff --git a/.gitignore b/.gitignore
index b833677..a153b2b 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,2 +1,4 @@
 install.sh
-*.sublime*
\ No newline at end of file
+*.sublime*
+
+report.cfg
diff --git a/report.sh b/report.sh
index b594188..48cdc88 100755
--- a/report.sh
+++ b/report.sh
@@ -51,6 +51,12 @@
 # - Fix SSD SMART reporting
 # - Add support for conveyance test
 
+# Write out a default config file
+function rpConfig {
+	tee > "${configFile}" <<"EOF"
+
+# Set this to 0 to enable
+defaultFile="1"
 
 ###### User-definable Parameters
 ### Email Address
@@ -80,6 +86,47 @@ saveBackup="true"       # Change to "false" to delete FreeNAS config backup afte
 backupLocation="/path/to/config/backup"   # Directory in which to save FreeNAS config backups
 
 
+EOF
+	exit 0
+}
+
+
+#
+# Main Script Starts Here
+#
+
+while getopts ":c:" OPTION; do
+	case "${OPTION}" in
+		c)
+			configFile="${OPTARG}"
+		;;
+		?)
+			# If an unknown flag is used (or -?):
+			echo "${0} {-c configFile}" >&2
+			exit 1
+		;;
+	esac
+done
+
+if [ -z "${configFile}" ]; then
+	echo "Please specify a config file location." >&2
+	exit 1
+elif [ ! -f "${configFile}" ]; then
+	rpConfig
+fi
+
+# Source external config file
+# shellcheck source=/dev/null
+. "${configFile}"
+
+
+# Do not run if the config file has not been edited.
+if [ ! "${defaultFile}" = "0" ]; then
+	echo "Please edit the config file for your setup" >&2
+	exit 1
+fi
+
+
 ###### Auto-generated Parameters
 host=$(hostname -s)
 logfile="/tmp/smart_report.tmp"

From fe82ce78365e42c971ad4139c47af749d19ed5d7 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 11 Apr 2021 10:59:36 -0400
Subject: [PATCH 015/160] Add a check for commands.

---
 report.sh | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/report.sh b/report.sh
index 48cdc88..f9ee825 100755
--- a/report.sh
+++ b/report.sh
@@ -119,6 +119,27 @@ fi
 # shellcheck source=/dev/null
 . "${configFile}"
 
+# Check if needed software is installed.
+PATH="${PATH}:/usr/local/sbin:/usr/local/bin"
+commands=(
+grep
+sed
+cut
+sleep
+bc
+smartctl
+jq
+ipmitool
+awk
+tar
+)
+for command in "${commands[@]}"; do
+	if ! type "${command}" &> /dev/null; then
+		echo "${command} is missing, please install" >&2
+		exit 100
+	fi
+done
+
 
 # Do not run if the config file has not been edited.
 if [ ! "${defaultFile}" = "0" ]; then

From 39128d8cf47920940cda152558b29a93453ccec1 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 11 Apr 2021 13:44:37 -0400
Subject: [PATCH 016/160] Shellcheck pass and general formatting.

---
 report.sh | 53 +++++++++++++++++++++++++++--------------------------
 1 file changed, 27 insertions(+), 26 deletions(-)

diff --git a/report.sh b/report.sh
index cf71afa..052c783 100755
--- a/report.sh
+++ b/report.sh
@@ -1,4 +1,5 @@
 #!/bin/bash
+# shellcheck disable=SC1004,SC2236
 
 #set -euxo pipefail
 
@@ -179,15 +180,15 @@ boundary="gc0p4Jq0M2Yt08jU534c0p"
 
 # Reorders the drives in ascending order
 drives=$(for drive in $(sysctl -n kern.disks); do
-    if [ "$(smartctl -i /dev/"${drive}" | grep "SMART support is: Enabled")" ]; then
+    if smartctl -i "/dev/${drive}" | grep -q "SMART support is: Enabled"; then
         printf "%s " "${drive}"
     fi
 done | awk '{for (i=NF; i!=0 ; i--) print $i }')
 
 # Toggles the 'ssdExist' flag to true if SSDs are detected in order to add the summary table
-if [ "$includeSSD" == "true" ]; then
+if [ "${includeSSD}" == "true" ]; then
     for drive in $drives; do
-        if [ "$(smartctl -i /dev/"${drive}" | grep "Solid State Device")" ]; then
+        if smartctl -i "/dev/${drive}" | grep -q "Solid State Device"; then
             ssdExist="true"
         else
             ssdExist="false"
@@ -440,7 +441,7 @@ echo "</table>" >> "$logfile"
 
 
 ###### SSD SMART status summary table
-if [ "$ssdExist" == "true" ]; then
+if [ "${ssdExist}" == "true" ]; then
     (
         # Write HTML table headers to log file
         echo "<br><br>"
@@ -469,7 +470,7 @@ if [ "$ssdExist" == "true" ]; then
     ) >> "$logfile"
 
     for drive in $drives; do
-        if [ "$(smartctl -i /dev/"${drive}" | grep "Solid State Device")" ]; then
+        if smartctl -i "/dev/${drive}" | grep -q "Solid State Device"; then
             (
                 # For each drive detected, run "smartctl -A -i" and parse its output. This whole section is a single, long statement, so I'll make all comments here.
                 # Start by passing awk variables (all the -v's) used in other parts of the script. Other variables are calculated in-line with other smartctl calls.
@@ -477,12 +478,12 @@ if [ "$ssdExist" == "true" ]; then
                 # After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).
                 # After these computations, determine the row's background color (alternating as above, subbing in other colors from the palate as needed).
                 # Finally, print the HTML code for the current row of the table with all the gathered data.
-                smartctl -A -i /dev/"$drive" | \
+                smartctl -A -i "/dev/${drive}" | \
                 awk -v device="$drive" -v tempWarn="$tempWarn" -v tempCrit="$tempCrit" -v sectorsCrit="$sectorsCrit" -v testAgeWarn="$testAgeWarn" \
                 -v okColor="$okColor" -v warnColor="$warnColor" -v critColor="$critColor" -v altColor="$altColor" -v powerTimeFormat="$powerTimeFormat" \
                 -v totalBWWarn="$totalBWWarn" -v totalBWCrit="$totalBWCrit" -v lifeRemainWarn="$lifeRemainWarn" -v lifeRemainCrit="$lifeRemainCrit" \
-                -v lastTestHours="$(smartctl -l selftest /dev/"$drive" | grep "# 1" | awk '{print $9}')" \
-                -v lastTestType="$(smartctl -l selftest /dev/"$drive" | grep "# 1" | awk '{print $3}')" \
+                -v lastTestHours="$(smartctl -l selftest "/dev/${drive}" | grep "# 1" | awk '{print $9}')" \
+                -v lastTestType="$(smartctl -l selftest "/dev/${drive}" | grep "# 1" | awk '{print $3}')" \
                 -v smartStatus="$(smartctl -H /dev/"$drive" | grep "SMART overall-health" | awk '{print $6}')" ' \
                 /Device Model:/{$1="";$2=""; model=$0} \
                 /Serial Number:/{serial=$3} \
@@ -589,8 +590,8 @@ fi
 ) >> "$logfile"
 
 for drive in $drives; do
-    if [ "$(smartctl -i /dev/"${drive}" | grep "SMART support is: Enabled")" ]; then
-        if ! [ "$(smartctl -i /dev/"${drive}" | grep "Solid State Device")" ]; then
+    if smartctl -i "/dev/${drive}" | grep -q "SMART support is: Enabled"; then
+        if ! smartctl -i "/dev/${drive}" | grep -q "Solid State Device"; then
         (
             # For each drive detected, run "smartctl -A -i" and parse its output. This whole section is a single, long statement, so I'll make all comments here.
             # Start by passing awk variables (all the -v's) used in other parts of the script. Other variables are calculated in-line with other smartctl calls.
@@ -733,9 +734,9 @@ if [ "$reportUPS" == "true" ]; then
             echo ""
         fi
     done
-    ) >> ${logfile}
+    ) >> "${logfile}"
 
-    echo "</pre>" >> ${logfile}
+    echo "</pre>" >> "${logfile}"
 fi
 
 
@@ -760,31 +761,31 @@ done
 
 ### SMART status for each drive
 for drive in $drives; do
-    if [ "$(smartctl -i /dev/"${drive}" | grep "SMART support is: Enabled")" ]; then
+    if smartctl -i "/dev/${drive}" | grep -q "SMART support is: Enabled"; then
         # Gather brand and serial number of each drive
-        brand="$(smartctl -i /dev/"$drive" | grep "Model Family" | awk '{print $3, $4, $5}')"
+        brand="$(smartctl -i "/dev/${drive}" | grep "Model Family" | awk '{print $3, $4, $5}')"
         if [ "$brand" == "" ]; then
-            brand="$(smartctl -i /dev/"$drive" | grep "Device Model" | awk '{print $3, $4, $5}')";
+            brand="$(smartctl -i "/dev/${drive}" | grep "Device Model" | awk '{print $3, $4, $5}')";
         fi
-        serial="$(smartctl -i /dev/"$drive" | grep "Serial Number" | awk '{print $3}')"
+        serial="$(smartctl -i "/dev/${drive}" | grep "Serial Number" | awk '{print $3}')"
         (
             # Create a simple header and drop the output of some basic smartctl commands
             echo "<b>########## SMART status report for ${drive} drive (${brand}: ${serial}) ##########</b>"
-            smartctl -H -A -l error /dev/"$drive"
-            smartctl -l selftest /dev/"$drive" | grep "Extended \\|Num" | cut -c6- | head -2
-            smartctl -l selftest /dev/"$drive" | grep "Short \\|Num" | cut -c6- | head -2 | tail -n -1
+            smartctl -H -A -l error "/dev/${drive}"
+            smartctl -l selftest "/dev/${drive}" | grep "Extended \\|Num" | cut -c6- | head -2
+            smartctl -l selftest "/dev/${drive}" | grep "Short \\|Num" | cut -c6- | head -2 | tail -n -1
             echo "<br><br>"
-        ) >> "$logfile"
+        ) >> "${logfile}"
     fi
 done
 
 # Remove some un-needed junk from the output
-sed -i '' -e '/smartctl 6.3/d' "$logfile"
-sed -i '' -e '/Copyright/d' "$logfile"
-sed -i '' -e '/=== START OF READ/d' "$logfile"
-sed -i '' -e '/SMART Attributes Data/d' "$logfile"
-sed -i '' -e '/Vendor Specific SMART/d' "$logfile"
-sed -i '' -e '/SMART Error Log Version/d' "$logfile"
+sed -i '' -e '/smartctl 6.3/d' "${logfile}"
+sed -i '' -e '/Copyright/d' "${logfile}"
+sed -i '' -e '/=== START OF READ/d' "${logfile}"
+sed -i '' -e '/SMART Attributes Data/d' "${logfile}"
+sed -i '' -e '/Vendor Specific SMART/d' "${logfile}"
+sed -i '' -e '/SMART Error Log Version/d' "${logfile}"
 
 ### End details section, close MIME section
 (

From c5c3636276a31d1a5b394bb868e25951f58f1d4e Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 11 Apr 2021 13:59:50 -0400
Subject: [PATCH 017/160] Make sure the ssd table actually gets displayed.

---
 report.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/report.sh b/report.sh
index 052c783..dede1f9 100755
--- a/report.sh
+++ b/report.sh
@@ -190,6 +190,7 @@ if [ "${includeSSD}" == "true" ]; then
     for drive in $drives; do
         if smartctl -i "/dev/${drive}" | grep -q "Solid State Device"; then
             ssdExist="true"
+            break
         else
             ssdExist="false"
         fi
@@ -441,7 +442,7 @@ echo "</table>" >> "$logfile"
 
 
 ###### SSD SMART status summary table
-if [ "${ssdExist}" == "true" ]; then
+if [ "${ssdExist}" = "true" ]; then
     (
         # Write HTML table headers to log file
         echo "<br><br>"

From 1f51c279490456ed7844534c93ffcf1d87a5bfaa Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 11 Apr 2021 14:20:32 -0400
Subject: [PATCH 018/160] Use either common wear level indicator.

---
 report.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/report.sh b/report.sh
index dede1f9..e36c594 100755
--- a/report.sh
+++ b/report.sh
@@ -497,7 +497,7 @@ if [ "${ssdExist}" = "true" ]; then
                 $1 ~ /^172$/{eraseFail=$10} \
                 $1 ~ /^187$/{offlineUnc=$10} \
                 $1 ~ /^199$/{crcErrors=$10} \
-                $1 ~ /^173$/{wearLeveling=$4} \
+                $1 ~ /^173$/ || $1 ~ /^233$/{wearLeveling=$4} \
                 /Sector Size/{sectorSize=$3} \
                 $1 ~ /^241$/{totalLBA=$10} \
                 END {

From e3c272e62d66b00c3ad8ee40288634237b14036c Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 12 Apr 2021 01:30:57 +0000
Subject: [PATCH 019/160] Try to make things work for more ssds.

Only use smart 321 when both 231 and 233 are present.
---
 report.sh | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/report.sh b/report.sh
index e36c594..bb23702 100755
--- a/report.sh
+++ b/report.sh
@@ -479,27 +479,32 @@ if [ "${ssdExist}" = "true" ]; then
                 # After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).
                 # After these computations, determine the row's background color (alternating as above, subbing in other colors from the palate as needed).
                 # Finally, print the HTML code for the current row of the table with all the gathered data.
-                smartctl -A -i "/dev/${drive}" | \
+                ssdInfoSmrt="$(smartctl -A -i "/dev/${drive}")"
+                if echo "${ssdInfoSmrt}" | grep -q "^231"; then
+            		ssdInfoSmrt="$(echo "${ssdInfoSmrt}" | grep -v '^233')"
+            	fi
+                echo "${ssdInfoSmrt}" | \
                 awk -v device="$drive" -v tempWarn="$tempWarn" -v tempCrit="$tempCrit" -v sectorsCrit="$sectorsCrit" -v testAgeWarn="$testAgeWarn" \
                 -v okColor="$okColor" -v warnColor="$warnColor" -v critColor="$critColor" -v altColor="$altColor" -v powerTimeFormat="$powerTimeFormat" \
                 -v totalBWWarn="$totalBWWarn" -v totalBWCrit="$totalBWCrit" -v lifeRemainWarn="$lifeRemainWarn" -v lifeRemainCrit="$lifeRemainCrit" \
-                -v lastTestHours="$(smartctl -l selftest "/dev/${drive}" | grep "# 1" | awk '{print $9}')" \
-                -v lastTestType="$(smartctl -l selftest "/dev/${drive}" | grep "# 1" | awk '{print $3}')" \
+                -v lastTestHours="$(smartctl -l selftest "/dev/${drive}" | grep '# 1' | awk '{print $9}')" \
+                -v lastTestType="$(smartctl -l selftest "/dev/${drive}" | grep '# 1' | awk '{print $3}')" \
                 -v smartStatus="$(smartctl -H /dev/"$drive" | grep "SMART overall-health" | awk '{print $6}')" ' \
                 /Device Model:/{$1="";$2=""; model=$0} \
                 /Serial Number:/{serial=$3} \
                 /User Capacity:/{capacity=$5 $6} \
                 $1 ~ /^194$/{temp=($10 + 0)} \
                 $1 ~ /^9$/{onHours=$10} \
-                $1 ~ /^4$/{startStop=$10} \
+                $1 ~ /^12$/{startStop=$10} \
                 $1 ~ /^5$/{reAlloc=$10} \
                 $1 ~ /^171$/{progFail=$10} \
                 $1 ~ /^172$/{eraseFail=$10} \
                 $1 ~ /^187$/{offlineUnc=$10} \
                 $1 ~ /^199$/{crcErrors=$10} \
-                $1 ~ /^173$/ || $1 ~ /^233$/{wearLeveling=$4} \
+                {if ($1 ~ /^173$/) {wearLeveling=$4}} \
+                {if ($1 ~ /^(231)|(233)$/) {wearLeveling=$4}} \
                 /Sector Size/{sectorSize=$3} \
-                $1 ~ /^241$/{totalLBA=$10} \
+                $1 ~ /^241$/ || $1 ~ /^246$/{totalLBA=$10} \
                 END {
                     testAge=int((onHours - lastTestHours) / 24);
                     yrs=int(onHours / 8760);

From b023681c3991476dfb4ea6e634e335a50488b615 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 12 Apr 2021 00:08:22 -0400
Subject: [PATCH 020/160] Print NVMe smart data.

---
 report.sh | 29 +++++++++++++++++++++++------
 1 file changed, 23 insertions(+), 6 deletions(-)

diff --git a/report.sh b/report.sh
index bb23702..cd9e9f4 100755
--- a/report.sh
+++ b/report.sh
@@ -179,9 +179,11 @@ subject="Status Report and Configuration Backup for ${host} - $(date "+%Y-%m-%d
 boundary="gc0p4Jq0M2Yt08jU534c0p"
 
 # Reorders the drives in ascending order
-drives=$(for drive in $(sysctl -n kern.disks); do
+drives=$(for drive in $(sysctl -n kern.disks | sed -e 's:nvd:nvme:g'); do
     if smartctl -i "/dev/${drive}" | grep -q "SMART support is: Enabled"; then
         printf "%s " "${drive}"
+	elif smartctl -a "/dev/${drive}" | grep -q "SMART overall-health self-assessment test result"; then
+		printf "%s " "${drive}"
     fi
 done | awk '{for (i=NF; i!=0 ; i--) print $i }')
 
@@ -769,11 +771,11 @@ done
 for drive in $drives; do
     if smartctl -i "/dev/${drive}" | grep -q "SMART support is: Enabled"; then
         # Gather brand and serial number of each drive
-        brand="$(smartctl -i "/dev/${drive}" | grep "Model Family" | awk '{print $3, $4, $5}')"
-        if [ "$brand" == "" ]; then
-            brand="$(smartctl -i "/dev/${drive}" | grep "Device Model" | awk '{print $3, $4, $5}')";
+        brand="$(smartctl -ij "/dev/${drive}" | jq -Mre '.model_family | values')"
+        if [ -z "${brand}" ]; then
+            brand="$(smartctl -ij "/dev/${drive}" | jq -Mre '.model_name | values')";
         fi
-        serial="$(smartctl -i "/dev/${drive}" | grep "Serial Number" | awk '{print $3}')"
+        serial="$(smartctl -ij "/dev/${drive}" | jq -Mre '.serial_number | values')"
         (
             # Create a simple header and drop the output of some basic smartctl commands
             echo "<b>########## SMART status report for ${drive} drive (${brand}: ${serial}) ##########</b>"
@@ -782,11 +784,26 @@ for drive in $drives; do
             smartctl -l selftest "/dev/${drive}" | grep "Short \\|Num" | cut -c6- | head -2 | tail -n -1
             echo "<br><br>"
         ) >> "${logfile}"
+
+    elif smartctl -a "/dev/${drive}" | grep -q "SMART overall-health self-assessment test result"; then
+        # Gather brand and serial number of each drive
+		nvmeSmartOut="$(smartctl -aj /dev/nvme0)"
+		brand="$(echo "${nvmeSmartOut}" | jq -Mre '.model_family| values')"
+        if [ -z "${brand}" ]; then
+            brand="$(echo "${nvmeSmartOut}" | jq -Mre '.model_name | values')";
+        fi
+		serial="$(echo "${nvmeSmartOut}" | jq -Mre '.serial_number | values')"
+		(
+			# Create a simple header and drop the output of some basic smartctl commands
+            echo "<b>########## SMART status report for ${drive} drive (${brand}: ${serial}) ##########</b>"
+            smartctl -H -A -l error "/dev/${drive}"
+            echo "<br><br>"
+		) >> "${logfile}"
     fi
 done
 
 # Remove some un-needed junk from the output
-sed -i '' -e '/smartctl 6.3/d' "${logfile}"
+sed -i '' -e '/smartctl 7.1/d' "${logfile}"
 sed -i '' -e '/Copyright/d' "${logfile}"
 sed -i '' -e '/=== START OF READ/d' "${logfile}"
 sed -i '' -e '/SMART Attributes Data/d' "${logfile}"

From 58efca14f9c5556bc8748a15772e1afc6bb014c0 Mon Sep 17 00:00:00 2001
From: Robert Muchsel <7576579+rotx@users.noreply.github.com>
Date: Mon, 12 Apr 2021 05:25:33 +0000
Subject: [PATCH 021/160] Fix extended self test time parsing.

---
 report.sh | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/report.sh b/report.sh
index cd9e9f4..3dd1644 100755
--- a/report.sh
+++ b/report.sh
@@ -486,12 +486,12 @@ if [ "${ssdExist}" = "true" ]; then
             		ssdInfoSmrt="$(echo "${ssdInfoSmrt}" | grep -v '^233')"
             	fi
                 echo "${ssdInfoSmrt}" | \
-                awk -v device="$drive" -v tempWarn="$tempWarn" -v tempCrit="$tempCrit" -v sectorsCrit="$sectorsCrit" -v testAgeWarn="$testAgeWarn" \
-                -v okColor="$okColor" -v warnColor="$warnColor" -v critColor="$critColor" -v altColor="$altColor" -v powerTimeFormat="$powerTimeFormat" \
-                -v totalBWWarn="$totalBWWarn" -v totalBWCrit="$totalBWCrit" -v lifeRemainWarn="$lifeRemainWarn" -v lifeRemainCrit="$lifeRemainCrit" \
-                -v lastTestHours="$(smartctl -l selftest "/dev/${drive}" | grep '# 1' | awk '{print $9}')" \
-                -v lastTestType="$(smartctl -l selftest "/dev/${drive}" | grep '# 1' | awk '{print $3}')" \
-                -v smartStatus="$(smartctl -H /dev/"$drive" | grep "SMART overall-health" | awk '{print $6}')" ' \
+                awk -v device="${drive}" -v tempWarn="${tempWarn}" -v tempCrit="${tempCrit}" -v sectorsCrit="${sectorsCrit}" -v testAgeWarn="${testAgeWarn}" \
+                -v okColor="${okColor}" -v warnColor="${warnColor}" -v critColor="${critColor}" -v altColor="${altColor}" -v powerTimeFormat="${powerTimeFormat}" \
+                -v totalBWWarn="${totalBWWarn}" -v totalBWCrit="${totalBWCrit}" -v lifeRemainWarn="${lifeRemainWarn}" -v lifeRemainCrit="${lifeRemainCrit}" \
+                -v lastTestHours="$(smartctl -jl selftest "/dev/${drive}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].lifetime_hours | values')" \
+                -v lastTestType="$(smartctl -jl selftest "/dev/${drive}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].type.string | values')" \
+                -v smartStatus="$(smartctl -H "/dev/${drive}" | grep "SMART overall-health" | awk '{print $6}')" ' \
                 /Device Model:/{$1="";$2=""; model=$0} \
                 /Serial Number:/{serial=$3} \
                 /User Capacity:/{capacity=$5 $6} \
@@ -608,11 +608,11 @@ for drive in $drives; do
             # After these computations, determine the row's background color (alternating as above, subbing in other colors from the palate as needed).
             # Finally, print the HTML code for the current row of the table with all the gathered data.
             smartctl -A -i /dev/"$drive" | \
-            awk -v device="$drive" -v tempWarn="$tempWarn" -v tempCrit="$tempCrit" -v sectorsCrit="$sectorsCrit" -v testAgeWarn="$testAgeWarn" \
-            -v okColor="$okColor" -v warnColor="$warnColor" -v critColor="$critColor" -v altColor="$altColor" -v powerTimeFormat="$powerTimeFormat" \
-            -v lastTestHours="$(smartctl -l selftest /dev/"$drive" | grep "# 1" | awk '{print $9}')" \
-            -v lastTestType="$(smartctl -l selftest /dev/"$drive" | grep "# 1" | awk '{print $3}')" \
-            -v smartStatus="$(smartctl -H /dev/"$drive" | grep "SMART overall-health" | awk '{print $6}')" ' \
+            awk -v device="${drive}" -v tempWarn="${tempWarn}" -v tempCrit="${tempCrit}" -v sectorsCrit="${sectorsCrit}" -v testAgeWarn="${testAgeWarn}" \
+            -v okColor="${okColor}" -v warnColor="${warnColor}" -v critColor="${critColor}" -v altColor="${altColor}" -v powerTimeFormat="${powerTimeFormat}" \
+            -v lastTestHours="$(smartctl -jl selftest "/dev/${drive}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].lifetime_hours | values')" \
+            -v lastTestType="$(smartctl -jl selftest "/dev/${drive}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].type.string | values')" \
+            -v smartStatus="$(smartctl -H "/dev/${drive}" | grep "SMART overall-health" | awk '{print $6}')" ' \
             /Device Model:/{$1="";$2=""; model=$0} \
             /Serial Number:/{serial=$3} \
             /User Capacity:/{capacity=$5 $6} \

From fa09d6af205a867db262e3c15c9314e4855617d1 Mon Sep 17 00:00:00 2001
From: Robert Muchsel <7576579+rotx@users.noreply.github.com>
Date: Thu, 28 May 2020 22:33:39 -0500
Subject: [PATCH 022/160] cherry-pick 66d6277

HTML boundary fix & proper message ids
Better support for NVMe and SSD
Support for new smartmon-tools
---
 report.sh | 214 +++++++++++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 186 insertions(+), 28 deletions(-)

diff --git a/report.sh b/report.sh
index 3dd1644..0ae2f73 100755
--- a/report.sh
+++ b/report.sh
@@ -15,6 +15,10 @@
 ### https://github.com/isentropik/FreeNAS-Report
 
 ### Changelog:
+# v1.6.5
+#   - HTML boundary fix, proper message ids, support for dma mailer
+#   - Better support for NVMe and SSD
+#   - Support for new smartmon-tools
 # v1.6
 #   - Actually fixed the broken borders in the tables.
 #   - Split the SMART table into two tables, one for SSDs and one for HDDs.
@@ -29,7 +33,7 @@
 #   - Added Glabel Status Report
 #   - Removed Power-On time labels and added ":" as a separator.
 #   - Added Power-On format to the Power-On time Header.
-#   - Changed Backup deafult to false.
+#   - Changed Backup default to false.
 # v1.4
 #   - in statusOutput changed grep to scrub: instead of scrub
 #   - added elif for resilvered/resilver in progress and scrub in progress with (hopefully) som useful info fields
@@ -92,7 +96,7 @@ tempWarn=40             # Drive temp (in C) at which WARNING color will be used
 tempCrit=45             # Drive temp (in C) at which CRITICAL color will be used
 sectorsCrit=10          # Number of sectors per drive with errors before CRITICAL color will be used
 testAgeWarn=5           # Maximum age (in days) of last SMART test before CRITICAL color will be used
-powerTimeFormat="ymd"   # Format for power-on hours string, valid options are "ymdh", "ymd", "ym", or "y" (year month day hour)
+powerTimeFormat="ymdh"  # Format for power-on hours string, valid options are "ymdh", "ymd", "ym", or "y" (year month day hour)
 
 ### FreeNAS config backup settings
 configBackup="false"     # Change to "false" to skip config backup (which renders next two options meaningless); "true" to keep config backups enabled
@@ -176,7 +180,8 @@ fi
 host=$(hostname -s)
 logfile="${logfileLocation}/$(date +%Y%m%d%H%M%S)_${logfileName}.tmp"
 subject="Status Report and Configuration Backup for ${host} - $(date "+%Y-%m-%d %H:%M")"
-boundary="gc0p4Jq0M2Yt08jU534c0p"
+boundary="$(dbus-uuidgen)"
+messageid="$(dbus-uuidgen)"
 
 # Reorders the drives in ascending order
 drives=$(for drive in $(sysctl -n kern.disks | sed -e 's:nvd:nvme:g'); do
@@ -189,7 +194,7 @@ done | awk '{for (i=NF; i!=0 ; i--) print $i }')
 
 # Toggles the 'ssdExist' flag to true if SSDs are detected in order to add the summary table
 if [ "${includeSSD}" == "true" ]; then
-    for drive in $drives; do
+    for drive in ${drives}; do
         if smartctl -i "/dev/${drive}" | grep -q "Solid State Device"; then
             ssdExist="true"
             break
@@ -197,6 +202,9 @@ if [ "${includeSSD}" == "true" ]; then
             ssdExist="false"
         fi
     done
+    if echo "${drives}" | grep -q "nvme"; then
+    	NVMeExist="true"
+    fi
 fi
 
 
@@ -204,12 +212,14 @@ fi
 ###### Email pre-formatting
 ### Set email headers
 (
-    echo "From: ${email}"
+    echo "From: $host <${email}>"
     echo "To: ${email}"
     echo "Subject: ${subject}"
     echo "MIME-Version: 1.0"
-    echo "Content-Type: multipart/mixed; boundary=${boundary}"
-) > "$logfile"
+    echo "Content-Type: multipart/mixed; boundary=\"${boundary}\""
+    echo "Date: $(date -R)"
+    echo "Message-Id: <${messageid}@${host}>"
+) > "${logfile}"
 
 
 
@@ -228,11 +238,12 @@ if [ "$configBackup" == "true" ]; then
         # Config integrity check failed, set MIME content type to html and print warning
         (
             echo "--${boundary}"
-            echo "Content-Type: text/html"
+            echo "Content-Transfer-Encoding: 8bit"
+            echo -e "Content-Type: text/html; charset=utf-8\n"
             echo "<b>Automatic backup of FreeNAS configuration has failed! The configuration file is corrupted!</b>"
             echo "<b>You should correct this problem as soon as possible!</b>"
             echo "<br>"
-        ) >> "$logfile"
+        ) >> "${logfile}"
     else
         # Config integrity check passed; copy config db, generate checksums, make .tar.gz archive
         cp /data/freenas-v1.db "/tmp/${filename}.db"
@@ -246,19 +257,20 @@ if [ "$configBackup" == "true" ]; then
         if [ "$emailBackup" == "true" ]; then
             # Write MIME section header for file attachment (encoded with base64)
             echo "--${boundary}"
-            echo "Content-Type: application/tar+gzip"
+            echo -e "Content-Type: application/tar+gzip\n"
             echo "Content-Transfer-Encoding: base64"
             echo "Content-Disposition: attachment; filename=${filename}.tar.gz"
-            base64 "$tarfile"
+            base64 "${tarfile}"
     fi
 
-        # Write MIME section header for html content to come below
-        echo "--${boundary}"
-        echo "Content-Type: text/html"
-        ) >> "$logfile"
+            # Write MIME section header for html content to come below
+            echo "--${boundary}"
+            echo "Content-Transfer-Encoding: 8bit"
+            echo -e "Content-Type: text/html; charset=utf-8\n"
+        ) >> "${logfile}"
 
         # If logfile saving is enabled, copy .tar.gz file to specified location before it (and everything else) is removed below
-        if [ "$saveBackup" == "true" ]; then
+        if [ "${saveBackup}" == "true" ]; then
             cp "${tarfile}" "${backupLocation}/${filename}.tar.gz"
         fi
         rm "/tmp/${filename}.db"
@@ -270,8 +282,9 @@ else
     # Config backup enabled; set up for html-type content
     (
         echo "--${boundary}"
-        echo "Content-Type: text/html"
-    ) >> "$logfile"
+        echo "Content-Transfer-Encoding: 8bit"
+        echo -e "Content-Type: text/html; charset=utf-8\n"
+    ) >> "${logfile}"
 fi
 
 
@@ -402,7 +415,7 @@ for pool in $pools; do
         fi
     fi
 
-   # Set row's background color; alternates between white and $altColor (light gray)
+    # Set row's background color; alternates between white and $altColor (light gray)
     if [ $((poolNum % 2)) == 1 ]; then bgColor="#ffffff"; else bgColor="$altColor"; fi
     poolNum=$((poolNum + 1))
 
@@ -413,7 +426,8 @@ for pool in $pools; do
     if [ "$writeErrors" != "0" ]; then writeErrorsColor="$warnColor"; else writeErrorsColor="$bgColor"; fi
     if [ "$cksumErrors" != "0" ]; then cksumErrorsColor="$warnColor"; else cksumErrorsColor="$bgColor"; fi
     if [ "$used" -gt "$usedWarn" ]; then usedColor="$warnColor"; else usedColor="$bgColor"; fi
-    if [ "$scrubRepBytes" != "N/A" ] && [ "$scrubRepBytes" != "0" ]; then scrubRepBytesColor="$warnColor"; else scrubRepBytesColor="$bgColor"; fi
+    if [ "$scrubRepBytes" != "N/A" ] && [ "$scrubRepBytes" != "0" ] && [ "$scrubRepBytes" != "0B" ]; then
+        scrubRepBytesColor="$warnColor"; else scrubRepBytesColor="$bgColor"; fi
     if [ "$scrubErrors" != "N/A" ] && [ "$scrubErrors" != "0" ]; then scrubErrorsColor="$warnColor"; else scrubErrorsColor="$bgColor"; fi
     if [ "$(echo "$scrubAge" | awk '{print int($1)}')" -gt "$scrubAgeWarn" ]; then scrubAgeColor="$warnColor"; else scrubAgeColor="$bgColor"; fi
     (
@@ -442,6 +456,149 @@ done
 echo "</table>" >> "$logfile"
 
 
+### SMART status summary tables
+
+
+###### NVMe SMART status summary table
+if [ "${NVMeExist}" = "true" ]; then
+    (
+        # Write HTML table headers to log file
+        echo "<br><br>"
+        echo "<table style=\"border: 1px solid black; border-collapse: collapse;\">"
+        echo "<tr><th colspan=\"18\" style=\"text-align:center; font-size:20px; height:40px; font-family:courier;\">NVMe SMART Status Report Summary</th></tr>"
+        echo "<tr>"
+
+        echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Device</th>" # Device
+
+        echo "  <th style=\"text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Model</th>" # Model
+
+        echo "  <th style=\"text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Serial<br>Number</th>" # Serial Number
+
+        echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Capacity</th>" # Capacity
+
+        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">SMART<br>Status</th>" # SMART Status
+
+        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Temp</th>" # Temp
+
+        echo "  <th style=\"text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Power-On<br>Time<br>($powerTimeFormat)</th>" # Power-On Time
+
+        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Power<br>Cycle<br>Count</th>" # Power Cycle Count
+
+        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Integrity<br>Errors</th>" # Integrity Errors
+
+        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Error<br>Log<br>Entries</th>" # Error Log Entries
+
+        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Critical<br>Warning</th>" # Critical Warning
+
+        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Wear<br>Leveling<br>Count</th>" # Wear Leveling Count
+
+        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Total<br>Bytes<br>Written</th>" # Total Bytes Written
+
+        echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Bytes Written<br>(per Day)</th>" # Bytes Written (per Day)
+
+        echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Last Test<br>Age (days)</th>" # Last Test Age (days)
+
+        echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Last Test<br>Type</th></tr>" # Last Test Type
+
+        echo "</tr>"
+    ) >> "$logfile"
+
+
+	for drive in ${drives}; do
+        if echo "${drive}" | grep -q "nvme"; then
+			(
+				# For each drive detected, run "smartctl -A -i" and parse its output. This whole section is a single, long statement, so I'll make all comments here.
+				# Start by passing awk variables (all the -v's) used in other parts of the script. Other variables are calculated in-line with other smartctl calls.
+				# Next, pull values out of the original "smartctl -A -i" statement by searching for the text between the //'s.
+				# After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).
+				# After these computations, determine the row's background color (alternating as above, subbing in other colors from the palate as needed).
+				# Finally, print the HTML code for the current row of the table with all the gathered data.
+				nvmeSmarOut="$(smartctl -Aij "/dev/${drive}")"
+				model="$(echo "${nvmeSmarOut}" | jq -Mre '.model_name | values')"
+				serial="$(echo "${nvmeSmarOut}" | jq -Mre '.serial_number | values')"
+				capacity="[$(echo "${nvmeSmarOut}" | jq -Mre '(.user_capacity.bytes/1000215216) | values')GB]"
+				temp="$(echo "${nvmeSmarOut}" | jq -Mre '.temperature.current | values')"
+				onHours="$(echo "${nvmeSmarOut}" | jq -Mre '.power_on_time.hours | values')"
+				startStop="$(echo "${nvmeSmarOut}" | jq -Mre '.power_cycle_count | values')"
+				mediaErrors="$(echo "${nvmeSmarOut}" | jq -Mre '.nvme_smart_health_information_log.media_errors | values')"
+				errorsLogs="$(echo "${nvmeSmarOut}" | jq -Mre '.nvme_smart_health_information_log.num_err_log_entries | values')"
+				critWarning="$(echo "${nvmeSmarOut}" | jq -Mre '.nvme_smart_health_information_log.critical_warning | values')"
+				wearLeveling="$(echo "${nvmeSmarOut}" | jq -Mre '.nvme_smart_health_information_log.available_spare | values')"
+				sectorSize="$(echo "${nvmeSmarOut}" | jq -Mre '.logical_block_size | values')"
+				totalLBA="$(echo "${nvmeSmarOut}" | jq -Mre '.user_capacity.blocks | values')"
+
+				smartStatus="$(smartctl -H "/dev/${drive}" | grep "SMART overall-health" | awk '{print $6}')"
+
+
+				smartctl -Ai "/dev/${drive}" | awk -v device="${drive}" -v tempWarn="${tempWarn}" -v tempCrit="${tempCrit}" -v okColor="${okColor}" \
+				-v warnColor="${warnColor}" -v critColor="${critColor}" -v altColor="${altColor}" \
+				-v powerTimeFormat="${powerTimeFormat}" \
+                -v totalBWWarn="${totalBWWarn}" -v totalBWCrit="${totalBWCrit}" -v lifeRemainWarn="${lifeRemainWarn}" -v lifeRemainCrit="${lifeRemainCrit}" \
+				-v model="${model}" -v serial="${serial}" -v capacity="${capacity}" -v temp="${temp}" -v onHours="${onHours}" \
+				-v startStop="${startStop}" -v mediaErrors="${mediaErrors}" -v errorsLogs="${errorsLogs}" \
+				-v critWarning="${critWarning}" -v wearLeveling="${wearLeveling}" -v sectorSize="${sectorSize}" \
+				-v totalLBA="${totalLBA}" \
+				-v smartStatus="${smartStatus}" -v lastTestHours="$((onHours - 2))" ' \
+				END {
+                    testAge=int((onHours - lastTestHours) / 24);
+                    yrs=int(onHours / 8760);
+                    mos=int((onHours % 8760) / 730);
+                    dys=int(((onHours % 8760) % 730) / 24);
+                    hrs=((onHours % 8760) % 730) % 24;
+                    if (powerTimeFormat == "ymdh") onTime=yrs "y " mos "m " dys "d " hrs "h ";
+                    else if (powerTimeFormat == "ymd") onTime=yrs "y " mos "m " dys "d ";
+                    else if (powerTimeFormat == "ym") onTime=yrs "y " mos "m ";
+                    else if (powerTimeFormat == "y") onTime=yrs "y ";
+                    else onTime=yrs "y " mos "m " dys "d " hrs "h ";
+                    if ((substr(device, length(device), 1) + 0) % 2 == 1) bgColor = "#ffffff"; else bgColor = altColor;
+                    if (smartStatus != "PASSED") smartStatusColor = critColor; else smartStatusColor = okColor;
+                    if (temp >= tempCrit) tempColor = critColor; else if (temp >= tempWarn) tempColor = warnColor; else tempColor = bgColor;
+                    if (temp == 0) temp = "N/A"; else temp = temp "*C";
+                    if ((reAlloc + 0) > sectorsCrit) reAllocColor = critColor; else if (reAlloc != 0) reAllocColor = warnColor; else reAllocColor = bgColor;
+                    if ((errorsLogs + 0) > sectorsCrit) errorsLogsColor = critColor; else if (errorsLogs != 0) errorsLogsColor = warnColor; else errorsLogsColor = bgColor;
+                    if ((eraseFail + 0) > sectorsCrit) eraseFailColor = critColor; else if (eraseFail != 0) eraseFailColor = warnColor; else eraseFailColor = bgColor;
+                    if ((critWarning + 0) > sectorsCrit) critWarningColor = critColor; else if (critWarning != 0) critWarningColor = warnColor; else critWarningColor = bgColor;
+                    if (mediaErrors != "0") mediaErrorsColor = warnColor; else mediaErrorsColor = bgColor;
+                    if (wearLeveling <= lifeRemainCrit) wearLevelingColor = critColor; else if (wearLeveling <= lifeRemainWarn) wearLevelingColor = warnColor; else wearLevelingColor = bgColor;
+                    totalBW=(((totalLBA * sectorSize) / 1048576) / 1048576);
+                    if (totalBW >= totalBWCrit) totalBWColor = critColor; else if (totalBW >= totalBWWarn) totalBWColor = warnColor; else totalBWColor = bgColor;
+                    if (totalBW == 0) totalBW = "N/A"; else totalBW = (int(totalBW) + int(((totalBW - int(totalBW)) * 10) + 0.501) / 10) "TB";
+                    bwPerDay=((totalBW * 1024)/ (onHours / 24));
+                    if (totalBW == "N/A") bwPerDay = "N/A"; else bwPerDay = (int(bwPerDay) + int(((bwPerDay - int(bwPerDay)) * 10) + 0.501) / 10) "GB";
+                    if (testAge > testAgeWarn) testAgeColor = critColor; else testAgeColor = bgColor;
+                    printf "<tr style=\"background-color:%s;\">" \
+                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">/dev/%s</td> <!-- device -->\n" \
+                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td> <!-- model -->\n" \
+                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td> <!-- serial -->\n" \
+                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td> <!-- capacity -->\n" \
+                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td> <!-- smartStatusColor, smartStatus -->\n" \
+                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td> <!-- tempColor, temp -->\n" \
+                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td> <!-- onTime -->\n" \
+                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td> <!-- startStop -->\n" \
+                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td> <!-- mediaErrorsColor, mediaErrors -->\n" \
+                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td> <!-- errorsLogsColor, errorsLogs -->\n" \
+                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td> <!-- critWarningColor, critWarning -->\n" \
+                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%d%%</td> <!-- wearLevelingColor, wearLeveling -->\n" \
+                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td> <!-- totalBWColor, totalBW -->\n" \
+                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td> <!-- bwPerDay -->\n" \
+                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">N/A</td> <!-- testAgeColor, testAge -->\n" \
+                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">N/A</td> <!-- lastTestType -->\n" \
+                    "</tr>\n", bgColor, device, model, serial, capacity, smartStatusColor, smartStatus, tempColor, temp, onTime, startStop, mediaErrorsColor, mediaErrors, \
+                    errorsLogsColor, errorsLogs, critWarningColor, critWarning, wearLevelingColor, wearLeveling, totalBWColor, totalBW, \
+                    bwPerDay, testAgeColor;
+				}'
+				#                 "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\"></td>\n" \
+
+			) >> "$logfile"
+		fi
+	done
+
+    # End SMART summary table and summary section
+    (
+        echo "</table>"
+    ) >> "$logfile"
+fi
+
 
 ###### SSD SMART status summary table
 if [ "${ssdExist}" = "true" ]; then
@@ -472,7 +629,7 @@ if [ "${ssdExist}" = "true" ]; then
         echo "</tr>"
     ) >> "$logfile"
 
-    for drive in $drives; do
+    for drive in ${drives}; do
         if smartctl -i "/dev/${drive}" | grep -q "Solid State Device"; then
             (
                 # For each drive detected, run "smartctl -A -i" and parse its output. This whole section is a single, long statement, so I'll make all comments here.
@@ -593,11 +750,11 @@ fi
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">CRC<br>Errors</th>"
     echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Seek<br>Error<br>Health</th>"
     echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Last Test<br>Age (days)</th>"
-    echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Last Test<br>Type</th></tr>"    
+    echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Last Test<br>Type</th></tr>"
     echo "</tr>"
 ) >> "$logfile"
 
-for drive in $drives; do
+for drive in ${drives}; do
     if smartctl -i "/dev/${drive}" | grep -q "SMART support is: Enabled"; then
         if ! smartctl -i "/dev/${drive}" | grep -q "Solid State Device"; then
         (
@@ -768,7 +925,7 @@ done
 
 
 ### SMART status for each drive
-for drive in $drives; do
+for drive in ${drives}; do
     if smartctl -i "/dev/${drive}" | grep -q "SMART support is: Enabled"; then
         # Gather brand and serial number of each drive
         brand="$(smartctl -ij "/dev/${drive}" | jq -Mre '.model_family | values')"
@@ -785,10 +942,10 @@ for drive in $drives; do
             echo "<br><br>"
         ) >> "${logfile}"
 
-    elif smartctl -a "/dev/${drive}" | grep -q "SMART overall-health self-assessment test result"; then
+    elif echo "${drive}" | grep -q "nvme"; then
         # Gather brand and serial number of each drive
-		nvmeSmartOut="$(smartctl -aj /dev/nvme0)"
-		brand="$(echo "${nvmeSmartOut}" | jq -Mre '.model_family| values')"
+		nvmeSmartOut="$(smartctl -aj "/dev/${drive}")"
+		brand="$(echo "${nvmeSmartOut}" | jq -Mre '.model_family | values')"
         if [ -z "${brand}" ]; then
             brand="$(echo "${nvmeSmartOut}" | jq -Mre '.model_name | values')";
         fi
@@ -803,9 +960,10 @@ for drive in $drives; do
 done
 
 # Remove some un-needed junk from the output
-sed -i '' -e '/smartctl 7.1/d' "${logfile}"
+sed -i '' -e '/smartctl [6-9].[0-9]/d' "${logfile}"
 sed -i '' -e '/Copyright/d' "${logfile}"
 sed -i '' -e '/=== START OF READ/d' "${logfile}"
+sed -i '' -e '/=== START OF SMART DATA SECTION ===/d' "${logfile}"
 sed -i '' -e '/SMART Attributes Data/d' "${logfile}"
 sed -i '' -e '/Vendor Specific SMART/d' "${logfile}"
 sed -i '' -e '/SMART Error Log Version/d' "${logfile}"

From 7761aa2eadcd770e3fb7f974e083f306b8e27265 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Fri, 16 Apr 2021 21:58:52 -0400
Subject: [PATCH 023/160] Misc updates.

---
 report.sh | 32 ++++++++++++++++++--------------
 1 file changed, 18 insertions(+), 14 deletions(-)

diff --git a/report.sh b/report.sh
index 0ae2f73..6d4d01f 100755
--- a/report.sh
+++ b/report.sh
@@ -3,18 +3,21 @@
 
 #set -euxo pipefail
 
-###### ZPool, SMART, and UPS Status Report with FreeNAS Config Backup
+###### ZPool, SMART, and UPS Status Report with TrueNAS Config Backup
 ### Original Script By: joeschmuck
-### Modified By: bidelu0hm, melp, fohlsso2, onlinepcwizard, ninpucho
-### Last Edited By: isentropik
+### Modified By: bidelu0hm, melp, fohlsso2, onlinepcwizard, ninpucho, isentropik
+### Last Edited By: dak180
 
-### At a minimum, enter email address in user-definable parameter section. The default is set to 'root' as I assume that the root email was set in FreeNAS.
+### At a minimum, enter email address and set defaultFile to 0 in the config file.
 ### Feel free to edit other user parameters as needed.
 
-### Current Version: v1.6
-### https://github.com/isentropik/FreeNAS-Report
+### Current Version: v1.7
+### https://github.com/dak180/FreeNAS-Report
 
 ### Changelog:
+# v1.7
+#   - Refactor to reduce dependence on awk
+#   - Use a separate config file
 # v1.6.5
 #   - HTML boundary fix, proper message ids, support for dma mailer
 #   - Better support for NVMe and SSD
@@ -98,23 +101,24 @@ sectorsCrit=10          # Number of sectors per drive with errors before CRITICA
 testAgeWarn=5           # Maximum age (in days) of last SMART test before CRITICAL color will be used
 powerTimeFormat="ymdh"  # Format for power-on hours string, valid options are "ymdh", "ymd", "ym", or "y" (year month day hour)
 
-### FreeNAS config backup settings
+### TrueNAS config backup settings
 configBackup="false"     # Change to "false" to skip config backup (which renders next two options meaningless); "true" to keep config backups enabled
-emailBackup="false"     # Change to "true" to email FreeNAS config backup
-saveBackup="true"       # Change to "false" to delete FreeNAS config backup after mail is sent; "true" to keep it in dir below
-backupLocation="/root/backup"    # Directory in which to save FreeNAS config backups
+emailBackup="false"     # Change to "true" to email TrueNAS config backup
+saveBackup="true"       # Change to "false" to delete TrueNAS config backup after mail is sent; "true" to keep it in dir below
+backupLocation="/root/backup"    # Directory in which to save TrueNAS config backups
 
 ### UPS status summary settings
 reportUPS="false"        # Change to "false" to skip reporting the status of the UPS
 
 ### General script settings
-logfileLocation="/tmp"      # Directory in which to save FreeNAS log file. Can be set to /tmp.
+logfileLocation="/tmp"      # Directory in which to save TrueNAS log file. Can be set to /tmp.
 logfileName="logfilename"                  # Log file name
 saveLogfile="true"                         # Change to "false" to delete the log file after creation
 
 
 
 EOF
+	echo "Please edit the config file for your setup" >&2
 	exit 0
 }
 
@@ -187,7 +191,7 @@ messageid="$(dbus-uuidgen)"
 drives=$(for drive in $(sysctl -n kern.disks | sed -e 's:nvd:nvme:g'); do
     if smartctl -i "/dev/${drive}" | grep -q "SMART support is: Enabled"; then
         printf "%s " "${drive}"
-	elif smartctl -a "/dev/${drive}" | grep -q "SMART overall-health self-assessment test result"; then
+	elif echo "${drive}" | grep -q "nvme"; then
 		printf "%s " "${drive}"
     fi
 done | awk '{for (i=NF; i!=0 ; i--) print $i }')
@@ -212,7 +216,7 @@ fi
 ###### Email pre-formatting
 ### Set email headers
 (
-    echo "From: $host <${email}>"
+    echo "From: ${host} <root@$(hostname)>"
     echo "To: ${email}"
     echo "Subject: ${subject}"
     echo "MIME-Version: 1.0"
@@ -240,7 +244,7 @@ if [ "$configBackup" == "true" ]; then
             echo "--${boundary}"
             echo "Content-Transfer-Encoding: 8bit"
             echo -e "Content-Type: text/html; charset=utf-8\n"
-            echo "<b>Automatic backup of FreeNAS configuration has failed! The configuration file is corrupted!</b>"
+            echo "<b>Automatic backup of TrueNAS configuration has failed! The configuration file is corrupted!</b>"
             echo "<b>You should correct this problem as soon as possible!</b>"
             echo "<br>"
         ) >> "${logfile}"

From 0c73fedccb0f49e84bcd3a4815b0d10b1d3a5e3b Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sat, 17 Apr 2021 01:03:57 -0400
Subject: [PATCH 024/160] Refactor to get rid of awk.

This also uses a function and is much easier to read.
---
 report.sh | 307 ++++++++++++++++++++++++++++++++++--------------------
 1 file changed, 193 insertions(+), 114 deletions(-)

diff --git a/report.sh b/report.sh
index 6d4d01f..b1b281e 100755
--- a/report.sh
+++ b/report.sh
@@ -463,144 +463,223 @@ echo "</table>" >> "$logfile"
 ### SMART status summary tables
 
 
-###### NVMe SMART status summary table
-if [ "${NVMeExist}" = "true" ]; then
-    (
-        # Write HTML table headers to log file
-        echo "<br><br>"
-        echo "<table style=\"border: 1px solid black; border-collapse: collapse;\">"
-        echo "<tr><th colspan=\"18\" style=\"text-align:center; font-size:20px; height:40px; font-family:courier;\">NVMe SMART Status Report Summary</th></tr>"
-        echo "<tr>"
+# shellcheck disable=SC2155
+function NVMeSummary () {
 
-        echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Device</th>" # Device
+	###### NVMe SMART status summary table
+	(
+		# Write HTML table headers to log file
+		echo '<br><br>'
+		echo '<table style="border: 1px solid black; border-collapse: collapse;">'
+		echo '<tr><th colspan="18" style="text-align:center; font-size:20px; height:40px; font-family:courier;">NVMe SMART Status Report Summary</th></tr>'
+		echo '<tr>'
 
-        echo "  <th style=\"text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Model</th>" # Model
+		echo '  <th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Device</th>' # Device
 
-        echo "  <th style=\"text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Serial<br>Number</th>" # Serial Number
+		echo '  <th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Model</th>' # Model
 
-        echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Capacity</th>" # Capacity
+		echo '  <th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Serial<br>Number</th>' # Serial Number
 
-        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">SMART<br>Status</th>" # SMART Status
+		echo '  <th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Capacity</th>' # Capacity
 
-        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Temp</th>" # Temp
+		echo '  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">SMART<br>Status</th>' # SMART Status
 
-        echo "  <th style=\"text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Power-On<br>Time<br>($powerTimeFormat)</th>" # Power-On Time
+		echo '  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Temp</th>' # Temp
 
-        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Power<br>Cycle<br>Count</th>" # Power Cycle Count
+		echo '  <th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Power-On<br>Time<br>('"$powerTimeFormat"')</th>' # Power-On Time
 
-        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Integrity<br>Errors</th>" # Integrity Errors
+		echo '  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Power<br>Cycle<br>Count</th>' # Power Cycle Count
 
-        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Error<br>Log<br>Entries</th>" # Error Log Entries
+		echo '  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Integrity<br>Errors</th>' # Integrity Errors
 
-        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Critical<br>Warning</th>" # Critical Warning
+		echo '  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Error<br>Log<br>Entries</th>' # Error Log Entries
 
-        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Wear<br>Leveling<br>Count</th>" # Wear Leveling Count
+		echo '  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Critical<br>Warning</th>' # Critical Warning
 
-        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Total<br>Bytes<br>Written</th>" # Total Bytes Written
+		echo '  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Wear<br>Leveling<br>Count</th>' # Wear Leveling Count
 
-        echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Bytes Written<br>(per Day)</th>" # Bytes Written (per Day)
+		echo '  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Total<br>Bytes<br>Written</th>' # Total Bytes Written
 
-        echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Last Test<br>Age (days)</th>" # Last Test Age (days)
+		echo '  <th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Bytes Written<br>(per Day)</th>' # Bytes Written (per Day)
 
-        echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Last Test<br>Type</th></tr>" # Last Test Type
+		echo '  <th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Age (days)</th>' # Last Test Age (days)
 
-        echo "</tr>"
-    ) >> "$logfile"
+		echo '  <th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Type</th></tr>' # Last Test Type
+
+		echo '</tr>'
+	) >> "${logfile}"
 
 
 	for drive in ${drives}; do
-        if echo "${drive}" | grep -q "nvme"; then
+		local altRow="false"
+		if echo "${drive}" | grep -q "nvme"; then
+			# For each drive detected, run "smartctl -Aij" and parse its output. This whole section is a single, long statement, so I'll make all comments here.
+			# Start by passing awk variables (all the -v's) used in other parts of the script. Other variables are calculated in-line with other smartctl calls.
+			# Next, pull values out of the original "smartctl -Aij" statement by searching for the text between the //'s.
+			# After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).
+			# After these computations, determine the row's background color (alternating as above, subbing in other colors from the palate as needed).
+			# Finally, print the HTML code for the current row of the table with all the gathered data.
+
+			# Get drive attributes
+			local nvmeSmarOut="$(smartctl -Aij "/dev/${drive}")"
+
+			local model="$(echo "${nvmeSmarOut}" | jq -Mre '.model_name | values')"
+			local serial="$(echo "${nvmeSmarOut}" | jq -Mre '.serial_number | values')"
+			local capacity="[$(echo "${nvmeSmarOut}" | jq -Mre '(.user_capacity.bytes/1000215216) | values')GB]"
+			local temp="$(echo "${nvmeSmarOut}" | jq -Mre '.temperature.current | values')"
+			local onHours="$(echo "${nvmeSmarOut}" | jq -Mre '.power_on_time.hours | values')"
+			local startStop="$(echo "${nvmeSmarOut}" | jq -Mre '.power_cycle_count | values')"
+			local mediaErrors="$(echo "${nvmeSmarOut}" | jq -Mre '.nvme_smart_health_information_log.media_errors | values')"
+			local errorsLogs="$(echo "${nvmeSmarOut}" | jq -Mre '.nvme_smart_health_information_log.num_err_log_entries | values')"
+			local critWarning="$(echo "${nvmeSmarOut}" | jq -Mre '.nvme_smart_health_information_log.critical_warning | values')"
+			local wearLeveling="$(echo "${nvmeSmarOut}" | jq -Mre '.nvme_smart_health_information_log.available_spare | values')"
+			local sectorSize="$(echo "${nvmeSmarOut}" | jq -Mre '.logical_block_size | values')"
+			local totalLBA="$(echo "${nvmeSmarOut}" | jq -Mre '.nvme_smart_health_information_log.data_units_written | values')"
+
+			local smartStatus="$(smartctl -H "/dev/${drive}" | grep "SMART overall-health" | awk '{print $6}')"
+
+			# Get more useful times from hours
+			local testAge="$(bc <<< "(${onHours} - (${onHours} - 2) ) / 24")" # ${lastTestHours}
+			local yrs="$(bc <<< "${onHours} / 8760")"
+			local mos="$(bc <<< "(${onHours} % 8760) / 730")"
+			local dys="$(bc <<< "((${onHours} % 8760) % 730) / 24")"
+			local hrs="$(bc <<< "((${onHours} % 8760) % 730) % 24")"
+
+			# Set Power-On Time format
+			if [ "${powerTimeFormat}" = "ymdh" ]; then
+				local onTime="${yrs}y ${mos}m ${dys}d ${hrs}h"
+			elif [ "${powerTimeFormat}" = "ymd" ]; then
+				local onTime="${yrs}y ${mos}m ${dys}d"
+			elif [ "${powerTimeFormat}" = "ym" ]; then
+				local onTime="${yrs}y ${mos}m"
+			elif [ "${powerTimeFormat}" = "y" ]; then
+				local onTime="${yrs}y"
+			else
+				local onTime="${yrs}y ${mos}m ${dys}d ${hrs}h"
+			fi
+
+			# Set the row background color
+			if [ "${altRow}" = "false" ]; then
+				local bgColor="#ffffff"
+				altRow="true"
+			else
+				local bgColor="${altColor}"
+				altRow="false"
+			fi
+
+			# Colorize smart status
+			if [ ! "${smartStatus}" = "PASSED" ]; then
+				local smartStatusColor="${critColor}"
+			else
+				local smartStatusColor="${okColor}"
+			fi
+
+			# Colorize temp
+			if [ "${temp}" -ge "${tempCrit}" ]; then
+				local tempColor="${critColor}"
+			elif [ "${temp}" -ge "${tempWarn}" ]; then
+				tempColor="${warnColor}"
+			else
+				local tempColor="${bgColor}"
+			fi
+			if [ "${temp}" = "0" ]; then
+				local temp="N/A"
+			else
+				local temp="${temp}&deg;C"
+			fi
+
+			# Colorize log errors
+			if [ "${errorsLogs:=0}" -gt "${sectorsCrit}" ]; then
+				local errorsLogsColor="${critColor}"
+			elif [ ! "${errorsLogs}" = "0" ]; then
+				local errorsLogsColor="${warnColor}"
+			else
+				local errorsLogsColor="${bgColor}"
+			fi
+
+			# Colorize warnings
+			if [ "${critWarning:=0}" -gt "${sectorsCrit}" ]; then
+				local critWarningColor="${critColor}"
+			elif [ ! "${critWarning}" = "0" ]; then
+				local critWarningColor="${warnColor}"
+			else
+				local critWarningColor="${bgColor}"
+			fi
+
+			# Colorize Media Errors
+			if [ ! "${mediaErrors}" = "0" ]; then
+				local mediaErrorsColor="${warnColor}"
+			else
+				local mediaErrorsColor="${bgColor}"
+			fi
+
+			# Colorize Wear Leveling
+			if [ "${wearLeveling}" -le "${lifeRemainCrit}" ]; then
+				local wearLevelingColor="${critColor}"
+			elif [ "${wearLeveling}" -le "${lifeRemainWarn}" ]; then
+				local wearLevelingColor="${warnColor}"
+			else
+				local wearLevelingColor="${bgColor}"
+			fi
+
+			# Colorize & derive write stats
+			local totalBW="$(bc <<< "(${totalLBA} * ${sectorSize}) / (10^9)")"
+			if [ "${totalBW}" -ge "${totalBWCrit}" ]; then
+				local totalBWColor="${critColor}"
+			elif [ "${totalBW}" -ge "${totalBWWarn}" ]; then
+				local totalBWColor="${warnColor}"
+			else
+				local totalBWColor="${bgColor}"
+			fi
+			if [ "${totalBW}" = "0" ]; then
+				totalBW="N/A"
+				bwPerDay="N/A"
+			else
+				bwPerDay="$(bc <<< "(${totalBW} * 1024) / (${onHours} / 24)")GB"
+				totalBW="${totalBW}TB"
+			fi
+
+			# Colorize test age
+			if [ "${testAge}" -gt "${testAgeWarn}" ]; then
+				testAgeColor="${critColor}"
+			else
+				testAgeColor="${bgColor}"
+			fi
+
+
 			(
-				# For each drive detected, run "smartctl -A -i" and parse its output. This whole section is a single, long statement, so I'll make all comments here.
-				# Start by passing awk variables (all the -v's) used in other parts of the script. Other variables are calculated in-line with other smartctl calls.
-				# Next, pull values out of the original "smartctl -A -i" statement by searching for the text between the //'s.
-				# After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).
-				# After these computations, determine the row's background color (alternating as above, subbing in other colors from the palate as needed).
-				# Finally, print the HTML code for the current row of the table with all the gathered data.
-				nvmeSmarOut="$(smartctl -Aij "/dev/${drive}")"
-				model="$(echo "${nvmeSmarOut}" | jq -Mre '.model_name | values')"
-				serial="$(echo "${nvmeSmarOut}" | jq -Mre '.serial_number | values')"
-				capacity="[$(echo "${nvmeSmarOut}" | jq -Mre '(.user_capacity.bytes/1000215216) | values')GB]"
-				temp="$(echo "${nvmeSmarOut}" | jq -Mre '.temperature.current | values')"
-				onHours="$(echo "${nvmeSmarOut}" | jq -Mre '.power_on_time.hours | values')"
-				startStop="$(echo "${nvmeSmarOut}" | jq -Mre '.power_cycle_count | values')"
-				mediaErrors="$(echo "${nvmeSmarOut}" | jq -Mre '.nvme_smart_health_information_log.media_errors | values')"
-				errorsLogs="$(echo "${nvmeSmarOut}" | jq -Mre '.nvme_smart_health_information_log.num_err_log_entries | values')"
-				critWarning="$(echo "${nvmeSmarOut}" | jq -Mre '.nvme_smart_health_information_log.critical_warning | values')"
-				wearLeveling="$(echo "${nvmeSmarOut}" | jq -Mre '.nvme_smart_health_information_log.available_spare | values')"
-				sectorSize="$(echo "${nvmeSmarOut}" | jq -Mre '.logical_block_size | values')"
-				totalLBA="$(echo "${nvmeSmarOut}" | jq -Mre '.user_capacity.blocks | values')"
-
-				smartStatus="$(smartctl -H "/dev/${drive}" | grep "SMART overall-health" | awk '{print $6}')"
-
-
-				smartctl -Ai "/dev/${drive}" | awk -v device="${drive}" -v tempWarn="${tempWarn}" -v tempCrit="${tempCrit}" -v okColor="${okColor}" \
-				-v warnColor="${warnColor}" -v critColor="${critColor}" -v altColor="${altColor}" \
-				-v powerTimeFormat="${powerTimeFormat}" \
-                -v totalBWWarn="${totalBWWarn}" -v totalBWCrit="${totalBWCrit}" -v lifeRemainWarn="${lifeRemainWarn}" -v lifeRemainCrit="${lifeRemainCrit}" \
-				-v model="${model}" -v serial="${serial}" -v capacity="${capacity}" -v temp="${temp}" -v onHours="${onHours}" \
-				-v startStop="${startStop}" -v mediaErrors="${mediaErrors}" -v errorsLogs="${errorsLogs}" \
-				-v critWarning="${critWarning}" -v wearLeveling="${wearLeveling}" -v sectorSize="${sectorSize}" \
-				-v totalLBA="${totalLBA}" \
-				-v smartStatus="${smartStatus}" -v lastTestHours="$((onHours - 2))" ' \
-				END {
-                    testAge=int((onHours - lastTestHours) / 24);
-                    yrs=int(onHours / 8760);
-                    mos=int((onHours % 8760) / 730);
-                    dys=int(((onHours % 8760) % 730) / 24);
-                    hrs=((onHours % 8760) % 730) % 24;
-                    if (powerTimeFormat == "ymdh") onTime=yrs "y " mos "m " dys "d " hrs "h ";
-                    else if (powerTimeFormat == "ymd") onTime=yrs "y " mos "m " dys "d ";
-                    else if (powerTimeFormat == "ym") onTime=yrs "y " mos "m ";
-                    else if (powerTimeFormat == "y") onTime=yrs "y ";
-                    else onTime=yrs "y " mos "m " dys "d " hrs "h ";
-                    if ((substr(device, length(device), 1) + 0) % 2 == 1) bgColor = "#ffffff"; else bgColor = altColor;
-                    if (smartStatus != "PASSED") smartStatusColor = critColor; else smartStatusColor = okColor;
-                    if (temp >= tempCrit) tempColor = critColor; else if (temp >= tempWarn) tempColor = warnColor; else tempColor = bgColor;
-                    if (temp == 0) temp = "N/A"; else temp = temp "*C";
-                    if ((reAlloc + 0) > sectorsCrit) reAllocColor = critColor; else if (reAlloc != 0) reAllocColor = warnColor; else reAllocColor = bgColor;
-                    if ((errorsLogs + 0) > sectorsCrit) errorsLogsColor = critColor; else if (errorsLogs != 0) errorsLogsColor = warnColor; else errorsLogsColor = bgColor;
-                    if ((eraseFail + 0) > sectorsCrit) eraseFailColor = critColor; else if (eraseFail != 0) eraseFailColor = warnColor; else eraseFailColor = bgColor;
-                    if ((critWarning + 0) > sectorsCrit) critWarningColor = critColor; else if (critWarning != 0) critWarningColor = warnColor; else critWarningColor = bgColor;
-                    if (mediaErrors != "0") mediaErrorsColor = warnColor; else mediaErrorsColor = bgColor;
-                    if (wearLeveling <= lifeRemainCrit) wearLevelingColor = critColor; else if (wearLeveling <= lifeRemainWarn) wearLevelingColor = warnColor; else wearLevelingColor = bgColor;
-                    totalBW=(((totalLBA * sectorSize) / 1048576) / 1048576);
-                    if (totalBW >= totalBWCrit) totalBWColor = critColor; else if (totalBW >= totalBWWarn) totalBWColor = warnColor; else totalBWColor = bgColor;
-                    if (totalBW == 0) totalBW = "N/A"; else totalBW = (int(totalBW) + int(((totalBW - int(totalBW)) * 10) + 0.501) / 10) "TB";
-                    bwPerDay=((totalBW * 1024)/ (onHours / 24));
-                    if (totalBW == "N/A") bwPerDay = "N/A"; else bwPerDay = (int(bwPerDay) + int(((bwPerDay - int(bwPerDay)) * 10) + 0.501) / 10) "GB";
-                    if (testAge > testAgeWarn) testAgeColor = critColor; else testAgeColor = bgColor;
-                    printf "<tr style=\"background-color:%s;\">" \
-                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">/dev/%s</td> <!-- device -->\n" \
-                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td> <!-- model -->\n" \
-                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td> <!-- serial -->\n" \
-                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td> <!-- capacity -->\n" \
-                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td> <!-- smartStatusColor, smartStatus -->\n" \
-                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td> <!-- tempColor, temp -->\n" \
-                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td> <!-- onTime -->\n" \
-                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td> <!-- startStop -->\n" \
-                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td> <!-- mediaErrorsColor, mediaErrors -->\n" \
-                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td> <!-- errorsLogsColor, errorsLogs -->\n" \
-                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td> <!-- critWarningColor, critWarning -->\n" \
-                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%d%%</td> <!-- wearLevelingColor, wearLeveling -->\n" \
-                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td> <!-- totalBWColor, totalBW -->\n" \
-                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td> <!-- bwPerDay -->\n" \
-                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">N/A</td> <!-- testAgeColor, testAge -->\n" \
-                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">N/A</td> <!-- lastTestType -->\n" \
-                    "</tr>\n", bgColor, device, model, serial, capacity, smartStatusColor, smartStatus, tempColor, temp, onTime, startStop, mediaErrorsColor, mediaErrors, \
-                    errorsLogsColor, errorsLogs, critWarningColor, critWarning, wearLevelingColor, wearLeveling, totalBWColor, totalBW, \
-                    bwPerDay, testAgeColor;
-				}'
-				#                 "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\"></td>\n" \
-
-			) >> "$logfile"
+				# Output the row
+				echo '<tr style="background-color:'"${bgColor}"';">'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"/dev/${drive}"'</td> <!-- device -->'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${model}"'</td> <!-- model -->'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${serial}"'</td> <!-- serial -->'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${capacity}"'</td> <!-- capacity -->'
+				echo '<td style="text-align:center; background-color:'"${smartStatusColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${smartStatus}"'</td> <!-- smartStatusColor, smartStatus -->'
+				echo '<td style="text-align:center; background-color:'"${tempColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${temp}"'</td> <!-- tempColor, temp -->'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${onTime}"'</td> <!-- onTime -->'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${startStop}"'</td> <!-- startStop -->'
+				echo '<td style="text-align:center; background-color:'"${mediaErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${mediaErrors}"'</td> <!-- mediaErrorsColor, mediaErrors -->'
+				echo '<td style="text-align:center; background-color:'"${errorsLogsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${errorsLogs}"'</td> <!-- errorsLogsColor, errorsLogs -->'
+				echo '<td style="text-align:center; background-color:'"${critWarningColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${critWarning}"'</td> <!-- critWarningColor, critWarning -->'
+				echo '<td style="text-align:center; background-color:'"${wearLevelingColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${wearLeveling}"'</td> <!-- wearLevelingColor, wearLeveling -->'
+				echo '<td style="text-align:center; background-color:'"${totalBWColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${totalBW}"'</td> <!-- totalBWColor, totalBW -->'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${bwPerDay}"'</td> <!-- bwPerDay -->'
+				echo '<td style="text-align:center; background-color:'"${testAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">N/A</td> <!-- testAgeColor, testAge -->'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">N/A</td> <!-- lastTestType -->'
+				echo '</tr>'
+			) >> "${logfile}"
 		fi
 	done
 
-    # End SMART summary table and summary section
-    (
-        echo "</table>"
-    ) >> "$logfile"
+	# End SMART summary table section
+	(
+		echo "</table>"
+	) >> "${logfile}"
+}
+
+
+if [ "${NVMeExist}" = "true" ]; then
+	NVMeSummary
 fi
 
 

From cfcf6c1e4eb51501779d45430d7e801c3d05f10b Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sat, 17 Apr 2021 01:05:17 -0400
Subject: [PATCH 025/160] A better command list.

Ordered by apearence.
---
 report.sh | 25 +++++++++++++++++++++----
 1 file changed, 21 insertions(+), 4 deletions(-)

diff --git a/report.sh b/report.sh
index b1b281e..dd3473f 100755
--- a/report.sh
+++ b/report.sh
@@ -154,17 +154,34 @@ fi
 # Check if needed software is installed.
 PATH="${PATH}:/usr/local/sbin:/usr/local/bin"
 commands=(
-grep
+hostname
+date
+sysctl
 sed
+grep
+awk
+zpool
 cut
-sleep
 bc
 smartctl
 jq
-ipmitool
-awk
+glabel
+sendmail
+)
+if [ "${configBackup}" = "true" ]; then
+commands+=(
 tar
+sqlite3
+md5
+sha256
+base64
+)
+fi
+if [ "${reportUPS}" = "true" ]; then
+commands+=(
+upsc
 )
+fi
 for command in "${commands[@]}"; do
 	if ! type "${command}" &> /dev/null; then
 		echo "${command} is missing, please install" >&2

From 9dd7061eda53cf08c5683bd2c5160171d2b78047 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 18 Apr 2021 00:15:52 +0000
Subject: [PATCH 026/160] Fix ups.

---
 report.sh | 536 +++++++++++++++++++++++++++++-------------------------
 1 file changed, 291 insertions(+), 245 deletions(-)

diff --git a/report.sh b/report.sh
index dd3473f..c358958 100755
--- a/report.sh
+++ b/report.sh
@@ -162,6 +162,7 @@ grep
 awk
 zpool
 cut
+tr
 bc
 smartctl
 jq
@@ -214,7 +215,7 @@ drives=$(for drive in $(sysctl -n kern.disks | sed -e 's:nvd:nvme:g'); do
 done | awk '{for (i=NF; i!=0 ; i--) print $i }')
 
 # Toggles the 'ssdExist' flag to true if SSDs are detected in order to add the summary table
-if [ "${includeSSD}" == "true" ]; then
+if [ "${includeSSD}" = "true" ]; then
     for drive in ${drives}; do
         if smartctl -i "/dev/${drive}" | grep -q "Solid State Device"; then
             ssdExist="true"
@@ -237,7 +238,7 @@ fi
     echo "To: ${email}"
     echo "Subject: ${subject}"
     echo "MIME-Version: 1.0"
-    echo "Content-Type: multipart/mixed; boundary=\"${boundary}\""
+    echo 'Content-Type: multipart/mixed; boundary="'"${boundary}"'"'
     echo "Date: $(date -R)"
     echo "Message-Id: <${messageid}@${host}>"
 ) > "${logfile}"
@@ -245,16 +246,16 @@ fi
 
 
 ###### Config backup (if enabled)
-if [ "$configBackup" == "true" ]; then
+if [ "$configBackup" = "true" ]; then
 
     # Set up file names, etc for later
     tarfile="/tmp/config_backup.tar.gz"
-    fnconfigdest_version=$(< /etc/version sed -e 's/)//;s/(//;s/ /-/' | tr -d '\n')
-    fnconfigdest_date=$(date +%Y%m%d%H%M%S)
-    filename="${fnconfigdest_date}"_"${fnconfigdest_version}"
+    fnconfigdest_version="$(< /etc/version sed -e 's:)::' -e 's:(::' -e 's: :-:' | tr -d '\n')"
+    fnconfigdest_date="$(date '+%Y%m%d%H%M%S')"
+    filename="${fnconfigdest_date}_${fnconfigdest_version}"
 
     ### Test config integrity
-    if ! [ "$(sqlite3 /data/freenas-v1.db "pragma integrity_check;")" == "ok" ]; then
+    if [ ! "$(sqlite3 "/data/freenas-v1.db" "pragma integrity_check;")" = "ok" ]; then
 
         # Config integrity check failed, set MIME content type to html and print warning
         (
@@ -267,22 +268,22 @@ if [ "$configBackup" == "true" ]; then
         ) >> "${logfile}"
     else
         # Config integrity check passed; copy config db, generate checksums, make .tar.gz archive
-        cp /data/freenas-v1.db "/tmp/${filename}.db"
+        sqlite3 "/data/freenas-v1.db" ".backup main /tmp/${filename}.db"
         md5 "/tmp/${filename}.db" > /tmp/config_backup.md5
         sha256 "/tmp/${filename}.db" > /tmp/config_backup.sha256
         (
             cd "/tmp/" || exit;
-            tar -czf "${tarfile}" "./${filename}.db" ./config_backup.md5 ./config_backup.sha256;
+            tar -czf "${tarfile}" "./${filename}.db" "./config_backup.md5" "./config_backup.sha256"
         )
         (
-        if [ "$emailBackup" == "true" ]; then
-            # Write MIME section header for file attachment (encoded with base64)
-            echo "--${boundary}"
-            echo -e "Content-Type: application/tar+gzip\n"
-            echo "Content-Transfer-Encoding: base64"
-            echo "Content-Disposition: attachment; filename=${filename}.tar.gz"
-            base64 "${tarfile}"
-    fi
+			if [ "${emailBackup}" = "true" ]; then
+				# Write MIME section header for file attachment (encoded with base64)
+				echo "--${boundary}"
+				echo -e "Content-Type: application/tar+gzip\n"
+				echo "Content-Transfer-Encoding: base64"
+				echo "Content-Disposition: attachment; filename=${filename}.tar.gz"
+				base64 "${tarfile}"
+			fi
 
             # Write MIME section header for html content to come below
             echo "--${boundary}"
@@ -291,16 +292,16 @@ if [ "$configBackup" == "true" ]; then
         ) >> "${logfile}"
 
         # If logfile saving is enabled, copy .tar.gz file to specified location before it (and everything else) is removed below
-        if [ "${saveBackup}" == "true" ]; then
+        if [ "${saveBackup}" = "true" ]; then
             cp "${tarfile}" "${backupLocation}/${filename}.tar.gz"
         fi
         rm "/tmp/${filename}.db"
-        rm /tmp/config_backup.md5
-        rm /tmp/config_backup.sha256
+        rm "/tmp/config_backup.md5"
+        rm "/tmp/config_backup.sha256"
         rm "${tarfile}"
     fi
 else
-    # Config backup enabled; set up for html-type content
+    # Config backup disabled; set up for html-type content
     (
         echo "--${boundary}"
         echo "Content-Transfer-Encoding: 8bit"
@@ -310,76 +311,77 @@ fi
 
 
 ###### Report Summary Section (html tables)
+
 ### zpool status summary table
 (
     # Write HTML table headers to log file; HTML in an email requires 100% in-line styling (no CSS or <style> section), hence the massive tags
-    echo "<br><br>"
-    echo "<table style=\"border: 1px solid black; border-collapse: collapse;\">"
-    echo "<tr><th colspan=\"14\" style=\"text-align:center; font-size:20px; height:40px; font-family:courier;\">ZPool Status Report Summary</th></tr>"
-    echo "<tr>"
-    echo "  <th style=\"text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Pool<br>Name</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Status</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Size</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Allocated</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Free</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Frag %</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Used %</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Read<br>Errors</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Write<br>Errors</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Cksum<br>Errors</th>"
-    echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Scrub<br>Repaired<br>Bytes</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Scrub<br>Errors</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Last<br>Scrub<br>Age (days)</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Last<br>Scrub<br>Duration</th>"
-    echo "</tr>"
-) >> "$logfile"
-
-poolNum=0
-pools=$(zpool list -H -o name)
-for pool in $pools; do
+    echo '<br><br>'
+    echo '<table style="border: 1px solid black; border-collapse: collapse;">'
+    echo '<tr><th colspan="14" style="text-align:center; font-size:20px; height:40px; font-family:courier;">ZPool Status Report Summary</th></tr>'
+    echo '<tr>'
+    echo '<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Pool<br>Name</th>'
+    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Status</th>'
+    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Size</th>'
+    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Allocated</th>'
+    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Free</th>'
+    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Frag %</th>'
+    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Used %</th>'
+    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Read<br>Errors</th>'
+    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Write<br>Errors</th>'
+    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Cksum<br>Errors</th>'
+    echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Scrub<br>Repaired<br>Bytes</th>'
+    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Scrub<br>Errors</th>'
+    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last<br>Scrub<br>Age (days)</th>'
+    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last<br>Scrub<br>Duration</th>'
+    echo '</tr>'
+) >> "${logfile}"
+
+poolNum="0"
+pools="$(zpool list -H -o name)"
+for pool in ${pools}; do
 
     # zpool health summary
-    status="$(zpool list -H -o health "$pool")"
+    status="$(zpool list -H -o health "${pool}")"
 
     # zpool fragment summary
-    frag="$(zpool list -H -p -o frag "$pool" | tr -d %% | awk '{print $0 + 0}')"
-    size="$(zpool list -H -o size "$pool")"
-    allocated="$(zpool list -H -o allocated "$pool")"
-    free="$(zpool list -H -o free "$pool")"
+    frag="$(zpool list -H -p -o frag "${pool}" | tr -d %% | awk '{print $0 + 0}')"
+    size="$(zpool list -H -o size "${pool}")"
+    allocated="$(zpool list -H -o allocated "${pool}")"
+    free="$(zpool list -H -o free "${pool}")"
 
     # Total all read, write, and checksum errors per pool
-    errors="$(zpool status "$pool" | grep -E "(ONLINE|DEGRADED|FAULTED|UNAVAIL|REMOVED)[ \\t]+[0-9]+")"
-    readErrors=0
-    for err in $(echo "$errors" | awk '{print $3}'); do
-        if echo "$err" | grep -E -q "[^0-9]+"; then
-            readErrors=1000
+    errors="$(zpool status "${pool}" | grep -E "(ONLINE|DEGRADED|FAULTED|UNAVAIL|REMOVED)[ \\t]+[0-9]+")"
+    readErrors="0"
+    for err in $(echo "${errors}" | awk '{print $3}'); do
+        if echo "${err}" | grep -E -q "[^0-9]+"; then
+            readErrors="1000"
             break
         fi
-        readErrors=$((readErrors + err))
+        readErrors="$((readErrors + err))"
     done
     writeErrors=0
-    for err in $(echo "$errors" | awk '{print $4}'); do
-        if echo "$err" | grep -E -q "[^0-9]+"; then
-            writeErrors=1000
+    for err in $(echo "${err}ors" | awk '{print $4}'); do
+        if echo "${err}" | grep -E -q "[^0-9]+"; then
+            writeErrors="1000"
             break
         fi
-        writeErrors=$((writeErrors + err))
+        writeErrors="$((writeErrors + err))"
     done
     cksumErrors=0
-    for err in $(echo "$errors" | awk '{print $5}'); do
-        if echo "$err" | grep -E -q "[^0-9]+"; then
-            cksumErrors=1000
+    for err in $(echo "${err}ors" | awk '{print $5}'); do
+        if echo "${err}" | grep -E -q "[^0-9]+"; then
+            cksumErrors="1000"
             break
         fi
-        cksumErrors=$((cksumErrors + err))
+        cksumErrors="$((cksumErrors + err))"
     done
     # Not sure why this changes values larger than 1000 to ">1K", but I guess it works, so I'm leaving it
-    if [ "$readErrors" -gt 999 ]; then readErrors=">1K"; fi
-    if [ "$writeErrors" -gt 999 ]; then writeErrors=">1K"; fi
-    if [ "$cksumErrors" -gt 999 ]; then cksumErrors=">1K"; fi
+    if [ "${readErrors}" -gt 999 ]; then readErrors=">1K"; fi
+    if [ "${writeErrors}" -gt 999 ]; then writeErrors=">1K"; fi
+    if [ "${cksumErrors}" -gt 999 ]; then cksumErrors=">1K"; fi
 
     # Get used capacity percentage of the zpool
-    used="$(zpool list -H -p -o capacity "$pool")"
+    used="$(zpool list -H -p -o capacity "${pool}")"
 
     # Gather info from most recent scrub; values set to "N/A" initially and overwritten when (and if) it gathers scrub info
     scrubRepBytes="N/A"
@@ -388,93 +390,135 @@ for pool in $pools; do
     scrubTime="N/A"
     resilver=""
 
-    statusOutput="$(zpool status "$pool")"
+    statusOutput="$(zpool status "${pool}")"
     # normal status i.e. scrub
-    if [ "$(echo "$statusOutput" | grep "scan:" | awk '{print $2" "$3}')" = "scrub repaired" ]; then
-        scrubRepBytes="$(echo "$statusOutput" | grep "scan:" | awk '{gsub(/B/,"",$4); print $4}')"
-        scrubErrors="$(echo "$statusOutput" | grep "scan:" | awk '{print $8}')"
+    if [ "$(echo "${statusOutput}" | grep "scan:" | awk '{print $2" "$3}')" = "scrub repaired" ]; then
+        scrubRepBytes="$(echo "${statusOutput}" | grep "scan:" | awk '{gsub(/B/,"",$4); print $4}')"
+        scrubErrors="$(echo "${statusOutput}" | grep "scan:" | awk '{print $8}')"
 
         # Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
-        scrubDate="$(echo "$statusOutput" | grep "scan:" | awk '{print $15"-"$12"-"$13"_"$14}')"
-        scrubTS="$(date -j -f "%Y-%b-%e_%H:%M:%S" "$scrubDate" "+%s")"
+        scrubDate="$(echo "${statusOutput}" | grep "scan:" | awk '{print $15"-"$12"-"$13"_"$14}')"
+        scrubTS="$(date -j -f "%Y-%b-%e_%H:%M:%S" "${scrubDate}" "+%s")"
         currentTS="$(date "+%s")"
-        scrubAge=$((((currentTS - scrubTS) + 43200) / 86400))
-        scrubTime="$(echo "$statusOutput" | grep "scan" | awk '{print $6}')"
+        scrubAge="$((((currentTS - scrubTS) + 43200) / 86400))"
+        scrubTime="$(echo "${statusOutput}" | grep "scan" | awk '{print $6}')"
 
     # if status is resilvered
-    elif [ "$(echo "$statusOutput" | grep "scan:" | awk '{print $2}')" = "resilvered" ]; then
+    elif [ "$(echo "${statusOutput}" | grep "scan:" | awk '{print $2}')" = "resilvered" ]; then
             resilver="<BR>Resilvered"
-            scrubRepBytes="$(echo "$statusOutput" | grep "scan:" | awk '{print $3}')"
-            scrubErrors="$(echo "$statusOutput" | grep "scan:" | awk '{print $9}')"
+            scrubRepBytes="$(echo "${statusOutput}" | grep "scan:" | awk '{print $3}')"
+            scrubErrors="$(echo "${statusOutput}" | grep "scan:" | awk '{print $9}')"
 
             # Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
-            scrubDate="$(echo "$statusOutput" | grep "scan:" | awk '{print $16"-"$13"-"$14"_"$15}')"
-            scrubTS="$(date -j -f "%Y-%b-%e_%H:%M:%S" "$scrubDate" "+%s")"
+            scrubDate="$(echo "${statusOutput}" | grep "scan:" | awk '{print $16"-"$13"-"$14"_"$15}')"
+            scrubTS="$(date -j -f "%Y-%b-%e_%H:%M:%S" "${scrubDate}" "+%s")"
             currentTS="$(date "+%s")"
-            scrubAge=$((((currentTS - scrubTS) + 43200) / 86400))
-            scrubTime="$(echo "$statusOutput" | grep "scan:" | awk '{print $7}')"
+            scrubAge="$((((currentTS - scrubTS) + 43200) / 86400))"
+            scrubTime="$(echo "${statusOutput}" | grep "scan:" | awk '{print $7}')"
 
     # Check if resilver is in progress
-    elif [ "$(echo "$statusOutput"| grep "scan:" | awk '{print $2}')" = "resilver" ]; then
+    elif [ "$(echo "${statusOutput}"| grep "scan:" | awk '{print $2}')" = "resilver" ]; then
         scrubRepBytes="Resilver In Progress"
-        scrubAge="$(echo "$statusOutput" | grep "resilvered," | awk '{print $3" done"}')"
-        if [ "$(echo "$statusOutput" | grep "resilvered," | awk '{print $5}')" = "0" ]; then
-            scrubTime="$(echo "$statusOutput" | grep "resilvered," | awk '{print $7"<br>to go"}')"
+        scrubAge="$(echo "${statusOutput}" | grep "resilvered," | awk '{print $3" done"}')"
+        if [ "$(echo "${statusOutput}" | grep "resilvered," | awk '{print $5}')" = "0" ]; then
+            scrubTime="$(echo "${statusOutput}" | grep "resilvered," | awk '{print $7"<br>to go"}')"
         else
-            scrubTime="$(echo "$statusOutput" | grep "resilvered," | awk '{print $5" "$6" "$7"<br>to go"}')"
+            scrubTime="$(echo "${statusOutput}" | grep "resilvered," | awk '{print $5" "$6" "$7"<br>to go"}')"
         fi
 
     # Check if scrub is in progress
-    elif [ "$(echo "$statusOutput"| grep "scan:" | awk '{print $4}')" = "progress" ]; then
+    elif [ "$(echo "${statusOutput}"| grep "scan:" | awk '{print $4}')" = "progress" ]; then
         scrubRepBytes="Scrub In Progress"
-        scrubErrors="$(echo "$statusOutput" | grep "repaired," | awk '{print $1" repaired"}')"
-        scrubAge="$(echo "$statusOutput" | grep "repaired," | awk '{print $3" done"}')"
-        if [ "$(echo "$statusOutput" | grep "repaired," | awk '{print $5}')" = "0" ]; then
-            scrubTime="$(echo "$statusOutput" | grep "repaired," | awk '{print $7"<br>to go"}')"
+        scrubErrors="$(echo "${statusOutput}" | grep "repaired," | awk '{print $1" repaired"}')"
+        scrubAge="$(echo "${statusOutput}" | grep "repaired," | awk '{print $3" done"}')"
+        if [ "$(echo "${statusOutput}" | grep "repaired," | awk '{print $5}')" = "0" ]; then
+            scrubTime="$(echo "${statusOutput}" | grep "repaired," | awk '{print $7"<br>to go"}')"
         else
-            scrubTime="$(echo "$statusOutput" | grep "repaired," | awk '{print $5" "$6" "$7"<br>to go"}')"
+            scrubTime="$(echo "${statusOutput}" | grep "repaired," | awk '{print $5" "$6" "$7"<br>to go"}')"
         fi
     fi
 
     # Set row's background color; alternates between white and $altColor (light gray)
-    if [ $((poolNum % 2)) == 1 ]; then bgColor="#ffffff"; else bgColor="$altColor"; fi
-    poolNum=$((poolNum + 1))
+    if [ "$((poolNum % 2))" = "1" ]; then
+		bgColor="#ffffff"
+    else
+		bgColor="$altColor"
+    fi
+    poolNum="$((poolNum + 1))"
 
     # Set up conditions for warning or critical colors to be used in place of standard background colors
-    if [ "$status" != "ONLINE" ]; then statusColor="$warnColor"; else statusColor="$bgColor"; fi
-    status+="$resilver"
-    if [ "$readErrors" != "0" ]; then readErrorsColor="$warnColor"; else readErrorsColor="$bgColor"; fi
-    if [ "$writeErrors" != "0" ]; then writeErrorsColor="$warnColor"; else writeErrorsColor="$bgColor"; fi
-    if [ "$cksumErrors" != "0" ]; then cksumErrorsColor="$warnColor"; else cksumErrorsColor="$bgColor"; fi
-    if [ "$used" -gt "$usedWarn" ]; then usedColor="$warnColor"; else usedColor="$bgColor"; fi
-    if [ "$scrubRepBytes" != "N/A" ] && [ "$scrubRepBytes" != "0" ] && [ "$scrubRepBytes" != "0B" ]; then
-        scrubRepBytesColor="$warnColor"; else scrubRepBytesColor="$bgColor"; fi
-    if [ "$scrubErrors" != "N/A" ] && [ "$scrubErrors" != "0" ]; then scrubErrorsColor="$warnColor"; else scrubErrorsColor="$bgColor"; fi
-    if [ "$(echo "$scrubAge" | awk '{print int($1)}')" -gt "$scrubAgeWarn" ]; then scrubAgeColor="$warnColor"; else scrubAgeColor="$bgColor"; fi
+    if [ ! "${status}" = "ONLINE" ]; then
+		statusColor="${warnColor}"
+    else
+		statusColor="${bgColor}"
+    fi
+    status+="${resilver}"
+
+    if [ ! "${readErrors}" = "0" ]; then
+		readErrorsColor="${warnColor}"
+    else
+		readErrorsColor="${bgColor}"
+    fi
+
+    if [ ! "${writeErrors}" = "0" ]; then
+		writeErrorsColor="${warnColor}"
+    else
+		writeErrorsColor="${bgColor}"
+    fi
+
+    if [ ! "${cksumErrors}" = "0" ]; then
+		cksumErrorsColor="${warnColor}"
+    else
+		cksumErrorsColor="${bgColor}"
+    fi
+
+    if [ "${used}" -gt "${usedWarn}" ]; then
+		usedColor="${warnColor}"
+    else
+		usedColor="${bgColor}"
+    fi
+
+    if [ ! "${scrubRepBytes}" = "N/A" ] && [ ! "${scrubRepBytes}" = "0" ] && [ ! "${scrubRepBytes}" = "0B" ]; then
+        scrubRepBytesColor="${warnColor}"
+	else
+		scrubRepBytesColor="${bgColor}"
+	fi
+
+    if [ ! "${scrubErrors}" = "N/A" ] && [ ! "${scrubErrors}" = "0" ]; then
+		scrubErrorsColor="${warnColor}"
+    else
+		scrubErrorsColor="${bgColor}"
+    fi
+
+    if [ "$(echo "$scrubAge" | awk '{print int($1)}')" -gt "${scrubAgeWarn}" ]; then
+		scrubAgeColor="${warnColor}"
+    else
+		scrubAgeColor="${bgColor}"
+    fi
+
     (
         # Use the information gathered above to write the date to the current table row
-        printf "<tr style=\"background-color:%s;\">
-            <td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
-            <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
-            <td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
-            <td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
-            <td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
-            <td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s%%</td>
-            <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s%%</td>
-            <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
-            <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
-            <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
-            <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
-            <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
-            <td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
-            <td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>
-        </tr>\\n" "$bgColor" "$pool" "$statusColor" "$status" "$size" "$allocated" "$free" "$frag" "$usedColor" "$used" "$readErrorsColor" "$readErrors" "$writeErrorsColor" "$writeErrors" "$cksumErrorsColor" \
-        "$cksumErrors" "$scrubRepBytesColor" "$scrubRepBytes" "$scrubErrorsColor" "$scrubErrors" "$scrubAgeColor" "$scrubAge" "$scrubTime"
-    ) >> "$logfile"
+		echo '<tr style="background-color:'"${bgColor}"'">'
+		echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${pool}"'</td>'
+		echo '<td style="text-align:center; background-color:'"${statusColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${status}"'</td>'
+		echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${size}"'</td>'
+		echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${allocated}"'</td>'
+		echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${free}"'</td>'
+		echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${frag}"'%</td>'
+		echo '<td style="text-align:center; background-color:'"${usedColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${used}"'%</td>'
+		echo '<td style="text-align:center; background-color:'"${readErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${readErrors}"'</td>'
+		echo '<td style="text-align:center; background-color:'"${writeErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${writeErrors}"'</td>'
+		echo '<td style="text-align:center; background-color:'"${cksumErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${cksumErrors}"'</td>'
+		echo '<td style="text-align:center; background-color:'"${scrubRepBytesColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scrubRepBytes}"'</td>'
+		echo '<td style="text-align:center; background-color:'"${scrubErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scrubErrors}"'</td>'
+		echo '<td style="text-align:center; background-color:'"${scrubAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scrubAge}"'</td>'
+		echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scrubTime}"'</td>'
+		echo '</tr>'
+    ) >> "${logfile}"
 done
 
 # End of zpool status table
-echo "</table>" >> "$logfile"
+echo '</table>' >> "${logfile}"
 
 
 ### SMART status summary tables
@@ -704,30 +748,30 @@ fi
 if [ "${ssdExist}" = "true" ]; then
     (
         # Write HTML table headers to log file
-        echo "<br><br>"
-        echo "<table style=\"border: 1px solid black; border-collapse: collapse;\">"
-        echo "<tr><th colspan=\"18\" style=\"text-align:center; font-size:20px; height:40px; font-family:courier;\">SSD SMART Status Report Summary</th></tr>"
-        echo "<tr>"
-        echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Device</th>"
-        echo "  <th style=\"text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Model</th>"
-        echo "  <th style=\"text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Serial<br>Number</th>"
-        echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Capacity</th>"
-        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">SMART<br>Status</th>"
-        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Temp</th>"
-        echo "  <th style=\"text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Power-On<br>Time<br>($powerTimeFormat)</th>"
-        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Power<br>Cycle<br>Count</th>"
-        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Realloc<br>Sectors</th>"
-        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Program<br>Fail<br>Count</th>"
-        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Erase<br>Fail<br>Count</th>"
-        echo "  <th style=\"text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Offline<br>Uncorrectable<br>Sectors</th>"
-        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">CRC<br>Errors</th>"
-        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Wear<br>Leveling<br>Count</th>"
-        echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Total<br>Bytes<br>Written</th>"
-        echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Bytes Written<br>(per Day)</th>"
-        echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Last Test<br>Age (days)</th>"
-        echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Last Test<br>Type</th></tr>"
-        echo "</tr>"
-    ) >> "$logfile"
+        echo '<br><br>'
+        echo '<table style="border: 1px solid black; border-collapse: collapse;">'
+        echo '<tr><th colspan="18" style="text-align:center; font-size:20px; height:40px; font-family:courier;">SSD SMART Status Report Summary</th></tr>'
+        echo '<tr>'
+        echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Device</th>'
+        echo '<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Model</th>'
+        echo '<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Serial<br>Number</th>'
+        echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Capacity</th>'
+        echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">SMART<br>Status</th>'
+        echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Temp</th>'
+        echo '<th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Power-On<br>Time<br>('"${powerTimeFormat}"')</th>'
+        echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Power<br>Cycle<br>Count</th>'
+        echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Realloc<br>Sectors</th>'
+        echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Program<br>Fail<br>Count</th>'
+        echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Erase<br>Fail<br>Count</th>'
+        echo '<th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Offline<br>Uncorrectable<br>Sectors</th>'
+        echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">CRC<br>Errors</th>'
+        echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Wear<br>Leveling<br>Count</th>'
+        echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Total<br>Bytes<br>Written</th>'
+        echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Bytes Written<br>(per Day)</th>'
+        echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Age (days)</th>'
+        echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Type</th></tr>'
+        echo '</tr>'
+    ) >> "${logfile}"
 
     for drive in ${drives}; do
         if smartctl -i "/dev/${drive}" | grep -q "Solid State Device"; then
@@ -814,14 +858,14 @@ if [ "${ssdExist}" = "true" ]; then
                     progFailColor, progFail, eraseFailColor, eraseFail, offlineUncColor, offlineUnc, crcErrorsColor, crcErrors, wearLevelingColor, wearLeveling, totalBWColor, totalBW, \
                     bwPerDay, testAgeColor, testAge, lastTestType;
                 }'
-            ) >> "$logfile"
+            ) >> "${logfile}"
         fi
     done
 
     # End SMART summary table and summary section
     (
-        echo "</table>"
-    ) >> "$logfile"
+        echo '</table>'
+    ) >> "${logfile}"
 fi
 
 
@@ -829,30 +873,30 @@ fi
 ###### HDD SMART status summary table
 (
     # Write HTML table headers to log file
-    echo "<br><br>"
-    echo "<table style=\"border: 1px solid black; border-collapse: collapse;\">"
-    echo "<tr><th colspan=\"18\" style=\"text-align:center; font-size:20px; height:40px; font-family:courier;\">HDD SMART Status Report Summary</th></tr>"
-    echo "<tr>"
-    echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Device</th>"
-    echo "  <th style=\"text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Model</th>"
-    echo "  <th style=\"text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Serial<br>Number</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">RPM</th>"
-    echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Capacity</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">SMART<br>Status</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Temp</th>"
-    echo "  <th style=\"text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Power-On<br>Time<br>($powerTimeFormat)</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Start<br>Stop<br>Count</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Spin<br>Retry<br>Count</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Realloc<br>Sectors</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Realloc<br>Events</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Current<br>Pending<br>Sectors</th>"
-    echo "  <th style=\"text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Offline<br>Uncorrectable<br>Sectors</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">CRC<br>Errors</th>"
-    echo "  <th style=\"text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Seek<br>Error<br>Health</th>"
-    echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Last Test<br>Age (days)</th>"
-    echo "  <th style=\"text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;\">Last Test<br>Type</th></tr>"
-    echo "</tr>"
-) >> "$logfile"
+    echo '<br><br>'
+    echo '<table style="border: 1px solid black; border-collapse: collapse;">'
+    echo '<tr><th colspan="18" style="text-align:center; font-size:20px; height:40px; font-family:courier;">HDD SMART Status Report Summary</th></tr>'
+    echo '<tr>'
+    echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Device</th>'
+    echo '<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Model</th>'
+    echo '<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Serial<br>Number</th>'
+    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">RPM</th>'
+    echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Capacity</th>'
+    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">SMART<br>Status</th>'
+    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Temp</th>'
+    echo '<th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Power-On<br>Time<br>('"${powerTimeFormat}"')</th>'
+    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Start<br>Stop<br>Count</th>'
+    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Spin<br>Retry<br>Count</th>'
+    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Realloc<br>Sectors</th>'
+    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Realloc<br>Events</th>'
+    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Current<br>Pending<br>Sectors</th>'
+    echo '<th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Offline<br>Uncorrectable<br>Sectors</th>'
+    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">CRC<br>Errors</th>'
+    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Seek<br>Error<br>Health</th>'
+    echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Age (days)</th>'
+    echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Type</th></tr>'
+    echo '</tr>'
+) >> "${logfile}"
 
 for drive in ${drives}; do
     if smartctl -i "/dev/${drive}" | grep -q "SMART support is: Enabled"; then
@@ -929,76 +973,78 @@ for drive in ${drives}; do
                 reAllocEventColor, reAllocEvent, pendingColor, pending, offlineUncColor, offlineUnc, crcErrorsColor, crcErrors, seekErrorHealthColor, seekErrorHealth, \
                 testAgeColor, testAge, lastTestType;
             }'
-        ) >> "$logfile"
+        ) >> "${logfile}"
         fi
     fi
 done
 
 # End SMART summary table and summary section
 (
-    echo "</table>"
-    echo "<br><br>"
-) >> "$logfile"
+    echo '</table>'
+    echo '<br><br>'
+) >> "${logfile}"
 
 
 
 ###### Detailed Report Section (monospace text)
-echo "<pre style=\"font-size:14px\">" >> "$logfile"
+echo '<pre style="font-size:14px">' >> "${logfile}"
 
 
 ### UPS status report
-if [ "$reportUPS" == "true" ]; then
+if [ "${reportUPS}" = "true" ]; then
 
     # Set to a value greater than zero to include all available UPSC
     # variables in the report:
-    senddetail=0
+    senddetail="0"
 
     # Get a list of all ups devices installed on the system:
-    upslist=$(upsc -l "${host}")
+    upslist="$(upsc -l "${host}")"
 
     (
-    echo "<pre style=\"font-size:14px\">"
-    echo "<b>########## UPS status report ##########</b>"
-        for ups in $upslist; do
-        ups_type=$(upsc "${ups}" device.type 2> /dev/null | tr '[:lower:]' '[:upper:]')
-        ups_mfr=$(upsc "${ups}" ups.mfr 2> /dev/null)
-        ups_model=$(upsc "${ups}" ups.model 2> /dev/null)
-        ups_serial=$(upsc "${ups}" ups.serial 2> /dev/null)
-        ups_status=$(upsc "${ups}" ups.status 2> /dev/null)
-        ups_load=$(upsc "${ups}" ups.load 2> /dev/null)
-        ups_realpower=$(upsc "${ups}" ups.realpower 2> /dev/null)
-        ups_realpowernominal=$(upsc "${ups}" ups.realpower.nominal 2> /dev/null)
-        ups_batterycharge=$(upsc "${ups}" battery.charge 2> /dev/null)
-        ups_batteryruntime=$(upsc "${ups}" battery.runtime 2> /dev/null)
-        ups_batteryvoltage=$(upsc "${ups}" battery.voltage 2> /dev/null)
-        ups_inputvoltage=$(upsc "${ups}" input.voltage 2> /dev/null)
-        ups_outputvoltage=$(upsc "${ups}" output.voltage 2> /dev/null)
-        printf "=== %s %s, model %s, serial number %s\n\n" "${ups_mfr}" "${ups_type}" "${ups_model}" "${ups_serial} ==="
-        echo "Name: ${ups}"
-        echo "Status: ${ups_status}"
-        echo "Output Load: ${ups_load}%"
-        if [ ! -z "${ups_realpower}" ]; then
-            echo "Real Power: ${ups_realpower}W"
-        fi
-        if [ ! -z "${ups_realpowernominal}" ]; then
-            echo "Real Power: ${ups_realpowernominal}W (nominal)"
-        fi
-        if [ ! -z "${ups_inputvoltage}" ]; then
-            echo "Input Voltage: ${ups_inputvoltage}V"
-        fi
-        if [ ! -z "${ups_outputvoltage}" ]; then
-            echo "Output Voltage: ${ups_outputvoltage}V"
-        fi
-        echo "Battery Runtime: ${ups_batteryruntime}s"
-        echo "Battery Charge: ${ups_batterycharge}%"
-        echo "Battery Voltage: ${ups_batteryvoltage}V"
-        echo ""
-        if [ $senddetail -gt 0 ]; then
-            echo "=== ALL AVAILABLE UPS VARIABLES ==="
-            upsc "${ups}"
-            echo ""
-        fi
-    done
+		echo '<pre style="font-size:14px">'
+		echo '<b>########## UPS status report ##########</b>'
+			for ups in ${upslist}; do
+
+				ups_type="$(upsc "${ups}" device.type 2> /dev/null | tr '[:lower:]' '[:upper:]')"
+				ups_mfr="$(upsc "${ups}" ups.mfr 2> /dev/null)"
+				ups_model="$(upsc "${ups}" ups.model 2> /dev/null)"
+				ups_serial="$(upsc "${ups}" ups.serial 2> /dev/null)"
+				ups_status="$(upsc "${ups}" ups.status 2> /dev/null)"
+				ups_load="$(upsc "${ups}" ups.load 2> /dev/null)"
+				ups_realpower="$(upsc "${ups}" ups.realpower 2> /dev/null)"
+				ups_realpowernominal="$(upsc "${ups}" ups.realpower.nominal 2> /dev/null)"
+				ups_batterycharge="$(upsc "${ups}" battery.charge 2> /dev/null)"
+				ups_batteryruntime="$(upsc "${ups}" battery.runtime 2> /dev/null)"
+				ups_batteryvoltage="$(upsc "${ups}" battery.voltage 2> /dev/null)"
+				ups_inputvoltage="$(upsc "${ups}" input.voltage 2> /dev/null)"
+				ups_outputvoltage="$(upsc "${ups}" output.voltage 2> /dev/null)"
+
+				printf "=== %s %s, model %s, serial number %s\n\n" "${ups_mfr}" "${ups_type}" "${ups_model}" "${ups_serial} ==="
+				echo "Name: ${ups}"
+				echo "Status: ${ups_status}"
+				echo "Output Load: ${ups_load}%"
+				if [ ! -z "${ups_realpower}" ]; then
+					echo "Real Power: ${ups_realpower}W"
+				fi
+				if [ ! -z "${ups_realpowernominal}" ]; then
+					echo "Real Power: ${ups_realpowernominal}W (nominal)"
+				fi
+				if [ ! -z "${ups_inputvoltage}" ]; then
+					echo "Input Voltage: ${ups_inputvoltage}V"
+				fi
+				if [ ! -z "${ups_outputvoltage}" ]; then
+					echo "Output Voltage: ${ups_outputvoltage}V"
+				fi
+				echo "Battery Runtime: ${ups_batteryruntime}s"
+				echo "Battery Charge: ${ups_batterycharge}%"
+				echo "Battery Voltage: ${ups_batteryvoltage}V"
+				echo ""
+				if [ "${senddetail}" -gt "0" ]; then
+					echo "=== ALL AVAILABLE UPS VARIABLES ==="
+					upsc "${ups}"
+					echo ""
+				fi
+			done
     ) >> "${logfile}"
 
     echo "</pre>" >> "${logfile}"
@@ -1007,20 +1053,20 @@ fi
 
 ### Print Glabel Status
 (
-    echo "<b>########## Glabel Status ##########</b>"
+    echo '<b>########## Glabel Status ##########</b>'
     glabel status
-    echo "<br><br>"
-) >> "$logfile"
+    echo '<br><br>'
+) >> "${logfile}"
 
 
 ### Zpool status for each pool
-for pool in $pools; do
+for pool in ${pools}; do
     (
         # Create a simple header and drop the output of zpool status -v
-        echo "<b>########## ZPool status report for ${pool} ##########</b>"
-        zpool status -v "$pool"
-        echo "<br><br>"
-    ) >> "$logfile"
+        echo '<b>########## ZPool status report for '"${pool}"' ##########</b>'
+        zpool status -v "${pool}"
+        echo '<br><br>'
+    ) >> "${logfile}"
 done
 
 
@@ -1035,11 +1081,11 @@ for drive in ${drives}; do
         serial="$(smartctl -ij "/dev/${drive}" | jq -Mre '.serial_number | values')"
         (
             # Create a simple header and drop the output of some basic smartctl commands
-            echo "<b>########## SMART status report for ${drive} drive (${brand}: ${serial}) ##########</b>"
+            echo '<b>########## SMART status report for '"${drive}"' drive ('"${brand}: ${serial}"') ##########</b>'
             smartctl -H -A -l error "/dev/${drive}"
-            smartctl -l selftest "/dev/${drive}" | grep "Extended \\|Num" | cut -c6- | head -2
-            smartctl -l selftest "/dev/${drive}" | grep "Short \\|Num" | cut -c6- | head -2 | tail -n -1
-            echo "<br><br>"
+            smartctl -l selftest "/dev/${drive}" | grep 'Extended \\|Num' | cut -c6- | head -2
+            smartctl -l selftest "/dev/${drive}" | grep 'Short \\|Num' | cut -c6- | head -2 | tail -n -1
+            echo '<br><br>'
         ) >> "${logfile}"
 
     elif echo "${drive}" | grep -q "nvme"; then
@@ -1052,9 +1098,9 @@ for drive in ${drives}; do
 		serial="$(echo "${nvmeSmartOut}" | jq -Mre '.serial_number | values')"
 		(
 			# Create a simple header and drop the output of some basic smartctl commands
-            echo "<b>########## SMART status report for ${drive} drive (${brand}: ${serial}) ##########</b>"
+            echo '<b>########## SMART status report for '"${drive}"' drive ('"${brand}: ${serial}"') ##########</b>'
             smartctl -H -A -l error "/dev/${drive}"
-            echo "<br><br>"
+            echo '<br><br>'
 		) >> "${logfile}"
     fi
 done
@@ -1070,12 +1116,12 @@ sed -i '' -e '/SMART Error Log Version/d' "${logfile}"
 
 ### End details section, close MIME section
 (
-    echo "</pre>"
+    echo '</pre>'
     echo "--${boundary}--"
-)  >> "$logfile"
+)  >> "${logfile}"
 
 ### Send report
-sendmail -t -oi < "$logfile"
-if [ "$saveLogfile" == "false" ]; then
-    rm "$logfile"
+sendmail -t -oi < "${logfile}"
+if [ "${saveLogfile}" = "false" ]; then
+    rm "${logfile}"
 fi

From 1b50183590305ef84f18568a478d636e6373ad43 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sat, 17 Apr 2021 20:50:45 -0400
Subject: [PATCH 027/160] Do not skew the current time.

---
 report.sh | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/report.sh b/report.sh
index c358958..bfd873a 100755
--- a/report.sh
+++ b/report.sh
@@ -200,8 +200,9 @@ fi
 
 ###### Auto-generated Parameters
 host=$(hostname -s)
-logfile="${logfileLocation}/$(date +%Y%m%d%H%M%S)_${logfileName}.tmp"
-subject="Status Report and Configuration Backup for ${host} - $(date "+%Y-%m-%d %H:%M")"
+runDate="$(date '+%s')"
+logfile="${logfileLocation}/$(date -r "${runDate}" '+%Y%m%d%H%M%S')_${logfileName}.tmp"
+subject="Status Report and Configuration Backup for ${host} - $(date -r "${runDate}" '+%Y-%m-%d %H:%M')"
 boundary="$(dbus-uuidgen)"
 messageid="$(dbus-uuidgen)"
 
@@ -239,7 +240,7 @@ fi
     echo "Subject: ${subject}"
     echo "MIME-Version: 1.0"
     echo 'Content-Type: multipart/mixed; boundary="'"${boundary}"'"'
-    echo "Date: $(date -R)"
+    echo "Date: $(date -Rr "${runDate}")"
     echo "Message-Id: <${messageid}@${host}>"
 ) > "${logfile}"
 
@@ -251,7 +252,7 @@ if [ "$configBackup" = "true" ]; then
     # Set up file names, etc for later
     tarfile="/tmp/config_backup.tar.gz"
     fnconfigdest_version="$(< /etc/version sed -e 's:)::' -e 's:(::' -e 's: :-:' | tr -d '\n')"
-    fnconfigdest_date="$(date '+%Y%m%d%H%M%S')"
+    fnconfigdest_date="$(date -r "${runDate}" '+%Y%m%d%H%M%S')"
     filename="${fnconfigdest_date}_${fnconfigdest_version}"
 
     ### Test config integrity
@@ -398,8 +399,8 @@ for pool in ${pools}; do
 
         # Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
         scrubDate="$(echo "${statusOutput}" | grep "scan:" | awk '{print $15"-"$12"-"$13"_"$14}')"
-        scrubTS="$(date -j -f "%Y-%b-%e_%H:%M:%S" "${scrubDate}" "+%s")"
-        currentTS="$(date "+%s")"
+        scrubTS="$(date -j -f '%Y-%b-%e_%H:%M:%S' "${scrubDate}" '+%s')"
+        currentTS="${runDate}"
         scrubAge="$((((currentTS - scrubTS) + 43200) / 86400))"
         scrubTime="$(echo "${statusOutput}" | grep "scan" | awk '{print $6}')"
 
@@ -411,8 +412,8 @@ for pool in ${pools}; do
 
             # Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
             scrubDate="$(echo "${statusOutput}" | grep "scan:" | awk '{print $16"-"$13"-"$14"_"$15}')"
-            scrubTS="$(date -j -f "%Y-%b-%e_%H:%M:%S" "${scrubDate}" "+%s")"
-            currentTS="$(date "+%s")"
+            scrubTS="$(date -j -f '%Y-%b-%e_%H:%M:%S' "${scrubDate}" '+%s')"
+            currentTS="${runDate}"
             scrubAge="$((((currentTS - scrubTS) + 43200) / 86400))"
             scrubTime="$(echo "${statusOutput}" | grep "scan:" | awk '{print $7}')"
 

From cccd88ef1215584bed01c4cd3d13976dc919b49b Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 18 Apr 2021 17:28:24 +0000
Subject: [PATCH 028/160] Reorg the nvme parsing.

---
 report.sh | 31 ++++++++++++++++++-------------
 1 file changed, 18 insertions(+), 13 deletions(-)

diff --git a/report.sh b/report.sh
index bfd873a..fb20e8e 100755
--- a/report.sh
+++ b/report.sh
@@ -572,12 +572,12 @@ function NVMeSummary () {
 	) >> "${logfile}"
 
 
+	local drive
+	local altRow="false"
 	for drive in ${drives}; do
-		local altRow="false"
 		if echo "${drive}" | grep -q "nvme"; then
-			# For each drive detected, run "smartctl -Aij" and parse its output. This whole section is a single, long statement, so I'll make all comments here.
-			# Start by passing awk variables (all the -v's) used in other parts of the script. Other variables are calculated in-line with other smartctl calls.
-			# Next, pull values out of the original "smartctl -Aij" statement by searching for the text between the //'s.
+			# For each drive detected, run "smartctl -Aij" and parse its output.
+			# Start by parsing variables used in other parts of the script.
 			# After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).
 			# After these computations, determine the row's background color (alternating as above, subbing in other colors from the palate as needed).
 			# Finally, print the HTML code for the current row of the table with all the gathered data.
@@ -587,18 +587,19 @@ function NVMeSummary () {
 
 			local model="$(echo "${nvmeSmarOut}" | jq -Mre '.model_name | values')"
 			local serial="$(echo "${nvmeSmarOut}" | jq -Mre '.serial_number | values')"
-			local capacity="[$(echo "${nvmeSmarOut}" | jq -Mre '(.user_capacity.bytes/1000215216) | values')GB]"
 			local temp="$(echo "${nvmeSmarOut}" | jq -Mre '.temperature.current | values')"
 			local onHours="$(echo "${nvmeSmarOut}" | jq -Mre '.power_on_time.hours | values')"
 			local startStop="$(echo "${nvmeSmarOut}" | jq -Mre '.power_cycle_count | values')"
+			local sectorSize="$(echo "${nvmeSmarOut}" | jq -Mre '.logical_block_size | values')"
+
 			local mediaErrors="$(echo "${nvmeSmarOut}" | jq -Mre '.nvme_smart_health_information_log.media_errors | values')"
 			local errorsLogs="$(echo "${nvmeSmarOut}" | jq -Mre '.nvme_smart_health_information_log.num_err_log_entries | values')"
 			local critWarning="$(echo "${nvmeSmarOut}" | jq -Mre '.nvme_smart_health_information_log.critical_warning | values')"
 			local wearLeveling="$(echo "${nvmeSmarOut}" | jq -Mre '.nvme_smart_health_information_log.available_spare | values')"
-			local sectorSize="$(echo "${nvmeSmarOut}" | jq -Mre '.logical_block_size | values')"
 			local totalLBA="$(echo "${nvmeSmarOut}" | jq -Mre '.nvme_smart_health_information_log.data_units_written | values')"
 
-			local smartStatus="$(smartctl -H "/dev/${drive}" | grep "SMART overall-health" | awk '{print $6}')"
+			local capacity="$(smartctl -i "/dev/${drive}" | grep '^Namespace 1 Size' | tr -s ' ' | cut -d ' ' -sf '5,6')"
+			local smartStatus="$(smartctl -H "/dev/${drive}" | grep "SMART overall-health" | cut -d ' ' -sf 6)"
 
 			# Get more useful times from hours
 			local testAge="$(bc <<< "(${onHours} - (${onHours} - 2) ) / 24")" # ${lastTestHours}
@@ -685,21 +686,25 @@ function NVMeSummary () {
 			fi
 
 			# Colorize & derive write stats
-			local totalBW="$(bc <<< "(${totalLBA} * ${sectorSize}) / (10^9)")"
-			if [ "${totalBW}" -ge "${totalBWCrit}" ]; then
+			local totalBW="$(bc <<< "scale=1; (${totalLBA} * ${sectorSize}) / (1024^4)" | sed -e 's:^\.:0.:')"
+			if (( $(bc -l <<< "${totalBW}" > "${totalBWCrit}") )); then
 				local totalBWColor="${critColor}"
-			elif [ "${totalBW}" -ge "${totalBWWarn}" ]; then
+			elif (( $(bc -l <<< "${totalBW}" > "${totalBWWarn}") )); then
 				local totalBWColor="${warnColor}"
 			else
 				local totalBWColor="${bgColor}"
 			fi
-			if [ "${totalBW}" = "0" ]; then
+			if [ "${totalBW}" = "0.0" ]; then
 				totalBW="N/A"
-				bwPerDay="N/A"
 			else
-				bwPerDay="$(bc <<< "(${totalBW} * 1024) / (${onHours} / 24)")GB"
 				totalBW="${totalBW}TB"
 			fi
+			local bwPerDay="$(bc <<< "scale=1; (((${totalLBA} * ${sectorSize}) / (1024^4)) * 1024) / (${onHours} / 24)" | sed -e 's:^\.:0.:')"
+			if [ "${bwPerDay}" = "0.0" ]; then
+				bwPerDay="N/A"
+			else
+				bwPerDay="${bwPerDay}GB"
+			fi
 
 			# Colorize test age
 			if [ "${testAge}" -gt "${testAgeWarn}" ]; then

From e0fa362cca6c7463f620fbaca360ac7983ad4dcd Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 18 Apr 2021 19:37:09 +0000
Subject: [PATCH 029/160] Refactor to get rid of awk part 2.

Address the SSD table.
---
 report.sh | 306 ++++++++++++++++++++++++++++++++++++++----------------
 1 file changed, 219 insertions(+), 87 deletions(-)

diff --git a/report.sh b/report.sh
index fb20e8e..814b545 100755
--- a/report.sh
+++ b/report.sh
@@ -218,7 +218,7 @@ done | awk '{for (i=NF; i!=0 ; i--) print $i }')
 # Toggles the 'ssdExist' flag to true if SSDs are detected in order to add the summary table
 if [ "${includeSSD}" = "true" ]; then
     for drive in ${drives}; do
-        if smartctl -i "/dev/${drive}" | grep -q "Solid State Device"; then
+        if [ "$(smartctl -ij "/dev/${drive}" | jq -Mre '.rotation_rate | values')" = "0" ]; then
             ssdExist="true"
             break
         else
@@ -750,8 +750,9 @@ if [ "${NVMeExist}" = "true" ]; then
 fi
 
 
-###### SSD SMART status summary table
-if [ "${ssdExist}" = "true" ]; then
+# shellcheck disable=SC2155
+function SSDSummary () {
+	###### SSD SMART status summary table
     (
         # Write HTML table headers to log file
         echo '<br><br>'
@@ -779,99 +780,230 @@ if [ "${ssdExist}" = "true" ]; then
         echo '</tr>'
     ) >> "${logfile}"
 
+	local drive
+	local altRow="false"
     for drive in ${drives}; do
-        if smartctl -i "/dev/${drive}" | grep -q "Solid State Device"; then
+        if [ "$(smartctl -ij "/dev/${drive}" | jq -Mre '.rotation_rate | values')" = "0" ]; then
+			# For each drive detected, run "smartctl -Aijl selftest" and parse its output.
+			# Start by parsing out the variables used in other parts of the script.
+			# After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).
+			# After these computations, determine the row's background color (alternating as above, subbing in other colors from the palate as needed).
+			# Finally, print the HTML code for the current row of the table with all the gathered data.
+			local ssdInfoSmrt="$(smartctl -Aijl selftest "/dev/${drive}")"
+
+			local device="${drive}"
+
+			# Available if any tests have completed
+			local lastTestHours="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].lifetime_hours | values')"
+			local lastTestType="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].type.string | values')"
+
+			# Available for any drive smartd knows about
+			local smartStatus="$(smartctl -H "/dev/${drive}" | grep 'SMART overall-health' | cut -d ' ' -sf 6)"
+			local model="$(echo "${ssdInfoSmrt}" | jq -Mre '.model_name | values')"
+			local serial="$(echo "${ssdInfoSmrt}" | jq -Mre '.serial_number | values')"
+			local capacity="$(smartctl -i "/dev/${drive}" | grep '^User Capacity:' | tr -s ' ' | cut -d ' ' -sf '5,6')"
+			local temp="$(echo "${ssdInfoSmrt}"| jq -Mre '.temperature.current | values')"
+			local onHours="$(echo "${ssdInfoSmrt}" | jq -Mre '.power_on_time.hours | values')"
+			local startStop="$(echo "${ssdInfoSmrt}" | jq -Mre '.power_cycle_count | values')"
+			local sectorSize="$(echo "${ssdInfoSmrt}" | jq -Mre '.logical_block_size | values')"
+
+			# Available for most common drives
+			local reAlloc="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 5) | .raw.value | values')"
+			local progFail="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 171) | .raw.value | values')"
+			local eraseFail="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 172) | .raw.value | values')"
+			local offlineUnc="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 187) | .raw.value | values')"
+			local crcErrors="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 199) | .raw.value | values')"
+
+			# No standard attribute for % ssd life remanining
+			local wearLeveling="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 173) | .value | values')"
+			if [ -z "${wearLeveling}" ]; then
+				wearLeveling="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 231) | .value | values')"
+				if [ -z "${wearLeveling}" ]; then
+					wearLeveling="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 233) | .value | values')"
+				fi
+			fi
+
+			# No standard attribute or recording method for data writen
+			local totalLBA="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 246) | .raw.value | values')"
+			if [ -z "${totalLBA}" ]; then
+				totalLBA="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 241) | .raw.value | values')"
+				local Host_Writes="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 241) | .name | values')"
+				if echo "${Host_Writes}" | grep -q 'GiB'; then
+					totalLBA="$(bc <<< "( ${totalLBA} * (1024^3) ) / ${sectorSize}")"
+				elif echo "${Host_Writes}" | grep -q '32MiB'; then
+					totalLBA="$(bc <<< "( (${totalLBA} * 32) * (1024^2) ) / ${sectorSize}")"
+				else
+					totalLBA="0"
+				fi
+			fi
+
+
+			# Get more useful times from hours
+			local testAge="$(bc <<< "(${onHours} - ${lastTestHours}) / 24")"
+			local yrs="$(bc <<< "${onHours} / 8760")"
+			local mos="$(bc <<< "(${onHours} % 8760) / 730")"
+			local dys="$(bc <<< "((${onHours} % 8760) % 730) / 24")"
+			local hrs="$(bc <<< "((${onHours} % 8760) % 730) % 24")"
+
+			# Set Power-On Time format
+			if [ "${powerTimeFormat}" = "ymdh" ]; then
+				local onTime="${yrs}y ${mos}m ${dys}d ${hrs}h"
+			elif [ "${powerTimeFormat}" = "ymd" ]; then
+				local onTime="${yrs}y ${mos}m ${dys}d"
+			elif [ "${powerTimeFormat}" = "ym" ]; then
+				local onTime="${yrs}y ${mos}m"
+			elif [ "${powerTimeFormat}" = "y" ]; then
+				local onTime="${yrs}y"
+			else
+				local onTime="${yrs}y ${mos}m ${dys}d ${hrs}h"
+			fi
+
+			# Set the row background color
+			if [ "${altRow}" = "false" ]; then
+				local bgColor="#ffffff"
+				altRow="true"
+			else
+				local bgColor="${altColor}"
+				altRow="false"
+			fi
+
+			# Colorize Smart Status
+			if [ ! "${smartStatus}" = "PASSED" ]; then
+				local smartStatusColor="${critColor}"
+			else
+				local smartStatusColor="${okColor}"
+			fi
+
+			# Colorize Temp
+			if [ "${temp}" -ge "${tempCrit}" ]; then
+				local tempColor="${critColor}"
+			elif [ "${temp}" -ge "${tempWarn}" ]; then
+				tempColor="${warnColor}"
+			else
+				local tempColor="${bgColor}"
+			fi
+			if [ "${temp}" = "0" ]; then
+				local temp="N/A"
+			else
+				local temp="${temp}&deg;C"
+			fi
+
+			# Colorize Sector Errors
+			if [ "${reAlloc:=0}" -gt "${sectorsCrit}" ]; then
+				local reAllocColor="${critColor}"
+			elif [ ! "${reAlloc}" = "0" ]; then
+				local reAllocColor="${warnColor}"
+			else
+				local reAllocColor="${bgColor}"
+			fi
+
+			# Colorize Program Fail
+			if [ "${progFail:=0}" -gt "${sectorsCrit}" ]; then
+				local progFailColor="${critColor}"
+			elif [ ! "${progFail}" = "0" ]; then
+				local progFailColor="${warnColor}"
+			else
+				local progFailColor="${bgColor}"
+			fi
+
+			# Colorize Erase Fail
+			if [ "${eraseFail:=0}" -gt "${sectorsCrit}" ]; then
+				local eraseFailColor="${critColor}"
+			elif [ ! "${eraseFail}" = "0" ]; then
+				local eraseFailColor="${warnColor}"
+			else
+				local eraseFailColor="${bgColor}"
+			fi
+
+			# Colorize Offline Uncorrectable
+			if [ "${offlineUnc:=0}" -gt "${sectorsCrit}" ]; then
+				local offlineUncColor="${critColor}"
+			elif [ ! "${offlineUnc}" = "0" ]; then
+				local offlineUncColor="${warnColor}"
+			else
+				local offlineUncColor="${bgColor}"
+			fi
+
+			# Colorize CRC Errors
+			if [ ! "${crcErrors:=0}" = "0" ]; then
+				local crcErrorsColor="${warnColor}"
+			else
+				local crcErrorsColor="${bgColor}"
+			fi
+
+			# Colorize Wear Leveling
+			if [ "${wearLeveling}" -le "${lifeRemainCrit}" ]; then
+				local wearLevelingColor="${critColor}"
+			elif [ "${wearLeveling}" -le "${lifeRemainWarn}" ]; then
+				local wearLevelingColor="${warnColor}"
+			else
+				local wearLevelingColor="${bgColor}"
+			fi
+
+			# Colorize & derive write stats
+			local totalBW="$(bc <<< "scale=1; (${totalLBA} * ${sectorSize}) / (1024^4)" | sed -e 's:^\.:0.:')"
+			if (( $(bc -l <<< "${totalBW}" > "${totalBWCrit}") )); then
+				local totalBWColor="${critColor}"
+			elif (( $(bc -l <<< "${totalBW}" > "${totalBWWarn}") )); then
+				local totalBWColor="${warnColor}"
+			else
+				local totalBWColor="${bgColor}"
+			fi
+			if [ "${totalBW}" = "0.0" ]; then
+				totalBW="N/A"
+			else
+				totalBW="${totalBW}TB"
+			fi
+			local bwPerDay="$(bc <<< "scale=1; (((${totalLBA} * ${sectorSize}) / (1024^4)) * 1024) / (${onHours} / 24)" | sed -e 's:^\.:0.:')"
+			if [ "${bwPerDay}" = "0.0" ]; then
+				bwPerDay="N/A"
+			else
+				bwPerDay="${bwPerDay}GB"
+			fi
+
+			# Colorize test age
+			if [ "${testAge}" -gt "${testAgeWarn}" ]; then
+				testAgeColor="${critColor}"
+			else
+				testAgeColor="${bgColor}"
+			fi
+
+
             (
-                # For each drive detected, run "smartctl -A -i" and parse its output. This whole section is a single, long statement, so I'll make all comments here.
-                # Start by passing awk variables (all the -v's) used in other parts of the script. Other variables are calculated in-line with other smartctl calls.
-                # Next, pull values out of the original "smartctl -A -i" statement by searching for the text between the //'s.
-                # After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).
-                # After these computations, determine the row's background color (alternating as above, subbing in other colors from the palate as needed).
-                # Finally, print the HTML code for the current row of the table with all the gathered data.
-                ssdInfoSmrt="$(smartctl -A -i "/dev/${drive}")"
-                if echo "${ssdInfoSmrt}" | grep -q "^231"; then
-            		ssdInfoSmrt="$(echo "${ssdInfoSmrt}" | grep -v '^233')"
-            	fi
-                echo "${ssdInfoSmrt}" | \
-                awk -v device="${drive}" -v tempWarn="${tempWarn}" -v tempCrit="${tempCrit}" -v sectorsCrit="${sectorsCrit}" -v testAgeWarn="${testAgeWarn}" \
-                -v okColor="${okColor}" -v warnColor="${warnColor}" -v critColor="${critColor}" -v altColor="${altColor}" -v powerTimeFormat="${powerTimeFormat}" \
-                -v totalBWWarn="${totalBWWarn}" -v totalBWCrit="${totalBWCrit}" -v lifeRemainWarn="${lifeRemainWarn}" -v lifeRemainCrit="${lifeRemainCrit}" \
-                -v lastTestHours="$(smartctl -jl selftest "/dev/${drive}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].lifetime_hours | values')" \
-                -v lastTestType="$(smartctl -jl selftest "/dev/${drive}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].type.string | values')" \
-                -v smartStatus="$(smartctl -H "/dev/${drive}" | grep "SMART overall-health" | awk '{print $6}')" ' \
-                /Device Model:/{$1="";$2=""; model=$0} \
-                /Serial Number:/{serial=$3} \
-                /User Capacity:/{capacity=$5 $6} \
-                $1 ~ /^194$/{temp=($10 + 0)} \
-                $1 ~ /^9$/{onHours=$10} \
-                $1 ~ /^12$/{startStop=$10} \
-                $1 ~ /^5$/{reAlloc=$10} \
-                $1 ~ /^171$/{progFail=$10} \
-                $1 ~ /^172$/{eraseFail=$10} \
-                $1 ~ /^187$/{offlineUnc=$10} \
-                $1 ~ /^199$/{crcErrors=$10} \
-                {if ($1 ~ /^173$/) {wearLeveling=$4}} \
-                {if ($1 ~ /^(231)|(233)$/) {wearLeveling=$4}} \
-                /Sector Size/{sectorSize=$3} \
-                $1 ~ /^241$/ || $1 ~ /^246$/{totalLBA=$10} \
-                END {
-                    testAge=int((onHours - lastTestHours) / 24);
-                    yrs=int(onHours / 8760);
-                    mos=int((onHours % 8760) / 730);
-                    dys=int(((onHours % 8760) % 730) / 24);
-                    hrs=((onHours % 8760) % 730) % 24;
-                    if (powerTimeFormat == "ymdh") onTime=yrs "y " mos "m " dys "d " hrs "h ";
-                    else if (powerTimeFormat == "ymd") onTime=yrs "y " mos "m " dys "d ";
-                    else if (powerTimeFormat == "ym") onTime=yrs "y " mos "m ";
-                    else if (powerTimeFormat == "y") onTime=yrs "y ";
-                    else onTime=yrs "y " mos "m " dys "d " hrs "h ";
-                    if ((substr(device, length(device), 1) + 0) % 2 == 1) bgColor = "#ffffff"; else bgColor = altColor;
-                    if (smartStatus != "PASSED") smartStatusColor = critColor; else smartStatusColor = okColor;
-                    if (temp >= tempCrit) tempColor = critColor; else if (temp >= tempWarn) tempColor = warnColor; else tempColor = bgColor;
-                    if (temp == 0) temp = "N/A"; else temp = temp "*C";
-                    if ((reAlloc + 0) > sectorsCrit) reAllocColor = critColor; else if (reAlloc != 0) reAllocColor = warnColor; else reAllocColor = bgColor;
-                    if ((progFail + 0) > sectorsCrit) progFailColor = critColor; else if (progFail != 0) progFailColor = warnColor; else progFailColor = bgColor;
-                    if ((eraseFail + 0) > sectorsCrit) eraseFailColor = critColor; else if (eraseFail != 0) eraseFailColor = warnColor; else eraseFailColor = bgColor;
-                    if ((offlineUnc + 0) > sectorsCrit) offlineUncColor = critColor; else if (offlineUnc != 0) offlineUncColor = warnColor; else offlineUncColor = bgColor;
-                    if (crcErrors != "0") crcErrorsColor = warnColor; else crcErrorsColor = bgColor;
-                    if (wearLeveling <= lifeRemainCrit) wearLevelingColor = critColor; else if (wearLeveling <= lifeRemainWarn) wearLevelingColor = warnColor; else wearLevelingColor = bgColor;
-                    totalBW=(((totalLBA * sectorSize) / 1048576) / 1048576);
-                    if (totalBW >= totalBWCrit) totalBWColor = critColor; else if (totalBW >= totalBWWarn) totalBWColor = warnColor; else totalBWColor = bgColor;
-                    if (totalBW == 0) totalBW = "N/A"; else totalBW = (int(totalBW) + int(((totalBW - int(totalBW)) * 10) + 0.501) / 10) "TB";
-                    bwPerDay=((totalBW * 1024)/ (onHours / 24));
-                    if (totalBW == "N/A") bwPerDay = "N/A"; else bwPerDay = (int(bwPerDay) + int(((bwPerDay - int(bwPerDay)) * 10) + 0.501) / 10) "GB";
-                    if (testAge > testAgeWarn) testAgeColor = critColor; else testAgeColor = bgColor;
-                    printf "<tr style=\"background-color:%s;\">" \
-                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">/dev/%s</td>" \
-                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%d%%</td>" \
-                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                        "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%d</td>" \
-                        "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                    "</tr>\n", bgColor, device, model, serial, capacity, smartStatusColor, smartStatus, tempColor, temp, onTime, startStop, reAllocColor, reAlloc, \
-                    progFailColor, progFail, eraseFailColor, eraseFail, offlineUncColor, offlineUnc, crcErrorsColor, crcErrors, wearLevelingColor, wearLeveling, totalBWColor, totalBW, \
-                    bwPerDay, testAgeColor, testAge, lastTestType;
-                }'
+				# Row Output
+				echo '<tr style="background-color:'"${bgColor}"';">'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"/dev/${device}"'</td>'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${model}"'</td>'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${serial}"'</td>'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${capacity}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${smartStatusColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${smartStatus}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${tempColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${temp}"'</td>'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${onTime}"'</td>'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${startStop}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${reAllocColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${reAlloc}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${progFailColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${progFail}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${eraseFailColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${eraseFail}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${offlineUncColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${offlineUnc}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${crcErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${crcErrors}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${wearLevelingColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${wearLeveling}"'%</td>'
+				echo '<td style="text-align:center; background-color:'"${totalBWColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${totalBW}"'</td>'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${bwPerDay}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${testAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${testAge}"'</td>'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${lastTestType}"'</td>'
+				echo '</tr>'
             ) >> "${logfile}"
         fi
     done
 
-    # End SMART summary table and summary section
+    # End SSD SMART summary table
     (
         echo '</table>'
     ) >> "${logfile}"
+}
+
+
+if [ "${ssdExist}" = "true" ]; then
+	SSDSummary
 fi
 
 

From c3b619380596959380f42e22480f8992246216a8 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 18 Apr 2021 17:17:45 -0400
Subject: [PATCH 030/160] Refactor to get rid of awk part 3.

Address the HDD table.
---
 report.sh | 335 ++++++++++++++++++++++++++++++++++++------------------
 1 file changed, 224 insertions(+), 111 deletions(-)

diff --git a/report.sh b/report.sh
index 814b545..924d9a6 100755
--- a/report.sh
+++ b/report.sh
@@ -229,6 +229,15 @@ if [ "${includeSSD}" = "true" ]; then
     	NVMeExist="true"
     fi
 fi
+# Test to see if there are any HDDs
+for drive in ${drives}; do
+	if [ ! "$(smartctl -ij "/dev/${drive}" | jq -Mre '.rotation_rate | values')" = "0" ]; then
+		hddExist="true"
+		break
+	else
+		hddExist="false"
+	fi
+done
 
 
 
@@ -1008,119 +1017,223 @@ fi
 
 
 
-###### HDD SMART status summary table
-(
-    # Write HTML table headers to log file
-    echo '<br><br>'
-    echo '<table style="border: 1px solid black; border-collapse: collapse;">'
-    echo '<tr><th colspan="18" style="text-align:center; font-size:20px; height:40px; font-family:courier;">HDD SMART Status Report Summary</th></tr>'
-    echo '<tr>'
-    echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Device</th>'
-    echo '<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Model</th>'
-    echo '<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Serial<br>Number</th>'
-    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">RPM</th>'
-    echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Capacity</th>'
-    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">SMART<br>Status</th>'
-    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Temp</th>'
-    echo '<th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Power-On<br>Time<br>('"${powerTimeFormat}"')</th>'
-    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Start<br>Stop<br>Count</th>'
-    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Spin<br>Retry<br>Count</th>'
-    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Realloc<br>Sectors</th>'
-    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Realloc<br>Events</th>'
-    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Current<br>Pending<br>Sectors</th>'
-    echo '<th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Offline<br>Uncorrectable<br>Sectors</th>'
-    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">CRC<br>Errors</th>'
-    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Seek<br>Error<br>Health</th>'
-    echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Age (days)</th>'
-    echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Type</th></tr>'
-    echo '</tr>'
-) >> "${logfile}"
+# shellcheck disable=SC2155
+function HDDSummary () {
+	###### HDD SMART status summary table
+	(
+		# Write HTML table headers to log file
+		echo '<br><br>'
+		echo '<table style="border: 1px solid black; border-collapse: collapse;">'
+		echo '<tr><th colspan="18" style="text-align:center; font-size:20px; height:40px; font-family:courier;">HDD SMART Status Report Summary</th></tr>'
+		echo '<tr>'
+		echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Device</th>'
+		echo '<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Model</th>'
+		echo '<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Serial<br>Number</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">RPM</th>'
+		echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Capacity</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">SMART<br>Status</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Temp</th>'
+		echo '<th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Power-On<br>Time<br>('"${powerTimeFormat}"')</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Start<br>Stop<br>Count</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Spin<br>Retry<br>Count</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Realloc<br>Sectors</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Realloc<br>Events</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Current<br>Pending<br>Sectors</th>'
+		echo '<th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Offline<br>Uncorrectable<br>Sectors</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">CRC<br>Errors</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Seek<br>Error<br>Health</th>'
+		echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Age (days)</th>'
+		echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Type</th></tr>'
+		echo '</tr>'
+	) >> "${logfile}"
 
-for drive in ${drives}; do
-    if smartctl -i "/dev/${drive}" | grep -q "SMART support is: Enabled"; then
-        if ! smartctl -i "/dev/${drive}" | grep -q "Solid State Device"; then
-        (
-            # For each drive detected, run "smartctl -A -i" and parse its output. This whole section is a single, long statement, so I'll make all comments here.
-            # Start by passing awk variables (all the -v's) used in other parts of the script. Other variables are calculated in-line with other smartctl calls.
-            # Next, pull values out of the original "smartctl -A -i" statement by searching for the text between the //'s.
-            # After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).
-            # After these computations, determine the row's background color (alternating as above, subbing in other colors from the palate as needed).
-            # Finally, print the HTML code for the current row of the table with all the gathered data.
-            smartctl -A -i /dev/"$drive" | \
-            awk -v device="${drive}" -v tempWarn="${tempWarn}" -v tempCrit="${tempCrit}" -v sectorsCrit="${sectorsCrit}" -v testAgeWarn="${testAgeWarn}" \
-            -v okColor="${okColor}" -v warnColor="${warnColor}" -v critColor="${critColor}" -v altColor="${altColor}" -v powerTimeFormat="${powerTimeFormat}" \
-            -v lastTestHours="$(smartctl -jl selftest "/dev/${drive}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].lifetime_hours | values')" \
-            -v lastTestType="$(smartctl -jl selftest "/dev/${drive}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].type.string | values')" \
-            -v smartStatus="$(smartctl -H "/dev/${drive}" | grep "SMART overall-health" | awk '{print $6}')" ' \
-            /Device Model:/{$1="";$2=""; model=$0} \
-            /Serial Number:/{serial=$3} \
-            /User Capacity:/{capacity=$5 $6} \
-            /Rotation Rate:/{rpm=$3} \
-            $1 ~ /^194$/{temp=($10 + 0)} \
-            $1 ~ /^9$/{onHours=$10} \
-            $1 ~ /^4$/{startStop=$10} \
-            $1 ~ /^10$/{spinRetry=$10} \
-            $1 ~ /^5$/{reAlloc=$10} \
-            $1 ~ /^196$/{reAllocEvent=$10} \
-            $1 ~ /^197$/{pending=$10} \
-            $1 ~ /^198$/{offlineUnc=$10} \
-            $1 ~ /^199$/{crcErrors=$10} \
-            $1 ~ /^7$/ {seekErrorHealth=$4} \
-            END {
-                testAge=int((onHours - lastTestHours) / 24);
-                yrs=int(onHours / 8760);
-                mos=int((onHours % 8760) / 730);
-                dys=int(((onHours % 8760) % 730) / 24);
-                hrs=((onHours % 8760) % 730) % 24;
-                if (powerTimeFormat == "ymdh") onTime=yrs "y " mos "m " dys "d " hrs "h ";
-                else if (powerTimeFormat == "ymd") onTime=yrs "y " mos "m " dys "d ";
-                else if (powerTimeFormat == "ym") onTime=yrs "y " mos "m ";
-                else if (powerTimeFormat == "y") onTime=yrs "y ";
-                else onTime=yrs "y " mos "m " dys "d " hrs "h ";
-                if ((substr(device, length(device), 1) + 0) % 2 == 1) bgColor = "#ffffff"; else bgColor = altColor;
-                if (smartStatus != "PASSED") smartStatusColor = critColor; else smartStatusColor = okColor;
-                if (temp >= tempCrit) tempColor = critColor; else if (temp >= tempWarn) tempColor = warnColor; else tempColor = bgColor;
-                if (spinRetry != "0") spinRetryColor = warnColor; else spinRetryColor = bgColor;
-                if ((reAlloc + 0) > sectorsCrit) reAllocColor = critColor; else if (reAlloc != 0) reAllocColor = warnColor; else reAllocColor = bgColor;
-                if (reAllocEvent != "0") reAllocEventColor = warnColor; else reAllocEventColor = bgColor;
-                if ((pending + 0) > sectorsCrit) pendingColor = critColor; else if (pending != 0) pendingColor = warnColor; else pendingColor = bgColor;
-                if ((offlineUnc + 0) > sectorsCrit) offlineUncColor = critColor; else if (offlineUnc != 0) offlineUncColor = warnColor; else offlineUncColor = bgColor;
-                if (crcErrors != "0") crcErrorsColor = warnColor; else crcErrorsColor = bgColor;
-                if ((seekErrorHealth + 0) < 100) seekErrorHealthColor = warnColor; else seekErrorHealthColor = bgColor;
-                if (testAge > testAgeWarn) testAgeColor = critColor; else testAgeColor = bgColor;
-                printf "<tr style=\"background-color:%s;\">" \
-                    "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">/dev/%s</td>" \
-                    "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                    "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                    "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                    "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                    "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                    "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%d*C</td>" \
-                    "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                    "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                    "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                    "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                    "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                    "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                    "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                    "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                    "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%d%%</td>" \
-                    "<td style=\"text-align:center; background-color:%s; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%d</td>" \
-                    "<td style=\"text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">%s</td>" \
-                "</tr>\n", bgColor, device, model, serial, rpm, capacity, smartStatusColor, smartStatus, tempColor, temp, onTime, startStop, spinRetryColor, spinRetry, reAllocColor, reAlloc, \
-                reAllocEventColor, reAllocEvent, pendingColor, pending, offlineUncColor, offlineUnc, crcErrorsColor, crcErrors, seekErrorHealthColor, seekErrorHealth, \
-                testAgeColor, testAge, lastTestType;
-            }'
-        ) >> "${logfile}"
-        fi
-    fi
-done
+	local drive
+	local altRow="false"
+	for drive in ${drives}; do
+		if smartctl -i "/dev/${drive}" | grep -q "SMART support is: Enabled" && [ ! "$(smartctl -ij "/dev/${drive}" | jq -Mre '.rotation_rate | values')" = "0" ]; then
+			# For each drive detected, run "smartctl -Aijl selftest" and parse its output.
+			# After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).
+			# After these computations, determine the row's background color (alternating as above, subbing in other colors from the palate as needed).
+			# Finally, print the HTML code for the current row of the table with all the gathered data.
 
-# End SMART summary table and summary section
-(
-    echo '</table>'
-    echo '<br><br>'
-) >> "${logfile}"
+			local hddInfoSmrt="$(smartctl -Aijl selftest "/dev/${drive}")"
+
+			local device="${drive}"
+
+			# Available if any tests have completed
+			local lastTestHours="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].lifetime_hours | values')"
+			local lastTestType="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].type.string | values')"
+
+			# Available for any drive smartd knows about
+			local smartStatus="$(smartctl -H "/dev/${drive}" | grep 'SMART overall-health' | cut -d ' ' -sf 6)"
+			local model="$(echo "${hddInfoSmrt}" | jq -Mre '.model_name | values')"
+			local serial="$(echo "${hddInfoSmrt}" | jq -Mre '.serial_number | values')"
+			local rpm="$(echo "${hddInfoSmrt}" | jq -Mre '.rotation_rate | values')"
+			local capacity="$(smartctl -i "/dev/${drive}" | grep '^User Capacity:' | tr -s ' ' | cut -d ' ' -sf '5,6')"
+			local temp="$(echo "${hddInfoSmrt}"| jq -Mre '.temperature.current | values')"
+			local onHours="$(echo "${hddInfoSmrt}" | jq -Mre '.power_on_time.hours | values')"
+			local startStop="$(echo "${hddInfoSmrt}" | jq -Mre '.power_cycle_count | values')"
+
+			# Available for most common drives
+			local reAlloc="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 5) | .raw.value | values')"
+			local spinRetry="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 10) | .raw.value | values')"
+			local reAllocEvent="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 196) | .raw.value | values')"
+			local pending="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 197) | .raw.value | values')"
+			local offlineUnc="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 198) | .raw.value | values')"
+			local crcErrors="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 199) | .raw.value | values')"
+			local seekErrorHealth="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 7) | .value | values')"
+
+
+			# Get more useful times from hours
+			local testAge="$(bc <<< "(${onHours} - ${lastTestHours}) / 24")"
+			local yrs="$(bc <<< "${onHours} / 8760")"
+			local mos="$(bc <<< "(${onHours} % 8760) / 730")"
+			local dys="$(bc <<< "((${onHours} % 8760) % 730) / 24")"
+			local hrs="$(bc <<< "((${onHours} % 8760) % 730) % 24")"
+
+			# Set Power-On Time format
+			if [ "${powerTimeFormat}" = "ymdh" ]; then
+				local onTime="${yrs}y ${mos}m ${dys}d ${hrs}h"
+			elif [ "${powerTimeFormat}" = "ymd" ]; then
+				local onTime="${yrs}y ${mos}m ${dys}d"
+			elif [ "${powerTimeFormat}" = "ym" ]; then
+				local onTime="${yrs}y ${mos}m"
+			elif [ "${powerTimeFormat}" = "y" ]; then
+				local onTime="${yrs}y"
+			else
+				local onTime="${yrs}y ${mos}m ${dys}d ${hrs}h"
+			fi
+
+			# Set the row background color
+			if [ "${altRow}" = "false" ]; then
+				local bgColor="#ffffff"
+				altRow="true"
+			else
+				local bgColor="${altColor}"
+				altRow="false"
+			fi
+
+			# Colorize Smart Status
+			if [ ! "${smartStatus}" = "PASSED" ]; then
+				local smartStatusColor="${critColor}"
+			else
+				local smartStatusColor="${okColor}"
+			fi
+
+			# Colorize Temp
+			if [ "${temp}" -ge "${tempCrit}" ]; then
+				local tempColor="${critColor}"
+			elif [ "${temp}" -ge "${tempWarn}" ]; then
+				tempColor="${warnColor}"
+			else
+				local tempColor="${bgColor}"
+			fi
+			if [ "${temp}" = "0" ]; then
+				local temp="N/A"
+			else
+				local temp="${temp}&deg;C"
+			fi
+
+			# Colorize Spin Retry Errors
+			if [ ! "${spinRetry:=0}" = "0" ]; then
+				local spinRetryColor="${warnColor}"
+			else
+				local spinRetryColor="${bgColor}"
+			fi
+
+			# Colorize Sector Errors
+			if [ "${reAlloc:=0}" -gt "${sectorsCrit}" ]; then
+				local reAllocColor="${critColor}"
+			elif [ ! "${reAlloc}" = "0" ]; then
+				local reAllocColor="${warnColor}"
+			else
+				local reAllocColor="${bgColor}"
+			fi
+
+			# Colorize Sector Event Errors
+			if [ ! "${reAllocEvent:=0}" = "0" ]; then
+				local reAllocEventColor="${warnColor}"
+			else
+				local reAllocEventColor="${bgColor}"
+			fi
+
+			# Colorize Pending Sector
+			if [ "${pending:=0}" -gt "${sectorsCrit}" ]; then
+				local pendingColor="${critColor}"
+			elif [ ! "${offlineUnc}" = "0" ]; then
+				local pendingColor="${warnColor}"
+			else
+				local pendingColor="${bgColor}"
+			fi
+
+			# Colorize Offline Uncorrectable
+			if [ "${offlineUnc:=0}" -gt "${sectorsCrit}" ]; then
+				local offlineUncColor="${critColor}"
+			elif [ ! "${offlineUnc}" = "0" ]; then
+				local offlineUncColor="${warnColor}"
+			else
+				local offlineUncColor="${bgColor}"
+			fi
+
+			# Colorize CRC Errors
+			if [ ! "${crcErrors:=0}" = "0" ]; then
+				local crcErrorsColor="${warnColor}"
+			else
+				local crcErrorsColor="${bgColor}"
+			fi
+
+			# Colorize Seek Error
+			if [ "${seekErrorHealth:=0}" -lt "100" ]; then
+				local seekErrorHealthColor="${warnColor}"
+			else
+				local seekErrorHealthColor="${bgColor}"
+			fi
+
+			# Colorize test age
+			if [ "${testAge}" -gt "${testAgeWarn}" ]; then
+				testAgeColor="${critColor}"
+			else
+				testAgeColor="${bgColor}"
+			fi
+
+
+			(
+				# Row Output
+				echo '<tr style="background-color:'"${bgColor}"';">'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"/dev/${device}"'</td>'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${model}"'</td>'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${serial}"'</td>'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${rpm}"'</td>'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${capacity}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${smartStatusColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${smartStatus}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${tempColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${temp}"'</td>'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${onTime}"'</td>'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${startStop}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${spinRetryColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${spinRetry}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${reAllocColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${reAlloc}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${reAllocEventColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${reAllocEvent}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${pendingColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${pending}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${offlineUncColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${offlineUnc}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${crcErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${crcErrors}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${seekErrorHealthColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${seekErrorHealth}"'%</td>'
+				echo '<td style="text-align:center; background-color:'"${testAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${testAge}"'</td>'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${lastTestType}"'</td>'
+				echo '</tr>'
+			) >> "${logfile}"
+		fi
+	done
+
+	# End SMART summary table and summary section
+	(
+		echo '</table>'
+		echo '<br><br>'
+	) >> "${logfile}"
+}
+
+
+if [ "${hddExist}" = "true" ]; then
+	HDDSummary
+fi
 
 
 

From 28c95d44a2d534b562ec04d025fc7744c50363bd Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 18 Apr 2021 21:33:53 +0000
Subject: [PATCH 031/160] More quotes.

---
 report.sh | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/report.sh b/report.sh
index 924d9a6..9f89e91 100755
--- a/report.sh
+++ b/report.sh
@@ -86,19 +86,19 @@ critColor="#ff0000"     # Hex code for CRITICAL color (default is bright red, #f
 altColor="#f4f4f4"      # Table background alternates row colors between white and this color (default is light gray, #f4f4f4)
 
 ### zpool status summary table settings
-usedWarn=90             # Pool used percentage for CRITICAL color to be used
-scrubAgeWarn=30         # Maximum age (in days) of last pool scrub before CRITICAL color will be used
+usedWarn="90"             # Pool used percentage for CRITICAL color to be used
+scrubAgeWarn="30"         # Maximum age (in days) of last pool scrub before CRITICAL color will be used
 
 ### SMART status summary table settings
 includeSSD="true"       # Change to "true" to include SSDs in SMART status summary table; "false" to disable
-lifeRemainWarn=75       # Life remaining in the SSD at which WARNING color will be used
-lifeRemainCrit=50       # Life remaining in the SSD at which CRITICAL color will be used
-totalBWWarn=100         # Total bytes written (in TB) to the SSD at which WARNING color will be used
-totalBWCrit=200         # Total bytes written (in TB) to the SSD at which CRITICAL color will be used
-tempWarn=40             # Drive temp (in C) at which WARNING color will be used
-tempCrit=45             # Drive temp (in C) at which CRITICAL color will be used
-sectorsCrit=10          # Number of sectors per drive with errors before CRITICAL color will be used
-testAgeWarn=5           # Maximum age (in days) of last SMART test before CRITICAL color will be used
+lifeRemainWarn="75"       # Life remaining in the SSD at which WARNING color will be used
+lifeRemainCrit="50"       # Life remaining in the SSD at which CRITICAL color will be used
+totalBWWarn="100"         # Total bytes written (in TB) to the SSD at which WARNING color will be used
+totalBWCrit="200"         # Total bytes written (in TB) to the SSD at which CRITICAL color will be used
+tempWarn="40"             # Drive temp (in C) at which WARNING color will be used
+tempCrit="45"             # Drive temp (in C) at which CRITICAL color will be used
+sectorsCrit="10"          # Number of sectors per drive with errors before CRITICAL color will be used
+testAgeWarn="5"           # Maximum age (in days) of last SMART test before CRITICAL color will be used
 powerTimeFormat="ymdh"  # Format for power-on hours string, valid options are "ymdh", "ymd", "ym", or "y" (year month day hour)
 
 ### TrueNAS config backup settings
@@ -369,7 +369,7 @@ for pool in ${pools}; do
         fi
         readErrors="$((readErrors + err))"
     done
-    writeErrors=0
+    writeErrors="0"
     for err in $(echo "${err}ors" | awk '{print $4}'); do
         if echo "${err}" | grep -E -q "[^0-9]+"; then
             writeErrors="1000"
@@ -377,7 +377,7 @@ for pool in ${pools}; do
         fi
         writeErrors="$((writeErrors + err))"
     done
-    cksumErrors=0
+    cksumErrors="0"
     for err in $(echo "${err}ors" | awk '{print $5}'); do
         if echo "${err}" | grep -E -q "[^0-9]+"; then
             cksumErrors="1000"

From 50d25d731578e6208f96b3326ab1b8a1c3955e08 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 2 May 2021 10:38:01 -0400
Subject: [PATCH 032/160] Less sub-shells.

---
 report.sh | 82 +++++++++++++++++++++++++++----------------------------
 1 file changed, 41 insertions(+), 41 deletions(-)

diff --git a/report.sh b/report.sh
index 9f89e91..4281bc0 100755
--- a/report.sh
+++ b/report.sh
@@ -199,7 +199,7 @@ fi
 
 
 ###### Auto-generated Parameters
-host=$(hostname -s)
+host="$(hostname -s)"
 runDate="$(date '+%s')"
 logfile="${logfileLocation}/$(date -r "${runDate}" '+%Y%m%d%H%M%S')_${logfileName}.tmp"
 subject="Status Report and Configuration Backup for ${host} - $(date -r "${runDate}" '+%Y-%m-%d %H:%M')"
@@ -243,7 +243,7 @@ done
 
 ###### Email pre-formatting
 ### Set email headers
-(
+{
     echo "From: ${host} <root@$(hostname)>"
     echo "To: ${email}"
     echo "Subject: ${subject}"
@@ -251,7 +251,7 @@ done
     echo 'Content-Type: multipart/mixed; boundary="'"${boundary}"'"'
     echo "Date: $(date -Rr "${runDate}")"
     echo "Message-Id: <${messageid}@${host}>"
-) > "${logfile}"
+} > "${logfile}"
 
 
 
@@ -268,14 +268,14 @@ if [ "$configBackup" = "true" ]; then
     if [ ! "$(sqlite3 "/data/freenas-v1.db" "pragma integrity_check;")" = "ok" ]; then
 
         # Config integrity check failed, set MIME content type to html and print warning
-        (
+        {
             echo "--${boundary}"
             echo "Content-Transfer-Encoding: 8bit"
             echo -e "Content-Type: text/html; charset=utf-8\n"
             echo "<b>Automatic backup of TrueNAS configuration has failed! The configuration file is corrupted!</b>"
             echo "<b>You should correct this problem as soon as possible!</b>"
             echo "<br>"
-        ) >> "${logfile}"
+        } >> "${logfile}"
     else
         # Config integrity check passed; copy config db, generate checksums, make .tar.gz archive
         sqlite3 "/data/freenas-v1.db" ".backup main /tmp/${filename}.db"
@@ -285,7 +285,7 @@ if [ "$configBackup" = "true" ]; then
             cd "/tmp/" || exit;
             tar -czf "${tarfile}" "./${filename}.db" "./config_backup.md5" "./config_backup.sha256"
         )
-        (
+        {
 			if [ "${emailBackup}" = "true" ]; then
 				# Write MIME section header for file attachment (encoded with base64)
 				echo "--${boundary}"
@@ -299,7 +299,7 @@ if [ "$configBackup" = "true" ]; then
             echo "--${boundary}"
             echo "Content-Transfer-Encoding: 8bit"
             echo -e "Content-Type: text/html; charset=utf-8\n"
-        ) >> "${logfile}"
+        } >> "${logfile}"
 
         # If logfile saving is enabled, copy .tar.gz file to specified location before it (and everything else) is removed below
         if [ "${saveBackup}" = "true" ]; then
@@ -312,18 +312,18 @@ if [ "$configBackup" = "true" ]; then
     fi
 else
     # Config backup disabled; set up for html-type content
-    (
+    {
         echo "--${boundary}"
         echo "Content-Transfer-Encoding: 8bit"
         echo -e "Content-Type: text/html; charset=utf-8\n"
-    ) >> "${logfile}"
+    } >> "${logfile}"
 fi
 
 
 ###### Report Summary Section (html tables)
 
 ### zpool status summary table
-(
+{
     # Write HTML table headers to log file; HTML in an email requires 100% in-line styling (no CSS or <style> section), hence the massive tags
     echo '<br><br>'
     echo '<table style="border: 1px solid black; border-collapse: collapse;">'
@@ -344,7 +344,7 @@ fi
     echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last<br>Scrub<br>Age (days)</th>'
     echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last<br>Scrub<br>Duration</th>'
     echo '</tr>'
-) >> "${logfile}"
+} >> "${logfile}"
 
 poolNum="0"
 pools="$(zpool list -H -o name)"
@@ -506,7 +506,7 @@ for pool in ${pools}; do
 		scrubAgeColor="${bgColor}"
     fi
 
-    (
+    {
         # Use the information gathered above to write the date to the current table row
 		echo '<tr style="background-color:'"${bgColor}"'">'
 		echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${pool}"'</td>'
@@ -524,7 +524,7 @@ for pool in ${pools}; do
 		echo '<td style="text-align:center; background-color:'"${scrubAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scrubAge}"'</td>'
 		echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scrubTime}"'</td>'
 		echo '</tr>'
-    ) >> "${logfile}"
+    } >> "${logfile}"
 done
 
 # End of zpool status table
@@ -538,7 +538,7 @@ echo '</table>' >> "${logfile}"
 function NVMeSummary () {
 
 	###### NVMe SMART status summary table
-	(
+	{
 		# Write HTML table headers to log file
 		echo '<br><br>'
 		echo '<table style="border: 1px solid black; border-collapse: collapse;">'
@@ -547,11 +547,11 @@ function NVMeSummary () {
 
 		echo '  <th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Device</th>' # Device
 
-		echo '  <th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Model</th>' # Model
+		echo '  <th style="text-align:center; width:140px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Model</th>' # Model
 
 		echo '  <th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Serial<br>Number</th>' # Serial Number
 
-		echo '  <th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Capacity</th>' # Capacity
+		echo '  <th style="text-align:center; width:90px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Capacity</th>' # Capacity
 
 		echo '  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">SMART<br>Status</th>' # SMART Status
 
@@ -578,7 +578,7 @@ function NVMeSummary () {
 		echo '  <th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Type</th></tr>' # Last Test Type
 
 		echo '</tr>'
-	) >> "${logfile}"
+	} >> "${logfile}"
 
 
 	local drive
@@ -723,7 +723,7 @@ function NVMeSummary () {
 			fi
 
 
-			(
+			{
 				# Output the row
 				echo '<tr style="background-color:'"${bgColor}"';">'
 				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"/dev/${drive}"'</td> <!-- device -->'
@@ -743,14 +743,14 @@ function NVMeSummary () {
 				echo '<td style="text-align:center; background-color:'"${testAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">N/A</td> <!-- testAgeColor, testAge -->'
 				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">N/A</td> <!-- lastTestType -->'
 				echo '</tr>'
-			) >> "${logfile}"
+			} >> "${logfile}"
 		fi
 	done
 
 	# End SMART summary table section
-	(
+	{
 		echo "</table>"
-	) >> "${logfile}"
+	} >> "${logfile}"
 }
 
 
@@ -762,7 +762,7 @@ fi
 # shellcheck disable=SC2155
 function SSDSummary () {
 	###### SSD SMART status summary table
-    (
+    {
         # Write HTML table headers to log file
         echo '<br><br>'
         echo '<table style="border: 1px solid black; border-collapse: collapse;">'
@@ -787,7 +787,7 @@ function SSDSummary () {
         echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Age (days)</th>'
         echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Type</th></tr>'
         echo '</tr>'
-    ) >> "${logfile}"
+    } >> "${logfile}"
 
 	local drive
 	local altRow="false"
@@ -978,7 +978,7 @@ function SSDSummary () {
 			fi
 
 
-            (
+            {
 				# Row Output
 				echo '<tr style="background-color:'"${bgColor}"';">'
 				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"/dev/${device}"'</td>'
@@ -1000,14 +1000,14 @@ function SSDSummary () {
 				echo '<td style="text-align:center; background-color:'"${testAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${testAge}"'</td>'
 				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${lastTestType}"'</td>'
 				echo '</tr>'
-            ) >> "${logfile}"
+            } >> "${logfile}"
         fi
     done
 
     # End SSD SMART summary table
-    (
+    {
         echo '</table>'
-    ) >> "${logfile}"
+    } >> "${logfile}"
 }
 
 
@@ -1020,7 +1020,7 @@ fi
 # shellcheck disable=SC2155
 function HDDSummary () {
 	###### HDD SMART status summary table
-	(
+	{
 		# Write HTML table headers to log file
 		echo '<br><br>'
 		echo '<table style="border: 1px solid black; border-collapse: collapse;">'
@@ -1045,7 +1045,7 @@ function HDDSummary () {
 		echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Age (days)</th>'
 		echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Type</th></tr>'
 		echo '</tr>'
-	) >> "${logfile}"
+	} >> "${logfile}"
 
 	local drive
 	local altRow="false"
@@ -1197,7 +1197,7 @@ function HDDSummary () {
 			fi
 
 
-			(
+			{
 				# Row Output
 				echo '<tr style="background-color:'"${bgColor}"';">'
 				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"/dev/${device}"'</td>'
@@ -1219,15 +1219,15 @@ function HDDSummary () {
 				echo '<td style="text-align:center; background-color:'"${testAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${testAge}"'</td>'
 				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${lastTestType}"'</td>'
 				echo '</tr>'
-			) >> "${logfile}"
+			} >> "${logfile}"
 		fi
 	done
 
 	# End SMART summary table and summary section
-	(
+	{
 		echo '</table>'
 		echo '<br><br>'
-	) >> "${logfile}"
+	} >> "${logfile}"
 }
 
 
@@ -1303,21 +1303,21 @@ fi
 
 
 ### Print Glabel Status
-(
+{
     echo '<b>########## Glabel Status ##########</b>'
     glabel status
     echo '<br><br>'
-) >> "${logfile}"
+} >> "${logfile}"
 
 
 ### Zpool status for each pool
 for pool in ${pools}; do
-    (
+    {
         # Create a simple header and drop the output of zpool status -v
         echo '<b>########## ZPool status report for '"${pool}"' ##########</b>'
         zpool status -v "${pool}"
         echo '<br><br>'
-    ) >> "${logfile}"
+    } >> "${logfile}"
 done
 
 
@@ -1330,14 +1330,14 @@ for drive in ${drives}; do
             brand="$(smartctl -ij "/dev/${drive}" | jq -Mre '.model_name | values')";
         fi
         serial="$(smartctl -ij "/dev/${drive}" | jq -Mre '.serial_number | values')"
-        (
+        {
             # Create a simple header and drop the output of some basic smartctl commands
             echo '<b>########## SMART status report for '"${drive}"' drive ('"${brand}: ${serial}"') ##########</b>'
             smartctl -H -A -l error "/dev/${drive}"
             smartctl -l selftest "/dev/${drive}" | grep 'Extended \\|Num' | cut -c6- | head -2
             smartctl -l selftest "/dev/${drive}" | grep 'Short \\|Num' | cut -c6- | head -2 | tail -n -1
             echo '<br><br>'
-        ) >> "${logfile}"
+        } >> "${logfile}"
 
     elif echo "${drive}" | grep -q "nvme"; then
         # Gather brand and serial number of each drive
@@ -1347,12 +1347,12 @@ for drive in ${drives}; do
             brand="$(echo "${nvmeSmartOut}" | jq -Mre '.model_name | values')";
         fi
 		serial="$(echo "${nvmeSmartOut}" | jq -Mre '.serial_number | values')"
-		(
+		{
 			# Create a simple header and drop the output of some basic smartctl commands
             echo '<b>########## SMART status report for '"${drive}"' drive ('"${brand}: ${serial}"') ##########</b>'
             smartctl -H -A -l error "/dev/${drive}"
             echo '<br><br>'
-		) >> "${logfile}"
+		} >> "${logfile}"
     fi
 done
 

From 2b899d159929a06650deb474584401e6aeaef9cc Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sat, 15 May 2021 12:00:25 -0400
Subject: [PATCH 033/160] Put the config backup in a function

---
 report.sh | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/report.sh b/report.sh
index 4281bc0..963dc87 100755
--- a/report.sh
+++ b/report.sh
@@ -255,8 +255,12 @@ done
 
 
 
-###### Config backup (if enabled)
-if [ "$configBackup" = "true" ]; then
+function ConfigBackup () {
+    local tarfile
+    local fnconfigdest_version
+    local fnconfigdest_date
+    local filename
+
 
     # Set up file names, etc for later
     tarfile="/tmp/config_backup.tar.gz"
@@ -310,6 +314,11 @@ if [ "$configBackup" = "true" ]; then
         rm "/tmp/config_backup.sha256"
         rm "${tarfile}"
     fi
+}
+
+###### Config backup (if enabled)
+if [ "${configBackup}" = "true" ]; then
+	ConfigBackup
 else
     # Config backup disabled; set up for html-type content
     {

From 0c5b3eb683be0c4ccf77a80b37b341b4a6949216 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sat, 15 May 2021 14:16:35 -0400
Subject: [PATCH 034/160] Make the zpool status into a function.

---
 report.sh | 423 +++++++++++++++++++++++++++++-------------------------
 1 file changed, 230 insertions(+), 193 deletions(-)

diff --git a/report.sh b/report.sh
index 963dc87..14bdf95 100755
--- a/report.sh
+++ b/report.sh
@@ -239,6 +239,9 @@ for drive in ${drives}; do
 	fi
 done
 
+# Get a list of pools
+pools="$(zpool list -H -o name)"
+
 
 
 ###### Email pre-formatting
@@ -331,213 +334,247 @@ fi
 
 ###### Report Summary Section (html tables)
 
-### zpool status summary table
-{
-    # Write HTML table headers to log file; HTML in an email requires 100% in-line styling (no CSS or <style> section), hence the massive tags
-    echo '<br><br>'
-    echo '<table style="border: 1px solid black; border-collapse: collapse;">'
-    echo '<tr><th colspan="14" style="text-align:center; font-size:20px; height:40px; font-family:courier;">ZPool Status Report Summary</th></tr>'
-    echo '<tr>'
-    echo '<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Pool<br>Name</th>'
-    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Status</th>'
-    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Size</th>'
-    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Allocated</th>'
-    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Free</th>'
-    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Frag %</th>'
-    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Used %</th>'
-    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Read<br>Errors</th>'
-    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Write<br>Errors</th>'
-    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Cksum<br>Errors</th>'
-    echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Scrub<br>Repaired<br>Bytes</th>'
-    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Scrub<br>Errors</th>'
-    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last<br>Scrub<br>Age (days)</th>'
-    echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last<br>Scrub<br>Duration</th>'
-    echo '</tr>'
-} >> "${logfile}"
+function ZpoolSummary () {
+	local poolNum
+	local pool
+	local status
+	local frag
+	local size
+	local allocated
+	local free
+	local errors
+	local readErrors
+	local err
+	local writeErrors
+	local cksumErrors
+	local used
+	local scrubRepBytes
+	local scrubErrors
+	local scrubAge
+	local scrubTime
+	local resilver
+	local statusOutput
+	local bgColor
+	local statusColor
+	local readErrorsColor
+	local writeErrorsColor
+	local cksumErrorsColor
+	local usedColor
+	local scrubRepBytesColor
+	local scrubErrorsColor
+	local scrubAgeColor
+
+
+	### zpool status summary table
+	{
+		# Write HTML table headers to log file; HTML in an email requires 100% in-line styling (no CSS or <style> section), hence the massive tags
+		echo '<br><br>'
+		echo '<table style="border: 1px solid black; border-collapse: collapse;">'
+		echo '<tr><th colspan="14" style="text-align:center; font-size:20px; height:40px; font-family:courier;">ZPool Status Report Summary</th></tr>'
+		echo '<tr>'
+		echo '<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Pool<br>Name</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Status</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Size</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Allocated</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Free</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Frag %</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Used %</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Read<br>Errors</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Write<br>Errors</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Cksum<br>Errors</th>'
+		echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Scrub<br>Repaired<br>Bytes</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Scrub<br>Errors</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last<br>Scrub<br>Age (days)</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last<br>Scrub<br>Duration</th>'
+		echo '</tr>'
+	} >> "${logfile}"
 
-poolNum="0"
-pools="$(zpool list -H -o name)"
-for pool in ${pools}; do
 
-    # zpool health summary
-    status="$(zpool list -H -o health "${pool}")"
-
-    # zpool fragment summary
-    frag="$(zpool list -H -p -o frag "${pool}" | tr -d %% | awk '{print $0 + 0}')"
-    size="$(zpool list -H -o size "${pool}")"
-    allocated="$(zpool list -H -o allocated "${pool}")"
-    free="$(zpool list -H -o free "${pool}")"
-
-    # Total all read, write, and checksum errors per pool
-    errors="$(zpool status "${pool}" | grep -E "(ONLINE|DEGRADED|FAULTED|UNAVAIL|REMOVED)[ \\t]+[0-9]+")"
-    readErrors="0"
-    for err in $(echo "${errors}" | awk '{print $3}'); do
-        if echo "${err}" | grep -E -q "[^0-9]+"; then
-            readErrors="1000"
-            break
-        fi
-        readErrors="$((readErrors + err))"
-    done
-    writeErrors="0"
-    for err in $(echo "${err}ors" | awk '{print $4}'); do
-        if echo "${err}" | grep -E -q "[^0-9]+"; then
-            writeErrors="1000"
-            break
-        fi
-        writeErrors="$((writeErrors + err))"
-    done
-    cksumErrors="0"
-    for err in $(echo "${err}ors" | awk '{print $5}'); do
-        if echo "${err}" | grep -E -q "[^0-9]+"; then
-            cksumErrors="1000"
-            break
-        fi
-        cksumErrors="$((cksumErrors + err))"
-    done
-    # Not sure why this changes values larger than 1000 to ">1K", but I guess it works, so I'm leaving it
-    if [ "${readErrors}" -gt 999 ]; then readErrors=">1K"; fi
-    if [ "${writeErrors}" -gt 999 ]; then writeErrors=">1K"; fi
-    if [ "${cksumErrors}" -gt 999 ]; then cksumErrors=">1K"; fi
-
-    # Get used capacity percentage of the zpool
-    used="$(zpool list -H -p -o capacity "${pool}")"
-
-    # Gather info from most recent scrub; values set to "N/A" initially and overwritten when (and if) it gathers scrub info
-    scrubRepBytes="N/A"
-    scrubErrors="N/A"
-    scrubAge="N/A"
-    scrubTime="N/A"
-    resilver=""
-
-    statusOutput="$(zpool status "${pool}")"
-    # normal status i.e. scrub
-    if [ "$(echo "${statusOutput}" | grep "scan:" | awk '{print $2" "$3}')" = "scrub repaired" ]; then
-        scrubRepBytes="$(echo "${statusOutput}" | grep "scan:" | awk '{gsub(/B/,"",$4); print $4}')"
-        scrubErrors="$(echo "${statusOutput}" | grep "scan:" | awk '{print $8}')"
-
-        # Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
-        scrubDate="$(echo "${statusOutput}" | grep "scan:" | awk '{print $15"-"$12"-"$13"_"$14}')"
-        scrubTS="$(date -j -f '%Y-%b-%e_%H:%M:%S' "${scrubDate}" '+%s')"
-        currentTS="${runDate}"
-        scrubAge="$((((currentTS - scrubTS) + 43200) / 86400))"
-        scrubTime="$(echo "${statusOutput}" | grep "scan" | awk '{print $6}')"
-
-    # if status is resilvered
-    elif [ "$(echo "${statusOutput}" | grep "scan:" | awk '{print $2}')" = "resilvered" ]; then
-            resilver="<BR>Resilvered"
-            scrubRepBytes="$(echo "${statusOutput}" | grep "scan:" | awk '{print $3}')"
-            scrubErrors="$(echo "${statusOutput}" | grep "scan:" | awk '{print $9}')"
-
-            # Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
-            scrubDate="$(echo "${statusOutput}" | grep "scan:" | awk '{print $16"-"$13"-"$14"_"$15}')"
-            scrubTS="$(date -j -f '%Y-%b-%e_%H:%M:%S' "${scrubDate}" '+%s')"
-            currentTS="${runDate}"
-            scrubAge="$((((currentTS - scrubTS) + 43200) / 86400))"
-            scrubTime="$(echo "${statusOutput}" | grep "scan:" | awk '{print $7}')"
-
-    # Check if resilver is in progress
-    elif [ "$(echo "${statusOutput}"| grep "scan:" | awk '{print $2}')" = "resilver" ]; then
-        scrubRepBytes="Resilver In Progress"
-        scrubAge="$(echo "${statusOutput}" | grep "resilvered," | awk '{print $3" done"}')"
-        if [ "$(echo "${statusOutput}" | grep "resilvered," | awk '{print $5}')" = "0" ]; then
-            scrubTime="$(echo "${statusOutput}" | grep "resilvered," | awk '{print $7"<br>to go"}')"
-        else
-            scrubTime="$(echo "${statusOutput}" | grep "resilvered," | awk '{print $5" "$6" "$7"<br>to go"}')"
-        fi
+	poolNum="0"
+	for pool in ${pools}; do
 
-    # Check if scrub is in progress
-    elif [ "$(echo "${statusOutput}"| grep "scan:" | awk '{print $4}')" = "progress" ]; then
-        scrubRepBytes="Scrub In Progress"
-        scrubErrors="$(echo "${statusOutput}" | grep "repaired," | awk '{print $1" repaired"}')"
-        scrubAge="$(echo "${statusOutput}" | grep "repaired," | awk '{print $3" done"}')"
-        if [ "$(echo "${statusOutput}" | grep "repaired," | awk '{print $5}')" = "0" ]; then
-            scrubTime="$(echo "${statusOutput}" | grep "repaired," | awk '{print $7"<br>to go"}')"
-        else
-            scrubTime="$(echo "${statusOutput}" | grep "repaired," | awk '{print $5" "$6" "$7"<br>to go"}')"
-        fi
-    fi
+		# zpool health summary
+		status="$(zpool list -H -o health "${pool}")"
 
-    # Set row's background color; alternates between white and $altColor (light gray)
-    if [ "$((poolNum % 2))" = "1" ]; then
-		bgColor="#ffffff"
-    else
-		bgColor="$altColor"
-    fi
-    poolNum="$((poolNum + 1))"
+		# zpool fragment summary
+		frag="$(zpool list -H -p -o frag "${pool}" | tr -d %% | awk '{print $0 + 0}')"
+		size="$(zpool list -H -o size "${pool}")"
+		allocated="$(zpool list -H -o allocated "${pool}")"
+		free="$(zpool list -H -o free "${pool}")"
 
-    # Set up conditions for warning or critical colors to be used in place of standard background colors
-    if [ ! "${status}" = "ONLINE" ]; then
-		statusColor="${warnColor}"
-    else
-		statusColor="${bgColor}"
-    fi
-    status+="${resilver}"
+		# Total all read, write, and checksum errors per pool
+		errors="$(zpool status "${pool}" | grep -E "(ONLINE|DEGRADED|FAULTED|UNAVAIL|REMOVED)[ \\t]+[0-9]+")"
+		readErrors="0"
+		for err in $(echo "${errors}" | awk '{print $3}'); do
+			if echo "${err}" | grep -E -q "[^0-9]+"; then
+				readErrors="1000"
+				break
+			fi
+			readErrors="$((readErrors + err))"
+		done
+		writeErrors="0"
+		for err in $(echo "${err}ors" | awk '{print $4}'); do
+			if echo "${err}" | grep -E -q "[^0-9]+"; then
+				writeErrors="1000"
+				break
+			fi
+			writeErrors="$((writeErrors + err))"
+		done
+		cksumErrors="0"
+		for err in $(echo "${err}ors" | awk '{print $5}'); do
+			if echo "${err}" | grep -E -q "[^0-9]+"; then
+				cksumErrors="1000"
+				break
+			fi
+			cksumErrors="$((cksumErrors + err))"
+		done
+		# Not sure why this changes values larger than 1000 to ">1K", but I guess it works, so I'm leaving it
+		if [ "${readErrors}" -gt 999 ]; then readErrors=">1K"; fi
+		if [ "${writeErrors}" -gt 999 ]; then writeErrors=">1K"; fi
+		if [ "${cksumErrors}" -gt 999 ]; then cksumErrors=">1K"; fi
+
+		# Get used capacity percentage of the zpool
+		used="$(zpool list -H -p -o capacity "${pool}")"
+
+		# Gather info from most recent scrub; values set to "N/A" initially and overwritten when (and if) it gathers scrub info
+		scrubRepBytes="N/A"
+		scrubErrors="N/A"
+		scrubAge="N/A"
+		scrubTime="N/A"
+		resilver=""
+
+		statusOutput="$(zpool status "${pool}")"
+		# normal status i.e. scrub
+		if [ "$(echo "${statusOutput}" | grep "scan:" | awk '{print $2" "$3}')" = "scrub repaired" ]; then
+			scrubRepBytes="$(echo "${statusOutput}" | grep "scan:" | awk '{gsub(/B/,"",$4); print $4}')"
+			scrubErrors="$(echo "${statusOutput}" | grep "scan:" | awk '{print $8}')"
+
+			# Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
+			scrubDate="$(echo "${statusOutput}" | grep "scan:" | awk '{print $15"-"$12"-"$13"_"$14}')"
+			scrubTS="$(date -j -f '%Y-%b-%e_%H:%M:%S' "${scrubDate}" '+%s')"
+			currentTS="${runDate}"
+			scrubAge="$((((currentTS - scrubTS) + 43200) / 86400))"
+			scrubTime="$(echo "${statusOutput}" | grep "scan" | awk '{print $6}')"
+
+		# if status is resilvered
+		elif [ "$(echo "${statusOutput}" | grep "scan:" | awk '{print $2}')" = "resilvered" ]; then
+				resilver="<BR>Resilvered"
+				scrubRepBytes="$(echo "${statusOutput}" | grep "scan:" | awk '{print $3}')"
+				scrubErrors="$(echo "${statusOutput}" | grep "scan:" | awk '{print $9}')"
+
+				# Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
+				scrubDate="$(echo "${statusOutput}" | grep "scan:" | awk '{print $16"-"$13"-"$14"_"$15}')"
+				scrubTS="$(date -j -f '%Y-%b-%e_%H:%M:%S' "${scrubDate}" '+%s')"
+				currentTS="${runDate}"
+				scrubAge="$((((currentTS - scrubTS) + 43200) / 86400))"
+				scrubTime="$(echo "${statusOutput}" | grep "scan:" | awk '{print $7}')"
+
+		# Check if resilver is in progress
+		elif [ "$(echo "${statusOutput}"| grep "scan:" | awk '{print $2}')" = "resilver" ]; then
+			scrubRepBytes="Resilver In Progress"
+			scrubAge="$(echo "${statusOutput}" | grep "resilvered," | awk '{print $3" done"}')"
+			if [ "$(echo "${statusOutput}" | grep "resilvered," | awk '{print $5}')" = "0" ]; then
+				scrubTime="$(echo "${statusOutput}" | grep "resilvered," | awk '{print $7"<br>to go"}')"
+			else
+				scrubTime="$(echo "${statusOutput}" | grep "resilvered," | awk '{print $5" "$6" "$7"<br>to go"}')"
+			fi
 
-    if [ ! "${readErrors}" = "0" ]; then
-		readErrorsColor="${warnColor}"
-    else
-		readErrorsColor="${bgColor}"
-    fi
+		# Check if scrub is in progress
+		elif [ "$(echo "${statusOutput}"| grep "scan:" | awk '{print $4}')" = "progress" ]; then
+			scrubRepBytes="Scrub In Progress"
+			scrubErrors="$(echo "${statusOutput}" | grep "repaired," | awk '{print $1" repaired"}')"
+			scrubAge="$(echo "${statusOutput}" | grep "repaired," | awk '{print $3" done"}')"
+			if [ "$(echo "${statusOutput}" | grep "repaired," | awk '{print $5}')" = "0" ]; then
+				scrubTime="$(echo "${statusOutput}" | grep "repaired," | awk '{print $7"<br>to go"}')"
+			else
+				scrubTime="$(echo "${statusOutput}" | grep "repaired," | awk '{print $5" "$6" "$7"<br>to go"}')"
+			fi
+		fi
 
-    if [ ! "${writeErrors}" = "0" ]; then
-		writeErrorsColor="${warnColor}"
-    else
-		writeErrorsColor="${bgColor}"
-    fi
+		# Set row's background color; alternates between white and $altColor (light gray)
+		if [ "$((poolNum % 2))" = "1" ]; then
+			bgColor="#ffffff"
+		else
+			bgColor="$altColor"
+		fi
+		poolNum="$((poolNum + 1))"
 
-    if [ ! "${cksumErrors}" = "0" ]; then
-		cksumErrorsColor="${warnColor}"
-    else
-		cksumErrorsColor="${bgColor}"
-    fi
+		# Set up conditions for warning or critical colors to be used in place of standard background colors
+		if [ ! "${status}" = "ONLINE" ]; then
+			statusColor="${warnColor}"
+		else
+			statusColor="${bgColor}"
+		fi
+		status+="${resilver}"
 
-    if [ "${used}" -gt "${usedWarn}" ]; then
-		usedColor="${warnColor}"
-    else
-		usedColor="${bgColor}"
-    fi
+		if [ ! "${readErrors}" = "0" ]; then
+			readErrorsColor="${warnColor}"
+		else
+			readErrorsColor="${bgColor}"
+		fi
 
-    if [ ! "${scrubRepBytes}" = "N/A" ] && [ ! "${scrubRepBytes}" = "0" ] && [ ! "${scrubRepBytes}" = "0B" ]; then
-        scrubRepBytesColor="${warnColor}"
-	else
-		scrubRepBytesColor="${bgColor}"
-	fi
+		if [ ! "${writeErrors}" = "0" ]; then
+			writeErrorsColor="${warnColor}"
+		else
+			writeErrorsColor="${bgColor}"
+		fi
 
-    if [ ! "${scrubErrors}" = "N/A" ] && [ ! "${scrubErrors}" = "0" ]; then
-		scrubErrorsColor="${warnColor}"
-    else
-		scrubErrorsColor="${bgColor}"
-    fi
+		if [ ! "${cksumErrors}" = "0" ]; then
+			cksumErrorsColor="${warnColor}"
+		else
+			cksumErrorsColor="${bgColor}"
+		fi
 
-    if [ "$(echo "$scrubAge" | awk '{print int($1)}')" -gt "${scrubAgeWarn}" ]; then
-		scrubAgeColor="${warnColor}"
-    else
-		scrubAgeColor="${bgColor}"
-    fi
+		if [ "${used}" -gt "${usedWarn}" ]; then
+			usedColor="${warnColor}"
+		else
+			usedColor="${bgColor}"
+		fi
 
-    {
-        # Use the information gathered above to write the date to the current table row
-		echo '<tr style="background-color:'"${bgColor}"'">'
-		echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${pool}"'</td>'
-		echo '<td style="text-align:center; background-color:'"${statusColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${status}"'</td>'
-		echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${size}"'</td>'
-		echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${allocated}"'</td>'
-		echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${free}"'</td>'
-		echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${frag}"'%</td>'
-		echo '<td style="text-align:center; background-color:'"${usedColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${used}"'%</td>'
-		echo '<td style="text-align:center; background-color:'"${readErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${readErrors}"'</td>'
-		echo '<td style="text-align:center; background-color:'"${writeErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${writeErrors}"'</td>'
-		echo '<td style="text-align:center; background-color:'"${cksumErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${cksumErrors}"'</td>'
-		echo '<td style="text-align:center; background-color:'"${scrubRepBytesColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scrubRepBytes}"'</td>'
-		echo '<td style="text-align:center; background-color:'"${scrubErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scrubErrors}"'</td>'
-		echo '<td style="text-align:center; background-color:'"${scrubAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scrubAge}"'</td>'
-		echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scrubTime}"'</td>'
-		echo '</tr>'
-    } >> "${logfile}"
-done
+		if [ ! "${scrubRepBytes}" = "N/A" ] && [ ! "${scrubRepBytes}" = "0" ] && [ ! "${scrubRepBytes}" = "0B" ]; then
+			scrubRepBytesColor="${warnColor}"
+		else
+			scrubRepBytesColor="${bgColor}"
+		fi
+
+		if [ ! "${scrubErrors}" = "N/A" ] && [ ! "${scrubErrors}" = "0" ]; then
+			scrubErrorsColor="${warnColor}"
+		else
+			scrubErrorsColor="${bgColor}"
+		fi
+
+		if [ "$(echo "$scrubAge" | awk '{print int($1)}')" -gt "${scrubAgeWarn}" ]; then
+			scrubAgeColor="${warnColor}"
+		else
+			scrubAgeColor="${bgColor}"
+		fi
+
+		{
+			# Use the information gathered above to write the date to the current table row
+			echo '<tr style="background-color:'"${bgColor}"'">'
+			echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${pool}"'</td>'
+			echo '<td style="text-align:center; background-color:'"${statusColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${status}"'</td>'
+			echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${size}"'</td>'
+			echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${allocated}"'</td>'
+			echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${free}"'</td>'
+			echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${frag}"'%</td>'
+			echo '<td style="text-align:center; background-color:'"${usedColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${used}"'%</td>'
+			echo '<td style="text-align:center; background-color:'"${readErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${readErrors}"'</td>'
+			echo '<td style="text-align:center; background-color:'"${writeErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${writeErrors}"'</td>'
+			echo '<td style="text-align:center; background-color:'"${cksumErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${cksumErrors}"'</td>'
+			echo '<td style="text-align:center; background-color:'"${scrubRepBytesColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scrubRepBytes}"'</td>'
+			echo '<td style="text-align:center; background-color:'"${scrubErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scrubErrors}"'</td>'
+			echo '<td style="text-align:center; background-color:'"${scrubAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scrubAge}"'</td>'
+			echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scrubTime}"'</td>'
+			echo '</tr>'
+		} >> "${logfile}"
+	done
+
+	# End of zpool status table
+	echo '</table>' >> "${logfile}"
+}
 
-# End of zpool status table
-echo '</table>' >> "${logfile}"
+ZpoolSummary
 
 
 ### SMART status summary tables

From 63aa127d1670acd59f1afb7eaf9ec82f8b349426 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sat, 15 May 2021 14:17:32 -0400
Subject: [PATCH 035/160] Make the UPS report into a function.

---
 report.sh | 42 +++++++++++++++++++++++-------------------
 1 file changed, 23 insertions(+), 19 deletions(-)

diff --git a/report.sh b/report.sh
index 14bdf95..a99f343 100755
--- a/report.sh
+++ b/report.sh
@@ -1288,33 +1288,33 @@ echo '<pre style="font-size:14px">' >> "${logfile}"
 
 
 ### UPS status report
-if [ "${reportUPS}" = "true" ]; then
-
+function ReportUPS () {
     # Set to a value greater than zero to include all available UPSC
     # variables in the report:
-    senddetail="0"
+	local senddetail="0"
+	local ups
 
     # Get a list of all ups devices installed on the system:
-    upslist="$(upsc -l "${host}")"
+    local upslist="$(upsc -l "${host}")"
 
-    (
+    {
 		echo '<pre style="font-size:14px">'
 		echo '<b>########## UPS status report ##########</b>'
 			for ups in ${upslist}; do
 
-				ups_type="$(upsc "${ups}" device.type 2> /dev/null | tr '[:lower:]' '[:upper:]')"
-				ups_mfr="$(upsc "${ups}" ups.mfr 2> /dev/null)"
-				ups_model="$(upsc "${ups}" ups.model 2> /dev/null)"
-				ups_serial="$(upsc "${ups}" ups.serial 2> /dev/null)"
-				ups_status="$(upsc "${ups}" ups.status 2> /dev/null)"
-				ups_load="$(upsc "${ups}" ups.load 2> /dev/null)"
-				ups_realpower="$(upsc "${ups}" ups.realpower 2> /dev/null)"
-				ups_realpowernominal="$(upsc "${ups}" ups.realpower.nominal 2> /dev/null)"
-				ups_batterycharge="$(upsc "${ups}" battery.charge 2> /dev/null)"
-				ups_batteryruntime="$(upsc "${ups}" battery.runtime 2> /dev/null)"
-				ups_batteryvoltage="$(upsc "${ups}" battery.voltage 2> /dev/null)"
-				ups_inputvoltage="$(upsc "${ups}" input.voltage 2> /dev/null)"
-				ups_outputvoltage="$(upsc "${ups}" output.voltage 2> /dev/null)"
+				local ups_type="$(upsc "${ups}" device.type 2> /dev/null | tr '[:lower:]' '[:upper:]')"
+				local ups_mfr="$(upsc "${ups}" ups.mfr 2> /dev/null)"
+				local ups_model="$(upsc "${ups}" ups.model 2> /dev/null)"
+				local ups_serial="$(upsc "${ups}" ups.serial 2> /dev/null)"
+				local ups_status="$(upsc "${ups}" ups.status 2> /dev/null)"
+				local ups_load="$(upsc "${ups}" ups.load 2> /dev/null)"
+				local ups_realpower="$(upsc "${ups}" ups.realpower 2> /dev/null)"
+				local ups_realpowernominal="$(upsc "${ups}" ups.realpower.nominal 2> /dev/null)"
+				local ups_batterycharge="$(upsc "${ups}" battery.charge 2> /dev/null)"
+				local ups_batteryruntime="$(upsc "${ups}" battery.runtime 2> /dev/null)"
+				local ups_batteryvoltage="$(upsc "${ups}" battery.voltage 2> /dev/null)"
+				local ups_inputvoltage="$(upsc "${ups}" input.voltage 2> /dev/null)"
+				local ups_outputvoltage="$(upsc "${ups}" output.voltage 2> /dev/null)"
 
 				printf "=== %s %s, model %s, serial number %s\n\n" "${ups_mfr}" "${ups_type}" "${ups_model}" "${ups_serial} ==="
 				echo "Name: ${ups}"
@@ -1342,9 +1342,13 @@ if [ "${reportUPS}" = "true" ]; then
 					echo ""
 				fi
 			done
-    ) >> "${logfile}"
+    } >> "${logfile}"
 
     echo "</pre>" >> "${logfile}"
+}
+
+if [ "${reportUPS}" = "true" ]; then
+	ReportUPS
 fi
 
 

From 8b2eff55ec7a89fc4ac8cf43153d51da97564776 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sat, 15 May 2021 18:10:38 -0400
Subject: [PATCH 036/160] Consolidate the functions.

---
 report.sh | 366 +++++++++++++++++++++++++++---------------------------
 1 file changed, 182 insertions(+), 184 deletions(-)

diff --git a/report.sh b/report.sh
index a99f343..7739998 100755
--- a/report.sh
+++ b/report.sh
@@ -68,8 +68,9 @@
 #   - Initial release
 
 
-# Write out a default config file
-function rpConfig {
+# Functions
+function rpConfig () {
+	# Write out a default config file
 	tee > "${configFile}" <<"EOF"
 
 # Set this to 0 to enable
@@ -122,142 +123,6 @@ EOF
 	exit 0
 }
 
-
-#
-# Main Script Starts Here
-#
-
-while getopts ":c:" OPTION; do
-	case "${OPTION}" in
-		c)
-			configFile="${OPTARG}"
-		;;
-		?)
-			# If an unknown flag is used (or -?):
-			echo "${0} {-c configFile}" >&2
-			exit 1
-		;;
-	esac
-done
-
-if [ -z "${configFile}" ]; then
-	echo "Please specify a config file location." >&2
-	exit 1
-elif [ ! -f "${configFile}" ]; then
-	rpConfig
-fi
-
-# Source external config file
-# shellcheck source=/dev/null
-. "${configFile}"
-
-# Check if needed software is installed.
-PATH="${PATH}:/usr/local/sbin:/usr/local/bin"
-commands=(
-hostname
-date
-sysctl
-sed
-grep
-awk
-zpool
-cut
-tr
-bc
-smartctl
-jq
-glabel
-sendmail
-)
-if [ "${configBackup}" = "true" ]; then
-commands+=(
-tar
-sqlite3
-md5
-sha256
-base64
-)
-fi
-if [ "${reportUPS}" = "true" ]; then
-commands+=(
-upsc
-)
-fi
-for command in "${commands[@]}"; do
-	if ! type "${command}" &> /dev/null; then
-		echo "${command} is missing, please install" >&2
-		exit 100
-	fi
-done
-
-
-# Do not run if the config file has not been edited.
-if [ ! "${defaultFile}" = "0" ]; then
-	echo "Please edit the config file for your setup" >&2
-	exit 1
-fi
-
-
-###### Auto-generated Parameters
-host="$(hostname -s)"
-runDate="$(date '+%s')"
-logfile="${logfileLocation}/$(date -r "${runDate}" '+%Y%m%d%H%M%S')_${logfileName}.tmp"
-subject="Status Report and Configuration Backup for ${host} - $(date -r "${runDate}" '+%Y-%m-%d %H:%M')"
-boundary="$(dbus-uuidgen)"
-messageid="$(dbus-uuidgen)"
-
-# Reorders the drives in ascending order
-drives=$(for drive in $(sysctl -n kern.disks | sed -e 's:nvd:nvme:g'); do
-    if smartctl -i "/dev/${drive}" | grep -q "SMART support is: Enabled"; then
-        printf "%s " "${drive}"
-	elif echo "${drive}" | grep -q "nvme"; then
-		printf "%s " "${drive}"
-    fi
-done | awk '{for (i=NF; i!=0 ; i--) print $i }')
-
-# Toggles the 'ssdExist' flag to true if SSDs are detected in order to add the summary table
-if [ "${includeSSD}" = "true" ]; then
-    for drive in ${drives}; do
-        if [ "$(smartctl -ij "/dev/${drive}" | jq -Mre '.rotation_rate | values')" = "0" ]; then
-            ssdExist="true"
-            break
-        else
-            ssdExist="false"
-        fi
-    done
-    if echo "${drives}" | grep -q "nvme"; then
-    	NVMeExist="true"
-    fi
-fi
-# Test to see if there are any HDDs
-for drive in ${drives}; do
-	if [ ! "$(smartctl -ij "/dev/${drive}" | jq -Mre '.rotation_rate | values')" = "0" ]; then
-		hddExist="true"
-		break
-	else
-		hddExist="false"
-	fi
-done
-
-# Get a list of pools
-pools="$(zpool list -H -o name)"
-
-
-
-###### Email pre-formatting
-### Set email headers
-{
-    echo "From: ${host} <root@$(hostname)>"
-    echo "To: ${email}"
-    echo "Subject: ${subject}"
-    echo "MIME-Version: 1.0"
-    echo 'Content-Type: multipart/mixed; boundary="'"${boundary}"'"'
-    echo "Date: $(date -Rr "${runDate}")"
-    echo "Message-Id: <${messageid}@${host}>"
-} > "${logfile}"
-
-
-
 function ConfigBackup () {
     local tarfile
     local fnconfigdest_version
@@ -319,21 +184,6 @@ function ConfigBackup () {
     fi
 }
 
-###### Config backup (if enabled)
-if [ "${configBackup}" = "true" ]; then
-	ConfigBackup
-else
-    # Config backup disabled; set up for html-type content
-    {
-        echo "--${boundary}"
-        echo "Content-Transfer-Encoding: 8bit"
-        echo -e "Content-Type: text/html; charset=utf-8\n"
-    } >> "${logfile}"
-fi
-
-
-###### Report Summary Section (html tables)
-
 function ZpoolSummary () {
 	local poolNum
 	local pool
@@ -574,12 +424,6 @@ function ZpoolSummary () {
 	echo '</table>' >> "${logfile}"
 }
 
-ZpoolSummary
-
-
-### SMART status summary tables
-
-
 # shellcheck disable=SC2155
 function NVMeSummary () {
 
@@ -799,12 +643,6 @@ function NVMeSummary () {
 	} >> "${logfile}"
 }
 
-
-if [ "${NVMeExist}" = "true" ]; then
-	NVMeSummary
-fi
-
-
 # shellcheck disable=SC2155
 function SSDSummary () {
 	###### SSD SMART status summary table
@@ -1056,13 +894,6 @@ function SSDSummary () {
     } >> "${logfile}"
 }
 
-
-if [ "${ssdExist}" = "true" ]; then
-	SSDSummary
-fi
-
-
-
 # shellcheck disable=SC2155
 function HDDSummary () {
 	###### HDD SMART status summary table
@@ -1276,18 +1107,6 @@ function HDDSummary () {
 	} >> "${logfile}"
 }
 
-
-if [ "${hddExist}" = "true" ]; then
-	HDDSummary
-fi
-
-
-
-###### Detailed Report Section (monospace text)
-echo '<pre style="font-size:14px">' >> "${logfile}"
-
-
-### UPS status report
 function ReportUPS () {
     # Set to a value greater than zero to include all available UPSC
     # variables in the report:
@@ -1347,6 +1166,185 @@ function ReportUPS () {
     echo "</pre>" >> "${logfile}"
 }
 
+
+#
+# Main Script Starts Here
+#
+
+while getopts ":c:" OPTION; do
+	case "${OPTION}" in
+		c)
+			configFile="${OPTARG}"
+		;;
+		?)
+			# If an unknown flag is used (or -?):
+			echo "${0} {-c configFile}" >&2
+			exit 1
+		;;
+	esac
+done
+
+if [ -z "${configFile}" ]; then
+	echo "Please specify a config file location." >&2
+	exit 1
+elif [ ! -f "${configFile}" ]; then
+	rpConfig
+fi
+
+# Source external config file
+# shellcheck source=/dev/null
+. "${configFile}"
+
+# Check if needed software is installed.
+PATH="${PATH}:/usr/local/sbin:/usr/local/bin"
+commands=(
+hostname
+date
+sysctl
+sed
+grep
+awk
+zpool
+cut
+tr
+bc
+smartctl
+jq
+glabel
+sendmail
+)
+if [ "${configBackup}" = "true" ]; then
+commands+=(
+tar
+sqlite3
+md5
+sha256
+base64
+)
+fi
+if [ "${reportUPS}" = "true" ]; then
+commands+=(
+upsc
+)
+fi
+for command in "${commands[@]}"; do
+	if ! type "${command}" &> /dev/null; then
+		echo "${command} is missing, please install" >&2
+		exit 100
+	fi
+done
+
+
+# Do not run if the config file has not been edited.
+if [ ! "${defaultFile}" = "0" ]; then
+	echo "Please edit the config file for your setup" >&2
+	exit 1
+fi
+
+
+###### Auto-generated Parameters
+host="$(hostname -s)"
+runDate="$(date '+%s')"
+logfile="${logfileLocation}/$(date -r "${runDate}" '+%Y%m%d%H%M%S')_${logfileName}.tmp"
+subject="Status Report and Configuration Backup for ${host} - $(date -r "${runDate}" '+%Y-%m-%d %H:%M')"
+boundary="$(dbus-uuidgen)"
+messageid="$(dbus-uuidgen)"
+
+# Reorders the drives in ascending order
+drives=$(for drive in $(sysctl -n kern.disks | sed -e 's:nvd:nvme:g'); do
+    if smartctl -i "/dev/${drive}" | grep -q "SMART support is: Enabled"; then
+        printf "%s " "${drive}"
+	elif echo "${drive}" | grep -q "nvme"; then
+		printf "%s " "${drive}"
+    fi
+done | awk '{for (i=NF; i!=0 ; i--) print $i }')
+
+# Toggles the 'ssdExist' flag to true if SSDs are detected in order to add the summary table
+if [ "${includeSSD}" = "true" ]; then
+    for drive in ${drives}; do
+        if [ "$(smartctl -ij "/dev/${drive}" | jq -Mre '.rotation_rate | values')" = "0" ]; then
+            ssdExist="true"
+            break
+        else
+            ssdExist="false"
+        fi
+    done
+    if echo "${drives}" | grep -q "nvme"; then
+    	NVMeExist="true"
+    fi
+fi
+# Test to see if there are any HDDs
+for drive in ${drives}; do
+	if [ ! "$(smartctl -ij "/dev/${drive}" | jq -Mre '.rotation_rate | values')" = "0" ]; then
+		hddExist="true"
+		break
+	else
+		hddExist="false"
+	fi
+done
+
+# Get a list of pools
+pools="$(zpool list -H -o name)"
+
+
+
+###### Email pre-formatting
+### Set email headers
+{
+    echo "From: ${host} <root@$(hostname)>"
+    echo "To: ${email}"
+    echo "Subject: ${subject}"
+    echo "MIME-Version: 1.0"
+    echo 'Content-Type: multipart/mixed; boundary="'"${boundary}"'"'
+    echo "Date: $(date -Rr "${runDate}")"
+    echo "Message-Id: <${messageid}@${host}>"
+} > "${logfile}"
+
+
+
+
+###### Config backup (if enabled)
+if [ "${configBackup}" = "true" ]; then
+	ConfigBackup
+else
+    # Config backup disabled; set up for html-type content
+    {
+        echo "--${boundary}"
+        echo "Content-Transfer-Encoding: 8bit"
+        echo -e "Content-Type: text/html; charset=utf-8\n"
+    } >> "${logfile}"
+fi
+
+
+###### Report Summary Section (html tables)
+
+ZpoolSummary
+
+
+### SMART status summary tables
+
+
+if [ "${NVMeExist}" = "true" ]; then
+	NVMeSummary
+fi
+
+
+if [ "${ssdExist}" = "true" ]; then
+	SSDSummary
+fi
+
+
+if [ "${hddExist}" = "true" ]; then
+	HDDSummary
+fi
+
+
+
+###### Detailed Report Section (monospace text)
+echo '<pre style="font-size:14px">' >> "${logfile}"
+
+
+### UPS status report
 if [ "${reportUPS}" = "true" ]; then
 	ReportUPS
 fi

From 2182516994dabad3d57b04a0de22b5c3690064d9 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 16 May 2021 11:06:05 -0400
Subject: [PATCH 037/160] Add to the list of commands.

---
 report.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/report.sh b/report.sh
index 7739998..b065724 100755
--- a/report.sh
+++ b/report.sh
@@ -1211,6 +1211,8 @@ bc
 smartctl
 jq
 glabel
+head
+tail
 sendmail
 )
 if [ "${configBackup}" = "true" ]; then

From 6bc541e9b516423f3c5cf2c414a0c244e5ac842c Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 16 May 2021 11:52:48 -0400
Subject: [PATCH 038/160] Use arrays in loops.

---
 report.sh | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/report.sh b/report.sh
index 2ddc57b..19bebe7 100755
--- a/report.sh
+++ b/report.sh
@@ -242,7 +242,7 @@ function ZpoolSummary () {
 
 
 	poolNum="0"
-	for pool in ${pools}; do
+	for pool in "${pools[@]}"; do
 
 		# zpool health summary
 		status="$(zpool list -H -o health "${pool}")"
@@ -487,7 +487,7 @@ function NVMeSummary () {
 
 	local drive
 	local altRow="false"
-	for drive in ${drives}; do
+	for drive in "${drives[@]}"; do
 		if echo "${drive}" | grep -q "nvme"; then
 			# For each drive detected, run "smartctl -Aij" and parse its output.
 			# Start by parsing variables used in other parts of the script.
@@ -689,7 +689,7 @@ function SSDSummary () {
 
 	local drive
 	local altRow="false"
-    for drive in ${drives}; do
+    for drive in "${drives[@]}"; do
         if [ "$(smartctl -ij "/dev/${drive}" | jq -Mre '.rotation_rate | values')" = "0" ]; then
 			# For each drive detected, run "smartctl -Aijl selftest" and parse its output.
 			# Start by parsing out the variables used in other parts of the script.
@@ -940,7 +940,7 @@ function HDDSummary () {
 
 	local drive
 	local altRow="false"
-	for drive in ${drives}; do
+	for drive in "${drives[@]}"; do
 		if smartctl -i "/dev/${drive}" | grep -q "SMART support is: Enabled" && [ ! "$(smartctl -ij "/dev/${drive}" | jq -Mre '.rotation_rate | values')" = "0" ]; then
 			# For each drive detected, run "smartctl -Aijl selftest" and parse its output.
 			# After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).
@@ -1121,6 +1121,7 @@ function HDDSummary () {
 	} >> "${logfile}"
 }
 
+# shellcheck disable=SC2155
 function ReportUPS () {
     # Set to a value greater than zero to include all available UPSC
     # variables in the report:
@@ -1133,7 +1134,7 @@ function ReportUPS () {
     {
 		echo '<pre style="font-size:14px">'
 		echo '<b>########## UPS status report ##########</b>'
-			for ups in ${upslist}; do
+			for ups in "${upslist[@]}"; do
 
 				local ups_type="$(upsc "${ups}" device.type 2> /dev/null | tr '[:lower:]' '[:upper:]')"
 				local ups_mfr="$(upsc "${ups}" ups.mfr 2> /dev/null)"
@@ -1277,7 +1278,7 @@ done | awk '{for (i=NF; i!=0 ; i--) print $i }')
 
 # Toggles the 'ssdExist' flag to true if SSDs are detected in order to add the summary table
 if [ "${includeSSD}" = "true" ]; then
-    for drive in ${drives}; do
+    for drive in "${drives[@]}"; do
         if [ "$(smartctl -ij "/dev/${drive}" | jq -Mre '.rotation_rate | values')" = "0" ]; then
             ssdExist="true"
             break
@@ -1290,7 +1291,7 @@ if [ "${includeSSD}" = "true" ]; then
     fi
 fi
 # Test to see if there are any HDDs
-for drive in ${drives}; do
+for drive in "${drives[@]}"; do
 	if [ ! "$(smartctl -ij "/dev/${drive}" | jq -Mre '.rotation_rate | values')" = "0" ]; then
 		hddExist="true"
 		break
@@ -1375,7 +1376,7 @@ fi
 
 
 ### Zpool status for each pool
-for pool in ${pools}; do
+for pool in "${pools[@]}"; do
     {
         # Create a simple header and drop the output of zpool status -v
         echo '<b>########## ZPool status report for '"${pool}"' ##########</b>'
@@ -1386,7 +1387,7 @@ done
 
 
 ### SMART status for each drive
-for drive in ${drives}; do
+for drive in "${drives[@]}"; do
     if smartctl -i "/dev/${drive}" | grep -q "SMART support is: Enabled"; then
         # Gather brand and serial number of each drive
         brand="$(smartctl -ij "/dev/${drive}" | jq -Mre '.model_family | values')"

From 4bc6d9b9873c291939b8e97632f214dee09b75ee Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 16 May 2021 13:06:05 -0400
Subject: [PATCH 039/160] No need for nested <pre> tags.

---
 report.sh | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/report.sh b/report.sh
index 19bebe7..b988c11 100755
--- a/report.sh
+++ b/report.sh
@@ -1132,7 +1132,6 @@ function ReportUPS () {
     local upslist="$(upsc -l "${host}")"
 
     {
-		echo '<pre style="font-size:14px">'
 		echo '<b>########## UPS status report ##########</b>'
 			for ups in "${upslist[@]}"; do
 
@@ -1178,7 +1177,7 @@ function ReportUPS () {
 			done
     } >> "${logfile}"
 
-    echo "</pre>" >> "${logfile}"
+    echo "<br><br>" >> "${logfile}"
 }
 
 

From 79eda045a203ec132b86eef8e0e158bd81188f99 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 16 May 2021 13:12:36 -0400
Subject: [PATCH 040/160] Set arrays allowing for spaces in items.

Fixes edgarsuit/FreeNAS-Report#27
---
 report.sh | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/report.sh b/report.sh
index b988c11..d475623 100755
--- a/report.sh
+++ b/report.sh
@@ -1127,9 +1127,10 @@ function ReportUPS () {
     # variables in the report:
 	local senddetail="0"
 	local ups
+    local upslist
 
     # Get a list of all ups devices installed on the system:
-    local upslist="$(upsc -l "${host}")"
+    readarray -t "upslist" <<< "$(upsc -l "${host}")"
 
     {
 		echo '<b>########## UPS status report ##########</b>'
@@ -1267,13 +1268,13 @@ boundary="$(dbus-uuidgen)"
 messageid="$(dbus-uuidgen)"
 
 # Reorders the drives in ascending order
-drives=$(for drive in $(sysctl -n kern.disks | sed -e 's:nvd:nvme:g'); do
-    if smartctl -i "/dev/${drive}" | grep -q "SMART support is: Enabled"; then
-        printf "%s " "${drive}"
+readarray -t "drives" <<< "$(for drive in $(sysctl -n kern.disks | sed -e 's:nvd:nvme:g'); do
+	if smartctl -i "/dev/${drive}" | grep -q "SMART support is: Enabled"; then
+		printf "%s " "${drive}"
 	elif echo "${drive}" | grep -q "nvme"; then
 		printf "%s " "${drive}"
-    fi
-done | awk '{for (i=NF; i!=0 ; i--) print $i }')
+	fi
+done | awk '{for (i=NF; i!=0 ; i--) print $i }')"
 
 # Toggles the 'ssdExist' flag to true if SSDs are detected in order to add the summary table
 if [ "${includeSSD}" = "true" ]; then
@@ -1300,7 +1301,7 @@ for drive in "${drives[@]}"; do
 done
 
 # Get a list of pools
-pools="$(zpool list -H -o name)"
+readarray -t "pools" <<< "$(zpool list -H -o name)"
 
 
 

From 27d0c32848a75a22cc90eb5653d496a2521dcf56 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 16 May 2021 13:44:20 -0400
Subject: [PATCH 041/160] Update the ReadMe file.

---
 README.md | 23 +++++++++++++++--------
 report.sh |  2 +-
 2 files changed, 16 insertions(+), 9 deletions(-)

diff --git a/README.md b/README.md
index 2432c18..f3af5e4 100644
--- a/README.md
+++ b/README.md
@@ -1,19 +1,29 @@
-# ZPool, SMART, and UPS Status Report with FreeNAS Config Backup
+# ZPool, SMART, and UPS Status Report with TrueNAS Config Backup
 Original Script By: joeschmuck<br>
-Modified By: bidelu0hm, melp, fohlsso2, onlinepcwizard, ninpucho, isentropik<br>
-Last Edited By: aserrallerios
+Modified By: bidelu0hm, melp, fohlsso2, onlinepcwizard, ninpucho, isentropik, rotx, dak180<br>
+Last Edited By: dak180
 
 Preview of the output here: https://i.imgur.com/K38T1u8.png<br>
 When a resilver is in progress: https://i.imgur.com/CUNUZ7r.png<br>
 After the resilver is done: https://i.imgur.com/I43MLLf.png<br>
 When a scrub is in progess: https://i.imgur.com/YGmvZT4.png<br><br>
 
-**At a minimum, enter email address in user-definable parameter section. The default is set to 'root' as I assume that the root email was set in FreeNAS. Feel free to edit other user parameters as needed. Backup has been enabled by default so if it's not required please set to false.**<br><br>
+**At a minimum, enter email address and set defaultFile to 0 in the generated config file. Feel free to edit other user parameters as needed. Backup has been disabled by default so if it is required please set to true.**<br><br>
 
-**Current Version: v1.6**
+**Current Version: v1.7**
 
 **Changelog:**
 
+*v1.7* (dak180)
+ - Refactor to reduce dependence on awk
+ - Use a separate config file
+ - Add support for conveyance test
+
+*v1.6.5* (rotx)
+ - HTML boundary fix, proper message ids, support for dma mailer
+ - Better support for NVMe and SSD
+ - Support for new smartmon-tools
+
 *v1.6* (isentropik)
  - Actually fixed the broken borders in the tables.
  - Split the SMART table into two tables, one for SSDs and one for HDDs.
@@ -67,6 +77,3 @@ When a scrub is in progess: https://i.imgur.com/YGmvZT4.png<br><br>
 
 *v1.0*
 - Initial release
-
-**TODO**
-- Add support for conveyance test
diff --git a/report.sh b/report.sh
index d475623..0f1a82e 100755
--- a/report.sh
+++ b/report.sh
@@ -5,7 +5,7 @@
 
 ###### ZPool, SMART, and UPS Status Report with TrueNAS Config Backup
 ### Original Script By: joeschmuck
-### Modified By: bidelu0hm, melp, fohlsso2, onlinepcwizard, ninpucho, isentropik
+### Modified By: bidelu0hm, melp, fohlsso2, onlinepcwizard, ninpucho, isentropik, dak180
 ### Last Edited By: dak180
 
 ### At a minimum, enter email address and set defaultFile to 0 in the config file.

From ec2ec1bff1f0ee599d6e8225dac7874238d7574b Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 16 May 2021 18:14:33 -0400
Subject: [PATCH 042/160] Make sure the selftest info is printed properly.

---
 report.sh | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/report.sh b/report.sh
index 0f1a82e..7fac4cd 100755
--- a/report.sh
+++ b/report.sh
@@ -1399,8 +1399,9 @@ for drive in "${drives[@]}"; do
             # Create a simple header and drop the output of some basic smartctl commands
             echo '<b>########## SMART status report for '"${drive}"' drive ('"${brand}: ${serial}"') ##########</b>'
             smartctl -H -A -l error "/dev/${drive}"
-            smartctl -l selftest "/dev/${drive}" | grep 'Extended \\|Num' | cut -c6- | head -2
-            smartctl -l selftest "/dev/${drive}" | grep 'Short \\|Num' | cut -c6- | head -2 | tail -n -1
+            smartctl -l selftest "/dev/${drive}" | grep 'Num' | cut -c6- | head -1
+            smartctl -l selftest "/dev/${drive}" | grep 'Extended' | cut -c6- | head -1
+            smartctl -l selftest "/dev/${drive}" | grep 'Short' | cut -c6- | head -1
             echo '<br><br>'
         } >> "${logfile}"
 

From 0b889c6cf45a66bda7eced944bc2814802fc13d4 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 16 May 2021 18:44:13 -0400
Subject: [PATCH 043/160] Support for conveyance test output requires support
 from smartctl.

---
 README.md | 1 -
 1 file changed, 1 deletion(-)

diff --git a/README.md b/README.md
index f3af5e4..ac11aca 100644
--- a/README.md
+++ b/README.md
@@ -17,7 +17,6 @@ When a scrub is in progess: https://i.imgur.com/YGmvZT4.png<br><br>
 *v1.7* (dak180)
  - Refactor to reduce dependence on awk
  - Use a separate config file
- - Add support for conveyance test
 
 *v1.6.5* (rotx)
  - HTML boundary fix, proper message ids, support for dma mailer

From 29a58a78be2fd1717bd96ca5041a5a0b80aa51fa Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 16 May 2021 18:47:50 -0400
Subject: [PATCH 044/160] New preview image.

---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index ac11aca..8e06ae8 100644
--- a/README.md
+++ b/README.md
@@ -3,7 +3,7 @@ Original Script By: joeschmuck<br>
 Modified By: bidelu0hm, melp, fohlsso2, onlinepcwizard, ninpucho, isentropik, rotx, dak180<br>
 Last Edited By: dak180
 
-Preview of the output here: https://i.imgur.com/K38T1u8.png<br>
+Preview of the output here: https://i.imgur.com/jKwraw4.png<br>
 When a resilver is in progress: https://i.imgur.com/CUNUZ7r.png<br>
 After the resilver is done: https://i.imgur.com/I43MLLf.png<br>
 When a scrub is in progess: https://i.imgur.com/YGmvZT4.png<br><br>

From a0af399b0ef51e18fb36a83acef507a52b74a233 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 16 May 2021 19:09:23 -0400
Subject: [PATCH 045/160] Support for conveyance test output.

---
 README.md | 1 +
 report.sh | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/README.md b/README.md
index 8e06ae8..960ea45 100644
--- a/README.md
+++ b/README.md
@@ -17,6 +17,7 @@ When a scrub is in progess: https://i.imgur.com/YGmvZT4.png<br><br>
 *v1.7* (dak180)
  - Refactor to reduce dependence on awk
  - Use a separate config file
+ - Add support for conveyance test
 
 *v1.6.5* (rotx)
  - HTML boundary fix, proper message ids, support for dma mailer
diff --git a/report.sh b/report.sh
index 7fac4cd..8eb48bd 100755
--- a/report.sh
+++ b/report.sh
@@ -18,6 +18,7 @@
 # v1.7
 #   - Refactor to reduce dependence on awk
 #   - Use a separate config file
+#   - Add support for conveyance test
 # v1.6.5
 #   - HTML boundary fix, proper message ids, support for dma mailer
 #   - Better support for NVMe and SSD
@@ -1402,6 +1403,7 @@ for drive in "${drives[@]}"; do
             smartctl -l selftest "/dev/${drive}" | grep 'Num' | cut -c6- | head -1
             smartctl -l selftest "/dev/${drive}" | grep 'Extended' | cut -c6- | head -1
             smartctl -l selftest "/dev/${drive}" | grep 'Short' | cut -c6- | head -1
+            smartctl -l selftest "/dev/${drive}" | grep 'Conveyance' | cut -c6- | head -1
             echo '<br><br>'
         } >> "${logfile}"
 

From 632b1078570cf4d59602f40af19fefca1a7dce03 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 17 May 2021 11:37:22 -0400
Subject: [PATCH 046/160] Reduce calls to smartctl.

---
 report.sh | 27 +++++++++++++++------------
 1 file changed, 15 insertions(+), 12 deletions(-)

diff --git a/report.sh b/report.sh
index 8eb48bd..0b3e834 100755
--- a/report.sh
+++ b/report.sh
@@ -1389,32 +1389,35 @@ done
 
 ### SMART status for each drive
 for drive in "${drives[@]}"; do
-    if smartctl -i "/dev/${drive}" | grep -q "SMART support is: Enabled"; then
+    smartOut="$(smartctl --json=u -i "/dev/${drive}")"
+    smartTestOut="$(smartctl -l selftest "/dev/${drive}")"
+
+    if echo "${smartOut}" | grep -q "SMART support is: Enabled"; then
         # Gather brand and serial number of each drive
-        brand="$(smartctl -ij "/dev/${drive}" | jq -Mre '.model_family | values')"
+        brand="$(echo "${smartOut}" | jq -Mre '.model_family | values')"
         if [ -z "${brand}" ]; then
-            brand="$(smartctl -ij "/dev/${drive}" | jq -Mre '.model_name | values')";
+            brand="$(echo "${smartOut}" | jq -Mre '.model_name | values')";
         fi
-        serial="$(smartctl -ij "/dev/${drive}" | jq -Mre '.serial_number | values')"
+        serial="$(echo "${smartOut}" | jq -Mre '.serial_number | values')"
         {
             # Create a simple header and drop the output of some basic smartctl commands
             echo '<b>########## SMART status report for '"${drive}"' drive ('"${brand}: ${serial}"') ##########</b>'
             smartctl -H -A -l error "/dev/${drive}"
-            smartctl -l selftest "/dev/${drive}" | grep 'Num' | cut -c6- | head -1
-            smartctl -l selftest "/dev/${drive}" | grep 'Extended' | cut -c6- | head -1
-            smartctl -l selftest "/dev/${drive}" | grep 'Short' | cut -c6- | head -1
-            smartctl -l selftest "/dev/${drive}" | grep 'Conveyance' | cut -c6- | head -1
+            echo "${smartTestOut}" | grep 'Num' | cut -c6- | head -1
+            echo "${smartTestOut}" | grep 'Extended' | cut -c6- | head -1
+            echo "${smartTestOut}" | grep 'Short' | cut -c6- | head -1
+            echo "${smartTestOut}" | grep 'Conveyance' | cut -c6- | head -1
             echo '<br><br>'
         } >> "${logfile}"
 
     elif echo "${drive}" | grep -q "nvme"; then
+    	# NVMe drives are handled separately because self tests are not yet supported.
         # Gather brand and serial number of each drive
-		nvmeSmartOut="$(smartctl -aj "/dev/${drive}")"
-		brand="$(echo "${nvmeSmartOut}" | jq -Mre '.model_family | values')"
+		brand="$(echo "${smartOut}" | jq -Mre '.model_family | values')"
         if [ -z "${brand}" ]; then
-            brand="$(echo "${nvmeSmartOut}" | jq -Mre '.model_name | values')";
+            brand="$(echo "${smartOut}" | jq -Mre '.model_name | values')";
         fi
-		serial="$(echo "${nvmeSmartOut}" | jq -Mre '.serial_number | values')"
+		serial="$(echo "${smartOut}" | jq -Mre '.serial_number | values')"
 		{
 			# Create a simple header and drop the output of some basic smartctl commands
             echo '<b>########## SMART status report for '"${drive}"' drive ('"${brand}: ${serial}"') ##########</b>'

From 03a706d36d4989952e6bd1223e2d822650701369 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 17 May 2021 14:23:09 -0400
Subject: [PATCH 047/160] Add some notes about workarounds.

---
 report.sh | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/report.sh b/report.sh
index 0b3e834..3093a58 100755
--- a/report.sh
+++ b/report.sh
@@ -1269,6 +1269,7 @@ boundary="$(dbus-uuidgen)"
 messageid="$(dbus-uuidgen)"
 
 # Reorders the drives in ascending order
+# FixMe: smart support flag is not yet implemented in smartctl json output.
 readarray -t "drives" <<< "$(for drive in $(sysctl -n kern.disks | sed -e 's:nvd:nvme:g'); do
 	if smartctl -i "/dev/${drive}" | grep -q "SMART support is: Enabled"; then
 		printf "%s " "${drive}"
@@ -1389,10 +1390,10 @@ done
 
 ### SMART status for each drive
 for drive in "${drives[@]}"; do
-    smartOut="$(smartctl --json=u -i "/dev/${drive}")"
+    smartOut="$(smartctl --json=u -i "/dev/${drive}")" # FixMe: smart support flag is not yet implemented in smartctl json output.
     smartTestOut="$(smartctl -l selftest "/dev/${drive}")"
 
-    if echo "${smartOut}" | grep -q "SMART support is: Enabled"; then
+    if echo "${smartOut}" | grep -q "SMART support is: Enabled"; then # FixMe: smart support flag is not yet implemented in smartctl json output.
         # Gather brand and serial number of each drive
         brand="$(echo "${smartOut}" | jq -Mre '.model_family | values')"
         if [ -z "${brand}" ]; then

From 82c7d1af50744c3f175e5a722f94137dd9137190 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 17 May 2021 15:14:06 -0400
Subject: [PATCH 048/160] Less calls to smartctl is faster.

---
 report.sh | 51 +++++++++++++++++++++++++++++++++++----------------
 1 file changed, 35 insertions(+), 16 deletions(-)

diff --git a/report.sh b/report.sh
index 3093a58..d0238b7 100755
--- a/report.sh
+++ b/report.sh
@@ -490,14 +490,14 @@ function NVMeSummary () {
 	local altRow="false"
 	for drive in "${drives[@]}"; do
 		if echo "${drive}" | grep -q "nvme"; then
-			# For each drive detected, run "smartctl -Aij" and parse its output.
+			# For each drive detected, run "smartctl -AHij" and parse its output.
 			# Start by parsing variables used in other parts of the script.
 			# After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).
 			# After these computations, determine the row's background color (alternating as above, subbing in other colors from the palate as needed).
 			# Finally, print the HTML code for the current row of the table with all the gathered data.
 
 			# Get drive attributes
-			local nvmeSmarOut="$(smartctl -Aij "/dev/${drive}")"
+			local nvmeSmarOut="$(smartctl -AHij "/dev/${drive}")"
 
 			local model="$(echo "${nvmeSmarOut}" | jq -Mre '.model_name | values')"
 			local serial="$(echo "${nvmeSmarOut}" | jq -Mre '.serial_number | values')"
@@ -512,8 +512,13 @@ function NVMeSummary () {
 			local wearLeveling="$(echo "${nvmeSmarOut}" | jq -Mre '.nvme_smart_health_information_log.available_spare | values')"
 			local totalLBA="$(echo "${nvmeSmarOut}" | jq -Mre '.nvme_smart_health_information_log.data_units_written | values')"
 
-			local capacity="$(smartctl -i "/dev/${drive}" | grep '^Namespace 1 Size' | tr -s ' ' | cut -d ' ' -sf '5,6')"
-			local smartStatus="$(smartctl -H "/dev/${drive}" | grep "SMART overall-health" | cut -d ' ' -sf 6)"
+			local capacity="$(smartctl -i "/dev/${drive}" | grep '^Namespace 1 Size' | tr -s ' ' | cut -d ' ' -sf '5,6')" # FixMe: have not yet figured out how to best calculate this from json values
+
+			if [ "$(echo "${nvmeSmarOut}" | jq -Mre '.smart_status.passed | values')" = "true" ]; then
+				local smartStatus="PASSED"
+			else
+				local smartStatus="FAILED"
+			fi
 
 			# Get more useful times from hours
 			local testAge="$(bc <<< "(${onHours} - (${onHours} - 2) ) / 24")" # ${lastTestHours}
@@ -691,14 +696,14 @@ function SSDSummary () {
 	local drive
 	local altRow="false"
     for drive in "${drives[@]}"; do
-        if [ "$(smartctl -ij "/dev/${drive}" | jq -Mre '.rotation_rate | values')" = "0" ]; then
-			# For each drive detected, run "smartctl -Aijl selftest" and parse its output.
+    	local ssdInfoSmrt="$(smartctl -AHijl selftest "/dev/${drive}")"
+    	local rotTst="$(echo "${ssdInfoSmrt}" | jq -Mre '.rotation_rate | values')"
+        if [ "${rotTst}" = "0" ]; then
+			# For each drive detected, run "smartctl -AHijl selftest" and parse its output.
 			# Start by parsing out the variables used in other parts of the script.
 			# After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).
 			# After these computations, determine the row's background color (alternating as above, subbing in other colors from the palate as needed).
 			# Finally, print the HTML code for the current row of the table with all the gathered data.
-			local ssdInfoSmrt="$(smartctl -Aijl selftest "/dev/${drive}")"
-
 			local device="${drive}"
 
 			# Available if any tests have completed
@@ -706,10 +711,17 @@ function SSDSummary () {
 			local lastTestType="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].type.string | values')"
 
 			# Available for any drive smartd knows about
-			local smartStatus="$(smartctl -H "/dev/${drive}" | grep 'SMART overall-health' | cut -d ' ' -sf 6)"
+			if [ "$(echo "${ssdInfoSmrt}" | jq -Mre '.smart_status.passed | values')" = "true" ]; then
+				local smartStatus="PASSED"
+			else
+				local smartStatus="FAILED"
+			fi
+
 			local model="$(echo "${ssdInfoSmrt}" | jq -Mre '.model_name | values')"
 			local serial="$(echo "${ssdInfoSmrt}" | jq -Mre '.serial_number | values')"
-			local capacity="$(smartctl -i "/dev/${drive}" | grep '^User Capacity:' | tr -s ' ' | cut -d ' ' -sf '5,6')"
+
+			local capacity="$(smartctl -i "/dev/${drive}" | grep '^User Capacity:' | tr -s ' ' | cut -d ' ' -sf '5,6')" # FixMe: have not yet figured out how to best calculate this from json values
+
 			local temp="$(echo "${ssdInfoSmrt}"| jq -Mre '.temperature.current | values')"
 			local onHours="$(echo "${ssdInfoSmrt}" | jq -Mre '.power_on_time.hours | values')"
 			local startStop="$(echo "${ssdInfoSmrt}" | jq -Mre '.power_cycle_count | values')"
@@ -942,14 +954,14 @@ function HDDSummary () {
 	local drive
 	local altRow="false"
 	for drive in "${drives[@]}"; do
-		if smartctl -i "/dev/${drive}" | grep -q "SMART support is: Enabled" && [ ! "$(smartctl -ij "/dev/${drive}" | jq -Mre '.rotation_rate | values')" = "0" ]; then
-			# For each drive detected, run "smartctl -Aijl selftest" and parse its output.
+		local hddInfoSmrt="$(smartctl -AHijl selftest "/dev/${drive}")"
+		local rotTst="$(echo "${hddInfoSmrt}" | jq -Mre '.rotation_rate | values')"
+		if [ ! "${rotTst:="0"}" = "0" ]; then
+			# For each drive detected, run "smartctl -AHijl selftest" and parse its output.
 			# After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).
 			# After these computations, determine the row's background color (alternating as above, subbing in other colors from the palate as needed).
 			# Finally, print the HTML code for the current row of the table with all the gathered data.
 
-			local hddInfoSmrt="$(smartctl -Aijl selftest "/dev/${drive}")"
-
 			local device="${drive}"
 
 			# Available if any tests have completed
@@ -957,11 +969,18 @@ function HDDSummary () {
 			local lastTestType="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].type.string | values')"
 
 			# Available for any drive smartd knows about
-			local smartStatus="$(smartctl -H "/dev/${drive}" | grep 'SMART overall-health' | cut -d ' ' -sf 6)"
+			if [ "$(echo "${hddInfoSmrt}" | jq -Mre '.smart_status.passed | values')" = "true" ]; then
+				local smartStatus="PASSED"
+			else
+				local smartStatus="FAILED"
+			fi
+
 			local model="$(echo "${hddInfoSmrt}" | jq -Mre '.model_name | values')"
 			local serial="$(echo "${hddInfoSmrt}" | jq -Mre '.serial_number | values')"
 			local rpm="$(echo "${hddInfoSmrt}" | jq -Mre '.rotation_rate | values')"
-			local capacity="$(smartctl -i "/dev/${drive}" | grep '^User Capacity:' | tr -s ' ' | cut -d ' ' -sf '5,6')"
+
+			local capacity="$(smartctl -i "/dev/${drive}" | grep '^User Capacity:' | tr -s ' ' | cut -d ' ' -sf '5,6')" # FixMe: have not yet figured out how to best calculate this from json values
+
 			local temp="$(echo "${hddInfoSmrt}"| jq -Mre '.temperature.current | values')"
 			local onHours="$(echo "${hddInfoSmrt}" | jq -Mre '.power_on_time.hours | values')"
 			local startStop="$(echo "${hddInfoSmrt}" | jq -Mre '.power_cycle_count | values')"

From c099699c0e26a0880078b5cb87843c76f67f40b9 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 17 May 2021 17:58:51 -0400
Subject: [PATCH 049/160] Standardize colorizing the rows.

Also fix indentation.
---
 report.sh | 33 +++++++++++++++++----------------
 1 file changed, 17 insertions(+), 16 deletions(-)

diff --git a/report.sh b/report.sh
index d0238b7..5746349 100755
--- a/report.sh
+++ b/report.sh
@@ -186,7 +186,6 @@ function ConfigBackup () {
 }
 
 function ZpoolSummary () {
-	local poolNum
 	local pool
 	local status
 	local frag
@@ -215,6 +214,7 @@ function ZpoolSummary () {
 	local scrubErrorsColor
 	local scrubAgeColor
 	local multiDay
+	local altRow
 
 
 	### zpool status summary table
@@ -242,7 +242,7 @@ function ZpoolSummary () {
 	} >> "${logfile}"
 
 
-	poolNum="0"
+	altRow="false"
 	for pool in "${pools[@]}"; do
 
 		# zpool health summary
@@ -323,16 +323,16 @@ function ZpoolSummary () {
 
 		# if status is resilvered
 		elif [ "$(echo "${statusOutput}" | grep "scan:" | awk '{print $2}')" = "resilvered" ]; then
-				resilver="<BR>Resilvered"
-				scrubRepBytes="$(echo "${statusOutput}" | grep "scan:" | awk '{print $3}')"
-				scrubErrors="$(echo "${statusOutput}" | grep "scan:" | awk '{print $9}')"
+			resilver="<BR>Resilvered"
+			scrubRepBytes="$(echo "${statusOutput}" | grep "scan:" | awk '{print $3}')"
+			scrubErrors="$(echo "${statusOutput}" | grep "scan:" | awk '{print $9}')"
 
-				# Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
-				scrubDate="$(echo "${statusOutput}" | grep "scan:" | awk '{print $16"-"$13"-"$14"_"$15}')"
-				scrubTS="$(date -j -f '%Y-%b-%e_%H:%M:%S' "${scrubDate}" '+%s')"
-				currentTS="${runDate}"
-				scrubAge="$((((currentTS - scrubTS) + 43200) / 86400))"
-				scrubTime="$(echo "${statusOutput}" | grep "scan:" | awk '{print $7}')"
+			# Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
+			scrubDate="$(echo "${statusOutput}" | grep "scan:" | awk '{print $16"-"$13"-"$14"_"$15}')"
+			scrubTS="$(date -j -f '%Y-%b-%e_%H:%M:%S' "${scrubDate}" '+%s')"
+			currentTS="${runDate}"
+			scrubAge="$((((currentTS - scrubTS) + 43200) / 86400))"
+			scrubTime="$(echo "${statusOutput}" | grep "scan:" | awk '{print $7}')"
 
 		# Check if resilver is in progress
 		elif [ "$(echo "${statusOutput}"| grep "scan:" | awk '{print $2}')" = "resilver" ]; then
@@ -356,13 +356,14 @@ function ZpoolSummary () {
 			fi
 		fi
 
-		# Set row's background color; alternates between white and $altColor (light gray)
-		if [ "$((poolNum % 2))" = "1" ]; then
-			bgColor="#ffffff"
+		# Set the row background color
+		if [ "${altRow}" = "false" ]; then
+			local bgColor="#ffffff"
+			altRow="true"
 		else
-			bgColor="$altColor"
+			local bgColor="${altColor}"
+			altRow="false"
 		fi
-		poolNum="$((poolNum + 1))"
 
 		# Set up conditions for warning or critical colors to be used in place of standard background colors
 		if [ ! "${status}" = "ONLINE" ]; then

From 12507b8b7934af438da32a9896fb6ac2a53f29ce Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Wed, 18 Aug 2021 10:49:07 -0400
Subject: [PATCH 050/160] Also backup the secret seed.

---
 report.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/report.sh b/report.sh
index 5746349..5698100 100755
--- a/report.sh
+++ b/report.sh
@@ -152,11 +152,12 @@ function ConfigBackup () {
     else
         # Config integrity check passed; copy config db, generate checksums, make .tar.gz archive
         sqlite3 "/data/freenas-v1.db" ".backup main /tmp/${filename}.db"
+        cp -f "/data/pwenc_secret" "/tmp/"
         md5 "/tmp/${filename}.db" > /tmp/config_backup.md5
         sha256 "/tmp/${filename}.db" > /tmp/config_backup.sha256
         (
             cd "/tmp/" || exit;
-            tar -czf "${tarfile}" "./${filename}.db" "./config_backup.md5" "./config_backup.sha256"
+            tar -czf "${tarfile}" "./${filename}.db" "./config_backup.md5" "./config_backup.sha256" "./pwenc_secret"
         )
         {
 			if [ "${emailBackup}" = "true" ]; then

From 6790c85ae1f5c5dd76c6478300d07f58ff493c23 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 22 Aug 2021 18:01:55 -0400
Subject: [PATCH 051/160] Get the whole array.

---
 report.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/report.sh b/report.sh
index 5698100..d157daa 100755
--- a/report.sh
+++ b/report.sh
@@ -1309,7 +1309,7 @@ if [ "${includeSSD}" = "true" ]; then
             ssdExist="false"
         fi
     done
-    if echo "${drives}" | grep -q "nvme"; then
+    if echo "${drives[*]}" | grep -q "nvme"; then
     	NVMeExist="true"
     fi
 fi

From 71b4f4add7a1fabc37af96f597a8a1746ff7c997 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 22 Aug 2021 18:03:04 -0400
Subject: [PATCH 052/160] correct quoting.

---
 report.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/report.sh b/report.sh
index d157daa..25a1099 100755
--- a/report.sh
+++ b/report.sh
@@ -608,9 +608,9 @@ function NVMeSummary () {
 
 			# Colorize & derive write stats
 			local totalBW="$(bc <<< "scale=1; (${totalLBA} * ${sectorSize}) / (1024^4)" | sed -e 's:^\.:0.:')"
-			if (( $(bc -l <<< "${totalBW}" > "${totalBWCrit}") )); then
+			if (( $(bc -l <<< "${totalBW} > ${totalBWCrit}") )); then
 				local totalBWColor="${critColor}"
-			elif (( $(bc -l <<< "${totalBW}" > "${totalBWWarn}") )); then
+			elif (( $(bc -l <<< "${totalBW} > ${totalBWWarn}") )); then
 				local totalBWColor="${warnColor}"
 			else
 				local totalBWColor="${bgColor}"
@@ -864,9 +864,9 @@ function SSDSummary () {
 
 			# Colorize & derive write stats
 			local totalBW="$(bc <<< "scale=1; (${totalLBA} * ${sectorSize}) / (1024^4)" | sed -e 's:^\.:0.:')"
-			if (( $(bc -l <<< "${totalBW}" > "${totalBWCrit}") )); then
+			if (( $(bc -l <<< "${totalBW} > ${totalBWCrit}") )); then
 				local totalBWColor="${critColor}"
-			elif (( $(bc -l <<< "${totalBW}" > "${totalBWWarn}") )); then
+			elif (( $(bc -l <<< "${totalBW} > ${totalBWWarn}") )); then
 				local totalBWColor="${warnColor}"
 			else
 				local totalBWColor="${bgColor}"

From 059e8529c37f646c545f465bfce2e840ec45ddf4 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 23 Aug 2021 18:00:49 -0400
Subject: [PATCH 053/160] Fix math on NVMe write stats.

---
 report.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/report.sh b/report.sh
index 25a1099..14f31d1 100755
--- a/report.sh
+++ b/report.sh
@@ -607,7 +607,7 @@ function NVMeSummary () {
 			fi
 
 			# Colorize & derive write stats
-			local totalBW="$(bc <<< "scale=1; (${totalLBA} * ${sectorSize}) / (1024^4)" | sed -e 's:^\.:0.:')"
+			local totalBW="$(bc <<< "scale=1; (${totalLBA} * ${sectorSize}) / (1024^3)" | sed -e 's:^\.:0.:')"
 			if (( $(bc -l <<< "${totalBW} > ${totalBWCrit}") )); then
 				local totalBWColor="${critColor}"
 			elif (( $(bc -l <<< "${totalBW} > ${totalBWWarn}") )); then
@@ -620,7 +620,7 @@ function NVMeSummary () {
 			else
 				totalBW="${totalBW}TB"
 			fi
-			local bwPerDay="$(bc <<< "scale=1; (((${totalLBA} * ${sectorSize}) / (1024^4)) * 1024) / (${onHours} / 24)" | sed -e 's:^\.:0.:')"
+			local bwPerDay="$(bc <<< "scale=1; (((${totalLBA} * ${sectorSize}) / (1024^3)) * 1024) / (${onHours} / 24)" | sed -e 's:^\.:0.:')"
 			if [ "${bwPerDay}" = "0.0" ]; then
 				bwPerDay="N/A"
 			else

From 841be1f81e77dffd8da85522fdf38364d8b1566d Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Wed, 1 Sep 2021 00:32:55 -0400
Subject: [PATCH 054/160] Fix units.

---
 report.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/report.sh b/report.sh
index 14f31d1..663aeb3 100755
--- a/report.sh
+++ b/report.sh
@@ -607,7 +607,7 @@ function NVMeSummary () {
 			fi
 
 			# Colorize & derive write stats
-			local totalBW="$(bc <<< "scale=1; (${totalLBA} * ${sectorSize}) / (1024^3)" | sed -e 's:^\.:0.:')"
+			local totalBW="$(bc <<< "scale=1; (${totalLBA} * ${sectorSize}) / (1000^3)" | sed -e 's:^\.:0.:')"
 			if (( $(bc -l <<< "${totalBW} > ${totalBWCrit}") )); then
 				local totalBWColor="${critColor}"
 			elif (( $(bc -l <<< "${totalBW} > ${totalBWWarn}") )); then
@@ -620,7 +620,7 @@ function NVMeSummary () {
 			else
 				totalBW="${totalBW}TB"
 			fi
-			local bwPerDay="$(bc <<< "scale=1; (((${totalLBA} * ${sectorSize}) / (1024^3)) * 1024) / (${onHours} / 24)" | sed -e 's:^\.:0.:')"
+			local bwPerDay="$(bc <<< "scale=1; (((${totalLBA} * ${sectorSize}) / (1000^3)) * 1000) / (${onHours} / 24)" | sed -e 's:^\.:0.:')"
 			if [ "${bwPerDay}" = "0.0" ]; then
 				bwPerDay="N/A"
 			else
@@ -863,7 +863,7 @@ function SSDSummary () {
 			fi
 
 			# Colorize & derive write stats
-			local totalBW="$(bc <<< "scale=1; (${totalLBA} * ${sectorSize}) / (1024^4)" | sed -e 's:^\.:0.:')"
+			local totalBW="$(bc <<< "scale=1; (${totalLBA} * ${sectorSize}) / (1000^4)" | sed -e 's:^\.:0.:')"
 			if (( $(bc -l <<< "${totalBW} > ${totalBWCrit}") )); then
 				local totalBWColor="${critColor}"
 			elif (( $(bc -l <<< "${totalBW} > ${totalBWWarn}") )); then
@@ -876,7 +876,7 @@ function SSDSummary () {
 			else
 				totalBW="${totalBW}TB"
 			fi
-			local bwPerDay="$(bc <<< "scale=1; (((${totalLBA} * ${sectorSize}) / (1024^4)) * 1024) / (${onHours} / 24)" | sed -e 's:^\.:0.:')"
+			local bwPerDay="$(bc <<< "scale=1; (((${totalLBA} * ${sectorSize}) / (1000^4)) * 1000) / (${onHours} / 24)" | sed -e 's:^\.:0.:')"
 			if [ "${bwPerDay}" = "0.0" ]; then
 				bwPerDay="N/A"
 			else

From b7f175fce019bd68bf5ac0d3b23bf2d221f18187 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Wed, 1 Sep 2021 00:46:15 -0400
Subject: [PATCH 055/160] Support more drives.

---
 report.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/report.sh b/report.sh
index 663aeb3..b3da96c 100755
--- a/report.sh
+++ b/report.sh
@@ -752,6 +752,8 @@ function SSDSummary () {
 				local Host_Writes="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 241) | .name | values')"
 				if echo "${Host_Writes}" | grep -q 'GiB'; then
 					totalLBA="$(bc <<< "( ${totalLBA} * (1024^3) ) / ${sectorSize}")"
+				elif echo "${Host_Writes}" | grep -q 'GB'; then
+					totalLBA="$(bc <<< "( ${totalLBA} * (1000^3) ) / ${sectorSize}")"
 				elif echo "${Host_Writes}" | grep -q '32MiB'; then
 					totalLBA="$(bc <<< "( (${totalLBA} * 32) * (1024^2) ) / ${sectorSize}")"
 				else

From febe4e72b36dad92d930036faf108ecf29af790f Mon Sep 17 00:00:00 2001
From: Anthony <syserr0r@users.noreply.github.com>
Date: Thu, 9 Sep 2021 17:29:02 +0100
Subject: [PATCH 056/160] Add Wear_Leveling_Count for some Samsung SSDs

Samsung 870-series SSDs
---
 report.sh | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/report.sh b/report.sh
index b3da96c..ccf4436 100755
--- a/report.sh
+++ b/report.sh
@@ -742,6 +742,9 @@ function SSDSummary () {
 				wearLeveling="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 231) | .value | values')"
 				if [ -z "${wearLeveling}" ]; then
 					wearLeveling="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 233) | .value | values')"
+					if [ -z "${wearLeveling}" ]; then
+						wearLeveling="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 177) | .value | values')"
+					fi
 				fi
 			fi
 

From 437393e3bb867349363652d5daa0f122d4920c72 Mon Sep 17 00:00:00 2001
From: Zane Chua <4265429+zanechua@users.noreply.github.com>
Date: Mon, 20 Sep 2021 14:19:01 +0800
Subject: [PATCH 057/160] use system configured from name and from email

---
 report.sh | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/report.sh b/report.sh
index b3da96c..85e8cb7 100755
--- a/report.sh
+++ b/report.sh
@@ -1285,6 +1285,8 @@ fi
 
 ###### Auto-generated Parameters
 host="$(hostname -s)"
+fromEmail="$(sqlite3 /data/freenas-v1.db "select em_fromemail from system_email;")"
+fromName="$(sqlite3 /data/freenas-v1.db "select em_fromname from system_email;")"
 runDate="$(date '+%s')"
 logfile="${logfileLocation}/$(date -r "${runDate}" '+%Y%m%d%H%M%S')_${logfileName}.tmp"
 subject="Status Report and Configuration Backup for ${host} - $(date -r "${runDate}" '+%Y-%m-%d %H:%M')"
@@ -1333,7 +1335,7 @@ readarray -t "pools" <<< "$(zpool list -H -o name)"
 ###### Email pre-formatting
 ### Set email headers
 {
-    echo "From: ${host} <root@$(hostname)>"
+    echo "From: ${fromName} <${fromEmail}>"
     echo "To: ${email}"
     echo "Subject: ${subject}"
     echo "MIME-Version: 1.0"

From 9d3a0b19ea6eafd2b7b4cb93fcbd1d87235ffaf3 Mon Sep 17 00:00:00 2001
From: Zane Chua <4265429+zanechua@users.noreply.github.com>
Date: Mon, 20 Sep 2021 14:37:58 +0800
Subject: [PATCH 058/160] Update README

---
 README.md | 52 ++++++++++++++++++++++++++++++++++++++++++----------
 1 file changed, 42 insertions(+), 10 deletions(-)

diff --git a/README.md b/README.md
index 960ea45..0fad9bf 100644
--- a/README.md
+++ b/README.md
@@ -1,18 +1,43 @@
 # ZPool, SMART, and UPS Status Report with TrueNAS Config Backup
-Original Script By: joeschmuck<br>
-Modified By: bidelu0hm, melp, fohlsso2, onlinepcwizard, ninpucho, isentropik, rotx, dak180<br>
-Last Edited By: dak180
 
-Preview of the output here: https://i.imgur.com/jKwraw4.png<br>
-When a resilver is in progress: https://i.imgur.com/CUNUZ7r.png<br>
-After the resilver is done: https://i.imgur.com/I43MLLf.png<br>
-When a scrub is in progess: https://i.imgur.com/YGmvZT4.png<br><br>
+**Current Version: v1.7**
 
-**At a minimum, enter email address and set defaultFile to 0 in the generated config file. Feel free to edit other user parameters as needed. Backup has been disabled by default so if it is required please set to true.**<br><br>
+Preview of the output here: https://i.imgur.com/jKwraw4.png
 
-**Current Version: v1.7**
+When a resilver is in progress: https://i.imgur.com/CUNUZ7r.png
+
+After the resilver is done: https://i.imgur.com/I43MLLf.png
+
+When a scrub is in progess: https://i.imgur.com/YGmvZT4.png
+
+# Get Started
+
+Place the script under a user `/home/user` or in one of your pools.
+
+Create a Cron Job with the following configuration:
+
+```
+Description: Run Smart Report
+Command: /mnt/pool/storage/smartreport.sh -c /mnt/pool/storage/smartreport.conf
+Run as: root
+Schedule: Daily
+Hide Standard Output: **Checked**
+Enabled: **Checked**
+```
+
+Click `Submit` and then `Run Now`.
 
-**Changelog:**
+A configuration file will be generated at `/mnt/pool/storage/smartreport.conf`
+
+Make sure the email credentials are configured in `System -> Email`. 
+
+> `From Email` and `From Name` are required
+
+At a minimum, enter an email address for the report to be sent to and set `defaultFile` to 0 in the generated config file. Feel free to edit other user parameters as needed. Backup has been disabled by default so if it is required please set to true.
+
+Once you have updated the config file, click `Run Now` again to generate your first report.
+
+# Changelog
 
 *v1.7* (dak180)
  - Refactor to reduce dependence on awk
@@ -77,3 +102,10 @@ When a scrub is in progess: https://i.imgur.com/YGmvZT4.png<br><br>
 
 *v1.0*
 - Initial release
+
+# Contributors
+Original Script By: joeschmuck
+
+Modified By: bidelu0hm, melp, fohlsso2, onlinepcwizard, ninpucho, isentropik, rotx, dak180
+
+Last Edited By: dak180

From cc0da0c7de77ac7d2b086d4f5ac7ac74bf60364c Mon Sep 17 00:00:00 2001
From: Zane Chua <4265429+zanechua@users.noreply.github.com>
Date: Tue, 21 Sep 2021 01:46:00 +0800
Subject: [PATCH 059/160] Update README about SMART tests

---
 README.md | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/README.md b/README.md
index 0fad9bf..359aac2 100644
--- a/README.md
+++ b/README.md
@@ -22,6 +22,7 @@ Command: /mnt/pool/storage/smartreport.sh -c /mnt/pool/storage/smartreport.conf
 Run as: root
 Schedule: Daily
 Hide Standard Output: **Checked**
+Hide Standard Error: **Unchecked**
 Enabled: **Checked**
 ```
 
@@ -37,6 +38,14 @@ At a minimum, enter an email address for the report to be sent to and set `defau
 
 Once you have updated the config file, click `Run Now` again to generate your first report.
 
+# SMART Tests
+
+You should also configure running your smart tests otherwise the script will not include smart test results and will generate an additional error unless you checked `Hide Standard Error` in the cron job.
+
+You can configure a `SHORT` SMART test to run daily at 11pm before the report is generated.
+
+A `LONG` SMART test can be configured to run once a month.
+
 # Changelog
 
 *v1.7* (dak180)

From a9121e5a9ccd28259350e2ec360ee724ad91fc6c Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 10 Oct 2021 10:20:13 -0400
Subject: [PATCH 060/160] Fix resliver output for TrueNAS 12.

---
 report.sh | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/report.sh b/report.sh
index b3da96c..2fd1d0e 100755
--- a/report.sh
+++ b/report.sh
@@ -326,24 +326,20 @@ function ZpoolSummary () {
 		elif [ "$(echo "${statusOutput}" | grep "scan:" | awk '{print $2}')" = "resilvered" ]; then
 			resilver="<BR>Resilvered"
 			scrubRepBytes="$(echo "${statusOutput}" | grep "scan:" | awk '{print $3}')"
-			scrubErrors="$(echo "${statusOutput}" | grep "scan:" | awk '{print $9}')"
+			scrubErrors="$(echo "${statusOutput}" | grep "scan:" | awk '{print $7}')"
 
 			# Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
-			scrubDate="$(echo "${statusOutput}" | grep "scan:" | awk '{print $16"-"$13"-"$14"_"$15}')"
+			scrubDate="$(echo "${statusOutput}" | grep "scan:" | awk '{print $14"-"$11"-"$12"_"$13}')"
 			scrubTS="$(date -j -f '%Y-%b-%e_%H:%M:%S' "${scrubDate}" '+%s')"
 			currentTS="${runDate}"
 			scrubAge="$((((currentTS - scrubTS) + 43200) / 86400))"
-			scrubTime="$(echo "${statusOutput}" | grep "scan:" | awk '{print $7}')"
+			scrubTime="$(echo "${statusOutput}" | grep "scan:" | awk '{print $5}')"
 
 		# Check if resilver is in progress
 		elif [ "$(echo "${statusOutput}"| grep "scan:" | awk '{print $2}')" = "resilver" ]; then
 			scrubRepBytes="Resilver In Progress"
 			scrubAge="$(echo "${statusOutput}" | grep "resilvered," | awk '{print $3" done"}')"
-			if [ "$(echo "${statusOutput}" | grep "resilvered," | awk '{print $5}')" = "0" ]; then
-				scrubTime="$(echo "${statusOutput}" | grep "resilvered," | awk '{print $7"<br>to go"}')"
-			else
-				scrubTime="$(echo "${statusOutput}" | grep "resilvered," | awk '{print $5" "$6" "$7"<br>to go"}')"
-			fi
+			scrubTime="$(echo "${statusOutput}" | grep "resilvered," | awk '{print $5"<br>to go"}')"
 
 		# Check if scrub is in progress
 		elif [ "$(echo "${statusOutput}"| grep "scan:" | awk '{print $4}')" = "progress" ]; then

From ff5fb35835ff377f36a86a7a40b4fd453ac7a7c6 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 10 Oct 2021 10:23:50 -0400
Subject: [PATCH 061/160] More reliable way to get LBAs written.

---
 report.sh | 19 +++----------------
 1 file changed, 3 insertions(+), 16 deletions(-)

diff --git a/report.sh b/report.sh
index 2fd1d0e..6f8aeb1 100755
--- a/report.sh
+++ b/report.sh
@@ -694,7 +694,7 @@ function SSDSummary () {
 	local drive
 	local altRow="false"
     for drive in "${drives[@]}"; do
-    	local ssdInfoSmrt="$(smartctl -AHijl selftest "/dev/${drive}")"
+		local ssdInfoSmrt="$(smartctl -AHijl selftest --log="devstat" "/dev/${drive}")"
     	local rotTst="$(echo "${ssdInfoSmrt}" | jq -Mre '.rotation_rate | values')"
         if [ "${rotTst}" = "0" ]; then
 			# For each drive detected, run "smartctl -AHijl selftest" and parse its output.
@@ -741,21 +741,8 @@ function SSDSummary () {
 				fi
 			fi
 
-			# No standard attribute or recording method for data writen
-			local totalLBA="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 246) | .raw.value | values')"
-			if [ -z "${totalLBA}" ]; then
-				totalLBA="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 241) | .raw.value | values')"
-				local Host_Writes="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 241) | .name | values')"
-				if echo "${Host_Writes}" | grep -q 'GiB'; then
-					totalLBA="$(bc <<< "( ${totalLBA} * (1024^3) ) / ${sectorSize}")"
-				elif echo "${Host_Writes}" | grep -q 'GB'; then
-					totalLBA="$(bc <<< "( ${totalLBA} * (1000^3) ) / ${sectorSize}")"
-				elif echo "${Host_Writes}" | grep -q '32MiB'; then
-					totalLBA="$(bc <<< "( (${totalLBA} * 32) * (1024^2) ) / ${sectorSize}")"
-				else
-					totalLBA="0"
-				fi
-			fi
+			# Get LBA written from the stats page for data writen
+			local totalLBA="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_device_statistics.pages[0].table[] | select(.name == "Logical Sectors Written") | .value | values')"
 
 
 			# Get more useful times from hours

From 03e1bc2ea94a7c97c92874ebc5bb0e5aa0d9d73c Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 10 Oct 2021 10:26:00 -0400
Subject: [PATCH 062/160] Account for the case of no tests run.

---
 report.sh | 24 ++++++++++++++++--------
 1 file changed, 16 insertions(+), 8 deletions(-)

diff --git a/report.sh b/report.sh
index 6f8aeb1..4b905d8 100755
--- a/report.sh
+++ b/report.sh
@@ -746,7 +746,11 @@ function SSDSummary () {
 
 
 			# Get more useful times from hours
-			local testAge="$(bc <<< "(${onHours} - ${lastTestHours}) / 24")"
+			local testAge
+			if [ ! -z "${lastTestHours}" ]; then
+				testAge="$(bc <<< "(${onHours} - ${lastTestHours}) / 24")"
+			fi
+
 			local yrs="$(bc <<< "${onHours} / 8760")"
 			local mos="$(bc <<< "(${onHours} % 8760) / 730")"
 			local dys="$(bc <<< "((${onHours} % 8760) % 730) / 24")"
@@ -869,7 +873,7 @@ function SSDSummary () {
 			fi
 
 			# Colorize test age
-			if [ "${testAge}" -gt "${testAgeWarn}" ]; then
+			if [ "${testAge:-0}" -gt "${testAgeWarn}" ]; then
 				testAgeColor="${critColor}"
 			else
 				testAgeColor="${bgColor}"
@@ -895,8 +899,8 @@ function SSDSummary () {
 				echo '<td style="text-align:center; background-color:'"${wearLevelingColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${wearLeveling}"'%</td>'
 				echo '<td style="text-align:center; background-color:'"${totalBWColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${totalBW}"'</td>'
 				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${bwPerDay}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${testAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${testAge}"'</td>'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${lastTestType}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${testAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${testAge:-"N/A"}"'</td>'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${lastTestType:-"N/A"}"'</td>'
 				echo '</tr>'
             } >> "${logfile}"
         fi
@@ -983,7 +987,11 @@ function HDDSummary () {
 
 
 			# Get more useful times from hours
-			local testAge="$(bc <<< "(${onHours} - ${lastTestHours}) / 24")"
+			local testAge
+			if [ ! -z "${lastTestHours}" ]; then
+				testAge="$(bc <<< "(${onHours} - ${lastTestHours}) / 24")"
+			fi
+
 			local yrs="$(bc <<< "${onHours} / 8760")"
 			local mos="$(bc <<< "(${onHours} % 8760) / 730")"
 			local dys="$(bc <<< "((${onHours} % 8760) % 730) / 24")"
@@ -1088,7 +1096,7 @@ function HDDSummary () {
 			fi
 
 			# Colorize test age
-			if [ "${testAge}" -gt "${testAgeWarn}" ]; then
+			if [ "${testAge:-0}" -gt "${testAgeWarn}" ]; then
 				testAgeColor="${critColor}"
 			else
 				testAgeColor="${bgColor}"
@@ -1114,8 +1122,8 @@ function HDDSummary () {
 				echo '<td style="text-align:center; background-color:'"${offlineUncColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${offlineUnc}"'</td>'
 				echo '<td style="text-align:center; background-color:'"${crcErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${crcErrors}"'</td>'
 				echo '<td style="text-align:center; background-color:'"${seekErrorHealthColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${seekErrorHealth}"'%</td>'
-				echo '<td style="text-align:center; background-color:'"${testAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${testAge}"'</td>'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${lastTestType}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${testAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${testAge:-"N/A"}"'</td>'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${lastTestType:-"N/A"}"'</td>'
 				echo '</tr>'
 			} >> "${logfile}"
 		fi

From cf76fa81543d2d542a77d4c578cf6bb204dfac10 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Fri, 17 Dec 2021 15:09:39 -0500
Subject: [PATCH 063/160] Update Readme to note first time configuration
 changes.

---
 README.md | 8 +++++++-
 report.sh | 2 +-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index 960ea45..2491ad2 100644
--- a/README.md
+++ b/README.md
@@ -8,7 +8,13 @@ When a resilver is in progress: https://i.imgur.com/CUNUZ7r.png<br>
 After the resilver is done: https://i.imgur.com/I43MLLf.png<br>
 When a scrub is in progess: https://i.imgur.com/YGmvZT4.png<br><br>
 
-**At a minimum, enter email address and set defaultFile to 0 in the generated config file. Feel free to edit other user parameters as needed. Backup has been disabled by default so if it is required please set to true.**<br><br>
+### Usage
+
+`./report.sh -c ./report.cfg`
+
+**report.cfg** will be created if it does not exist and populated with default values.
+
+**At a minimum, enter an email address and set defaultFile to 0 in the generated config file. Feel free to edit other user parameters as needed. Backup has been disabled by default so if it is required please set to true.**<br><br>
 
 **Current Version: v1.7**
 
diff --git a/report.sh b/report.sh
index 4b905d8..baaf013 100755
--- a/report.sh
+++ b/report.sh
@@ -1215,7 +1215,7 @@ while getopts ":c:" OPTION; do
 done
 
 if [ -z "${configFile}" ]; then
-	echo "Please specify a config file location." >&2
+	echo "Please specify a config file location; if none exist one will be created." >&2
 	exit 1
 elif [ ! -f "${configFile}" ]; then
 	rpConfig

From b84ea2abe42359a9460ba044ff099fc42364aad6 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 20 Dec 2021 02:01:04 -0500
Subject: [PATCH 064/160] Use sane defaults for from email.

Reformat the readme.
---
 README.md | 27 ++++++++-------------------
 report.sh |  2 +-
 2 files changed, 9 insertions(+), 20 deletions(-)

diff --git a/README.md b/README.md
index 359aac2..131e9ec 100644
--- a/README.md
+++ b/README.md
@@ -3,14 +3,16 @@
 **Current Version: v1.7**
 
 Preview of the output here: https://i.imgur.com/jKwraw4.png
-
 When a resilver is in progress: https://i.imgur.com/CUNUZ7r.png
-
 After the resilver is done: https://i.imgur.com/I43MLLf.png
-
 When a scrub is in progess: https://i.imgur.com/YGmvZT4.png
 
-# Get Started
+# SMART Tests
+
+You should also configure running your smart tests otherwise the script will not include smart test results and will generate an additional error unless you checked `Hide Standard Error` in the cron job.
+
+
+# Getting Started
 
 Place the script under a user `/home/user` or in one of your pools.
 
@@ -18,7 +20,7 @@ Create a Cron Job with the following configuration:
 
 ```
 Description: Run Smart Report
-Command: /mnt/pool/storage/smartreport.sh -c /mnt/pool/storage/smartreport.conf
+Command: /path/to/script/smartreport.sh -c /path/to/script/smartreport.conf
 Run as: root
 Schedule: Daily
 Hide Standard Output: **Checked**
@@ -28,23 +30,12 @@ Enabled: **Checked**
 
 Click `Submit` and then `Run Now`.
 
-A configuration file will be generated at `/mnt/pool/storage/smartreport.conf`
-
-Make sure the email credentials are configured in `System -> Email`. 
-
-> `From Email` and `From Name` are required
+A configuration file will be generated at `/path/to/script/smartreport.conf`
 
 At a minimum, enter an email address for the report to be sent to and set `defaultFile` to 0 in the generated config file. Feel free to edit other user parameters as needed. Backup has been disabled by default so if it is required please set to true.
 
 Once you have updated the config file, click `Run Now` again to generate your first report.
 
-# SMART Tests
-
-You should also configure running your smart tests otherwise the script will not include smart test results and will generate an additional error unless you checked `Hide Standard Error` in the cron job.
-
-You can configure a `SHORT` SMART test to run daily at 11pm before the report is generated.
-
-A `LONG` SMART test can be configured to run once a month.
 
 # Changelog
 
@@ -114,7 +105,5 @@ A `LONG` SMART test can be configured to run once a month.
 
 # Contributors
 Original Script By: joeschmuck
-
 Modified By: bidelu0hm, melp, fohlsso2, onlinepcwizard, ninpucho, isentropik, rotx, dak180
-
 Last Edited By: dak180
diff --git a/report.sh b/report.sh
index 85e8cb7..d41cf90 100755
--- a/report.sh
+++ b/report.sh
@@ -1335,7 +1335,7 @@ readarray -t "pools" <<< "$(zpool list -H -o name)"
 ###### Email pre-formatting
 ### Set email headers
 {
-    echo "From: ${fromName} <${fromEmail}>"
+    echo "From: ${fromName:=${host}} <${fromEmail:=root@$(hostname)}>"
     echo "To: ${email}"
     echo "Subject: ${subject}"
     echo "MIME-Version: 1.0"

From 3596e3797239233f3247eb7339e2ba4b8163ef6e Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 20 Dec 2021 12:24:28 -0500
Subject: [PATCH 065/160] Fail unknown wear leveling gracefully.

Refs #4.
---
 report.sh | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/report.sh b/report.sh
index d70462a..2041bd0 100755
--- a/report.sh
+++ b/report.sh
@@ -846,12 +846,14 @@ function SSDSummary () {
 			fi
 
 			# Colorize Wear Leveling
-			if [ "${wearLeveling}" -le "${lifeRemainCrit}" ]; then
-				local wearLevelingColor="${critColor}"
-			elif [ "${wearLeveling}" -le "${lifeRemainWarn}" ]; then
-				local wearLevelingColor="${warnColor}"
-			else
-				local wearLevelingColor="${bgColor}"
+			if [ ! -z "${wearLeveling}" ]; then
+				if [ "${wearLeveling}" -le "${lifeRemainCrit}" ]; then
+					local wearLevelingColor="${critColor}"
+				elif [ "${wearLeveling}" -le "${lifeRemainWarn}" ]; then
+					local wearLevelingColor="${warnColor}"
+				else
+					local wearLevelingColor="${bgColor}"
+				fi
 			fi
 
 			# Colorize & derive write stats
@@ -899,7 +901,7 @@ function SSDSummary () {
 				echo '<td style="text-align:center; background-color:'"${eraseFailColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${eraseFail}"'</td>'
 				echo '<td style="text-align:center; background-color:'"${offlineUncColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${offlineUnc}"'</td>'
 				echo '<td style="text-align:center; background-color:'"${crcErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${crcErrors}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${wearLevelingColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${wearLeveling}"'%</td>'
+				echo '<td style="text-align:center; background-color:'"${wearLevelingColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${wearLeveling:=N/A}"'%</td>'
 				echo '<td style="text-align:center; background-color:'"${totalBWColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${totalBW}"'</td>'
 				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${bwPerDay}"'</td>'
 				echo '<td style="text-align:center; background-color:'"${testAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${testAge:-"N/A"}"'</td>'

From 7ff4bdaea8564e8f7830543a46ccc8f4a05966bf Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 20 Dec 2021 12:34:18 -0500
Subject: [PATCH 066/160] Fail unknown temp gracefully.

Refs #4.
---
 report.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/report.sh b/report.sh
index 2041bd0..6179199 100755
--- a/report.sh
+++ b/report.sh
@@ -720,7 +720,7 @@ function SSDSummary () {
 
 			local capacity="$(smartctl -i "/dev/${drive}" | grep '^User Capacity:' | tr -s ' ' | cut -d ' ' -sf '5,6')" # FixMe: have not yet figured out how to best calculate this from json values
 
-			local temp="$(echo "${ssdInfoSmrt}"| jq -Mre '.temperature.current | values')"
+			local temp="$(echo "${ssdInfoSmrt}" | jq -Mre '.temperature.current | values')"
 			local onHours="$(echo "${ssdInfoSmrt}" | jq -Mre '.power_on_time.hours | values')"
 			local startStop="$(echo "${ssdInfoSmrt}" | jq -Mre '.power_cycle_count | values')"
 			local sectorSize="$(echo "${ssdInfoSmrt}" | jq -Mre '.logical_block_size | values')"
@@ -789,7 +789,7 @@ function SSDSummary () {
 			fi
 
 			# Colorize Temp
-			if [ "${temp}" -ge "${tempCrit}" ]; then
+			if [ "${temp:="0"}" -ge "${tempCrit}" ]; then
 				local tempColor="${critColor}"
 			elif [ "${temp}" -ge "${tempWarn}" ]; then
 				tempColor="${warnColor}"

From dead41f05716a58b746891da0e984b433279cd54 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 20 Dec 2021 12:34:57 -0500
Subject: [PATCH 067/160] Better quoting.

---
 report.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/report.sh b/report.sh
index 6179199..fa0d52d 100755
--- a/report.sh
+++ b/report.sh
@@ -1331,7 +1331,7 @@ readarray -t "pools" <<< "$(zpool list -H -o name)"
 ###### Email pre-formatting
 ### Set email headers
 {
-    echo "From: ${fromName:=${host}} <${fromEmail:=root@$(hostname)}>"
+    echo "From: ${fromName:="${host}"} <${fromEmail:="root@$(hostname)"}>"
     echo "To: ${email}"
     echo "Subject: ${subject}"
     echo "MIME-Version: 1.0"

From 5996aafec0af3c38fd6a378f28c20bcd35daa972 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 20 Dec 2021 12:44:05 -0500
Subject: [PATCH 068/160] Fail unknown temp gracefully for HDDs too.

Refs #4.
---
 report.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/report.sh b/report.sh
index fa0d52d..6bc18c4 100755
--- a/report.sh
+++ b/report.sh
@@ -1032,7 +1032,7 @@ function HDDSummary () {
 			fi
 
 			# Colorize Temp
-			if [ "${temp}" -ge "${tempCrit}" ]; then
+			if [ "${temp:="0"}" -ge "${tempCrit}" ]; then
 				local tempColor="${critColor}"
 			elif [ "${temp}" -ge "${tempWarn}" ]; then
 				tempColor="${warnColor}"

From 8cccef77f538b720a2ad0d3c139701ffa9f4bf08 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sat, 25 Dec 2021 19:59:19 -0500
Subject: [PATCH 069/160] Fail gracefully if the statistics page does not
 exist.

---
 report.sh | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/report.sh b/report.sh
index 6bc18c4..934f0fb 100755
--- a/report.sh
+++ b/report.sh
@@ -744,8 +744,12 @@ function SSDSummary () {
 				fi
 			fi
 
-			# Get LBA written from the stats page for data writen
-			local totalLBA="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_device_statistics.pages[0].table[] | select(.name == "Logical Sectors Written") | .value | values')"
+			# Get LBA written from the stats page for data written
+			if [ ! -z "$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_device_statistics.pages[0] | values')" ]; then
+				local totalLBA="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_device_statistics.pages[0].table[] | select(.name == "Logical Sectors Written") | .value | values')"
+			else
+				local totalLBA="0"
+			fi
 
 
 			# Get more useful times from hours

From 8bd7c14a28ee3cc6fe9b84a3849ed27260e3fc05 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sat, 25 Dec 2021 20:33:19 -0500
Subject: [PATCH 070/160] Account for very new drives.

Refs #4.
---
 report.sh | 26 ++++++++++++++++++--------
 1 file changed, 18 insertions(+), 8 deletions(-)

diff --git a/report.sh b/report.sh
index 934f0fb..321feeb 100755
--- a/report.sh
+++ b/report.sh
@@ -616,11 +616,16 @@ function NVMeSummary () {
 			else
 				totalBW="${totalBW}TB"
 			fi
-			local bwPerDay="$(bc <<< "scale=1; (((${totalLBA} * ${sectorSize}) / (1000^3)) * 1000) / (${onHours} / 24)" | sed -e 's:^\.:0.:')"
-			if [ "${bwPerDay}" = "0.0" ]; then
-				bwPerDay="N/A"
+			# Try to not divide by zero
+			if [ ! "0" = "$(bc <<< "scale=1; ${onHours} / 24")" ]; then
+				local bwPerDay="$(bc <<< "scale=1; (((${totalLBA} * ${sectorSize}) / (1000^3)) * 1000) / (${onHours} / 24)" | sed -e 's:^\.:0.:')"
+				if [ "${bwPerDay}" = "0.0" ]; then
+					bwPerDay="N/A"
+				else
+					bwPerDay="${bwPerDay}GB"
+				fi
 			else
-				bwPerDay="${bwPerDay}GB"
+				local bwPerDay="N/A"
 			fi
 
 			# Colorize test age
@@ -874,11 +879,16 @@ function SSDSummary () {
 			else
 				totalBW="${totalBW}TB"
 			fi
-			local bwPerDay="$(bc <<< "scale=1; (((${totalLBA} * ${sectorSize}) / (1000^4)) * 1000) / (${onHours} / 24)" | sed -e 's:^\.:0.:')"
-			if [ "${bwPerDay}" = "0.0" ]; then
-				bwPerDay="N/A"
+			# Try to not divide by zero
+			if [ ! "0" = "$(bc <<< "scale=1; ${onHours} / 24")" ]; then
+				local bwPerDay="$(bc <<< "scale=1; (((${totalLBA} * ${sectorSize}) / (1000^4)) * 1000) / (${onHours} / 24)" | sed -e 's:^\.:0.:')"
+				if [ "${bwPerDay}" = "0.0" ]; then
+					bwPerDay="N/A"
+				else
+					bwPerDay="${bwPerDay}GB"
+				fi
 			else
-				bwPerDay="${bwPerDay}GB"
+				local bwPerDay="N/A"
 			fi
 
 			# Colorize test age

From e5930fbe028a889467f113b9d334b54030c7a762 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 2 Jan 2022 17:39:22 -0500
Subject: [PATCH 071/160] Adjust default drive temps.

---
 report.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/report.sh b/report.sh
index 321feeb..09229ae 100755
--- a/report.sh
+++ b/report.sh
@@ -97,8 +97,8 @@ lifeRemainWarn="75"       # Life remaining in the SSD at which WARNING color wil
 lifeRemainCrit="50"       # Life remaining in the SSD at which CRITICAL color will be used
 totalBWWarn="100"         # Total bytes written (in TB) to the SSD at which WARNING color will be used
 totalBWCrit="200"         # Total bytes written (in TB) to the SSD at which CRITICAL color will be used
-tempWarn="40"             # Drive temp (in C) at which WARNING color will be used
-tempCrit="45"             # Drive temp (in C) at which CRITICAL color will be used
+tempWarn="35"             # Drive temp (in C) at which WARNING color will be used
+tempCrit="40"             # Drive temp (in C) at which CRITICAL color will be used
 sectorsCrit="10"          # Number of sectors per drive with errors before CRITICAL color will be used
 testAgeWarn="5"           # Maximum age (in days) of last SMART test before CRITICAL color will be used
 powerTimeFormat="ymdh"  # Format for power-on hours string, valid options are "ymdh", "ymd", "ym", or "y" (year month day hour)

From 6906fda40e056706005e427f4f0ad7230989ca9e Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 2 Jan 2022 17:40:34 -0500
Subject: [PATCH 072/160] Separate SSD temps from HDD temps.

---
 report.sh | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/report.sh b/report.sh
index 09229ae..b9e1686 100755
--- a/report.sh
+++ b/report.sh
@@ -99,6 +99,8 @@ totalBWWarn="100"         # Total bytes written (in TB) to the SSD at which WARN
 totalBWCrit="200"         # Total bytes written (in TB) to the SSD at which CRITICAL color will be used
 tempWarn="35"             # Drive temp (in C) at which WARNING color will be used
 tempCrit="40"             # Drive temp (in C) at which CRITICAL color will be used
+ssdTempWarn="40"          # SSD drive temp (in C) at which WARNING color will be used
+ssdTempCrit="45"          # SSD drive temp (in C) at which CRITICAL color will be used
 sectorsCrit="10"          # Number of sectors per drive with errors before CRITICAL color will be used
 testAgeWarn="5"           # Maximum age (in days) of last SMART test before CRITICAL color will be used
 powerTimeFormat="ymdh"  # Format for power-on hours string, valid options are "ymdh", "ymd", "ym", or "y" (year month day hour)
@@ -555,9 +557,9 @@ function NVMeSummary () {
 			fi
 
 			# Colorize temp
-			if [ "${temp}" -ge "${tempCrit}" ]; then
+			if [ "${temp}" -ge "${ssdTempCrit}" ]; then
 				local tempColor="${critColor}"
-			elif [ "${temp}" -ge "${tempWarn}" ]; then
+			elif [ "${temp}" -ge "${ssdTempWarn}" ]; then
 				tempColor="${warnColor}"
 			else
 				local tempColor="${bgColor}"
@@ -798,9 +800,9 @@ function SSDSummary () {
 			fi
 
 			# Colorize Temp
-			if [ "${temp:="0"}" -ge "${tempCrit}" ]; then
+			if [ "${temp:="0"}" -ge "${ssdTempCrit}" ]; then
 				local tempColor="${critColor}"
-			elif [ "${temp}" -ge "${tempWarn}" ]; then
+			elif [ "${temp}" -ge "${ssdTempWarn}" ]; then
 				tempColor="${warnColor}"
 			else
 				local tempColor="${bgColor}"

From eca1fc33927a8103a9f7ab6ddce7befc50e4f3bb Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 7 Mar 2022 09:49:44 -0500
Subject: [PATCH 073/160] glabel is not used on scale.

---
 report.sh | 25 ++++++++++++++++++-------
 1 file changed, 18 insertions(+), 7 deletions(-)

diff --git a/report.sh b/report.sh
index b9e1686..f9eb4f5 100755
--- a/report.sh
+++ b/report.sh
@@ -1246,6 +1246,11 @@ fi
 # shellcheck source=/dev/null
 . "${configFile}"
 
+# Check if we are running on BSD
+if [[ "$(uname -mrs)" =~ .*"BSD".* ]]; then
+	systemType="BSD"
+fi
+
 # Check if needed software is installed.
 PATH="${PATH}:/usr/local/sbin:/usr/local/bin"
 commands=(
@@ -1261,11 +1266,15 @@ tr
 bc
 smartctl
 jq
-glabel
 head
 tail
 sendmail
 )
+if [ "${systemType}" = "BSD" ]; then
+commands+=(
+glabel
+)
+fi
 if [ "${configBackup}" = "true" ]; then
 commands+=(
 tar
@@ -1407,11 +1416,13 @@ fi
 
 
 ### Print Glabel Status
-{
-    echo '<b>########## Glabel Status ##########</b>'
-    glabel status
-    echo '<br><br>'
-} >> "${logfile}"
+if [ "${systemType}" = "BSD" ]; then
+	{
+		echo '<b>########## Glabel Status ##########</b>'
+		glabel status
+		echo '<br><br>'
+	} >> "${logfile}"
+fi
 
 
 ### Zpool status for each pool
@@ -1419,7 +1430,7 @@ for pool in "${pools[@]}"; do
     {
         # Create a simple header and drop the output of zpool status -v
         echo '<b>########## ZPool status report for '"${pool}"' ##########</b>'
-        zpool status -v "${pool}"
+        zpool status -Lv "${pool}"
         echo '<br><br>'
     } >> "${logfile}"
 done

From 26c0af019ddc6db283e082bf60ab8a8e7db02087 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 1 May 2022 12:31:37 -0400
Subject: [PATCH 074/160] First pass at sas compatibility.

Fixes #1.
---
 report.sh | 218 +++++++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 215 insertions(+), 3 deletions(-)

diff --git a/report.sh b/report.sh
index b9e1686..49e4240 100755
--- a/report.sh
+++ b/report.sh
@@ -1157,6 +1157,204 @@ function HDDSummary () {
 	} >> "${logfile}"
 }
 
+# shellcheck disable=SC2155
+function SASSummary () {
+	###### SAS SMART status summary table
+	{
+		# Write HTML table headers to log file
+		echo '<br><br>'
+		echo '<table style="border: 1px solid black; border-collapse: collapse;">'
+		echo '<tr><th colspan="18" style="text-align:center; font-size:20px; height:40px; font-family:courier;">SAS SMART Status Report Summary</th></tr>'
+		echo '<tr>'
+		echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Device</th>'
+		echo '<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Model</th>'
+		echo '<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Serial<br>Number</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">RPM</th>'
+		echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Capacity</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">SMART<br>Status</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Temp</th>'
+		echo '<th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Power-On<br>Time<br>('"${powerTimeFormat}"')</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Grown<br>Defect<br>List</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Uncorrected<br>Read<br>Errors</th>'
+		echo '<th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Uncorrected<br>Write<br>Errors</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Uncorrected<br>Verify<br>Errors</th>'
+		echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Age (days)</th>'
+		echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Type</th></tr>'
+		echo '</tr>'
+	} >> "${logfile}"
+
+	local drive
+	local altRow="false"
+	for drive in "${drives[@]}"; do
+		local sasInfoSmrt="$(smartctl -AHijl selftest "/dev/${drive}")"
+		local rotTst="$(echo "${sasInfoSmrt}" | jq -Mre '.device.type | values')"
+		if [ "${rotTst}" = "scsi" ]; then
+			# For each drive detected, run "smartctl -AHijl selftest" and parse its output.
+			# After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).
+			# After these computations, determine the row's background color (alternating as above, subbing in other colors from the palate as needed).
+			# Finally, print the HTML code for the current row of the table with all the gathered data.
+
+			local device="${drive}"
+
+			# Available if any tests have completed
+			local lastTestHours="$(echo "${sasInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].lifetime_hours | values')"
+			local lastTestType="$(echo "${sasInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].type.string | values')"
+
+			# Available for any drive smartd knows about
+			if [ "$(echo "${sasInfoSmrt}" | jq -Mre '.smart_status.passed | values')" = "true" ]; then
+				local smartStatus="PASSED"
+			else
+				local smartStatus="FAILED"
+			fi
+
+			local model="$(echo "${sasInfoSmrt}" | jq -Mre '.model_name | values')"
+			local serial="$(echo "${sasInfoSmrt}" | jq -Mre '.serial_number | values')"
+			local rpm="$(echo "${sasInfoSmrt}" | jq -Mre '.rotation_rate | values')"
+			# SAS drives may be SSDs or HDDs
+			if [ "${rpm}" = "0" ]; then
+				rpm="SSD"
+			fi
+
+			local capacity="$(smartctl -i "/dev/${drive}" | grep '^User Capacity:' | tr -s ' ' | cut -d ' ' -sf '5,6')" # FixMe: have not yet figured out how to best calculate this from json values
+
+			local temp="$(echo "${sasInfoSmrt}" | jq -Mre '.temperature.current | values')"
+			local onHours="$(echo "${sasInfoSmrt}" | jq -Mre '.power_on_time.hours | values')"
+
+			# Available for most common drives
+			local scsiGrownDefectList="$(echo "${sasInfoSmrt}" | jq -Mre '.scsi_grown_defect_list | values')"
+			local uncorrectedReadErrors="$(echo "${sasInfoSmrt}" | jq -Mre '.read.total_uncorrected_errors | values')"
+			local uncorrectedWriteErrors="$(echo "${sasInfoSmrt}" | jq -Mre '.write.total_uncorrected_errors | values')"
+			local uncorrectedVerifyErrors="$(echo "${sasInfoSmrt}" | jq -Mre '.verify.total_uncorrected_errors | values')"
+
+
+			# Get more useful times from hours
+			local testAge
+			if [ ! -z "${lastTestHours}" ]; then
+				testAge="$(bc <<< "(${onHours} - ${lastTestHours}) / 24")"
+			fi
+
+			local yrs="$(bc <<< "${onHours} / 8760")"
+			local mos="$(bc <<< "(${onHours} % 8760) / 730")"
+			local dys="$(bc <<< "((${onHours} % 8760) % 730) / 24")"
+			local hrs="$(bc <<< "((${onHours} % 8760) % 730) % 24")"
+
+			# Set Power-On Time format
+			if [ "${powerTimeFormat}" = "ymdh" ]; then
+				local onTime="${yrs}y ${mos}m ${dys}d ${hrs}h"
+			elif [ "${powerTimeFormat}" = "ymd" ]; then
+				local onTime="${yrs}y ${mos}m ${dys}d"
+			elif [ "${powerTimeFormat}" = "ym" ]; then
+				local onTime="${yrs}y ${mos}m"
+			elif [ "${powerTimeFormat}" = "y" ]; then
+				local onTime="${yrs}y"
+			else
+				local onTime="${yrs}y ${mos}m ${dys}d ${hrs}h"
+			fi
+
+			# Set the row background color
+			if [ "${altRow}" = "false" ]; then
+				local bgColor="#ffffff"
+				altRow="true"
+			else
+				local bgColor="${altColor}"
+				altRow="false"
+			fi
+
+			# Colorize Smart Status
+			if [ ! "${smartStatus}" = "PASSED" ]; then
+				local smartStatusColor="${critColor}"
+			else
+				local smartStatusColor="${okColor}"
+			fi
+
+			# Colorize Temp
+			if [ "${temp:="0"}" -ge "${tempCrit}" ]; then
+				local tempColor="${critColor}"
+			elif [ "${temp}" -ge "${tempWarn}" ]; then
+				tempColor="${warnColor}"
+			else
+				local tempColor="${bgColor}"
+			fi
+			if [ "${temp}" = "0" ]; then
+				local temp="N/A"
+			else
+				local temp="${temp}&deg;C"
+			fi
+
+			# Colorize Spin Retry Errors
+			if [ ! "${spinRetry:=0}" = "0" ]; then
+				local spinRetryColor="${warnColor}"
+			else
+				local spinRetryColor="${bgColor}"
+			fi
+
+			# Colorize scsi Grown Defect List Errors
+			if [ "${scsiGrownDefectList:=0}" -gt "${sectorsCrit}" ]; then
+				local scsiGrownDefectListColor="${critColor}"
+			elif [ ! "${scsiGrownDefectList}" = "0" ]; then
+				local scsiGrownDefectListColor="${warnColor}"
+			else
+				local scsiGrownDefectListColor="${bgColor}"
+			fi
+
+			# Colorize Read Errors
+			if [ ! "${uncorrectedReadErrors:=0}" = "0" ]; then
+				local uncorrectedReadErrorsColor="${warnColor}"
+			else
+				local uncorrectedReadErrorsColor="${bgColor}"
+			fi
+
+			# Colorize Write Errors
+			if [ ! "${uncorrectedWriteErrors:=0}" = "0" ]; then
+				local uncorrectedWriteErrorsColor="${warnColor}"
+			else
+				local uncorrectedWriteErrorsColor="${bgColor}"
+			fi
+
+			# Colorize Verify Errors
+			if [ ! "${uncorrectedVerifyErrors:=0}" = "0" ]; then
+				local uncorrectedVerifyErrorsColor="${warnColor}"
+			else
+				local uncorrectedVerifyErrorsColor="${bgColor}"
+			fi
+
+			# Colorize test age
+			if [ "${testAge:-0}" -gt "${testAgeWarn}" ]; then
+				testAgeColor="${critColor}"
+			else
+				testAgeColor="${bgColor}"
+			fi
+
+
+			{
+				# Row Output
+				echo '<tr style="background-color:'"${bgColor}"';">'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"/dev/${device}"'</td>'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${model}"'</td>'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${serial}"'</td>'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${rpm}"'</td>'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${capacity}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${smartStatusColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${smartStatus}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${tempColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${temp}"'</td>'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${onTime}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${scsiGrownDefectListColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scsiGrownDefectList}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${uncorrectedReadErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${uncorrectedReadErrors}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${uncorrectedWriteErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${uncorrectedWriteErrors}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${uncorrectedVerifyErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${uncorrectedVerifyErrors}"'%</td>'
+				echo '<td style="text-align:center; background-color:'"${testAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${testAge:-"N/A"}"'</td>'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${lastTestType:-"N/A"}"'</td>'
+				echo '</tr>'
+			} >> "${logfile}"
+		fi
+	done
+
+	# End SMART summary table and summary section
+	{
+		echo '</table>'
+		echo '<br><br>'
+	} >> "${logfile}"
+}
+
 # shellcheck disable=SC2155
 function ReportUPS () {
     # Set to a value greater than zero to include all available UPSC
@@ -1308,7 +1506,7 @@ messageid="$(dbus-uuidgen)"
 # Reorders the drives in ascending order
 # FixMe: smart support flag is not yet implemented in smartctl json output.
 readarray -t "drives" <<< "$(for drive in $(sysctl -n kern.disks | sed -e 's:nvd:nvme:g'); do
-	if smartctl -i "/dev/${drive}" | grep -q "SMART support is: Enabled"; then
+	if smartctl --json=u -i "/dev/${drive}" | grep -q "SMART support is: Enabled"; then
 		printf "%s " "${drive}"
 	elif echo "${drive}" | grep -q "nvme"; then
 		printf "%s " "${drive}"
@@ -1318,7 +1516,7 @@ done | awk '{for (i=NF; i!=0 ; i--) print $i }')"
 # Toggles the 'ssdExist' flag to true if SSDs are detected in order to add the summary table
 if [ "${includeSSD}" = "true" ]; then
     for drive in "${drives[@]}"; do
-        if [ "$(smartctl -ij "/dev/${drive}" | jq -Mre '.rotation_rate | values')" = "0" ]; then
+        if [ "$(smartctl -ij "/dev/${drive}" | jq -Mre '.rotation_rate | values')" = "0" ] && [ ! "$(smartctl -ij "/dev/${drive}" | jq -Mre '.device.type | values')" = "scsi" ]; then
             ssdExist="true"
             break
         else
@@ -1331,13 +1529,22 @@ if [ "${includeSSD}" = "true" ]; then
 fi
 # Test to see if there are any HDDs
 for drive in "${drives[@]}"; do
-	if [ ! "$(smartctl -ij "/dev/${drive}" | jq -Mre '.rotation_rate | values')" = "0" ]; then
+	if [ ! "$(smartctl -ij "/dev/${drive}" | jq -Mre '.rotation_rate | values')" = "0" ] && [ ! "$(smartctl -ij "/dev/${drive}" | jq -Mre '.device.type | values')" = "scsi" ]; then
 		hddExist="true"
 		break
 	else
 		hddExist="false"
 	fi
 done
+# Test to see if there are any SAS drives
+for drive in "${drives[@]}"; do
+	if [ "$(smartctl -ij "/dev/${drive}" | jq -Mre '.device.type | values')" = "scsi" ]; then
+		sasExist="true"
+		break
+	else
+		sasExist="false"
+	fi
+done
 
 # Get a list of pools
 readarray -t "pools" <<< "$(zpool list -H -o name)"
@@ -1385,6 +1592,11 @@ if [ "${NVMeExist}" = "true" ]; then
 fi
 
 
+if [ "${sasExist}" = "true" ]; then
+	SASSummary
+fi
+
+
 if [ "${ssdExist}" = "true" ]; then
 	SSDSummary
 fi

From e43e83c7df152e22e9ac9400c123849e4ca4da06 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 1 May 2022 15:25:36 -0400
Subject: [PATCH 075/160] Do not care about whitespace variations.

---
 report.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/report.sh b/report.sh
index 49e4240..a3c3f1d 100755
--- a/report.sh
+++ b/report.sh
@@ -1506,7 +1506,7 @@ messageid="$(dbus-uuidgen)"
 # Reorders the drives in ascending order
 # FixMe: smart support flag is not yet implemented in smartctl json output.
 readarray -t "drives" <<< "$(for drive in $(sysctl -n kern.disks | sed -e 's:nvd:nvme:g'); do
-	if smartctl --json=u -i "/dev/${drive}" | grep -q "SMART support is: Enabled"; then
+	if smartctl --json=u -i "/dev/${drive}" | grep -q "SMART support is:" | grep -q "Enabled"; then
 		printf "%s " "${drive}"
 	elif echo "${drive}" | grep -q "nvme"; then
 		printf "%s " "${drive}"

From 9b36a3c73440259d9088e6ca5087e9c4a2e0c830 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 1 May 2022 15:30:17 -0400
Subject: [PATCH 076/160] Get rid of an extraneous %.

---
 report.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/report.sh b/report.sh
index a3c3f1d..be159a8 100755
--- a/report.sh
+++ b/report.sh
@@ -1340,7 +1340,7 @@ function SASSummary () {
 				echo '<td style="text-align:center; background-color:'"${scsiGrownDefectListColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scsiGrownDefectList}"'</td>'
 				echo '<td style="text-align:center; background-color:'"${uncorrectedReadErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${uncorrectedReadErrors}"'</td>'
 				echo '<td style="text-align:center; background-color:'"${uncorrectedWriteErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${uncorrectedWriteErrors}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${uncorrectedVerifyErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${uncorrectedVerifyErrors}"'%</td>'
+				echo '<td style="text-align:center; background-color:'"${uncorrectedVerifyErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${uncorrectedVerifyErrors}"'</td>'
 				echo '<td style="text-align:center; background-color:'"${testAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${testAge:-"N/A"}"'</td>'
 				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${lastTestType:-"N/A"}"'</td>'
 				echo '</tr>'

From 251f9b245b4e722c6c4c76d4b3bb4de8c285bc48 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 1 May 2022 17:26:05 -0400
Subject: [PATCH 077/160] Make sure the line gets passed through.

---
 report.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/report.sh b/report.sh
index be159a8..9351533 100755
--- a/report.sh
+++ b/report.sh
@@ -1506,7 +1506,7 @@ messageid="$(dbus-uuidgen)"
 # Reorders the drives in ascending order
 # FixMe: smart support flag is not yet implemented in smartctl json output.
 readarray -t "drives" <<< "$(for drive in $(sysctl -n kern.disks | sed -e 's:nvd:nvme:g'); do
-	if smartctl --json=u -i "/dev/${drive}" | grep -q "SMART support is:" | grep -q "Enabled"; then
+	if smartctl --json=u -i "/dev/${drive}" | grep "SMART support is:" | grep -q "Enabled"; then
 		printf "%s " "${drive}"
 	elif echo "${drive}" | grep -q "nvme"; then
 		printf "%s " "${drive}"

From 6831f9183d186f10fb708958350f42eeb1386874 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 1 May 2022 17:29:38 -0400
Subject: [PATCH 078/160] Support SAS drives for detailed output.

---
 report.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/report.sh b/report.sh
index 9351533..65341bb 100755
--- a/report.sh
+++ b/report.sh
@@ -1642,7 +1642,7 @@ for drive in "${drives[@]}"; do
     smartOut="$(smartctl --json=u -i "/dev/${drive}")" # FixMe: smart support flag is not yet implemented in smartctl json output.
     smartTestOut="$(smartctl -l selftest "/dev/${drive}")"
 
-    if echo "${smartOut}" | grep -q "SMART support is: Enabled"; then # FixMe: smart support flag is not yet implemented in smartctl json output.
+    if echo "${smartOut}" | grep "SMART support is:" | grep -q "Enabled"; then # FixMe: smart support flag is not yet implemented in smartctl json output.
         # Gather brand and serial number of each drive
         brand="$(echo "${smartOut}" | jq -Mre '.model_family | values')"
         if [ -z "${brand}" ]; then

From ffd4e3e35b0e6bf06ec8d12b0829aada746f47ed Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 1 May 2022 19:50:18 -0400
Subject: [PATCH 079/160] Clean things up a bit.

---
 report.sh | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/report.sh b/report.sh
index 65341bb..f2c42db 100755
--- a/report.sh
+++ b/report.sh
@@ -1196,7 +1196,7 @@ function SASSummary () {
 
 			local device="${drive}"
 
-			# Available if any tests have completed
+			# Available if any tests have completed #FixMe this info is not currently exported in json for sas drives
 			local lastTestHours="$(echo "${sasInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].lifetime_hours | values')"
 			local lastTestType="$(echo "${sasInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].type.string | values')"
 
@@ -1211,7 +1211,7 @@ function SASSummary () {
 			local serial="$(echo "${sasInfoSmrt}" | jq -Mre '.serial_number | values')"
 			local rpm="$(echo "${sasInfoSmrt}" | jq -Mre '.rotation_rate | values')"
 			# SAS drives may be SSDs or HDDs
-			if [ "${rpm}" = "0" ]; then
+			if [ "${rpm:-0}" = "0" ]; then
 				rpm="SSD"
 			fi
 
@@ -1281,13 +1281,6 @@ function SASSummary () {
 				local temp="${temp}&deg;C"
 			fi
 
-			# Colorize Spin Retry Errors
-			if [ ! "${spinRetry:=0}" = "0" ]; then
-				local spinRetryColor="${warnColor}"
-			else
-				local spinRetryColor="${bgColor}"
-			fi
-
 			# Colorize scsi Grown Defect List Errors
 			if [ "${scsiGrownDefectList:=0}" -gt "${sectorsCrit}" ]; then
 				local scsiGrownDefectListColor="${critColor}"

From 0c3748c17b884c24c7867cb3e29927cca0257c4f Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 1 May 2022 19:57:58 -0400
Subject: [PATCH 080/160] Update release notes.

---
 README.md | 5 ++++-
 report.sh | 4 +++-
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index aaf9720..cc7c354 100644
--- a/README.md
+++ b/README.md
@@ -3,7 +3,7 @@ Original Script By: joeschmuck<br>
 Modified By: bidelu0hm, melp, fohlsso2, onlinepcwizard, ninpucho, isentropik, rotx, dak180<br>
 Last Edited By: dak180
 
-**Current Version: v1.7**
+**Current Version: v1.7.5**
 
 Preview of the output here: https://i.imgur.com/jKwraw4.png
 When a resilver is in progress: https://i.imgur.com/CUNUZ7r.png
@@ -42,6 +42,9 @@ Once you have updated the config file, click `Run Now` again to generate your fi
 
 **Changelog**
 
+*v1.7.5* (dak180)
+ - Add initial support for SAS drives
+
 *v1.7* (dak180)
  - Refactor to reduce dependence on awk
  - Use a separate config file
diff --git a/report.sh b/report.sh
index f2c42db..9e2444b 100755
--- a/report.sh
+++ b/report.sh
@@ -11,10 +11,12 @@
 ### At a minimum, enter email address and set defaultFile to 0 in the config file.
 ### Feel free to edit other user parameters as needed.
 
-### Current Version: v1.7
+### Current Version: v1.7.5
 ### https://github.com/dak180/FreeNAS-Report
 
 ### Changelog:
+# v1.7.5
+#   - Add initial support for SAS drives
 # v1.7
 #   - Refactor to reduce dependence on awk
 #   - Use a separate config file

From 77449a2a89f78195815ec0f3c869109f9a889cf3 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 1 May 2022 20:30:32 -0400
Subject: [PATCH 081/160] Accommodate both SSD and HDD temp settings.

---
 report.sh | 24 ++++++++++++++++++------
 1 file changed, 18 insertions(+), 6 deletions(-)

diff --git a/report.sh b/report.sh
index 9e2444b..5880f99 100755
--- a/report.sh
+++ b/report.sh
@@ -1269,13 +1269,25 @@ function SASSummary () {
 				local smartStatusColor="${okColor}"
 			fi
 
-			# Colorize Temp
-			if [ "${temp:="0"}" -ge "${tempCrit}" ]; then
-				local tempColor="${critColor}"
-			elif [ "${temp}" -ge "${tempWarn}" ]; then
-				tempColor="${warnColor}"
+			# SAS is both SSD and HDD; colorize temp as appropriate
+			if [ "${rpm}" = "SSD" ]; then
+				# SAS SSD
+				if [ "${temp:="0"}" -ge "${ssdTempCrit}" ]; then
+					local tempColor="${critColor}"
+				elif [ "${temp}" -ge "${ssdTempWarn}" ]; then
+					tempColor="${warnColor}"
+				else
+					local tempColor="${bgColor}"
+				fi
 			else
-				local tempColor="${bgColor}"
+				# SAS HDD
+				if [ "${temp:="0"}" -ge "${tempCrit}" ]; then
+					local tempColor="${critColor}"
+				elif [ "${temp}" -ge "${tempWarn}" ]; then
+					tempColor="${warnColor}"
+				else
+					local tempColor="${bgColor}"
+				fi
 			fi
 			if [ "${temp}" = "0" ]; then
 				local temp="N/A"

From 790a20850c28f49ca1d5d00ba772fc612b042f8b Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 2 May 2022 02:11:16 -0400
Subject: [PATCH 082/160] Keep SAS drives in their own section.

---
 report.sh | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/report.sh b/report.sh
index 5880f99..2585e72 100755
--- a/report.sh
+++ b/report.sh
@@ -705,7 +705,8 @@ function SSDSummary () {
     for drive in "${drives[@]}"; do
 		local ssdInfoSmrt="$(smartctl -AHijl selftest --log="devstat" "/dev/${drive}")"
     	local rotTst="$(echo "${ssdInfoSmrt}" | jq -Mre '.rotation_rate | values')"
-        if [ "${rotTst}" = "0" ]; then
+    	local scsiTst="$(echo "${ssdInfoSmrt}" | jq -Mre '.device.type | values')"
+        if [ "${rotTst}" = "0" ] && [ ! "${scsiTst}" = "scsi" ]; then
 			# For each drive detected, run "smartctl -AHijl selftest" and parse its output.
 			# Start by parsing out the variables used in other parts of the script.
 			# After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).
@@ -970,7 +971,8 @@ function HDDSummary () {
 	for drive in "${drives[@]}"; do
 		local hddInfoSmrt="$(smartctl -AHijl selftest "/dev/${drive}")"
 		local rotTst="$(echo "${hddInfoSmrt}" | jq -Mre '.rotation_rate | values')"
-		if [ ! "${rotTst:="0"}" = "0" ]; then
+		local scsiTst="$(echo "${hddInfoSmrt}" | jq -Mre '.device.type | values')"
+		if [ ! "${rotTst:="0"}" = "0" ] && [ ! "${scsiTst}" = "scsi" ]; then
 			# For each drive detected, run "smartctl -AHijl selftest" and parse its output.
 			# After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).
 			# After these computations, determine the row's background color (alternating as above, subbing in other colors from the palate as needed).

From fdc274921d107625ea1a0ab18e3d3f9c70babfaa Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Fri, 6 May 2022 19:20:37 +0000
Subject: [PATCH 083/160] Reset vars for each loop.

---
 report.sh | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/report.sh b/report.sh
index 2585e72..915cd87 100755
--- a/report.sh
+++ b/report.sh
@@ -562,7 +562,7 @@ function NVMeSummary () {
 			if [ "${temp}" -ge "${ssdTempCrit}" ]; then
 				local tempColor="${critColor}"
 			elif [ "${temp}" -ge "${ssdTempWarn}" ]; then
-				tempColor="${warnColor}"
+				local tempColor="${warnColor}"
 			else
 				local tempColor="${bgColor}"
 			fi
@@ -634,9 +634,9 @@ function NVMeSummary () {
 
 			# Colorize test age
 			if [ "${testAge}" -gt "${testAgeWarn}" ]; then
-				testAgeColor="${critColor}"
+				local testAgeColor="${critColor}"
 			else
-				testAgeColor="${bgColor}"
+				local testAgeColor="${bgColor}"
 			fi
 
 
@@ -763,7 +763,7 @@ function SSDSummary () {
 
 
 			# Get more useful times from hours
-			local testAge
+			local testAge=""
 			if [ ! -z "${lastTestHours}" ]; then
 				testAge="$(bc <<< "(${onHours} - ${lastTestHours}) / 24")"
 			fi
@@ -806,7 +806,7 @@ function SSDSummary () {
 			if [ "${temp:="0"}" -ge "${ssdTempCrit}" ]; then
 				local tempColor="${critColor}"
 			elif [ "${temp}" -ge "${ssdTempWarn}" ]; then
-				tempColor="${warnColor}"
+				local tempColor="${warnColor}"
 			else
 				local tempColor="${bgColor}"
 			fi
@@ -898,9 +898,9 @@ function SSDSummary () {
 
 			# Colorize test age
 			if [ "${testAge:-0}" -gt "${testAgeWarn}" ]; then
-				testAgeColor="${critColor}"
+				local testAgeColor="${critColor}"
 			else
-				testAgeColor="${bgColor}"
+				local testAgeColor="${bgColor}"
 			fi
 
 
@@ -1012,7 +1012,7 @@ function HDDSummary () {
 
 
 			# Get more useful times from hours
-			local testAge
+			local testAge=""
 			if [ ! -z "${lastTestHours}" ]; then
 				testAge="$(bc <<< "(${onHours} - ${lastTestHours}) / 24")"
 			fi
@@ -1055,7 +1055,7 @@ function HDDSummary () {
 			if [ "${temp:="0"}" -ge "${tempCrit}" ]; then
 				local tempColor="${critColor}"
 			elif [ "${temp}" -ge "${tempWarn}" ]; then
-				tempColor="${warnColor}"
+				local tempColor="${warnColor}"
 			else
 				local tempColor="${bgColor}"
 			fi
@@ -1122,9 +1122,9 @@ function HDDSummary () {
 
 			# Colorize test age
 			if [ "${testAge:-0}" -gt "${testAgeWarn}" ]; then
-				testAgeColor="${critColor}"
+				local testAgeColor="${critColor}"
 			else
-				testAgeColor="${bgColor}"
+				local testAgeColor="${bgColor}"
 			fi
 
 
@@ -1232,7 +1232,7 @@ function SASSummary () {
 
 
 			# Get more useful times from hours
-			local testAge
+			local testAge=""
 			if [ ! -z "${lastTestHours}" ]; then
 				testAge="$(bc <<< "(${onHours} - ${lastTestHours}) / 24")"
 			fi
@@ -1277,7 +1277,7 @@ function SASSummary () {
 				if [ "${temp:="0"}" -ge "${ssdTempCrit}" ]; then
 					local tempColor="${critColor}"
 				elif [ "${temp}" -ge "${ssdTempWarn}" ]; then
-					tempColor="${warnColor}"
+					local tempColor="${warnColor}"
 				else
 					local tempColor="${bgColor}"
 				fi
@@ -1286,7 +1286,7 @@ function SASSummary () {
 				if [ "${temp:="0"}" -ge "${tempCrit}" ]; then
 					local tempColor="${critColor}"
 				elif [ "${temp}" -ge "${tempWarn}" ]; then
-					tempColor="${warnColor}"
+					local tempColor="${warnColor}"
 				else
 					local tempColor="${bgColor}"
 				fi
@@ -1329,9 +1329,9 @@ function SASSummary () {
 
 			# Colorize test age
 			if [ "${testAge:-0}" -gt "${testAgeWarn}" ]; then
-				testAgeColor="${critColor}"
+				local testAgeColor="${critColor}"
 			else
-				testAgeColor="${bgColor}"
+				local testAgeColor="${bgColor}"
 			fi
 
 

From 1c81a30361f6f8df01cd11f49550ff105a44fe82 Mon Sep 17 00:00:00 2001
From: mth309 <mth309@users.noreply.github.com>
Date: Sat, 7 May 2022 14:49:37 +0000
Subject: [PATCH 084/160] Update report.sh

---
 report.sh | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/report.sh b/report.sh
index 915cd87..e7a9cf6 100755
--- a/report.sh
+++ b/report.sh
@@ -1178,10 +1178,13 @@ function SASSummary () {
 		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">SMART<br>Status</th>'
 		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Temp</th>'
 		echo '<th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Power-On<br>Time<br>('"${powerTimeFormat}"')</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Start<br>Stop<br>Cycles</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Load<br>Unload<br>Cycles</th>'
 		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Grown<br>Defect<br>List</th>'
 		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Uncorrected<br>Read<br>Errors</th>'
 		echo '<th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Uncorrected<br>Write<br>Errors</th>'
 		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Uncorrected<br>Verify<br>Errors</th>'
+		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Non-medium<br>Errors</th>'
 		echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Age (days)</th>'
 		echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Type</th></tr>'
 		echo '</tr>'
@@ -1191,6 +1194,7 @@ function SASSummary () {
 	local altRow="false"
 	for drive in "${drives[@]}"; do
 		local sasInfoSmrt="$(smartctl -AHijl selftest "/dev/${drive}")"
+		local nonJsonSasInfoSmrt="$(smartctl -Al error -l selftest "/dev/${drive}")"
 		local rotTst="$(echo "${sasInfoSmrt}" | jq -Mre '.device.type | values')"
 		if [ "${rotTst}" = "scsi" ]; then
 			# For each drive detected, run "smartctl -AHijl selftest" and parse its output.
@@ -1204,6 +1208,17 @@ function SASSummary () {
 			local lastTestHours="$(echo "${sasInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].lifetime_hours | values')"
 			local lastTestType="$(echo "${sasInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].type.string | values')"
 
+			#FixMe: relies on non-json output
+			lastTestHours="$(echo "${nonJsonSasInfoSmrt}" | grep "# 1" | awk '{print $7}')"
+			lastTestType="$(echo "${nonJsonSasInfoSmrt}" | grep "# 1" | awk '{print $3" "$4}')"
+
+			# Workaround for some drives that do not support self testing but still report a garbage self test log
+			# Set last test type to 'N/A' and last test hours to null "" in this case
+			if [ "${lastTestType}" == "Default Self" ]; then
+				lastTestType="N/A"
+				lastTestHours=""
+			fi
+
 			# Available for any drive smartd knows about
 			if [ "$(echo "${sasInfoSmrt}" | jq -Mre '.smart_status.passed | values')" = "true" ]; then
 				local smartStatus="PASSED"
@@ -1230,6 +1245,10 @@ function SASSummary () {
 			local uncorrectedWriteErrors="$(echo "${sasInfoSmrt}" | jq -Mre '.write.total_uncorrected_errors | values')"
 			local uncorrectedVerifyErrors="$(echo "${sasInfoSmrt}" | jq -Mre '.verify.total_uncorrected_errors | values')"
 
+			#FixMe: relies on non-json output
+			local nonMediumErrors="$(echo "${nonJsonSasInfoSmrt}" | grep "Non-medium" | awk '{print $4}')"
+			local accumStartStopCycles="$(echo "${nonJsonSasInfoSmrt}" | grep "Accumulated start-stop" | awk '{print $4}')"
+			local accumLoadUnloadCycles="$(echo "${nonJsonSasInfoSmrt}" | grep "Accumulated load-unload" | awk '{print $4}')"
 
 			# Get more useful times from hours
 			local testAge=""
@@ -1346,10 +1365,13 @@ function SASSummary () {
 				echo '<td style="text-align:center; background-color:'"${smartStatusColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${smartStatus}"'</td>'
 				echo '<td style="text-align:center; background-color:'"${tempColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${temp}"'</td>'
 				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${onTime}"'</td>'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${accumStartStopCycles}"'</td>'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${accumLoadUnloadCycles}"'</td>'
 				echo '<td style="text-align:center; background-color:'"${scsiGrownDefectListColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scsiGrownDefectList}"'</td>'
 				echo '<td style="text-align:center; background-color:'"${uncorrectedReadErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${uncorrectedReadErrors}"'</td>'
 				echo '<td style="text-align:center; background-color:'"${uncorrectedWriteErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${uncorrectedWriteErrors}"'</td>'
 				echo '<td style="text-align:center; background-color:'"${uncorrectedVerifyErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${uncorrectedVerifyErrors}"'</td>'
+				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${nonMediumErrors}"'</td>'
 				echo '<td style="text-align:center; background-color:'"${testAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${testAge:-"N/A"}"'</td>'
 				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${lastTestType:-"N/A"}"'</td>'
 				echo '</tr>'

From 13ca372fc9705fee88da01858d2a58e3f74fbd12 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 8 May 2022 13:18:29 +0000
Subject: [PATCH 085/160] Remove awk.

---
 report.sh | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/report.sh b/report.sh
index e7a9cf6..59551ea 100755
--- a/report.sh
+++ b/report.sh
@@ -1209,8 +1209,8 @@ function SASSummary () {
 			local lastTestType="$(echo "${sasInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].type.string | values')"
 
 			#FixMe: relies on non-json output
-			lastTestHours="$(echo "${nonJsonSasInfoSmrt}" | grep "# 1" | awk '{print $7}')"
-			lastTestType="$(echo "${nonJsonSasInfoSmrt}" | grep "# 1" | awk '{print $3" "$4}')"
+			lastTestHours="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '7')"
+			lastTestType="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '3,4')"
 
 			# Workaround for some drives that do not support self testing but still report a garbage self test log
 			# Set last test type to 'N/A' and last test hours to null "" in this case
@@ -1246,9 +1246,9 @@ function SASSummary () {
 			local uncorrectedVerifyErrors="$(echo "${sasInfoSmrt}" | jq -Mre '.verify.total_uncorrected_errors | values')"
 
 			#FixMe: relies on non-json output
-			local nonMediumErrors="$(echo "${nonJsonSasInfoSmrt}" | grep "Non-medium" | awk '{print $4}')"
-			local accumStartStopCycles="$(echo "${nonJsonSasInfoSmrt}" | grep "Accumulated start-stop" | awk '{print $4}')"
-			local accumLoadUnloadCycles="$(echo "${nonJsonSasInfoSmrt}" | grep "Accumulated load-unload" | awk '{print $4}')"
+			local nonMediumErrors="$(echo "${nonJsonSasInfoSmrt}" | grep "Non-medium" | tr -s " " | cut -d ' ' -sf '4')"
+			local accumStartStopCycles="$(echo "${nonJsonSasInfoSmrt}" | grep "Accumulated start-stop" | tr -s " " | cut -d ' ' -sf '4')"
+			local accumLoadUnloadCycles="$(echo "${nonJsonSasInfoSmrt}" | grep "Accumulated load-unload" | tr -s " " | cut -d ' ' -sf '4')"
 
 			# Get more useful times from hours
 			local testAge=""

From 7f88351c6d82abe6c26e981a74ad5e58c6c8f1af Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 8 May 2022 09:45:06 -0400
Subject: [PATCH 086/160] Apparently some HDDs to not report a rotation rate so
 test 'Spin up Time' instead.

Fixes #7.
Closes #8.
---
 report.sh | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/report.sh b/report.sh
index 59551ea..03a58c2 100755
--- a/report.sh
+++ b/report.sh
@@ -972,6 +972,9 @@ function HDDSummary () {
 		local hddInfoSmrt="$(smartctl -AHijl selftest "/dev/${drive}")"
 		local rotTst="$(echo "${hddInfoSmrt}" | jq -Mre '.rotation_rate | values')"
 		local scsiTst="$(echo "${hddInfoSmrt}" | jq -Mre '.device.type | values')"
+		if [ -z "${rotTst}" ] && [ ! -z "$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.name == "Spin_Up_Time") | .id | values')" ]; then
+			rotTst="N/R"
+		fi
 		if [ ! "${rotTst:="0"}" = "0" ] && [ ! "${scsiTst}" = "scsi" ]; then
 			# For each drive detected, run "smartctl -AHijl selftest" and parse its output.
 			# After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).

From 972a18eb735ac2e1795e38219406c84e06d2a924 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Wed, 11 May 2022 23:30:29 -0400
Subject: [PATCH 087/160] Prevent error on nvme drives.

---
 report.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/report.sh b/report.sh
index 03a58c2..b2d7656 100755
--- a/report.sh
+++ b/report.sh
@@ -972,7 +972,7 @@ function HDDSummary () {
 		local hddInfoSmrt="$(smartctl -AHijl selftest "/dev/${drive}")"
 		local rotTst="$(echo "${hddInfoSmrt}" | jq -Mre '.rotation_rate | values')"
 		local scsiTst="$(echo "${hddInfoSmrt}" | jq -Mre '.device.type | values')"
-		if [ -z "${rotTst}" ] && [ ! -z "$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.name == "Spin_Up_Time") | .id | values')" ]; then
+		if [ -z "${rotTst}" ] && [ ! -z "$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[]? | select(.name == "Spin_Up_Time") | .id | values')" ]; then
 			rotTst="N/R"
 		fi
 		if [ ! "${rotTst:="0"}" = "0" ] && [ ! "${scsiTst}" = "scsi" ]; then

From ecfc7e1b5294e74c641859db02152e8c32b9ad9c Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Fri, 13 May 2022 09:37:12 -0400
Subject: [PATCH 088/160] Colorize on test failure (HDD & SSD).

Refs #9
---
 report.sh | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/report.sh b/report.sh
index b2d7656..651a856 100755
--- a/report.sh
+++ b/report.sh
@@ -717,6 +717,7 @@ function SSDSummary () {
 			# Available if any tests have completed
 			local lastTestHours="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].lifetime_hours | values')"
 			local lastTestType="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].type.string | values')"
+			local lastTestStatus="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].status.passed | values')"
 
 			# Available for any drive smartd knows about
 			if [ "$(echo "${ssdInfoSmrt}" | jq -Mre '.smart_status.passed | values')" = "true" ]; then
@@ -802,6 +803,13 @@ function SSDSummary () {
 				local smartStatusColor="${okColor}"
 			fi
 
+			# Colorize Smart test Status
+			if [ "${lastTestStatus}" = "false" ]; then
+				local lastTestStatusColor="${critColor}"
+			else
+				local lastTestStatusColor="${bgColor}"
+			fi
+
 			# Colorize Temp
 			if [ "${temp:="0"}" -ge "${ssdTempCrit}" ]; then
 				local tempColor="${critColor}"
@@ -924,7 +932,7 @@ function SSDSummary () {
 				echo '<td style="text-align:center; background-color:'"${totalBWColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${totalBW}"'</td>'
 				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${bwPerDay}"'</td>'
 				echo '<td style="text-align:center; background-color:'"${testAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${testAge:-"N/A"}"'</td>'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${lastTestType:-"N/A"}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${lastTestStatusColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${lastTestType:-"N/A"}"'</td>'
 				echo '</tr>'
             } >> "${logfile}"
         fi
@@ -986,6 +994,7 @@ function HDDSummary () {
 			# Available if any tests have completed
 			local lastTestHours="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].lifetime_hours | values')"
 			local lastTestType="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].type.string | values')"
+			local lastTestStatus="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].status.passed | values')"
 
 			# Available for any drive smartd knows about
 			if [ "$(echo "${hddInfoSmrt}" | jq -Mre '.smart_status.passed | values')" = "true" ]; then
@@ -1054,6 +1063,13 @@ function HDDSummary () {
 				local smartStatusColor="${okColor}"
 			fi
 
+			# Colorize Smart test Status
+			if [ "${lastTestStatus}" = "false" ]; then
+				local lastTestStatusColor="${critColor}"
+			else
+				local lastTestStatusColor="${bgColor}"
+			fi
+
 			# Colorize Temp
 			if [ "${temp:="0"}" -ge "${tempCrit}" ]; then
 				local tempColor="${critColor}"
@@ -1151,7 +1167,7 @@ function HDDSummary () {
 				echo '<td style="text-align:center; background-color:'"${crcErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${crcErrors}"'</td>'
 				echo '<td style="text-align:center; background-color:'"${seekErrorHealthColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${seekErrorHealth}"'%</td>'
 				echo '<td style="text-align:center; background-color:'"${testAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${testAge:-"N/A"}"'</td>'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${lastTestType:-"N/A"}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${lastTestStatusColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${lastTestType:-"N/A"}"'</td>'
 				echo '</tr>'
 			} >> "${logfile}"
 		fi

From 1e1638f098dd3f4b6aa219c0cfb64725c7cd45e0 Mon Sep 17 00:00:00 2001
From: mth309 <mth309@users.noreply.github.com>
Date: Fri, 13 May 2022 13:31:50 -0400
Subject: [PATCH 089/160] Update report.sh

---
 report.sh | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/report.sh b/report.sh
index 651a856..67dc62a 100755
--- a/report.sh
+++ b/report.sh
@@ -1226,10 +1226,12 @@ function SASSummary () {
 			# Available if any tests have completed #FixMe this info is not currently exported in json for sas drives
 			local lastTestHours="$(echo "${sasInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].lifetime_hours | values')"
 			local lastTestType="$(echo "${sasInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].type.string | values')"
-
+			local lastTestStatus="$(echo "${sasInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].status.passed | values')"
+            
 			#FixMe: relies on non-json output
 			lastTestHours="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '7')"
 			lastTestType="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '3,4')"
+			lastTestStatus="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '8,9,10,11')"
 
 			# Workaround for some drives that do not support self testing but still report a garbage self test log
 			# Set last test type to 'N/A' and last test hours to null "" in this case
@@ -1238,6 +1240,13 @@ function SASSummary () {
 				lastTestHours=""
 			fi
 
+            # Mimic the true/false response expected from json in the future
+            if [ "${lastTestStatus}" = "- [- - -]" ] || [ "${lastTestType}" = "N/A" ]; then 
+                lastTestStatus="true"
+            else
+                lastTestStatus="false"
+            fi
+            
 			# Available for any drive smartd knows about
 			if [ "$(echo "${sasInfoSmrt}" | jq -Mre '.smart_status.passed | values')" = "true" ]; then
 				local smartStatus="PASSED"
@@ -1372,6 +1381,12 @@ function SASSummary () {
 				local testAgeColor="${bgColor}"
 			fi
 
+            # Colorize Smart test Status
+			if [ "${lastTestStatus}" = "false" ]; then
+				local lastTestStatusColor="${critColor}"
+			else
+				local lastTestStatusColor="${bgColor}"
+			fi
 
 			{
 				# Row Output
@@ -1392,7 +1407,7 @@ function SASSummary () {
 				echo '<td style="text-align:center; background-color:'"${uncorrectedVerifyErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${uncorrectedVerifyErrors}"'</td>'
 				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${nonMediumErrors}"'</td>'
 				echo '<td style="text-align:center; background-color:'"${testAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${testAge:-"N/A"}"'</td>'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${lastTestType:-"N/A"}"'</td>'
+				echo '<td style="text-align:center; background-color:'"${lastTestStatusColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${lastTestType:-"N/A"}"'</td>'
 				echo '</tr>'
 			} >> "${logfile}"
 		fi

From 56acf86c03c176d4615763b4ba59ead63fc9f5c0 Mon Sep 17 00:00:00 2001
From: mth309 <mth309@users.noreply.github.com>
Date: Fri, 13 May 2022 13:39:44 -0400
Subject: [PATCH 090/160] Update report.sh

---
 report.sh | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/report.sh b/report.sh
index 67dc62a..5d353db 100755
--- a/report.sh
+++ b/report.sh
@@ -1240,13 +1240,13 @@ function SASSummary () {
 				lastTestHours=""
 			fi
 
-            # Mimic the true/false response expected from json in the future
-            if [ "${lastTestStatus}" = "- [- - -]" ] || [ "${lastTestType}" = "N/A" ]; then 
-                lastTestStatus="true"
-            else
-                lastTestStatus="false"
-            fi
-            
+			# Mimic the true/false response expected from json in the future
+			if [ "${lastTestStatus}" = "- [- - -]" ] || [ "${lastTestType}" = "N/A" ]; then 
+				lastTestStatus="true"
+			else
+				lastTestStatus="false"
+			fi
+
 			# Available for any drive smartd knows about
 			if [ "$(echo "${sasInfoSmrt}" | jq -Mre '.smart_status.passed | values')" = "true" ]; then
 				local smartStatus="PASSED"
@@ -1381,7 +1381,7 @@ function SASSummary () {
 				local testAgeColor="${bgColor}"
 			fi
 
-            # Colorize Smart test Status
+			# Colorize Smart test Status
 			if [ "${lastTestStatus}" = "false" ]; then
 				local lastTestStatusColor="${critColor}"
 			else

From bc574d6b4ba87e688a001cfde7012b13c2f53b2e Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Fri, 13 May 2022 16:19:03 -0400
Subject: [PATCH 091/160] Fix white space and normalize ordering.

Fixes #9.
---
 report.sh | 30 +++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/report.sh b/report.sh
index 5d353db..20e957c 100755
--- a/report.sh
+++ b/report.sh
@@ -1227,12 +1227,19 @@ function SASSummary () {
 			local lastTestHours="$(echo "${sasInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].lifetime_hours | values')"
 			local lastTestType="$(echo "${sasInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].type.string | values')"
 			local lastTestStatus="$(echo "${sasInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].status.passed | values')"
-            
+
 			#FixMe: relies on non-json output
 			lastTestHours="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '7')"
 			lastTestType="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '3,4')"
 			lastTestStatus="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '8,9,10,11')"
 
+			# Mimic the true/false response expected from json in the future
+			if [ "${lastTestStatus}" = "- [- - -]" ] || [ "${lastTestType}" = "N/A" ]; then
+				lastTestStatus="true"
+			else
+				lastTestStatus="false"
+			fi
+
 			# Workaround for some drives that do not support self testing but still report a garbage self test log
 			# Set last test type to 'N/A' and last test hours to null "" in this case
 			if [ "${lastTestType}" == "Default Self" ]; then
@@ -1240,13 +1247,6 @@ function SASSummary () {
 				lastTestHours=""
 			fi
 
-			# Mimic the true/false response expected from json in the future
-			if [ "${lastTestStatus}" = "- [- - -]" ] || [ "${lastTestType}" = "N/A" ]; then 
-				lastTestStatus="true"
-			else
-				lastTestStatus="false"
-			fi
-
 			# Available for any drive smartd knows about
 			if [ "$(echo "${sasInfoSmrt}" | jq -Mre '.smart_status.passed | values')" = "true" ]; then
 				local smartStatus="PASSED"
@@ -1318,6 +1318,13 @@ function SASSummary () {
 				local smartStatusColor="${okColor}"
 			fi
 
+			# Colorize Smart test Status
+			if [ "${lastTestStatus}" = "false" ]; then
+				local lastTestStatusColor="${critColor}"
+			else
+				local lastTestStatusColor="${bgColor}"
+			fi
+
 			# SAS is both SSD and HDD; colorize temp as appropriate
 			if [ "${rpm}" = "SSD" ]; then
 				# SAS SSD
@@ -1381,13 +1388,6 @@ function SASSummary () {
 				local testAgeColor="${bgColor}"
 			fi
 
-			# Colorize Smart test Status
-			if [ "${lastTestStatus}" = "false" ]; then
-				local lastTestStatusColor="${critColor}"
-			else
-				local lastTestStatusColor="${bgColor}"
-			fi
-
 			{
 				# Row Output
 				echo '<tr style="background-color:'"${bgColor}"';">'

From f3d841f53e119bfde2461e7a9036fa85726dbfb2 Mon Sep 17 00:00:00 2001
From: mth309 <mth309@users.noreply.github.com>
Date: Sat, 14 May 2022 17:33:30 -0400
Subject: [PATCH 092/160] Update report.sh

Fixed the out-of-order check for N/A test status prior to setting that status as a workaround for improper self test support
---
 report.sh | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/report.sh b/report.sh
index 20e957c..37b70b0 100755
--- a/report.sh
+++ b/report.sh
@@ -1234,17 +1234,18 @@ function SASSummary () {
 			lastTestStatus="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '8,9,10,11')"
 
 			# Mimic the true/false response expected from json in the future
-			if [ "${lastTestStatus}" = "- [- - -]" ] || [ "${lastTestType}" = "N/A" ]; then
+			if [ "${lastTestStatus}" = "- [- - -]" ] || 
 				lastTestStatus="true"
 			else
-				lastTestStatus="false"
-			fi
-
-			# Workaround for some drives that do not support self testing but still report a garbage self test log
-			# Set last test type to 'N/A' and last test hours to null "" in this case
-			if [ "${lastTestType}" == "Default Self" ]; then
-				lastTestType="N/A"
-				lastTestHours=""
+				# Workaround for some drives that do not support self testing but still report a garbage self test log
+				# Set last test type to 'N/A' and last test hours to null "" in this case.  Do not colorize test status as a failure.
+				if [ "${lastTestType}" == "Default Self" ]; then
+					lastTestType="N/A"
+					lastTestHours=""
+					lastTestStatus="true"
+				else
+					lastTestStatus="false"
+				fi
 			fi
 
 			# Available for any drive smartd knows about

From 4aecdf9b559659338cc073ccdcb7921642b0b86a Mon Sep 17 00:00:00 2001
From: mth309 <mth309@users.noreply.github.com>
Date: Sat, 14 May 2022 17:35:53 -0400
Subject: [PATCH 093/160] Update report.sh

typo
---
 report.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/report.sh b/report.sh
index 37b70b0..de3ef34 100755
--- a/report.sh
+++ b/report.sh
@@ -1234,7 +1234,7 @@ function SASSummary () {
 			lastTestStatus="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '8,9,10,11')"
 
 			# Mimic the true/false response expected from json in the future
-			if [ "${lastTestStatus}" = "- [- - -]" ] || 
+			if [ "${lastTestStatus}" = "- [- - -]" ]; then
 				lastTestStatus="true"
 			else
 				# Workaround for some drives that do not support self testing but still report a garbage self test log

From 9486e6ae6594cf621623434e8eecc2a8596bb9e8 Mon Sep 17 00:00:00 2001
From: mth309 <mth309@users.noreply.github.com>
Date: Sat, 14 May 2022 18:15:27 -0400
Subject: [PATCH 094/160] Update report.sh

---
 report.sh | 24 +++++++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)

diff --git a/report.sh b/report.sh
index de3ef34..137d9e3 100755
--- a/report.sh
+++ b/report.sh
@@ -766,7 +766,13 @@ function SSDSummary () {
 			# Get more useful times from hours
 			local testAge=""
 			if [ ! -z "${lastTestHours}" ]; then
-				testAge="$(bc <<< "(${onHours} - ${lastTestHours}) / 24")"
+				# Check whether the selftest log times have overflowed after 65,535 hours of total power-on time
+				overflowTest="$((${onHours} - ${lastTestHours}))"
+				if [ "${overflowTest}" -gt "65535" ]; then # Correct the overflow if necessary
+					testAge="$(bc <<< "(${onHours} - ${lastTestHours} - 65535) / 24")"
+				else # Normal Case, no overflow
+					testAge="$(bc <<< "(${onHours} - ${lastTestHours}) / 24")"
+				fi
 			fi
 
 			local yrs="$(bc <<< "${onHours} / 8760")"
@@ -1026,7 +1032,13 @@ function HDDSummary () {
 			# Get more useful times from hours
 			local testAge=""
 			if [ ! -z "${lastTestHours}" ]; then
-				testAge="$(bc <<< "(${onHours} - ${lastTestHours}) / 24")"
+				# Check whether the selftest log times have overflowed after 65,535 hours of total power-on time
+				overflowTest="$((${onHours} - ${lastTestHours}))"
+				if [ "${overflowTest}" -gt "65535" ]; then # Correct the overflow if necessary
+					testAge="$(bc <<< "(${onHours} - ${lastTestHours} - 65535) / 24")"
+				else # Normal Case, no overflow
+					testAge="$(bc <<< "(${onHours} - ${lastTestHours}) / 24")"
+				fi
 			fi
 
 			local yrs="$(bc <<< "${onHours} / 8760")"
@@ -1282,7 +1294,13 @@ function SASSummary () {
 			# Get more useful times from hours
 			local testAge=""
 			if [ ! -z "${lastTestHours}" ]; then
-				testAge="$(bc <<< "(${onHours} - ${lastTestHours}) / 24")"
+				# Check whether the selftest log times have overflowed after 65,535 hours of total power-on time
+				overflowTest="$((${onHours} - ${lastTestHours}))"
+				if [ "${overflowTest}" -gt "65535" ]; then # Correct the overflow if necessary
+					testAge="$(bc <<< "(${onHours} - ${lastTestHours} - 65535) / 24")"
+				else # Normal Case, no overflow
+					testAge="$(bc <<< "(${onHours} - ${lastTestHours}) / 24")"
+				fi
 			fi
 
 			local yrs="$(bc <<< "${onHours} / 8760")"

From 1e42900dded93b11f0bdf168ee7f04e5c3254222 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Fri, 13 May 2022 21:36:13 -0400
Subject: [PATCH 095/160] Remove the last awk outside of ZpoolSummary.

---
 report.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/report.sh b/report.sh
index 137d9e3..8714833 100755
--- a/report.sh
+++ b/report.sh
@@ -1595,7 +1595,7 @@ readarray -t "drives" <<< "$(for drive in $(sysctl -n kern.disks | sed -e 's:nvd
 	elif echo "${drive}" | grep -q "nvme"; then
 		printf "%s " "${drive}"
 	fi
-done | awk '{for (i=NF; i!=0 ; i--) print $i }')"
+done | tr ' ' '\n' | tail -r)"
 
 # Toggles the 'ssdExist' flag to true if SSDs are detected in order to add the summary table
 if [ "${includeSSD}" = "true" ]; then

From 26662714d4d5c4333a99897225b0af3eb567b36a Mon Sep 17 00:00:00 2001
From: mth309 <mth309@users.noreply.github.com>
Date: Sun, 22 May 2022 02:59:22 +0000
Subject: [PATCH 096/160] Fixed the parsing for when a self test is in progress
 on a SAS device.

The previous code was colorizing both lastTestHours and lastTestStatus as critical while the test was running due to parsing the wrong fields.

Fixes #12.
---
 report.sh | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/report.sh b/report.sh
index 8714833..af1a529 100755
--- a/report.sh
+++ b/report.sh
@@ -1241,9 +1241,15 @@ function SASSummary () {
 			local lastTestStatus="$(echo "${sasInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].status.passed | values')"
 
 			#FixMe: relies on non-json output
-			lastTestHours="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '7')"
 			lastTestType="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '3,4')"
-			lastTestStatus="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '8,9,10,11')"
+			local runningNowTest="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '5,6,7,8,9')"
+			if [ "${runningNowTest}" = "Self test in progress ..." ]; then
+				lastTestHours="$(echo "${sasInfoSmrt}" | jq -Mre '.power_on_time.hours | values')"
+				lastTestStatus="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '12,13,14,15')"
+			else
+				lastTestHours="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '7')"
+				lastTestStatus="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '8,9,10,11')"
+			fi
 
 			# Mimic the true/false response expected from json in the future
 			if [ "${lastTestStatus}" = "- [- - -]" ]; then

From a17f7c5e4cd2971c8f017527ce615bb48b10d433 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 27 Jun 2022 10:10:08 -0400
Subject: [PATCH 097/160] Try to be more compatible with different mail
 programs.

Refs #14.
---
 report.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/report.sh b/report.sh
index af1a529..0ce5990 100755
--- a/report.sh
+++ b/report.sh
@@ -167,9 +167,9 @@ function ConfigBackup () {
 			if [ "${emailBackup}" = "true" ]; then
 				# Write MIME section header for file attachment (encoded with base64)
 				echo "--${boundary}"
-				echo -e "Content-Type: application/tar+gzip\n"
+				echo -e "Content-Type: application/tar+gzip name='"'${filename}.tar.gz'"'\n"
+				echo "Content-Disposition: attachment; filename='"'${filename}.tar.gz'"'"
 				echo "Content-Transfer-Encoding: base64"
-				echo "Content-Disposition: attachment; filename=${filename}.tar.gz"
 				base64 "${tarfile}"
 			fi
 

From 9f4b629a1b543b8b1c93a4f14e7025098cbbff11 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Wed, 21 Dec 2022 18:17:55 -0500
Subject: [PATCH 098/160] More consistant sorting.

---
 report.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/report.sh b/report.sh
index af1a529..0575d38 100755
--- a/report.sh
+++ b/report.sh
@@ -1553,6 +1553,7 @@ glabel
 head
 tail
 sendmail
+sort
 )
 if [ "${configBackup}" = "true" ]; then
 commands+=(
@@ -1601,7 +1602,7 @@ readarray -t "drives" <<< "$(for drive in $(sysctl -n kern.disks | sed -e 's:nvd
 	elif echo "${drive}" | grep -q "nvme"; then
 		printf "%s " "${drive}"
 	fi
-done | tr ' ' '\n' | tail -r)"
+done | tr ' ' '\n' | sort -V | sed '/^nvme/!H;//p;$!d;g;s:\n::')"
 
 # Toggles the 'ssdExist' flag to true if SSDs are detected in order to add the summary table
 if [ "${includeSSD}" = "true" ]; then

From 1868d554392bd1be1a93a4cafa1e5995e44b4fb2 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Wed, 21 Dec 2022 18:18:10 -0500
Subject: [PATCH 099/160] Ensure that date functions work consistently.

---
 report.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/report.sh b/report.sh
index 0575d38..469f512 100755
--- a/report.sh
+++ b/report.sh
@@ -70,6 +70,8 @@
 # v1.0
 #   - Initial release
 
+# Defaults
+LANG="en_US.UTF-8" # Ensure date works as expected.
 
 # Functions
 function rpConfig () {

From de2084a0c2fd94fe36d9ef0cb69c1c4c2046638b Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Fri, 23 Dec 2022 15:56:27 -0500
Subject: [PATCH 100/160] Fix shellcheck warnings.

---
 report.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/report.sh b/report.sh
index 469f512..2fb3134 100755
--- a/report.sh
+++ b/report.sh
@@ -769,7 +769,7 @@ function SSDSummary () {
 			local testAge=""
 			if [ ! -z "${lastTestHours}" ]; then
 				# Check whether the selftest log times have overflowed after 65,535 hours of total power-on time
-				overflowTest="$((${onHours} - ${lastTestHours}))"
+				overflowTest="$((onHours - lastTestHours))"
 				if [ "${overflowTest}" -gt "65535" ]; then # Correct the overflow if necessary
 					testAge="$(bc <<< "(${onHours} - ${lastTestHours} - 65535) / 24")"
 				else # Normal Case, no overflow
@@ -1035,7 +1035,7 @@ function HDDSummary () {
 			local testAge=""
 			if [ ! -z "${lastTestHours}" ]; then
 				# Check whether the selftest log times have overflowed after 65,535 hours of total power-on time
-				overflowTest="$((${onHours} - ${lastTestHours}))"
+				overflowTest="$((onHours - lastTestHours))"
 				if [ "${overflowTest}" -gt "65535" ]; then # Correct the overflow if necessary
 					testAge="$(bc <<< "(${onHours} - ${lastTestHours} - 65535) / 24")"
 				else # Normal Case, no overflow
@@ -1303,7 +1303,7 @@ function SASSummary () {
 			local testAge=""
 			if [ ! -z "${lastTestHours}" ]; then
 				# Check whether the selftest log times have overflowed after 65,535 hours of total power-on time
-				overflowTest="$((${onHours} - ${lastTestHours}))"
+				overflowTest="$((onHours - lastTestHours))"
 				if [ "${overflowTest}" -gt "65535" ]; then # Correct the overflow if necessary
 					testAge="$(bc <<< "(${onHours} - ${lastTestHours} - 65535) / 24")"
 				else # Normal Case, no overflow

From 057037f9b37c95330309432c7fad5037d877d242 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 25 Dec 2022 11:33:09 -0500
Subject: [PATCH 101/160] More awk removal.

---
 report.sh | 64 +++++++++++++++++++++++++++++++++++++++++--------------
 1 file changed, 48 insertions(+), 16 deletions(-)

diff --git a/report.sh b/report.sh
index 2fb3134..40cdd7b 100755
--- a/report.sh
+++ b/report.sh
@@ -222,7 +222,9 @@ function ZpoolSummary () {
 	local scrubAgeColor
 	local multiDay
 	local altRow
+	local zfsVersion
 
+	zfsVersion="$(zpool version 2> /dev/null | head -n 1 | sed -e 's:zfs-::')"
 
 	### zpool status summary table
 	{
@@ -245,7 +247,7 @@ function ZpoolSummary () {
 		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Scrub<br>Errors</th>'
 		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last<br>Scrub<br>Age (days)</th>'
 		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last<br>Scrub<br>Duration</th>'
-		echo '</tr>'
+		echo "</tr> <!-- ${zfsVersion} -->"
 	} >> "${logfile}"
 
 
@@ -256,32 +258,35 @@ function ZpoolSummary () {
 		status="$(zpool list -H -o health "${pool}")"
 
 		# zpool fragment summary
-		frag="$(zpool list -H -p -o frag "${pool}" | tr -d %% | awk '{print $0 + 0}')"
+		frag="$(zpool list -H -p -o frag "${pool}")"
 		size="$(zpool list -H -o size "${pool}")"
 		allocated="$(zpool list -H -o allocated "${pool}")"
 		free="$(zpool list -H -o free "${pool}")"
 
 		# Total all read, write, and checksum errors per pool
-		errors="$(zpool status "${pool}" | grep -E "(ONLINE|DEGRADED|FAULTED|UNAVAIL|REMOVED)[ \\t]+[0-9]+")"
+		errors="$(zpool status "${pool}" | grep -E "(ONLINE|DEGRADED|FAULTED|UNAVAIL|REMOVED)[ \\t]+[0-9]+" | tr -s '[:blank:]' ' ')"
 		readErrors="0"
-		for err in $(echo "${errors}" | awk '{print $3}'); do
+		for err in $(echo "${errors}" | cut -d ' ' -f "4"); do
 			if echo "${err}" | grep -E -q "[^0-9]+"; then
+				# Assume a non number value is > 1000
 				readErrors="1000"
 				break
 			fi
 			readErrors="$((readErrors + err))"
 		done
 		writeErrors="0"
-		for err in $(echo "${err}ors" | awk '{print $4}'); do
+		for err in $(echo "${errors}" | cut -d ' ' -f "5"); do
 			if echo "${err}" | grep -E -q "[^0-9]+"; then
+				# Assume a non number value is > 1000
 				writeErrors="1000"
 				break
 			fi
 			writeErrors="$((writeErrors + err))"
 		done
 		cksumErrors="0"
-		for err in $(echo "${err}ors" | awk '{print $5}'); do
+		for err in $(echo "${errors}" | cut -d ' ' -f "6"); do
 			if echo "${err}" | grep -E -q "[^0-9]+"; then
+				# Assume a non number value is > 1000
 				cksumErrors="1000"
 				break
 			fi
@@ -301,24 +306,42 @@ function ZpoolSummary () {
 		scrubAge="N/A"
 		scrubTime="N/A"
 		resilver=""
+		local statusOutputLine
+		local scrubYear
+		local scrubMonth
+		local scrubDay
+		local scrubTime
 
 		statusOutput="$(zpool status "${pool}")"
+		statusOutputLine="$(echo "${statusOutput}" | grep "scan:" | sed -e 's:[[:blank:]]\{1,\}: :g' -e 's:^[[:blank:]]*::')"
+
 		# normal status i.e. scrub
-		if [ "$(echo "${statusOutput}" | grep "scan:" | awk '{print $2" "$3}')" = "scrub repaired" ]; then
+		if [ "$(echo "${statusOutputLine}" | cut -d ' ' -f "2,3")" = "scrub repaired" ]; then
 			multiDay="$(echo "${statusOutput}" | grep "scan" | grep -c "days")"
 			scrubRepBytes="$(echo "${statusOutput}" | grep "scan:" | awk '{gsub(/B/,"",$4); print $4}')"
 			if [ "${multiDay}" -ge 1 ] ; then
-				scrubErrors="$(echo "${statusOutput}" | grep "scan:" | awk '{print $10}')"
+				scrubErrors="$(echo "${statusOutputLine}" | cut -d ' ' -f "10")"
 			else
-				scrubErrors="$(echo "${statusOutput}" | grep "scan:" | awk '{print $8}')"
+				scrubErrors="$(echo "${statusOutputLine}" | cut -d ' ' -f "8")"
 			fi
 
 			# Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
 			if [ "${multiDay}" -ge 1 ] ; then
-				scrubDate="$(echo "${statusOutput}" | grep "scan:" | awk '{print $17"-"$14"-"$15"_"$16}')"
+				# We should test the version of zfs because there still is no json output
+				scrubYear="$(echo "${statusOutputLine}" | cut -d ' ' -f "17")"
+				scrubMonth="$(echo "${statusOutputLine}" | cut -d ' ' -f "14")"
+				scrubDay="$(echo "${statusOutputLine}" | cut -d ' ' -f "15")"
+				scrubTime="$(echo "${statusOutputLine}" | cut -d ' ' -f "16")"
 			else
-				scrubDate="$(echo "${statusOutput}" | grep "scan:" | awk '{print $15"-"$12"-"$13"_"$14}')"
+				# We should test the version of zfs because there still is no json output
+				scrubYear="$(echo "${statusOutputLine}" | cut -d ' ' -f "15")"
+				scrubMonth="$(echo "${statusOutputLine}" | cut -d ' ' -f "12")"
+				scrubDay="$(echo "${statusOutputLine}" | cut -d ' ' -f "13")"
+				scrubTime="$(echo "${statusOutputLine}" | cut -d ' ' -f "14")"
 			fi
+			scrubDate="${scrubYear}-${scrubMonth}-${scrubDay}_${scrubTime}"
+
+
 			scrubTS="$(date -j -f '%Y-%b-%e_%H:%M:%S' "${scrubDate}" '+%s')"
 			currentTS="${runDate}"
 			scrubAge="$((((currentTS - scrubTS) + 43200) / 86400))"
@@ -329,17 +352,26 @@ function ZpoolSummary () {
 			fi
 
 		# if status is resilvered
-		elif [ "$(echo "${statusOutput}" | grep "scan:" | awk '{print $2}')" = "resilvered" ]; then
+		elif [ "$(echo "${statusOutputLine}" | cut -d ' ' -f "2")" = "resilvered" ]; then
 			resilver="<BR>Resilvered"
-			scrubRepBytes="$(echo "${statusOutput}" | grep "scan:" | awk '{print $3}')"
-			scrubErrors="$(echo "${statusOutput}" | grep "scan:" | awk '{print $7}')"
+			scrubRepBytes="$(echo "${statusOutputLine}" | cut -d ' ' -f "3")"
+			scrubErrors="$(echo "${statusOutputLine}" | cut -d ' ' -f "7")"
 
 			# Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
-			scrubDate="$(echo "${statusOutput}" | grep "scan:" | awk '{print $14"-"$11"-"$12"_"$13}')"
+
+			# We should test the version of zfs because there still is no json output
+			scrubYear="$(echo "${statusOutputLine}" | cut -d ' ' -f "14")"
+			scrubMonth="$(echo "${statusOutputLine}" | cut -d ' ' -f "11")"
+			scrubDay="$(echo "${statusOutputLine}" | cut -d ' ' -f "12")"
+			scrubTime="$(echo "${statusOutputLine}" | cut -d ' ' -f "13")"
+
+			scrubDate="${scrubYear}-${scrubMonth}-${scrubDay}_${scrubTime}"
+
+
 			scrubTS="$(date -j -f '%Y-%b-%e_%H:%M:%S' "${scrubDate}" '+%s')"
 			currentTS="${runDate}"
 			scrubAge="$((((currentTS - scrubTS) + 43200) / 86400))"
-			scrubTime="$(echo "${statusOutput}" | grep "scan:" | awk '{print $5}')"
+			scrubTime="$(echo "${statusOutputLine}" | cut -d ' ' -f "5")"
 
 		# Check if resilver is in progress
 		elif [ "$(echo "${statusOutput}"| grep "scan:" | awk '{print $2}')" = "resilver" ]; then

From 87571298c0ad376f0404d3da07147d5f6e9aa910 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 8 Jan 2023 21:26:11 -0500
Subject: [PATCH 102/160] Use xselftest with fallback to selftest.

---
 report.sh | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/report.sh b/report.sh
index 40cdd7b..3e0e861 100755
--- a/report.sh
+++ b/report.sh
@@ -737,11 +737,11 @@ function SSDSummary () {
 	local drive
 	local altRow="false"
     for drive in "${drives[@]}"; do
-		local ssdInfoSmrt="$(smartctl -AHijl selftest --log="devstat" "/dev/${drive}")"
+		local ssdInfoSmrt="$(smartctl -AHijl xselftest,selftest --log="devstat" "/dev/${drive}")"
     	local rotTst="$(echo "${ssdInfoSmrt}" | jq -Mre '.rotation_rate | values')"
     	local scsiTst="$(echo "${ssdInfoSmrt}" | jq -Mre '.device.type | values')"
         if [ "${rotTst}" = "0" ] && [ ! "${scsiTst}" = "scsi" ]; then
-			# For each drive detected, run "smartctl -AHijl selftest" and parse its output.
+			# For each drive detected, run "smartctl -AHijl xselftest,selftest" and parse its output.
 			# Start by parsing out the variables used in other parts of the script.
 			# After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).
 			# After these computations, determine the row's background color (alternating as above, subbing in other colors from the palate as needed).
@@ -1017,14 +1017,14 @@ function HDDSummary () {
 	local drive
 	local altRow="false"
 	for drive in "${drives[@]}"; do
-		local hddInfoSmrt="$(smartctl -AHijl selftest "/dev/${drive}")"
+		local hddInfoSmrt="$(smartctl -AHijl xselftest,selftest "/dev/${drive}")"
 		local rotTst="$(echo "${hddInfoSmrt}" | jq -Mre '.rotation_rate | values')"
 		local scsiTst="$(echo "${hddInfoSmrt}" | jq -Mre '.device.type | values')"
 		if [ -z "${rotTst}" ] && [ ! -z "$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[]? | select(.name == "Spin_Up_Time") | .id | values')" ]; then
 			rotTst="N/R"
 		fi
 		if [ ! "${rotTst:="0"}" = "0" ] && [ ! "${scsiTst}" = "scsi" ]; then
-			# For each drive detected, run "smartctl -AHijl selftest" and parse its output.
+			# For each drive detected, run "smartctl -AHijl xselftest,selftest" and parse its output.
 			# After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).
 			# After these computations, determine the row's background color (alternating as above, subbing in other colors from the palate as needed).
 			# Finally, print the HTML code for the current row of the table with all the gathered data.
@@ -1258,11 +1258,11 @@ function SASSummary () {
 	local drive
 	local altRow="false"
 	for drive in "${drives[@]}"; do
-		local sasInfoSmrt="$(smartctl -AHijl selftest "/dev/${drive}")"
-		local nonJsonSasInfoSmrt="$(smartctl -Al error -l selftest "/dev/${drive}")"
+		local sasInfoSmrt="$(smartctl -AHijl xselftest,selftest "/dev/${drive}")"
+		local nonJsonSasInfoSmrt="$(smartctl -Al error -l xselftest,selftest "/dev/${drive}")"
 		local rotTst="$(echo "${sasInfoSmrt}" | jq -Mre '.device.type | values')"
 		if [ "${rotTst}" = "scsi" ]; then
-			# For each drive detected, run "smartctl -AHijl selftest" and parse its output.
+			# For each drive detected, run "smartctl -AHijl xselftest,selftest" and parse its output.
 			# After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).
 			# After these computations, determine the row's background color (alternating as above, subbing in other colors from the palate as needed).
 			# Finally, print the HTML code for the current row of the table with all the gathered data.
@@ -1765,7 +1765,7 @@ done
 ### SMART status for each drive
 for drive in "${drives[@]}"; do
     smartOut="$(smartctl --json=u -i "/dev/${drive}")" # FixMe: smart support flag is not yet implemented in smartctl json output.
-    smartTestOut="$(smartctl -l selftest "/dev/${drive}")"
+    smartTestOut="$(smartctl -l xselftest,selftest "/dev/${drive}")"
 
     if echo "${smartOut}" | grep "SMART support is:" | grep -q "Enabled"; then # FixMe: smart support flag is not yet implemented in smartctl json output.
         # Gather brand and serial number of each drive

From 21a54820f4fa5f51af3bb7a06fa3adc1befe5dee Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 8 Jan 2023 22:48:30 -0500
Subject: [PATCH 103/160] Make sure the blank line is where it should be.

---
 report.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/report.sh b/report.sh
index 0ce5990..bcfe67b 100755
--- a/report.sh
+++ b/report.sh
@@ -167,9 +167,9 @@ function ConfigBackup () {
 			if [ "${emailBackup}" = "true" ]; then
 				# Write MIME section header for file attachment (encoded with base64)
 				echo "--${boundary}"
-				echo -e "Content-Type: application/tar+gzip name='"'${filename}.tar.gz'"'\n"
+				echo "Content-Type: application/tar+gzip name='"'${filename}.tar.gz'"'"
 				echo "Content-Disposition: attachment; filename='"'${filename}.tar.gz'"'"
-				echo "Content-Transfer-Encoding: base64"
+				echo -e "Content-Transfer-Encoding: base64\n"
 				base64 "${tarfile}"
 			fi
 

From 0abff90996306e4b2fdf60e34a94381e97601dad Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 9 Jan 2023 09:04:52 -0500
Subject: [PATCH 104/160] Fix quotes.

---
 report.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/report.sh b/report.sh
index bcfe67b..f874f86 100755
--- a/report.sh
+++ b/report.sh
@@ -167,8 +167,8 @@ function ConfigBackup () {
 			if [ "${emailBackup}" = "true" ]; then
 				# Write MIME section header for file attachment (encoded with base64)
 				echo "--${boundary}"
-				echo "Content-Type: application/tar+gzip name='"'${filename}.tar.gz'"'"
-				echo "Content-Disposition: attachment; filename='"'${filename}.tar.gz'"'"
+				echo 'Content-Type: application/tar+gzip name="'"${filename}.tar.gz"'"'
+				echo 'Content-Disposition: attachment; filename="'"${filename}.tar.gz"'"'
 				echo -e "Content-Transfer-Encoding: base64\n"
 				base64 "${tarfile}"
 			fi

From 9e0be2158f0da7f061a9dd090572fab0bbf820fe Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 9 Jan 2023 15:12:45 -0500
Subject: [PATCH 105/160] Add examples to test against.

---
 examples/zfs-2.0.7-1-resilvered-days.txt      |  4 +++
 examples/zfs-2.1.6-1-resilvered.txt           | 29 +++++++++++++++++++
 .../zfs-2.1.6-1-scrub-progress-faulted.txt    | 29 +++++++++++++++++++
 examples/zfs-2.1.6-1-scrub.txt                | 22 ++++++++++++++
 4 files changed, 84 insertions(+)
 create mode 100644 examples/zfs-2.0.7-1-resilvered-days.txt
 create mode 100644 examples/zfs-2.1.6-1-resilvered.txt
 create mode 100644 examples/zfs-2.1.6-1-scrub-progress-faulted.txt
 create mode 100644 examples/zfs-2.1.6-1-scrub.txt

diff --git a/examples/zfs-2.0.7-1-resilvered-days.txt b/examples/zfs-2.0.7-1-resilvered-days.txt
new file mode 100644
index 0000000..20a97c2
--- /dev/null
+++ b/examples/zfs-2.0.7-1-resilvered-days.txt
@@ -0,0 +1,4 @@
+pool: pool1
+state: ONLINE
+scan: resilvered 2.31T in 1 days 02:55:32 with 0 errors on Sat Dec 24 02:33:08 2022
+config:
diff --git a/examples/zfs-2.1.6-1-resilvered.txt b/examples/zfs-2.1.6-1-resilvered.txt
new file mode 100644
index 0000000..2705f97
--- /dev/null
+++ b/examples/zfs-2.1.6-1-resilvered.txt
@@ -0,0 +1,29 @@
+  pool: data
+ state: ONLINE
+status: Some supported and requested features are not enabled on the pool.
+	The pool can still be used, but some features are unavailable.
+action: Enable all features using 'zpool upgrade'. Once this is done,
+	the pool may no longer be accessible by software that does not support
+	the features. See zpool-features(7) for details.
+  scan: resilvered 132K in 00:00:02 with 0 errors on Mon Jan  2 17:44:21 2023
+config:
+
+	NAME                                            STATE     READ WRITE CKSUM
+	data                                            ONLINE       0     0     0
+	  raidz3-0                                      ONLINE       0     0     0
+	    gptid/95378d35-7b98-11ed-b486-d05099c13d03  ONLINE       0     0     0
+	    gptid/4b4c3c38-6e06-11ed-a9d5-d05099c13d03  ONLINE       0     0     0
+	    gptid/9b844178-2482-11ec-8714-d05099c13d03  ONLINE       0     0     0
+	    gptid/f0affe10-321b-11ec-ba66-d05099c13d03  ONLINE       0     0     0
+	    gptid/e5f87be0-27e7-11ec-96bc-d05099c13d03  ONLINE       0     0     0
+	    gptid/e9d6ea26-25dc-11ec-8714-d05099c13d03  ONLINE       0     0     0
+	    gptid/a02741cb-2527-11ec-8714-d05099c13d03  ONLINE       0     0     0
+	    gptid/33fe635d-2713-11ec-8714-d05099c13d03  ONLINE       0     0     0
+	logs	
+	  mirror-7                                      ONLINE       0     0     0
+	    gptid/5055ae20-8aed-11ed-9195-d05099c13d03  ONLINE       0     0     0
+	    gptid/50543165-8aed-11ed-9195-d05099c13d03  ONLINE       0     0     0
+	cache
+	  gptid/5052b77e-8aed-11ed-9195-d05099c13d03    ONLINE       0     0     0
+
+errors: No known data errors
diff --git a/examples/zfs-2.1.6-1-scrub-progress-faulted.txt b/examples/zfs-2.1.6-1-scrub-progress-faulted.txt
new file mode 100644
index 0000000..a2c90e2
--- /dev/null
+++ b/examples/zfs-2.1.6-1-scrub-progress-faulted.txt
@@ -0,0 +1,29 @@
+  pool: data
+ state: DEGRADED
+status: One or more devices are faulted in response to persistent errors.
+	Sufficient replicas exist for the pool to continue functioning in a
+	degraded state.
+action: Replace the faulted device, or use 'zpool clear' to mark the device
+	repaired.
+  scan: scrub in progress since Mon Nov  7 16:49:08 2022
+	13.0T scanned at 897M/s, 12.3T issued at 844M/s, 19.6T total
+	0B repaired, 62.53% done, 02:32:21 to go
+config:
+
+	NAME                                            STATE     READ WRITE CKSUM
+	data                                            DEGRADED     0     0     0
+	  raidz3-0                                      DEGRADED     0     0     0
+	    gptid/9ad22988-32e1-11ec-ba66-d05099c13d03  ONLINE       0     0     0
+	    gptid/4543d53c-584a-11ed-9456-d05099c13d03  FAULTED     17   134     0  too many errors
+	    gptid/9b844178-2482-11ec-8714-d05099c13d03  ONLINE       0     0     0
+	    gptid/f0affe10-321b-11ec-ba66-d05099c13d03  ONLINE       0     0     0
+	    gptid/e5f87be0-27e7-11ec-96bc-d05099c13d03  ONLINE       0     0     0
+	    gptid/e9d6ea26-25dc-11ec-8714-d05099c13d03  ONLINE       0     0     0
+	    gptid/a02741cb-2527-11ec-8714-d05099c13d03  ONLINE       0     0     0
+	    gptid/33fe635d-2713-11ec-8714-d05099c13d03  ONLINE       0     0     0
+	logs	
+	  gptid/d0e8b937-6a7f-11ec-b0e6-d05099c13d03    ONLINE       0     0     0
+	cache
+	  gptid/a228d8bb-56ec-11eb-9900-d05099c13d03    ONLINE       0     0     0
+
+errors: No known data errors
diff --git a/examples/zfs-2.1.6-1-scrub.txt b/examples/zfs-2.1.6-1-scrub.txt
new file mode 100644
index 0000000..2d9534c
--- /dev/null
+++ b/examples/zfs-2.1.6-1-scrub.txt
@@ -0,0 +1,22 @@
+  pool: jails
+ state: ONLINE
+status: Some supported and requested features are not enabled on the pool.
+	The pool can still be used, but some features are unavailable.
+action: Enable all features using 'zpool upgrade'. Once this is done,
+	the pool may no longer be accessible by software that does not support
+	the features. See zpool-features(7) for details.
+  scan: scrub repaired 0B in 00:37:54 with 0 errors on Thu Dec 15 02:37:58 2022
+config:
+
+	NAME                                            STATE     READ WRITE CKSUM
+	jails                                           ONLINE       0     0     0
+	  mirror-0                                      ONLINE       0     0     0
+	    gptid/5af3b112-ae22-11ec-b1df-d05099c13d03  ONLINE       0     0     0
+	    gptid/eb3d01ce-ad8c-11ec-b1df-d05099c13d03  ONLINE       0     0     0
+	  mirror-1                                      ONLINE       0     0     0
+	    gptid/6f46a30c-0366-11ec-9de4-d05099c13d03  ONLINE       0     0     0
+	    gptid/dda6dac8-0382-11ec-9de4-d05099c13d03  ONLINE       0     0     0
+	cache
+	  gptid/3dce1035-8aea-11ed-b30b-d05099c13d03    ONLINE       0     0     0
+
+errors: No known data errors

From e67f138ce43945503a75e204539f7fc18203a9e9 Mon Sep 17 00:00:00 2001
From: Marco <marco@gmx.com>
Date: Mon, 9 Jan 2023 22:25:28 +0100
Subject: [PATCH 106/160] Add an example of long running resilver

---
 examples/zfs-2.0.7-1-resilvered-days.txt | 31 +++++++++++++++++++++---
 1 file changed, 28 insertions(+), 3 deletions(-)

diff --git a/examples/zfs-2.0.7-1-resilvered-days.txt b/examples/zfs-2.0.7-1-resilvered-days.txt
index 20a97c2..14287c5 100644
--- a/examples/zfs-2.0.7-1-resilvered-days.txt
+++ b/examples/zfs-2.0.7-1-resilvered-days.txt
@@ -1,4 +1,29 @@
-pool: pool1
-state: ONLINE
-scan: resilvered 2.31T in 1 days 02:55:32 with 0 errors on Sat Dec 24 02:33:08 2022
+  pool: pool1
+ state: ONLINE
+  scan: resilvered 2.31T in 1 days 02:55:32 with 0 errors on Sat Dec 24 02:33:08 2022
 config:
+
+	NAME                                            STATE     READ WRITE CKSUM
+	pool1                                           ONLINE       0     0     0
+	  raidz2-0                                      ONLINE       0     0     0
+	    gptid/ef161b9c-99fb-11eb-8c44-8cdcd4a82a00  ONLINE       0     0     0
+	    gptid/b2fbf31f-775c-11ea-bfca-8cdcd4a82a00  ONLINE       0     0     0
+	    gptid/dabfaddf-a405-11ea-b106-8cdcd4a82a00  ONLINE       0     0     0
+	    gptid/389c44fd-d75d-11eb-8c44-8cdcd4a82a00  ONLINE       0     0     0
+	    gptid/61a310f2-b648-11eb-8c44-8cdcd4a82a00  ONLINE       0     0     0
+	    gptid/9bbeb65a-5a7d-11ea-bfca-8cdcd4a82a00  ONLINE       0     0     0
+	  raidz2-3                                      ONLINE       0     0     0
+	    gptid/ddf50f19-3924-11ed-937c-8cdcd4a82a00  ONLINE       0     0     0
+	    gptid/261a8ad5-5d32-11ed-937c-8cdcd4a82a00  ONLINE       0     0     0
+	    gptid/490f137c-c2f2-11ec-937c-8cdcd4a82a00  ONLINE       0     0     0
+	    gptid/3aee2726-8249-11ed-937c-8cdcd4a82a00  ONLINE       0     0     0
+	    gptid/cbf18155-1cbf-11e5-a52f-74d02b98b14b  ONLINE       0     0     0
+	    gptid/cc577a01-1cbf-11e5-a52f-74d02b98b14b  ONLINE       0     0     0
+	logs	
+	  mirror-1                                      ONLINE       0     0     0
+	    gptid/5425d823-5d1b-11ed-937c-8cdcd4a82a00  ONLINE       0     0     0
+	    gptid/79af7112-758b-11ec-b210-8cdcd4a82a00  ONLINE       0     0     0
+	cache
+	  gptid/6f326eed-6dcd-11e6-92ad-74d02b98b14b    ONLINE       0     0     0
+
+errors: No known data errors

From 81d523eda795988bf10b9879b0d82f2d25162d8b Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 9 Jan 2023 18:44:53 -0500
Subject: [PATCH 107/160] Change to scrubDuration for better clarity and to
 avoid collisions.

---
 report.sh | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/report.sh b/report.sh
index 3e0e861..885d275 100755
--- a/report.sh
+++ b/report.sh
@@ -208,7 +208,7 @@ function ZpoolSummary () {
 	local scrubRepBytes
 	local scrubErrors
 	local scrubAge
-	local scrubTime
+	local scrubDuration
 	local resilver
 	local statusOutput
 	local bgColor
@@ -304,7 +304,7 @@ function ZpoolSummary () {
 		scrubRepBytes="N/A"
 		scrubErrors="N/A"
 		scrubAge="N/A"
-		scrubTime="N/A"
+		scrubDuration="N/A"
 		resilver=""
 		local statusOutputLine
 		local scrubYear
@@ -346,9 +346,9 @@ function ZpoolSummary () {
 			currentTS="${runDate}"
 			scrubAge="$((((currentTS - scrubTS) + 43200) / 86400))"
 			if [ "${multiDay}" -ge 1 ] ; then
-				scrubTime="$(echo "${statusOutput}" | grep "scan" | awk '{print $6" "$7" "$8}')"
+				scrubDuration="$(echo "${statusOutput}" | grep "scan" | awk '{print $6" "$7" "$8}')"
 			else
-				scrubTime="$(echo "${statusOutput}" | grep "scan" | awk '{print $6}')"
+				scrubDuration="$(echo "${statusOutput}" | grep "scan" | awk '{print $6}')"
 			fi
 
 		# if status is resilvered
@@ -371,13 +371,13 @@ function ZpoolSummary () {
 			scrubTS="$(date -j -f '%Y-%b-%e_%H:%M:%S' "${scrubDate}" '+%s')"
 			currentTS="${runDate}"
 			scrubAge="$((((currentTS - scrubTS) + 43200) / 86400))"
-			scrubTime="$(echo "${statusOutputLine}" | cut -d ' ' -f "5")"
+			scrubDuration="$(echo "${statusOutputLine}" | cut -d ' ' -f "5")"
 
 		# Check if resilver is in progress
 		elif [ "$(echo "${statusOutput}"| grep "scan:" | awk '{print $2}')" = "resilver" ]; then
 			scrubRepBytes="Resilver In Progress"
 			scrubAge="$(echo "${statusOutput}" | grep "resilvered," | awk '{print $3" done"}')"
-			scrubTime="$(echo "${statusOutput}" | grep "resilvered," | awk '{print $5"<br>to go"}')"
+			scrubDuration="$(echo "${statusOutput}" | grep "resilvered," | awk '{print $5"<br>to go"}')"
 
 		# Check if scrub is in progress
 		elif [ "$(echo "${statusOutput}"| grep "scan:" | awk '{print $4}')" = "progress" ]; then
@@ -385,9 +385,9 @@ function ZpoolSummary () {
 			scrubErrors="$(echo "${statusOutput}" | grep "repaired," | awk '{print $1" repaired"}')"
 			scrubAge="$(echo "${statusOutput}" | grep "repaired," | awk '{print $3" done"}')"
 			if [ "$(echo "${statusOutput}" | grep "repaired," | awk '{print $5}')" = "0" ]; then
-				scrubTime="$(echo "${statusOutput}" | grep "repaired," | awk '{print $7"<br>to go"}')"
+				scrubDuration="$(echo "${statusOutput}" | grep "repaired," | awk '{print $7"<br>to go"}')"
 			else
-				scrubTime="$(echo "${statusOutput}" | grep "repaired," | awk '{print $5" "$6" "$7"<br>to go"}')"
+				scrubDuration="$(echo "${statusOutput}" | grep "repaired," | awk '{print $5" "$6" "$7"<br>to go"}')"
 			fi
 		fi
 
@@ -466,7 +466,7 @@ function ZpoolSummary () {
 			echo '<td style="text-align:center; background-color:'"${scrubRepBytesColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scrubRepBytes}"'</td>'
 			echo '<td style="text-align:center; background-color:'"${scrubErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scrubErrors}"'</td>'
 			echo '<td style="text-align:center; background-color:'"${scrubAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scrubAge}"'</td>'
-			echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scrubTime}"'</td>'
+			echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scrubDuration}"'</td>'
 			echo '</tr>'
 		} >> "${logfile}"
 	done

From 1477f69d952d27453e2a65b7d823d77c1ca201d5 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 9 Jan 2023 20:08:30 -0500
Subject: [PATCH 108/160] Add sections.

---
 report.sh | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/report.sh b/report.sh
index 885d275..5ea02cd 100755
--- a/report.sh
+++ b/report.sh
@@ -193,6 +193,7 @@ function ConfigBackup () {
 }
 
 function ZpoolSummary () {
+	{
 	local pool
 	local status
 	local frag
@@ -223,6 +224,7 @@ function ZpoolSummary () {
 	local multiDay
 	local altRow
 	local zfsVersion
+	}
 
 	zfsVersion="$(zpool version 2> /dev/null | head -n 1 | sed -e 's:zfs-::')"
 
@@ -317,6 +319,7 @@ function ZpoolSummary () {
 
 		# normal status i.e. scrub
 		if [ "$(echo "${statusOutputLine}" | cut -d ' ' -f "2,3")" = "scrub repaired" ]; then
+			{
 			multiDay="$(echo "${statusOutput}" | grep "scan" | grep -c "days")"
 			scrubRepBytes="$(echo "${statusOutput}" | grep "scan:" | awk '{gsub(/B/,"",$4); print $4}')"
 			if [ "${multiDay}" -ge 1 ] ; then
@@ -350,9 +353,11 @@ function ZpoolSummary () {
 			else
 				scrubDuration="$(echo "${statusOutput}" | grep "scan" | awk '{print $6}')"
 			fi
+			}
 
 		# if status is resilvered
 		elif [ "$(echo "${statusOutputLine}" | cut -d ' ' -f "2")" = "resilvered" ]; then
+			{
 			resilver="<BR>Resilvered"
 			scrubRepBytes="$(echo "${statusOutputLine}" | cut -d ' ' -f "3")"
 			scrubErrors="$(echo "${statusOutputLine}" | cut -d ' ' -f "7")"
@@ -372,15 +377,19 @@ function ZpoolSummary () {
 			currentTS="${runDate}"
 			scrubAge="$((((currentTS - scrubTS) + 43200) / 86400))"
 			scrubDuration="$(echo "${statusOutputLine}" | cut -d ' ' -f "5")"
+			}
 
 		# Check if resilver is in progress
 		elif [ "$(echo "${statusOutput}"| grep "scan:" | awk '{print $2}')" = "resilver" ]; then
+			{
 			scrubRepBytes="Resilver In Progress"
 			scrubAge="$(echo "${statusOutput}" | grep "resilvered," | awk '{print $3" done"}')"
 			scrubDuration="$(echo "${statusOutput}" | grep "resilvered," | awk '{print $5"<br>to go"}')"
+			}
 
 		# Check if scrub is in progress
 		elif [ "$(echo "${statusOutput}"| grep "scan:" | awk '{print $4}')" = "progress" ]; then
+			{
 			scrubRepBytes="Scrub In Progress"
 			scrubErrors="$(echo "${statusOutput}" | grep "repaired," | awk '{print $1" repaired"}')"
 			scrubAge="$(echo "${statusOutput}" | grep "repaired," | awk '{print $3" done"}')"
@@ -389,8 +398,10 @@ function ZpoolSummary () {
 			else
 				scrubDuration="$(echo "${statusOutput}" | grep "repaired," | awk '{print $5" "$6" "$7"<br>to go"}')"
 			fi
+			}
 		fi
 
+		{
 		# Set the row background color
 		if [ "${altRow}" = "false" ]; then
 			local bgColor="#ffffff"
@@ -449,6 +460,7 @@ function ZpoolSummary () {
 		else
 			scrubAgeColor="${bgColor}"
 		fi
+		}
 
 		{
 			# Use the information gathered above to write the date to the current table row

From 74b4cad11811073af8e52050656f8fa39972bfda Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 9 Jan 2023 20:15:55 -0500
Subject: [PATCH 109/160] Support multi-day reslivers.

Fixes #16.
---
 report.sh | 25 ++++++++++++++++++-------
 1 file changed, 18 insertions(+), 7 deletions(-)

diff --git a/report.sh b/report.sh
index 5ea02cd..ce9e97c 100755
--- a/report.sh
+++ b/report.sh
@@ -359,24 +359,35 @@ function ZpoolSummary () {
 		elif [ "$(echo "${statusOutputLine}" | cut -d ' ' -f "2")" = "resilvered" ]; then
 			{
 			resilver="<BR>Resilvered"
+			multiDay="$(echo "${statusOutput}" | grep "scan" | grep -c "days")"
 			scrubRepBytes="$(echo "${statusOutputLine}" | cut -d ' ' -f "3")"
-			scrubErrors="$(echo "${statusOutputLine}" | cut -d ' ' -f "7")"
 
 			# Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
+			if [ "${multiDay}" -ge "1" ] ; then
+				# We should test the version of zfs because there still is no json output
+				scrubYear="$(echo "${statusOutputLine}" | cut -d ' ' -f "16")"
+				scrubMonth="$(echo "${statusOutputLine}" | cut -d ' ' -f "13")"
+				scrubDay="$(echo "${statusOutputLine}" | cut -d ' ' -f "14")"
+				scrubTime="$(echo "${statusOutputLine}" | cut -d ' ' -f "15")"
 
-			# We should test the version of zfs because there still is no json output
-			scrubYear="$(echo "${statusOutputLine}" | cut -d ' ' -f "14")"
-			scrubMonth="$(echo "${statusOutputLine}" | cut -d ' ' -f "11")"
-			scrubDay="$(echo "${statusOutputLine}" | cut -d ' ' -f "12")"
-			scrubTime="$(echo "${statusOutputLine}" | cut -d ' ' -f "13")"
+				scrubDuration="$(echo "${statusOutputLine}" | cut -d ' ' -f "5-7")"
+				scrubErrors="$(echo "${statusOutputLine}" | cut -d ' ' -f "9")"
+			else
+				# We should test the version of zfs because there still is no json output
+				scrubYear="$(echo "${statusOutputLine}" | cut -d ' ' -f "14")"
+				scrubMonth="$(echo "${statusOutputLine}" | cut -d ' ' -f "11")"
+				scrubDay="$(echo "${statusOutputLine}" | cut -d ' ' -f "12")"
+				scrubTime="$(echo "${statusOutputLine}" | cut -d ' ' -f "13")"
 
+				scrubDuration="$(echo "${statusOutputLine}" | cut -d ' ' -f "5")"
+				scrubErrors="$(echo "${statusOutputLine}" | cut -d ' ' -f "7")"
+			fi
 			scrubDate="${scrubYear}-${scrubMonth}-${scrubDay}_${scrubTime}"
 
 
 			scrubTS="$(date -j -f '%Y-%b-%e_%H:%M:%S' "${scrubDate}" '+%s')"
 			currentTS="${runDate}"
 			scrubAge="$((((currentTS - scrubTS) + 43200) / 86400))"
-			scrubDuration="$(echo "${statusOutputLine}" | cut -d ' ' -f "5")"
 			}
 
 		# Check if resilver is in progress

From 975277910b0935b0bb4bec7bf08f555148d60e1f Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 9 Jan 2023 20:19:49 -0500
Subject: [PATCH 110/160] Add more examples.

---
 examples/zfs-2.1.6-1-resilver-progress.txt | 29 ++++++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 examples/zfs-2.1.6-1-resilver-progress.txt

diff --git a/examples/zfs-2.1.6-1-resilver-progress.txt b/examples/zfs-2.1.6-1-resilver-progress.txt
new file mode 100644
index 0000000..6eb9aa4
--- /dev/null
+++ b/examples/zfs-2.1.6-1-resilver-progress.txt
@@ -0,0 +1,29 @@
+  pool: data
+ state: ONLINE
+status: One or more devices is currently being resilvered.  The pool will
+	continue to function, possibly in a degraded state.
+action: Wait for the resilver to complete.
+  scan: resilver in progress since Sat Dec 31 21:46:04 2022
+	14.9T scanned at 19.3G/s, 14.9T issued at 19.3G/s, 20.5T total
+	0B resilvered, 72.80% done, 00:04:56 to go
+config:
+
+	NAME                                            STATE     READ WRITE CKSUM
+	data                                            ONLINE       0     0     0
+	  raidz3-0                                      ONLINE       0     0     0
+	    gptid/95378d35-7b98-11ed-b486-d05099c13d03  ONLINE       0     0     0
+	    gptid/4b4c3c38-6e06-11ed-a9d5-d05099c13d03  ONLINE       0     0     0
+	    gptid/9b844178-2482-11ec-8714-d05099c13d03  ONLINE       0     0     0
+	    gptid/f0affe10-321b-11ec-ba66-d05099c13d03  ONLINE       0     0     0
+	    gptid/e5f87be0-27e7-11ec-96bc-d05099c13d03  ONLINE       0     0     0
+	    gptid/e9d6ea26-25dc-11ec-8714-d05099c13d03  ONLINE       0     0     0
+	    gptid/a02741cb-2527-11ec-8714-d05099c13d03  ONLINE       0     0     0
+	    gptid/33fe635d-2713-11ec-8714-d05099c13d03  ONLINE       0     0     0
+	logs	
+	  mirror-6                                      ONLINE       0     0     0
+	    gptid/e2c3914f-8596-11ed-bce6-d05099c13d03  ONLINE       0     0     0
+	    gptid/6f5748eb-897e-11ed-aa49-d05099c13d03  ONLINE       0     0     0
+	cache
+	  gptid/b2daa313-80d2-11ed-b9fa-d05099c13d03    ONLINE       0     0     0
+
+errors: No known data errors

From 2fb6954dda32ee957bb7be3ec037b8bc3f0a5730 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Tue, 10 Jan 2023 00:57:48 -0500
Subject: [PATCH 111/160] The last of the awk removal.

---
 report.sh | 47 ++++++++++++++++++++++++-----------------------
 1 file changed, 24 insertions(+), 23 deletions(-)

diff --git a/report.sh b/report.sh
index ce9e97c..d2ddf71 100755
--- a/report.sh
+++ b/report.sh
@@ -320,13 +320,8 @@ function ZpoolSummary () {
 		# normal status i.e. scrub
 		if [ "$(echo "${statusOutputLine}" | cut -d ' ' -f "2,3")" = "scrub repaired" ]; then
 			{
-			multiDay="$(echo "${statusOutput}" | grep "scan" | grep -c "days")"
-			scrubRepBytes="$(echo "${statusOutput}" | grep "scan:" | awk '{gsub(/B/,"",$4); print $4}')"
-			if [ "${multiDay}" -ge 1 ] ; then
-				scrubErrors="$(echo "${statusOutputLine}" | cut -d ' ' -f "10")"
-			else
-				scrubErrors="$(echo "${statusOutputLine}" | cut -d ' ' -f "8")"
-			fi
+			multiDay="$(echo "${statusOutputLine}" | grep -c "days")"
+			scrubRepBytes="$(echo "${statusOutputLine}" | cut -d ' ' -f "4" | sed -e 's:B::')"
 
 			# Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
 			if [ "${multiDay}" -ge 1 ] ; then
@@ -335,12 +330,18 @@ function ZpoolSummary () {
 				scrubMonth="$(echo "${statusOutputLine}" | cut -d ' ' -f "14")"
 				scrubDay="$(echo "${statusOutputLine}" | cut -d ' ' -f "15")"
 				scrubTime="$(echo "${statusOutputLine}" | cut -d ' ' -f "16")"
+
+				scrubDuration="$(echo "${statusOutputLine}" | cut -d ' ' -f "6-8")"
+				scrubErrors="$(echo "${statusOutputLine}" | cut -d ' ' -f "10")"
 			else
 				# We should test the version of zfs because there still is no json output
 				scrubYear="$(echo "${statusOutputLine}" | cut -d ' ' -f "15")"
 				scrubMonth="$(echo "${statusOutputLine}" | cut -d ' ' -f "12")"
 				scrubDay="$(echo "${statusOutputLine}" | cut -d ' ' -f "13")"
 				scrubTime="$(echo "${statusOutputLine}" | cut -d ' ' -f "14")"
+
+				scrubDuration="$(echo "${statusOutputLine}" | cut -d ' ' -f "6")"
+				scrubErrors="$(echo "${statusOutputLine}" | cut -d ' ' -f "8")"
 			fi
 			scrubDate="${scrubYear}-${scrubMonth}-${scrubDay}_${scrubTime}"
 
@@ -348,11 +349,6 @@ function ZpoolSummary () {
 			scrubTS="$(date -j -f '%Y-%b-%e_%H:%M:%S' "${scrubDate}" '+%s')"
 			currentTS="${runDate}"
 			scrubAge="$((((currentTS - scrubTS) + 43200) / 86400))"
-			if [ "${multiDay}" -ge 1 ] ; then
-				scrubDuration="$(echo "${statusOutput}" | grep "scan" | awk '{print $6" "$7" "$8}')"
-			else
-				scrubDuration="$(echo "${statusOutput}" | grep "scan" | awk '{print $6}')"
-			fi
 			}
 
 		# if status is resilvered
@@ -391,23 +387,29 @@ function ZpoolSummary () {
 			}
 
 		# Check if resilver is in progress
-		elif [ "$(echo "${statusOutput}"| grep "scan:" | awk '{print $2}')" = "resilver" ]; then
+		elif [ "$(echo "${statusOutputLine}" | cut -d ' ' -f "2")" = "resilver" ]; then
 			{
 			scrubRepBytes="Resilver In Progress"
-			scrubAge="$(echo "${statusOutput}" | grep "resilvered," | awk '{print $3" done"}')"
-			scrubDuration="$(echo "${statusOutput}" | grep "resilvered," | awk '{print $5"<br>to go"}')"
+			statusOutputLine="$(echo "${statusOutput}" | grep "resilvered," | sed -e 's:[[:blank:]]\{1,\}: :g' -e 's:^[[:blank:]]*::')"
+
+			scrubAge="$(echo "${statusOutputLine}" | cut -d ' ' -f "3") done"
+			scrubDuration="$(echo "${statusOutputLine}" | cut -d ' ' -f "5") <br> to go"
 			}
 
 		# Check if scrub is in progress
-		elif [ "$(echo "${statusOutput}"| grep "scan:" | awk '{print $4}')" = "progress" ]; then
+		elif [ "$(echo "${statusOutputLine}" | cut -d ' ' -f "4")" = "progress" ]; then
 			{
 			scrubRepBytes="Scrub In Progress"
-			scrubErrors="$(echo "${statusOutput}" | grep "repaired," | awk '{print $1" repaired"}')"
-			scrubAge="$(echo "${statusOutput}" | grep "repaired," | awk '{print $3" done"}')"
-			if [ "$(echo "${statusOutput}" | grep "repaired," | awk '{print $5}')" = "0" ]; then
-				scrubDuration="$(echo "${statusOutput}" | grep "repaired," | awk '{print $7"<br>to go"}')"
+			statusOutputLine="$(echo "${statusOutput}" | grep "repaired," | sed -e 's:[[:blank:]]\{1,\}: :g' -e 's:^[[:blank:]]*::')"
+
+			scrubErrors="$(echo "${statusOutputLine}" | cut -d ' ' -f "1") repaired"
+			scrubAge="$(echo "${statusOutputLine}" | cut -d ' ' -f "3") done"
+
+			# FixMe: no example of this to test against
+			if [ "$(echo "${statusOutputLine}" | cut -d ' ' -f "5")" = "0" ]; then
+				scrubDuration="$(echo "${statusOutputLine}" | cut -d ' ' -f "7") <br> to go"
 			else
-				scrubDuration="$(echo "${statusOutput}" | grep "repaired," | awk '{print $5" "$6" "$7"<br>to go"}')"
+				scrubDuration="$(echo "${statusOutputLine}" | cut -d ' ' -f "5") <br> to go"
 			fi
 			}
 		fi
@@ -466,7 +468,7 @@ function ZpoolSummary () {
 			scrubErrorsColor="${bgColor}"
 		fi
 
-		if [ "$(echo "$scrubAge" | awk '{print int($1)}')" -gt "${scrubAgeWarn}" ]; then
+		if [ "$(bc <<< "scale=0;(${scrubAge//%//}+0)/1")" -gt "${scrubAgeWarn}" ]; then
 			scrubAgeColor="${warnColor}"
 		else
 			scrubAgeColor="${bgColor}"
@@ -1599,7 +1601,6 @@ date
 sysctl
 sed
 grep
-awk
 zpool
 cut
 tr

From e771d7f901424edf88282002f82f7fd5f023161e Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Tue, 10 Jan 2023 11:16:47 -0500
Subject: [PATCH 112/160] Combine multiple echos into single heredocs.

---
 report.sh | 63 ++++++++++++++++++++++++++++++++++---------------------
 1 file changed, 39 insertions(+), 24 deletions(-)

diff --git a/report.sh b/report.sh
index f874f86..730464a 100755
--- a/report.sh
+++ b/report.sh
@@ -146,12 +146,15 @@ function ConfigBackup () {
 
         # Config integrity check failed, set MIME content type to html and print warning
         {
-            echo "--${boundary}"
-            echo "Content-Transfer-Encoding: 8bit"
-            echo -e "Content-Type: text/html; charset=utf-8\n"
-            echo "<b>Automatic backup of TrueNAS configuration has failed! The configuration file is corrupted!</b>"
-            echo "<b>You should correct this problem as soon as possible!</b>"
-            echo "<br>"
+			tee <<- EOF
+				--${boundary}
+				Content-Transfer-Encoding: 8bit
+				Content-Type: text/html; charset=utf-8
+
+				<b>Automatic backup of TrueNAS configuration has failed! The configuration file is corrupted!</b>
+				<b>You should correct this problem as soon as possible!</b>
+				<br>
+EOF
         } >> "${logfile}"
     else
         # Config integrity check passed; copy config db, generate checksums, make .tar.gz archive
@@ -166,17 +169,23 @@ function ConfigBackup () {
         {
 			if [ "${emailBackup}" = "true" ]; then
 				# Write MIME section header for file attachment (encoded with base64)
-				echo "--${boundary}"
-				echo 'Content-Type: application/tar+gzip name="'"${filename}.tar.gz"'"'
-				echo 'Content-Disposition: attachment; filename="'"${filename}.tar.gz"'"'
-				echo -e "Content-Transfer-Encoding: base64\n"
+				tee <<- EOF
+					--${boundary}
+					Content-Type: application/tar+gzip name="${filename}.tar.gz"
+					Content-Disposition: attachment; filename="${filename}.tar.gz"
+					Content-Transfer-Encoding: base64
+
+EOF
 				base64 "${tarfile}"
 			fi
 
             # Write MIME section header for html content to come below
-            echo "--${boundary}"
-            echo "Content-Transfer-Encoding: 8bit"
-            echo -e "Content-Type: text/html; charset=utf-8\n"
+				tee <<- EOF
+					--${boundary}
+					Content-Transfer-Encoding: 8bit
+					Content-Type: text/html; charset="utf-8"
+
+EOF
         } >> "${logfile}"
 
         # If logfile saving is enabled, copy .tar.gz file to specified location before it (and everything else) is removed below
@@ -1553,6 +1562,7 @@ glabel
 head
 tail
 sendmail
+tee
 )
 if [ "${configBackup}" = "true" ]; then
 commands+=(
@@ -1644,13 +1654,15 @@ readarray -t "pools" <<< "$(zpool list -H -o name)"
 ###### Email pre-formatting
 ### Set email headers
 {
-    echo "From: ${fromName:="${host}"} <${fromEmail:="root@$(hostname)"}>"
-    echo "To: ${email}"
-    echo "Subject: ${subject}"
-    echo "MIME-Version: 1.0"
-    echo 'Content-Type: multipart/mixed; boundary="'"${boundary}"'"'
-    echo "Date: $(date -Rr "${runDate}")"
-    echo "Message-Id: <${messageid}@${host}>"
+tee <<- EOF
+	From: ${fromName:="${host}"} <${fromEmail:="root@$(hostname)"}>
+	To: ${email}
+	Subject: ${subject}
+	MIME-Version: 1.0
+	Content-Type: multipart/mixed; boundary="${boundary}"
+	Date: $(date -Rr "${runDate}")
+	Message-Id: <${messageid}@${host}>
+EOF
 } > "${logfile}"
 
 
@@ -1662,9 +1674,12 @@ if [ "${configBackup}" = "true" ]; then
 else
     # Config backup disabled; set up for html-type content
     {
-        echo "--${boundary}"
-        echo "Content-Transfer-Encoding: 8bit"
-        echo -e "Content-Type: text/html; charset=utf-8\n"
+	tee <<- EOF
+		--${boundary}
+		Content-Transfer-Encoding: 8bit
+		Content-Type: text/html; charset="utf-8"
+
+EOF
     } >> "${logfile}"
 fi
 
@@ -1767,7 +1782,7 @@ for drive in "${drives[@]}"; do
     fi
 done
 
-# Remove some un-needed junk from the output
+# Remove some un-needed labels from the output
 sed -i '' -e '/smartctl [6-9].[0-9]/d' "${logfile}"
 sed -i '' -e '/Copyright/d' "${logfile}"
 sed -i '' -e '/=== START OF READ/d' "${logfile}"

From b017cb3142d072e94f936ebd857c97ec33887a9c Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Tue, 10 Jan 2023 13:21:34 -0500
Subject: [PATCH 113/160] More heredoc conversions.

---
 report.sh | 428 ++++++++++++++++++++++++++++--------------------------
 1 file changed, 224 insertions(+), 204 deletions(-)

diff --git a/report.sh b/report.sh
index d196b1c..08dbebd 100755
--- a/report.sh
+++ b/report.sh
@@ -240,25 +240,27 @@ function ZpoolSummary () {
 	### zpool status summary table
 	{
 		# Write HTML table headers to log file; HTML in an email requires 100% in-line styling (no CSS or <style> section), hence the massive tags
-		echo '<br><br>'
-		echo '<table style="border: 1px solid black; border-collapse: collapse;">'
-		echo '<tr><th colspan="14" style="text-align:center; font-size:20px; height:40px; font-family:courier;">ZPool Status Report Summary</th></tr>'
-		echo '<tr>'
-		echo '<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Pool<br>Name</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Status</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Size</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Allocated</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Free</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Frag %</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Used %</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Read<br>Errors</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Write<br>Errors</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Cksum<br>Errors</th>'
-		echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Scrub<br>Repaired<br>Bytes</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Scrub<br>Errors</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last<br>Scrub<br>Age (days)</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last<br>Scrub<br>Duration</th>'
-		echo "</tr> <!-- ${zfsVersion} -->"
+		tee <<- EOF
+			<br><br>
+			<table style="border: 1px solid black; border-collapse: collapse;">
+			<tr><th colspan="14" style="text-align:center; font-size:20px; height:40px; font-family:courier;">ZPool Status Report Summary</th></tr>
+			<tr>
+			<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Pool<br>Name</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Status</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Size</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Allocated</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Free</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Frag %</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Used %</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Read<br>Errors</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Write<br>Errors</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Cksum<br>Errors</th>
+			<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Scrub<br>Repaired<br>Bytes</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Scrub<br>Errors</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last<br>Scrub<br>Age (days)</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last<br>Scrub<br>Duration</th>
+			</tr> <!-- ${zfsVersion} -->
+EOF
 	} >> "${logfile}"
 
 
@@ -486,22 +488,24 @@ function ZpoolSummary () {
 
 		{
 			# Use the information gathered above to write the date to the current table row
-			echo '<tr style="background-color:'"${bgColor}"'">'
-			echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${pool}"'</td>'
-			echo '<td style="text-align:center; background-color:'"${statusColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${status}"'</td>'
-			echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${size}"'</td>'
-			echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${allocated}"'</td>'
-			echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${free}"'</td>'
-			echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${frag}"'%</td>'
-			echo '<td style="text-align:center; background-color:'"${usedColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${used}"'%</td>'
-			echo '<td style="text-align:center; background-color:'"${readErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${readErrors}"'</td>'
-			echo '<td style="text-align:center; background-color:'"${writeErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${writeErrors}"'</td>'
-			echo '<td style="text-align:center; background-color:'"${cksumErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${cksumErrors}"'</td>'
-			echo '<td style="text-align:center; background-color:'"${scrubRepBytesColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scrubRepBytes}"'</td>'
-			echo '<td style="text-align:center; background-color:'"${scrubErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scrubErrors}"'</td>'
-			echo '<td style="text-align:center; background-color:'"${scrubAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scrubAge}"'</td>'
-			echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scrubDuration}"'</td>'
-			echo '</tr>'
+			tee <<- EOF
+				<tr style="background-color:${bgColor}">
+				<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${pool}</td>
+				<td style="text-align:center; background-color:${statusColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${status}</td>
+				<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${size}</td>
+				<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${allocated}</td>
+				<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${free}</td>
+				<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${frag}%</td>
+				<td style="text-align:center; background-color:${usedColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${used}%</td>
+				<td style="text-align:center; background-color:${readErrorsColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${readErrors}</td>
+				<td style="text-align:center; background-color:${writeErrorsColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${writeErrors}</td>
+				<td style="text-align:center; background-color:${cksumErrorsColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${cksumErrors}</td>
+				<td style="text-align:center; background-color:${scrubRepBytesColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${scrubRepBytes}</td>
+				<td style="text-align:center; background-color:${scrubErrorsColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${scrubErrors}</td>
+				<td style="text-align:center; background-color:${scrubAgeColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${scrubAge}</td>
+				<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${scrubDuration}</td>
+				</tr>
+EOF
 		} >> "${logfile}"
 	done
 
@@ -515,44 +519,46 @@ function NVMeSummary () {
 	###### NVMe SMART status summary table
 	{
 		# Write HTML table headers to log file
-		echo '<br><br>'
-		echo '<table style="border: 1px solid black; border-collapse: collapse;">'
-		echo '<tr><th colspan="18" style="text-align:center; font-size:20px; height:40px; font-family:courier;">NVMe SMART Status Report Summary</th></tr>'
-		echo '<tr>'
+		tee <<- EOF
+			<br><br>
+			<table style="border: 1px solid black; border-collapse: collapse;">
+			<tr><th colspan="18" style="text-align:center; font-size:20px; height:40px; font-family:courier;">NVMe SMART Status Report Summary</th></tr>
+			<tr>
 
-		echo '  <th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Device</th>' # Device
+			  <th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Device</th> <!-- Device -->
 
-		echo '  <th style="text-align:center; width:140px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Model</th>' # Model
+			  <th style="text-align:center; width:140px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Model</th> <!-- Model -->
 
-		echo '  <th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Serial<br>Number</th>' # Serial Number
+			  <th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Serial<br>Number</th> <!-- Serial Number -->
 
-		echo '  <th style="text-align:center; width:90px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Capacity</th>' # Capacity
+			  <th style="text-align:center; width:90px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Capacity</th> <!-- Capacity -->
 
-		echo '  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">SMART<br>Status</th>' # SMART Status
+			  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">SMART<br>Status</th> <!-- SMART Status -->
 
-		echo '  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Temp</th>' # Temp
+			  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Temp</th> <!-- Temp -->
 
-		echo '  <th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Power-On<br>Time<br>('"$powerTimeFormat"')</th>' # Power-On Time
+			  <th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Power-On<br>Time<br>('"$powerTimeFormat"')</th> <!-- Power-On Time -->
 
-		echo '  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Power<br>Cycle<br>Count</th>' # Power Cycle Count
+			  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Power<br>Cycle<br>Count</th> <!-- Power Cycle Count -->
 
-		echo '  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Integrity<br>Errors</th>' # Integrity Errors
+			  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Integrity<br>Errors</th> <!-- Integrity Errors -->
 
-		echo '  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Error<br>Log<br>Entries</th>' # Error Log Entries
+			  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Error<br>Log<br>Entries</th> <!-- Error Log Entries -->
 
-		echo '  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Critical<br>Warning</th>' # Critical Warning
+			  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Critical<br>Warning</th> <!-- Critical Warning -->
 
-		echo '  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Wear<br>Leveling<br>Count</th>' # Wear Leveling Count
+			  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Wear<br>Leveling<br>Count</th> <!-- Wear Leveling Count -->
 
-		echo '  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Total<br>Bytes<br>Written</th>' # Total Bytes Written
+			  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Total<br>Bytes<br>Written</th> <!-- Total Bytes Written -->
 
-		echo '  <th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Bytes Written<br>(per Day)</th>' # Bytes Written (per Day)
+			  <th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Bytes Written<br>(per Day)</th> <!-- Bytes Written (per Day) -->
 
-		echo '  <th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Age (days)</th>' # Last Test Age (days)
+			  <th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Age (days)</th> <!-- Last Test Age (days) -->
 
-		echo '  <th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Type</th></tr>' # Last Test Type
+			  <th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Type</th></tr> <!-- Last Test Type -->
 
-		echo '</tr>'
+			</tr>
+EOF
 	} >> "${logfile}"
 
 
@@ -710,24 +716,26 @@ function NVMeSummary () {
 
 			{
 				# Output the row
-				echo '<tr style="background-color:'"${bgColor}"';">'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"/dev/${drive}"'</td> <!-- device -->'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${model}"'</td> <!-- model -->'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${serial}"'</td> <!-- serial -->'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${capacity}"'</td> <!-- capacity -->'
-				echo '<td style="text-align:center; background-color:'"${smartStatusColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${smartStatus}"'</td> <!-- smartStatusColor, smartStatus -->'
-				echo '<td style="text-align:center; background-color:'"${tempColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${temp}"'</td> <!-- tempColor, temp -->'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${onTime}"'</td> <!-- onTime -->'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${startStop}"'</td> <!-- startStop -->'
-				echo '<td style="text-align:center; background-color:'"${mediaErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${mediaErrors}"'</td> <!-- mediaErrorsColor, mediaErrors -->'
-				echo '<td style="text-align:center; background-color:'"${errorsLogsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${errorsLogs}"'</td> <!-- errorsLogsColor, errorsLogs -->'
-				echo '<td style="text-align:center; background-color:'"${critWarningColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${critWarning}"'</td> <!-- critWarningColor, critWarning -->'
-				echo '<td style="text-align:center; background-color:'"${wearLevelingColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${wearLeveling}"'</td> <!-- wearLevelingColor, wearLeveling -->'
-				echo '<td style="text-align:center; background-color:'"${totalBWColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${totalBW}"'</td> <!-- totalBWColor, totalBW -->'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${bwPerDay}"'</td> <!-- bwPerDay -->'
-				echo '<td style="text-align:center; background-color:'"${testAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">N/A</td> <!-- testAgeColor, testAge -->'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;\">N/A</td> <!-- lastTestType -->'
-				echo '</tr>'
+				tee <<- EOF
+					<tr style="background-color:${bgColor};">
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">/dev/${drive}</td> <!-- device -->
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${model}</td> <!-- model -->
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${serial}</td> <!-- serial -->
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${capacity}</td> <!-- capacity -->
+					<td style="text-align:center; background-color:${smartStatusColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${smartStatus}</td> <!-- smartStatusColor, smartStatus -->
+					<td style="text-align:center; background-color:${tempColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${temp}</td> <!-- tempColor, temp -->
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${onTime}</td> <!-- onTime -->
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${startStop}</td> <!-- startStop -->
+					<td style="text-align:center; background-color:${mediaErrorsColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${mediaErrors}</td> <!-- mediaErrorsColor, mediaErrors -->
+					<td style="text-align:center; background-color:${errorsLogsColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${errorsLogs}</td> <!-- errorsLogsColor, errorsLogs -->
+					<td style="text-align:center; background-color:${critWarningColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${critWarning}</td> <!-- critWarningColor, critWarning -->
+					<td style="text-align:center; background-color:${wearLevelingColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${wearLeveling}</td> <!-- wearLevelingColor, wearLeveling -->
+					<td style="text-align:center; background-color:${totalBWColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${totalBW}</td> <!-- totalBWColor, totalBW -->
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${bwPerDay}</td> <!-- bwPerDay -->
+					<td style="text-align:center; background-color:${testAgeColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">N/A</td> <!-- testAgeColor, testAge -->
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">N/A</td> <!-- lastTestType -->
+					</tr>
+EOF
 			} >> "${logfile}"
 		fi
 	done
@@ -741,32 +749,34 @@ function NVMeSummary () {
 # shellcheck disable=SC2155
 function SSDSummary () {
 	###### SSD SMART status summary table
-    {
-        # Write HTML table headers to log file
-        echo '<br><br>'
-        echo '<table style="border: 1px solid black; border-collapse: collapse;">'
-        echo '<tr><th colspan="18" style="text-align:center; font-size:20px; height:40px; font-family:courier;">SSD SMART Status Report Summary</th></tr>'
-        echo '<tr>'
-        echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Device</th>'
-        echo '<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Model</th>'
-        echo '<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Serial<br>Number</th>'
-        echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Capacity</th>'
-        echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">SMART<br>Status</th>'
-        echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Temp</th>'
-        echo '<th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Power-On<br>Time<br>('"${powerTimeFormat}"')</th>'
-        echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Power<br>Cycle<br>Count</th>'
-        echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Realloc<br>Sectors</th>'
-        echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Program<br>Fail<br>Count</th>'
-        echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Erase<br>Fail<br>Count</th>'
-        echo '<th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Offline<br>Uncorrectable<br>Sectors</th>'
-        echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">CRC<br>Errors</th>'
-        echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Wear<br>Leveling<br>Count</th>'
-        echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Total<br>Bytes<br>Written</th>'
-        echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Bytes Written<br>(per Day)</th>'
-        echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Age (days)</th>'
-        echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Type</th></tr>'
-        echo '</tr>'
-    } >> "${logfile}"
+	{
+		# Write HTML table headers to log file
+		tee <<- EOF
+			<br><br>
+			<table style="border: 1px solid black; border-collapse: collapse;">
+			<tr><th colspan="18" style="text-align:center; font-size:20px; height:40px; font-family:courier;">SSD SMART Status Report Summary</th></tr>
+			<tr>
+			<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Device</th>
+			<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Model</th>
+			<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Serial<br>Number</th>
+			<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Capacity</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">SMART<br>Status</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Temp</th>
+			<th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Power-On<br>Time<br>(${powerTimeFormat})</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Power<br>Cycle<br>Count</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Realloc<br>Sectors</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Program<br>Fail<br>Count</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Erase<br>Fail<br>Count</th>
+			<th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Offline<br>Uncorrectable<br>Sectors</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">CRC<br>Errors</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Wear<br>Leveling<br>Count</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Total<br>Bytes<br>Written</th>
+			<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Bytes Written<br>(per Day)</th>
+			<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Age (days)</th>
+			<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Type</th></tr>
+			</tr>
+EOF
+	} >> "${logfile}"
 
 	local drive
 	local altRow="false"
@@ -988,26 +998,28 @@ function SSDSummary () {
 
             {
 				# Row Output
-				echo '<tr style="background-color:'"${bgColor}"';">'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"/dev/${device}"'</td>'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${model}"'</td>'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${serial}"'</td>'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${capacity}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${smartStatusColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${smartStatus}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${tempColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${temp}"'</td>'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${onTime}"'</td>'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${startStop}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${reAllocColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${reAlloc}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${progFailColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${progFail}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${eraseFailColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${eraseFail}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${offlineUncColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${offlineUnc}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${crcErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${crcErrors}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${wearLevelingColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${wearLeveling:=N/A}"'%</td>'
-				echo '<td style="text-align:center; background-color:'"${totalBWColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${totalBW}"'</td>'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${bwPerDay}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${testAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${testAge:-"N/A"}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${lastTestStatusColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${lastTestType:-"N/A"}"'</td>'
-				echo '</tr>'
+				tee <<- EOF
+					<tr style="background-color:${bgColor};">
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">/dev/${device}</td>
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${model}</td>
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${serial}</td>
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${capacity}</td>
+					<td style="text-align:center; background-color:${smartStatusColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${smartStatus}</td>
+					<td style="text-align:center; background-color:${tempColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${temp}</td>
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${onTime}</td>
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${startStop}</td>
+					<td style="text-align:center; background-color:${reAllocColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${reAlloc}</td>
+					<td style="text-align:center; background-color:${progFailColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${progFail}</td>
+					<td style="text-align:center; background-color:${eraseFailColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${eraseFail}</td>
+					<td style="text-align:center; background-color:${offlineUncColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${offlineUnc}</td>
+					<td style="text-align:center; background-color:${crcErrorsColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${crcErrors}</td>
+					<td style="text-align:center; background-color:${wearLevelingColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${wearLeveling:=N/A}%</td>
+					<td style="text-align:center; background-color:${totalBWColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${totalBW}</td>
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${bwPerDay}</td>
+					<td style="text-align:center; background-color:${testAgeColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${testAge:-"N/A"}</td>
+					<td style="text-align:center; background-color:${lastTestStatusColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${lastTestType:-"N/A"}</td>
+					</tr>
+EOF
             } >> "${logfile}"
         fi
     done
@@ -1023,29 +1035,31 @@ function HDDSummary () {
 	###### HDD SMART status summary table
 	{
 		# Write HTML table headers to log file
-		echo '<br><br>'
-		echo '<table style="border: 1px solid black; border-collapse: collapse;">'
-		echo '<tr><th colspan="18" style="text-align:center; font-size:20px; height:40px; font-family:courier;">HDD SMART Status Report Summary</th></tr>'
-		echo '<tr>'
-		echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Device</th>'
-		echo '<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Model</th>'
-		echo '<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Serial<br>Number</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">RPM</th>'
-		echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Capacity</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">SMART<br>Status</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Temp</th>'
-		echo '<th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Power-On<br>Time<br>('"${powerTimeFormat}"')</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Start<br>Stop<br>Count</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Spin<br>Retry<br>Count</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Realloc<br>Sectors</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Realloc<br>Events</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Current<br>Pending<br>Sectors</th>'
-		echo '<th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Offline<br>Uncorrectable<br>Sectors</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">CRC<br>Errors</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Seek<br>Error<br>Health</th>'
-		echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Age (days)</th>'
-		echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Type</th></tr>'
-		echo '</tr>'
+		tee <<- EOF
+			<br><br>
+			<table style="border: 1px solid black; border-collapse: collapse;">
+			<tr><th colspan="18" style="text-align:center; font-size:20px; height:40px; font-family:courier;">HDD SMART Status Report Summary</th></tr>
+			<tr>
+			<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Device</th>
+			<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Model</th>
+			<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Serial<br>Number</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">RPM</th>
+			<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Capacity</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">SMART<br>Status</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Temp</th>
+			<th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Power-On<br>Time<br>(${powerTimeFormat})</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Start<br>Stop<br>Count</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Spin<br>Retry<br>Count</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Realloc<br>Sectors</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Realloc<br>Events</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Current<br>Pending<br>Sectors</th>
+			<th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Offline<br>Uncorrectable<br>Sectors</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">CRC<br>Errors</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Seek<br>Error<br>Health</th>
+			<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Age (days)</th>
+			<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Type</th></tr>
+			</tr>
+EOF
 	} >> "${logfile}"
 
 	local drive
@@ -1229,26 +1243,28 @@ function HDDSummary () {
 
 			{
 				# Row Output
-				echo '<tr style="background-color:'"${bgColor}"';">'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"/dev/${device}"'</td>'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${model}"'</td>'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${serial}"'</td>'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${rpm}"'</td>'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${capacity}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${smartStatusColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${smartStatus}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${tempColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${temp}"'</td>'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${onTime}"'</td>'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${startStop}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${spinRetryColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${spinRetry}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${reAllocColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${reAlloc}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${reAllocEventColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${reAllocEvent}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${pendingColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${pending}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${offlineUncColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${offlineUnc}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${crcErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${crcErrors}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${seekErrorHealthColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${seekErrorHealth}"'%</td>'
-				echo '<td style="text-align:center; background-color:'"${testAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${testAge:-"N/A"}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${lastTestStatusColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${lastTestType:-"N/A"}"'</td>'
-				echo '</tr>'
+				tee <<- EOF
+					<tr style="background-color:${bgColor};">
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">/dev/${device}</td>
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${model}</td>
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${serial}</td>
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${rpm}</td>
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${capacity}</td>
+					<td style="text-align:center; background-color:${smartStatusColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${smartStatus}</td>
+					<td style="text-align:center; background-color:${tempColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${temp}</td>
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${onTime}</td>
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${startStop}</td>
+					<td style="text-align:center; background-color:${spinRetryColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${spinRetry}</td>
+					<td style="text-align:center; background-color:${reAllocColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${reAlloc}</td>
+					<td style="text-align:center; background-color:${reAllocEventColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${reAllocEvent}</td>
+					<td style="text-align:center; background-color:${pendingColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${pending}</td>
+					<td style="text-align:center; background-color:${offlineUncColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${offlineUnc}</td>
+					<td style="text-align:center; background-color:${crcErrorsColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${crcErrors}</td>
+					<td style="text-align:center; background-color:${seekErrorHealthColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${seekErrorHealth}%</td>
+					<td style="text-align:center; background-color:${testAgeColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${testAge:-"N/A"}</td>
+					<td style="text-align:center; background-color:${lastTestStatusColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${lastTestType:-"N/A"}</td>
+					</tr>
+EOF
 			} >> "${logfile}"
 		fi
 	done
@@ -1265,28 +1281,30 @@ function SASSummary () {
 	###### SAS SMART status summary table
 	{
 		# Write HTML table headers to log file
-		echo '<br><br>'
-		echo '<table style="border: 1px solid black; border-collapse: collapse;">'
-		echo '<tr><th colspan="18" style="text-align:center; font-size:20px; height:40px; font-family:courier;">SAS SMART Status Report Summary</th></tr>'
-		echo '<tr>'
-		echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Device</th>'
-		echo '<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Model</th>'
-		echo '<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Serial<br>Number</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">RPM</th>'
-		echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Capacity</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">SMART<br>Status</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Temp</th>'
-		echo '<th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Power-On<br>Time<br>('"${powerTimeFormat}"')</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Start<br>Stop<br>Cycles</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Load<br>Unload<br>Cycles</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Grown<br>Defect<br>List</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Uncorrected<br>Read<br>Errors</th>'
-		echo '<th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Uncorrected<br>Write<br>Errors</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Uncorrected<br>Verify<br>Errors</th>'
-		echo '<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Non-medium<br>Errors</th>'
-		echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Age (days)</th>'
-		echo '<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Type</th></tr>'
-		echo '</tr>'
+		tee <<- EOF
+			<br><br>
+			<table style="border: 1px solid black; border-collapse: collapse;">
+			<tr><th colspan="18" style="text-align:center; font-size:20px; height:40px; font-family:courier;">SAS SMART Status Report Summary</th></tr>
+			<tr>
+			<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Device</th>
+			<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Model</th>
+			<th style="text-align:center; width:130px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Serial<br>Number</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">RPM</th>
+			<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Capacity</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">SMART<br>Status</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Temp</th>
+			<th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Power-On<br>Time<br>(${powerTimeFormat})</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Start<br>Stop<br>Cycles</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Load<br>Unload<br>Cycles</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Grown<br>Defect<br>List</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Uncorrected<br>Read<br>Errors</th>
+			<th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Uncorrected<br>Write<br>Errors</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Uncorrected<br>Verify<br>Errors</th>
+			<th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Non-medium<br>Errors</th>
+			<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Age (days)</th>
+			<th style="text-align:center; width:100px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Last Test<br>Type</th></tr>
+			</tr>
+EOF
 	} >> "${logfile}"
 
 	local drive
@@ -1483,25 +1501,27 @@ function SASSummary () {
 
 			{
 				# Row Output
-				echo '<tr style="background-color:'"${bgColor}"';">'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"/dev/${device}"'</td>'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${model}"'</td>'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${serial}"'</td>'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${rpm}"'</td>'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${capacity}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${smartStatusColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${smartStatus}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${tempColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${temp}"'</td>'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${onTime}"'</td>'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${accumStartStopCycles}"'</td>'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${accumLoadUnloadCycles}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${scsiGrownDefectListColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${scsiGrownDefectList}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${uncorrectedReadErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${uncorrectedReadErrors}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${uncorrectedWriteErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${uncorrectedWriteErrors}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${uncorrectedVerifyErrorsColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${uncorrectedVerifyErrors}"'</td>'
-				echo '<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${nonMediumErrors}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${testAgeColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${testAge:-"N/A"}"'</td>'
-				echo '<td style="text-align:center; background-color:'"${lastTestStatusColor}"'; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">'"${lastTestType:-"N/A"}"'</td>'
-				echo '</tr>'
+				tee <<- EOF
+					<tr style="background-color:${bgColor};">
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">/dev/${device}</td>
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${model}</td>
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${serial}</td>
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${rpm}</td>
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${capacity}</td>
+					<td style="text-align:center; background-color:${smartStatusColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${smartStatus}</td>
+					<td style="text-align:center; background-color:${tempColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${temp}</td>
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${onTime}</td>
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${accumStartStopCycles}</td>
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${accumLoadUnloadCycles}</td>
+					<td style="text-align:center; background-color:${scsiGrownDefectListColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${scsiGrownDefectList}</td>
+					<td style="text-align:center; background-color:${uncorrectedReadErrorsColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${uncorrectedReadErrors}</td>
+					<td style="text-align:center; background-color:${uncorrectedWriteErrorsColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${uncorrectedWriteErrors}</td>
+					<td style="text-align:center; background-color:${uncorrectedVerifyErrorsColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${uncorrectedVerifyErrors}</td>
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${nonMediumErrors}</td>
+					<td style="text-align:center; background-color:${testAgeColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${testAge:-"N/A"}</td>
+					<td style="text-align:center; background-color:${lastTestStatusColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${lastTestType:-"N/A"}</td>
+					</tr>
+EOF
 			} >> "${logfile}"
 		fi
 	done

From f2159e70cacc92e9fb890fb3c458bacb7b294a2c Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Tue, 10 Jan 2023 15:12:53 -0500
Subject: [PATCH 114/160] Fix some quotes.

---
 report.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/report.sh b/report.sh
index 08dbebd..5e5ab2c 100755
--- a/report.sh
+++ b/report.sh
@@ -537,7 +537,7 @@ function NVMeSummary () {
 
 			  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Temp</th> <!-- Temp -->
 
-			  <th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Power-On<br>Time<br>('"$powerTimeFormat"')</th> <!-- Power-On Time -->
+			  <th style="text-align:center; width:120px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Power-On<br>Time<br>($powerTimeFormat)</th> <!-- Power-On Time -->
 
 			  <th style="text-align:center; width:80px; height:60px; border:1px solid black; border-collapse:collapse; font-family:courier;">Power<br>Cycle<br>Count</th> <!-- Power Cycle Count -->
 

From 583c66fe6ffed1f157c363678945b7ecae41a4bd Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Tue, 10 Jan 2023 15:18:39 -0500
Subject: [PATCH 115/160] Use the extended test data if available.

---
 report.sh | 36 +++++++++++++++++++++++++++---------
 1 file changed, 27 insertions(+), 9 deletions(-)

diff --git a/report.sh b/report.sh
index 5e5ab2c..ffe18e7 100755
--- a/report.sh
+++ b/report.sh
@@ -793,9 +793,15 @@ EOF
 			local device="${drive}"
 
 			# Available if any tests have completed
-			local lastTestHours="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].lifetime_hours | values')"
-			local lastTestType="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].type.string | values')"
-			local lastTestStatus="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].status.passed | values')"
+			if [ ! -z "$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.extended.table | values')" ]; then
+				local lastTestHours="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.extended.table[0].lifetime_hours | values')"
+				local lastTestType="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.extended.table[0].type.string | values')"
+				local lastTestStatus="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.extended.table[0].status.passed | values')"
+			else
+				local lastTestHours="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].lifetime_hours | values')"
+				local lastTestType="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].type.string | values')"
+				local lastTestStatus="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].status.passed | values')"
+			fi
 
 			# Available for any drive smartd knows about
 			if [ "$(echo "${ssdInfoSmrt}" | jq -Mre '.smart_status.passed | values')" = "true" ]; then
@@ -1080,9 +1086,15 @@ EOF
 			local device="${drive}"
 
 			# Available if any tests have completed
-			local lastTestHours="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].lifetime_hours | values')"
-			local lastTestType="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].type.string | values')"
-			local lastTestStatus="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].status.passed | values')"
+			if [ ! -z "$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.extended.table | values')" ]; then
+				local lastTestHours="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.extended.table[0].lifetime_hours | values')"
+				local lastTestType="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.extended.table[0].type.string | values')"
+				local lastTestStatus="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.extended.table[0].status.passed | values')"
+			else
+				local lastTestHours="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].lifetime_hours | values')"
+				local lastTestType="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].type.string | values')"
+				local lastTestStatus="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].status.passed | values')"
+			fi
 
 			# Available for any drive smartd knows about
 			if [ "$(echo "${hddInfoSmrt}" | jq -Mre '.smart_status.passed | values')" = "true" ]; then
@@ -1322,9 +1334,15 @@ EOF
 			local device="${drive}"
 
 			# Available if any tests have completed #FixMe this info is not currently exported in json for sas drives
-			local lastTestHours="$(echo "${sasInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].lifetime_hours | values')"
-			local lastTestType="$(echo "${sasInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].type.string | values')"
-			local lastTestStatus="$(echo "${sasInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].status.passed | values')"
+			if [ ! -z "$(echo "${sasInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.extended.table | values')" ]; then
+				local lastTestHours="$(echo "${sasInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.extended.table[0].lifetime_hours | values')"
+				local lastTestType="$(echo "${sasInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.extended.table[0].type.string | values')"
+				local lastTestStatus="$(echo "${sasInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.extended.table[0].status.passed | values')"
+			else
+				local lastTestHours="$(echo "${sasInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].lifetime_hours | values')"
+				local lastTestType="$(echo "${sasInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].type.string | values')"
+				local lastTestStatus="$(echo "${sasInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].status.passed | values')"
+			fi
 
 			#FixMe: relies on non-json output
 			lastTestType="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '3,4')"

From 98d7dd3f52973adc4c15751214e14518025d3a48 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 16 Jan 2023 00:00:10 -0500
Subject: [PATCH 116/160] Reduce the number of calls to smartctl.

---
 report.sh | 102 ++++++++++++++++++++++++++++++++++++++++++++++--------
 1 file changed, 88 insertions(+), 14 deletions(-)

diff --git a/report.sh b/report.sh
index ffe18e7..99c40cb 100755
--- a/report.sh
+++ b/report.sh
@@ -97,6 +97,7 @@ scrubAgeWarn="30"         # Maximum age (in days) of last pool scrub before CRIT
 
 ### SMART status summary table settings
 includeSSD="true"       # Change to "true" to include SSDs in SMART status summary table; "false" to disable
+includeSAS="false"       # Change to "true" to include SAS drives in SMART status summary table; "false" to disable
 lifeRemainWarn="75"       # Life remaining in the SSD at which WARNING color will be used
 lifeRemainCrit="50"       # Life remaining in the SSD at which CRITICAL color will be used
 totalBWWarn="100"         # Total bytes written (in TB) to the SSD at which WARNING color will be used
@@ -588,7 +589,24 @@ EOF
 			local wearLeveling="$(echo "${nvmeSmarOut}" | jq -Mre '.nvme_smart_health_information_log.available_spare | values')"
 			local totalLBA="$(echo "${nvmeSmarOut}" | jq -Mre '.nvme_smart_health_information_log.data_units_written | values')"
 
-			local capacity="$(smartctl -i "/dev/${drive}" | grep '^Namespace 1 Size' | tr -s ' ' | cut -d ' ' -sf '5,6')" # FixMe: have not yet figured out how to best calculate this from json values
+
+			local capacityByte="$(echo "${nvmeSmarOut}" | jq -Mre '.user_capacity.bytes | values')"
+			: "${capacityByte:="0"}"
+
+			if [ "${#capacityByte}" -gt "12" ]; then
+				local capacitySufx=" TB"
+				local capacityExp="12"
+			elif [ "${#capacityByte}" -gt "9" ]; then
+				local capacitySufx=" GB"
+				local capacityExp="9"
+			else
+				local capacitySufx=""
+				local capacityExp="1"
+			fi
+
+			local capacityPre="$(bc <<< "scale=2; ${capacityByte} / (1e${capacityExp})" | head -c 4 | sed -e 's:\.$::')"
+			local capacity="[${capacityPre}${capacitySufx}]"
+
 
 			if [ "$(echo "${nvmeSmarOut}" | jq -Mre '.smart_status.passed | values')" = "true" ]; then
 				local smartStatus="PASSED"
@@ -813,7 +831,24 @@ EOF
 			local model="$(echo "${ssdInfoSmrt}" | jq -Mre '.model_name | values')"
 			local serial="$(echo "${ssdInfoSmrt}" | jq -Mre '.serial_number | values')"
 
-			local capacity="$(smartctl -i "/dev/${drive}" | grep '^User Capacity:' | tr -s ' ' | cut -d ' ' -sf '5,6')" # FixMe: have not yet figured out how to best calculate this from json values
+
+			local capacityByte="$(echo "${ssdInfoSmrt}" | jq -Mre '.user_capacity.bytes | values')"
+			: "${capacityByte:="0"}"
+
+			if [ "${#capacityByte}" -gt "12" ]; then
+				local capacitySufx=" TB"
+				local capacityExp="12"
+			elif [ "${#capacityByte}" -gt "9" ]; then
+				local capacitySufx=" GB"
+				local capacityExp="9"
+			else
+				local capacitySufx=""
+				local capacityExp="1"
+			fi
+
+			local capacityPre="$(bc <<< "scale=2; ${capacityByte} / (1e${capacityExp})" | head -c 4 | sed -e 's:\.$::')"
+			local capacity="[${capacityPre}${capacitySufx}]"
+
 
 			local temp="$(echo "${ssdInfoSmrt}" | jq -Mre '.temperature.current | values')"
 			local onHours="$(echo "${ssdInfoSmrt}" | jq -Mre '.power_on_time.hours | values')"
@@ -1107,7 +1142,24 @@ EOF
 			local serial="$(echo "${hddInfoSmrt}" | jq -Mre '.serial_number | values')"
 			local rpm="$(echo "${hddInfoSmrt}" | jq -Mre '.rotation_rate | values')"
 
-			local capacity="$(smartctl -i "/dev/${drive}" | grep '^User Capacity:' | tr -s ' ' | cut -d ' ' -sf '5,6')" # FixMe: have not yet figured out how to best calculate this from json values
+
+			local capacityByte="$(echo "${hddInfoSmrt}" | jq -Mre '.user_capacity.bytes | values')"
+			: "${capacityByte:="0"}"
+
+			if [ "${#capacityByte}" -gt "12" ]; then
+				local capacitySufx=" TB"
+				local capacityExp="12"
+			elif [ "${#capacityByte}" -gt "9" ]; then
+				local capacitySufx=" GB"
+				local capacityExp="9"
+			else
+				local capacitySufx=""
+				local capacityExp="1"
+			fi
+
+			local capacityPre="$(bc <<< "scale=2; ${capacityByte} / (1e${capacityExp})" | head -c 4 | sed -e 's:\.$::')"
+			local capacity="[${capacityPre}${capacitySufx}]"
+
 
 			local temp="$(echo "${hddInfoSmrt}"| jq -Mre '.temperature.current | values')"
 			local onHours="$(echo "${hddInfoSmrt}" | jq -Mre '.power_on_time.hours | values')"
@@ -1385,7 +1437,24 @@ EOF
 				rpm="SSD"
 			fi
 
-			local capacity="$(smartctl -i "/dev/${drive}" | grep '^User Capacity:' | tr -s ' ' | cut -d ' ' -sf '5,6')" # FixMe: have not yet figured out how to best calculate this from json values
+
+			local capacityByte="$(echo "${sasInfoSmrt}" | jq -Mre '.user_capacity.bytes | values')"
+			: "${capacityByte:="0"}"
+
+			if [ "${#capacityByte}" -gt "12" ]; then
+				local capacitySufx=" TB"
+				local capacityExp="12"
+			elif [ "${#capacityByte}" -gt "9" ]; then
+				local capacitySufx=" GB"
+				local capacityExp="9"
+			else
+				local capacitySufx=""
+				local capacityExp="1"
+			fi
+
+			local capacityPre="$(bc <<< "scale=2; ${capacityByte} / (1e${capacityExp})" | head -c 4 | sed -e 's:\.$::')"
+			local capacity="[${capacityPre}${capacitySufx}]"
+
 
 			local temp="$(echo "${sasInfoSmrt}" | jq -Mre '.temperature.current | values')"
 			local onHours="$(echo "${sasInfoSmrt}" | jq -Mre '.power_on_time.hours | values')"
@@ -1713,7 +1782,8 @@ done | tr ' ' '\n' | sort -V | sed '/^nvme/!H;//p;$!d;g;s:\n::')"
 # Toggles the 'ssdExist' flag to true if SSDs are detected in order to add the summary table
 if [ "${includeSSD}" = "true" ]; then
     for drive in "${drives[@]}"; do
-        if [ "$(smartctl -ij "/dev/${drive}" | jq -Mre '.rotation_rate | values')" = "0" ] && [ ! "$(smartctl -ij "/dev/${drive}" | jq -Mre '.device.type | values')" = "scsi" ]; then
+        driveTypeExistSmartOutput="$(smartctl -ij "/dev/${drive}")"
+        if [ "$(echo "${driveTypeExistSmartOutput}" | jq -Mre '.rotation_rate | values')" = "0" ] && [ ! "$(echo "${driveTypeExistSmartOutput}" | jq -Mre '.device.type | values')" = "scsi" ]; then
             ssdExist="true"
             break
         else
@@ -1726,7 +1796,8 @@ if [ "${includeSSD}" = "true" ]; then
 fi
 # Test to see if there are any HDDs
 for drive in "${drives[@]}"; do
-	if [ ! "$(smartctl -ij "/dev/${drive}" | jq -Mre '.rotation_rate | values')" = "0" ] && [ ! "$(smartctl -ij "/dev/${drive}" | jq -Mre '.device.type | values')" = "scsi" ]; then
+	driveTypeExistSmartOutput="$(smartctl -ij "/dev/${drive}")"
+	if [ ! "$(echo "${driveTypeExistSmartOutput}" | jq -Mre '.rotation_rate | values')" = "0" ] && [ ! "$(echo "${driveTypeExistSmartOutput}" | jq -Mre '.device.type | values')" = "scsi" ]; then
 		hddExist="true"
 		break
 	else
@@ -1734,14 +1805,17 @@ for drive in "${drives[@]}"; do
 	fi
 done
 # Test to see if there are any SAS drives
-for drive in "${drives[@]}"; do
-	if [ "$(smartctl -ij "/dev/${drive}" | jq -Mre '.device.type | values')" = "scsi" ]; then
-		sasExist="true"
-		break
-	else
-		sasExist="false"
-	fi
-done
+if [ "${includeSAS}" = "true" ]; then
+	for drive in "${drives[@]}"; do
+		driveTypeExistSmartOutput="$(smartctl -ij "/dev/${drive}")"
+		if [ "$(echo "${driveTypeExistSmartOutput}" | jq -Mre '.device.type | values')" = "scsi" ]; then
+			sasExist="true"
+			break
+		else
+			sasExist="false"
+		fi
+	done
+fi
 
 # Get a list of pools
 readarray -t "pools" <<< "$(zpool list -H -o name)"

From 3ba4990d3fe3954afed1df7c9385d2b65f65be15 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 16 Jan 2023 00:01:11 -0500
Subject: [PATCH 117/160] Do not math non-numbers.

---
 report.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/report.sh b/report.sh
index 99c40cb..d5c8a80 100755
--- a/report.sh
+++ b/report.sh
@@ -480,7 +480,7 @@ EOF
 			scrubErrorsColor="${bgColor}"
 		fi
 
-		if [ "$(bc <<< "scale=0;(${scrubAge//%//}+0)/1")" -gt "${scrubAgeWarn}" ]; then
+		if [ "$(bc <<< "scale=0;($(echo "${scrubAge}" | sed -e 's:% done$::')+0)/1")" -gt "${scrubAgeWarn}" ]; then
 			scrubAgeColor="${warnColor}"
 		else
 			scrubAgeColor="${bgColor}"

From d22837e5c34b2657077426bb3bedb4c5f10b6e58 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 16 Jan 2023 09:21:06 -0500
Subject: [PATCH 118/160] Account for scrubs of indeterminate and multi-day
 duration.

Add examples.
---
 examples/zfs-2.1.6-1-scrub-progress-days.txt | 31 ++++++++++++++++++++
 examples/zfs-2.1.6-1-scrub-progress-no.txt   | 31 ++++++++++++++++++++
 report.sh                                    |  5 +++-
 3 files changed, 66 insertions(+), 1 deletion(-)
 create mode 100644 examples/zfs-2.1.6-1-scrub-progress-days.txt
 create mode 100644 examples/zfs-2.1.6-1-scrub-progress-no.txt

diff --git a/examples/zfs-2.1.6-1-scrub-progress-days.txt b/examples/zfs-2.1.6-1-scrub-progress-days.txt
new file mode 100644
index 0000000..d7659d0
--- /dev/null
+++ b/examples/zfs-2.1.6-1-scrub-progress-days.txt
@@ -0,0 +1,31 @@
+  pool: data
+ state: ONLINE
+status: Some supported and requested features are not enabled on the pool.
+	The pool can still be used, but some features are unavailable.
+action: Enable all features using 'zpool upgrade'. Once this is done,
+	the pool may no longer be accessible by software that does not support
+	the features. See zpool-features(7) for details.
+  scan: scrub in progress since Sun Jan 15 23:29:50 2023
+	12.8T scanned at 45.4G/s, 50.9G issued at 180M/s, 20.7T total
+	0B repaired, 0.24% done, 1 days 09:15:46 to go
+config:
+
+	NAME                                            STATE     READ WRITE CKSUM
+	data                                            ONLINE       0     0     0
+	  raidz3-0                                      ONLINE       0     0     0
+	    gptid/95378d35-7b98-11ed-b486-d05099c13d03  ONLINE       0     0     0
+	    gptid/4b4c3c38-6e06-11ed-a9d5-d05099c13d03  ONLINE       0     0     0
+	    gptid/9b844178-2482-11ec-8714-d05099c13d03  ONLINE       0     0     0
+	    gptid/f0affe10-321b-11ec-ba66-d05099c13d03  ONLINE       0     0     0
+	    gptid/e5f87be0-27e7-11ec-96bc-d05099c13d03  ONLINE       0     0     0
+	    gptid/e9d6ea26-25dc-11ec-8714-d05099c13d03  ONLINE       0     0     0
+	    gptid/a02741cb-2527-11ec-8714-d05099c13d03  ONLINE       0     0     0
+	    gptid/33fe635d-2713-11ec-8714-d05099c13d03  ONLINE       0     0     0
+	logs	
+	  mirror-7                                      ONLINE       0     0     0
+	    gptid/5055ae20-8aed-11ed-9195-d05099c13d03  ONLINE       0     0     0
+	    gptid/50543165-8aed-11ed-9195-d05099c13d03  ONLINE       0     0     0
+	cache
+	  gptid/5052b77e-8aed-11ed-9195-d05099c13d03    ONLINE       0     0     0
+
+errors: No known data errors
diff --git a/examples/zfs-2.1.6-1-scrub-progress-no.txt b/examples/zfs-2.1.6-1-scrub-progress-no.txt
new file mode 100644
index 0000000..34a51fa
--- /dev/null
+++ b/examples/zfs-2.1.6-1-scrub-progress-no.txt
@@ -0,0 +1,31 @@
+  pool: data
+ state: ONLINE
+status: Some supported and requested features are not enabled on the pool.
+	The pool can still be used, but some features are unavailable.
+action: Enable all features using 'zpool upgrade'. Once this is done,
+	the pool may no longer be accessible by software that does not support
+	the features. See zpool-features(7) for details.
+  scan: scrub in progress since Sun Jan 15 23:29:50 2023
+	3.54G scanned at 117M/s, 3.09M issued at 102K/s, 20.7T total
+	0B repaired, 0.00% done, no estimated completion time
+config:
+
+	NAME                                            STATE     READ WRITE CKSUM
+	data                                            ONLINE       0     0     0
+	  raidz3-0                                      ONLINE       0     0     0
+	    gptid/95378d35-7b98-11ed-b486-d05099c13d03  ONLINE       0     0     0
+	    gptid/4b4c3c38-6e06-11ed-a9d5-d05099c13d03  ONLINE       0     0     0
+	    gptid/9b844178-2482-11ec-8714-d05099c13d03  ONLINE       0     0     0
+	    gptid/f0affe10-321b-11ec-ba66-d05099c13d03  ONLINE       0     0     0
+	    gptid/e5f87be0-27e7-11ec-96bc-d05099c13d03  ONLINE       0     0     0
+	    gptid/e9d6ea26-25dc-11ec-8714-d05099c13d03  ONLINE       0     0     0
+	    gptid/a02741cb-2527-11ec-8714-d05099c13d03  ONLINE       0     0     0
+	    gptid/33fe635d-2713-11ec-8714-d05099c13d03  ONLINE       0     0     0
+	logs	
+	  mirror-7                                      ONLINE       0     0     0
+	    gptid/5055ae20-8aed-11ed-9195-d05099c13d03  ONLINE       0     0     0
+	    gptid/50543165-8aed-11ed-9195-d05099c13d03  ONLINE       0     0     0
+	cache
+	  gptid/5052b77e-8aed-11ed-9195-d05099c13d03    ONLINE       0     0     0
+
+errors: No known data errors
diff --git a/report.sh b/report.sh
index d5c8a80..1f751f7 100755
--- a/report.sh
+++ b/report.sh
@@ -417,9 +417,12 @@ EOF
 			scrubErrors="$(echo "${statusOutputLine}" | cut -d ' ' -f "1") repaired"
 			scrubAge="$(echo "${statusOutputLine}" | cut -d ' ' -f "3") done"
 
-			# FixMe: no example of this to test against
 			if [ "$(echo "${statusOutputLine}" | cut -d ' ' -f "5")" = "0" ]; then
 				scrubDuration="$(echo "${statusOutputLine}" | cut -d ' ' -f "7") <br> to go"
+			elif [ "$(echo "${statusOutputLine}" | cut -d ' ' -f "5")" = "no" ]; then
+				scrubDuration="Calculating"
+			elif [ "$(echo "${statusOutputLine}" | cut -d ' ' -f "6")" = "days" ]; then
+				scrubDuration="$(echo "${statusOutputLine}" | cut -d ' ' -f "5") <br> days to go"
 			else
 				scrubDuration="$(echo "${statusOutputLine}" | cut -d ' ' -f "5") <br> to go"
 			fi

From 410c86a68e8b275f23796c336859fe4d64d5ea00 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 16 Jan 2023 11:22:22 -0500
Subject: [PATCH 119/160] First pass at linux changes; untested.

---
 report.sh | 33 +++++++++++++++++++++++++--------
 1 file changed, 25 insertions(+), 8 deletions(-)

diff --git a/report.sh b/report.sh
index f9eb4f5..b3ab718 100755
--- a/report.sh
+++ b/report.sh
@@ -1316,7 +1316,13 @@ messageid="$(dbus-uuidgen)"
 
 # Reorders the drives in ascending order
 # FixMe: smart support flag is not yet implemented in smartctl json output.
-readarray -t "drives" <<< "$(for drive in $(sysctl -n kern.disks | sed -e 's:nvd:nvme:g'); do
+if [ "${systemType}" = "BSD" ]; then
+	localDriveList="$(sysctl -n kern.disks | sed -e 's:nvd:nvme:g')"
+else
+	localDriveList="$(ls -l "/sys/block" | grep -v 'devices/virtual' | cut -d ' ' -f "9")"
+fi
+
+readarray -t "drives" <<< "$(for drive in ${localDriveList}; do
 	if smartctl -i "/dev/${drive}" | grep -q "SMART support is: Enabled"; then
 		printf "%s " "${drive}"
 	elif echo "${drive}" | grep -q "nvme"; then
@@ -1477,13 +1483,24 @@ for drive in "${drives[@]}"; do
 done
 
 # Remove some un-needed junk from the output
-sed -i '' -e '/smartctl [6-9].[0-9]/d' "${logfile}"
-sed -i '' -e '/Copyright/d' "${logfile}"
-sed -i '' -e '/=== START OF READ/d' "${logfile}"
-sed -i '' -e '/=== START OF SMART DATA SECTION ===/d' "${logfile}"
-sed -i '' -e '/SMART Attributes Data/d' "${logfile}"
-sed -i '' -e '/Vendor Specific SMART/d' "${logfile}"
-sed -i '' -e '/SMART Error Log Version/d' "${logfile}"
+if [ "${systemType}" = "BSD" ]; then
+	sed -i '' -e '/smartctl [6-9].[0-9]/d' "${logfile}"
+	sed -i '' -e '/Copyright/d' "${logfile}"
+	sed -i '' -e '/=== START OF READ/d' "${logfile}"
+	sed -i '' -e '/=== START OF SMART DATA SECTION ===/d' "${logfile}"
+	sed -i '' -e '/SMART Attributes Data/d' "${logfile}"
+	sed -i '' -e '/Vendor Specific SMART/d' "${logfile}"
+	sed -i '' -e '/SMART Error Log Version/d' "${logfile}"
+else
+	sed -i -e '/smartctl [6-9].[0-9]/d' "${logfile}"
+	sed -i -e '/Copyright/d' "${logfile}"
+	sed -i -e '/=== START OF READ/d' "${logfile}"
+	sed -i -e '/=== START OF SMART DATA SECTION ===/d' "${logfile}"
+	sed -i -e '/SMART Attributes Data/d' "${logfile}"
+	sed -i -e '/Vendor Specific SMART/d' "${logfile}"
+	sed -i -e '/SMART Error Log Version/d' "${logfile}"
+
+fi
 
 ### End details section, close MIME section
 (

From a168d43617c60cafde60cc4274252f26c65c3a42 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 16 Jan 2023 14:28:35 -0500
Subject: [PATCH 120/160] Add a file dump option for debugging.

---
 report.sh | 76 ++++++++++++++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 69 insertions(+), 7 deletions(-)

diff --git a/report.sh b/report.sh
index 1f751f7..c221f6d 100755
--- a/report.sh
+++ b/report.sh
@@ -183,10 +183,10 @@ EOF
 			fi
 
             # Write MIME section header for html content to come below
-				tee <<- EOF
-					--${boundary}
-					Content-Transfer-Encoding: 8bit
-					Content-Type: text/html; charset="utf-8"
+			tee <<- EOF
+				--${boundary}
+				Content-Transfer-Encoding: 8bit
+				Content-Type: text/html; charset="utf-8"
 
 EOF
         } >> "${logfile}"
@@ -1683,16 +1683,76 @@ function ReportUPS () {
     echo "<br><br>" >> "${logfile}"
 }
 
+function DumpFiles () {
+	local filename="dumpfiles"
+    local dumpPath="/tmp/${filename}/"
+	local tarfile="/tmp/${filename}.tgz"
+	local zfsVersion
+	local drive
+	local infoSmrtJson
+	local infoSmrt
+
+	zfsVersion="$(zpool version 2> /dev/null | head -n 1)"
+
+	# Make the dump path
+	mkdir -p "${dumpPath}"
+
+	# Grab the config file
+	cp "${configFile}" "${dumpPath}"
+
+	# Dump zpool status
+	zpool status > "${dumpPath}${zfsVersion}.txt"
+
+	# Dump drive data
+	{
+		for drive in "${drives[@]}"; do
+			infoSmrtJson="$(smartctl -AHijl xselftest,selftest --quietmode=noserial "/dev/${drive}")"
+			infoSmrt="$(smartctl -AHil error -l xselftest,selftest --quietmode=noserial "/dev/${drive}")"
+
+			echo "${infoSmrtJson}" > "${dumpPath}${drive}.json.txt"
+			echo "${infoSmrt}" > "${dumpPath}${drive}.txt"
+		done
+	}
+
+	(
+		cd "${dumpPath}.." || exit;
+		tar -czf "${tarfile}" "${filename}"
+	)
+
+	{
+		# Write MIME section header for file attachment (encoded with base64)
+		tee <<- EOF
+			--${boundary}
+			Content-Type: application/tar+gzip name="${filename}.tgz"
+			Content-Disposition: attachment; filename="${filename}.tgz"
+			Content-Transfer-Encoding: base64
+
+EOF
+		base64 "${tarfile}"
+		# Write MIME section header for html content to come below
+		tee <<- EOF
+			--${boundary}
+			Content-Transfer-Encoding: 8bit
+			Content-Type: text/html; charset="utf-8"
+
+EOF
+    } >> "${logfile}"
+
+}
+
 
 #
 # Main Script Starts Here
 #
 
-while getopts ":c:" OPTION; do
+while getopts ":c:d" OPTION; do
 	case "${OPTION}" in
 		c)
 			configFile="${OPTARG}"
 		;;
+		d)
+			fileDump="1"
+		;;
 		?)
 			# If an unknown flag is used (or -?):
 			echo "${0} {-c configFile}" >&2
@@ -1733,7 +1793,7 @@ sendmail
 sort
 tee
 )
-if [ "${configBackup}" = "true" ]; then
+if [ "${configBackup}" = "true" ]  || [ "${fileDump}" = "1" ]; then
 commands+=(
 tar
 sqlite3
@@ -1843,7 +1903,9 @@ EOF
 
 
 ###### Config backup (if enabled)
-if [ "${configBackup}" = "true" ]; then
+if [ "${fileDump}" = "1" ]; then
+	DumpFiles
+elif [ "${configBackup}" = "true" ]; then
 	ConfigBackup
 else
     # Config backup disabled; set up for html-type content

From 575e671369868f835d2acbb9fa98a0b9476e38d5 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 16 Jan 2023 19:42:04 -0500
Subject: [PATCH 121/160] Reorder to be more consistent.

---
 report.sh | 116 +++++++++++++++++++++++++++---------------------------
 1 file changed, 57 insertions(+), 59 deletions(-)

diff --git a/report.sh b/report.sh
index c221f6d..93f4d40 100755
--- a/report.sh
+++ b/report.sh
@@ -592,7 +592,14 @@ EOF
 			local wearLeveling="$(echo "${nvmeSmarOut}" | jq -Mre '.nvme_smart_health_information_log.available_spare | values')"
 			local totalLBA="$(echo "${nvmeSmarOut}" | jq -Mre '.nvme_smart_health_information_log.data_units_written | values')"
 
+			if [ "$(echo "${nvmeSmarOut}" | jq -Mre '.smart_status.passed | values')" = "true" ]; then
+				local smartStatus="PASSED"
+			else
+				local smartStatus="FAILED"
+			fi
 
+			## Formatting
+			# Calculate capacity for user consumption
 			local capacityByte="$(echo "${nvmeSmarOut}" | jq -Mre '.user_capacity.bytes | values')"
 			: "${capacityByte:="0"}"
 
@@ -610,13 +617,6 @@ EOF
 			local capacityPre="$(bc <<< "scale=2; ${capacityByte} / (1e${capacityExp})" | head -c 4 | sed -e 's:\.$::')"
 			local capacity="[${capacityPre}${capacitySufx}]"
 
-
-			if [ "$(echo "${nvmeSmarOut}" | jq -Mre '.smart_status.passed | values')" = "true" ]; then
-				local smartStatus="PASSED"
-			else
-				local smartStatus="FAILED"
-			fi
-
 			# Get more useful times from hours
 			local testAge="$(bc <<< "(${onHours} - (${onHours} - 2) ) / 24")" # ${lastTestHours}
 			local yrs="$(bc <<< "${onHours} / 8760")"
@@ -833,26 +833,6 @@ EOF
 
 			local model="$(echo "${ssdInfoSmrt}" | jq -Mre '.model_name | values')"
 			local serial="$(echo "${ssdInfoSmrt}" | jq -Mre '.serial_number | values')"
-
-
-			local capacityByte="$(echo "${ssdInfoSmrt}" | jq -Mre '.user_capacity.bytes | values')"
-			: "${capacityByte:="0"}"
-
-			if [ "${#capacityByte}" -gt "12" ]; then
-				local capacitySufx=" TB"
-				local capacityExp="12"
-			elif [ "${#capacityByte}" -gt "9" ]; then
-				local capacitySufx=" GB"
-				local capacityExp="9"
-			else
-				local capacitySufx=""
-				local capacityExp="1"
-			fi
-
-			local capacityPre="$(bc <<< "scale=2; ${capacityByte} / (1e${capacityExp})" | head -c 4 | sed -e 's:\.$::')"
-			local capacity="[${capacityPre}${capacitySufx}]"
-
-
 			local temp="$(echo "${ssdInfoSmrt}" | jq -Mre '.temperature.current | values')"
 			local onHours="$(echo "${ssdInfoSmrt}" | jq -Mre '.power_on_time.hours | values')"
 			local startStop="$(echo "${ssdInfoSmrt}" | jq -Mre '.power_cycle_count | values')"
@@ -885,6 +865,25 @@ EOF
 			fi
 
 
+			## Formatting
+			# Calculate capacity for user consumption
+			local capacityByte="$(echo "${ssdInfoSmrt}" | jq -Mre '.user_capacity.bytes | values')"
+			: "${capacityByte:="0"}"
+
+			if [ "${#capacityByte}" -gt "12" ]; then
+				local capacitySufx=" TB"
+				local capacityExp="12"
+			elif [ "${#capacityByte}" -gt "9" ]; then
+				local capacitySufx=" GB"
+				local capacityExp="9"
+			else
+				local capacitySufx=""
+				local capacityExp="1"
+			fi
+
+			local capacityPre="$(bc <<< "scale=2; ${capacityByte} / (1e${capacityExp})" | head -c 4 | sed -e 's:\.$::')"
+			local capacity="[${capacityPre}${capacitySufx}]"
+
 			# Get more useful times from hours
 			local testAge=""
 			if [ ! -z "${lastTestHours}" ]; then
@@ -1144,8 +1143,22 @@ EOF
 			local model="$(echo "${hddInfoSmrt}" | jq -Mre '.model_name | values')"
 			local serial="$(echo "${hddInfoSmrt}" | jq -Mre '.serial_number | values')"
 			local rpm="$(echo "${hddInfoSmrt}" | jq -Mre '.rotation_rate | values')"
+			local temp="$(echo "${hddInfoSmrt}"| jq -Mre '.temperature.current | values')"
+			local onHours="$(echo "${hddInfoSmrt}" | jq -Mre '.power_on_time.hours | values')"
+			local startStop="$(echo "${hddInfoSmrt}" | jq -Mre '.power_cycle_count | values')"
+
+			# Available for most common drives
+			local reAlloc="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 5) | .raw.value | values')"
+			local spinRetry="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 10) | .raw.value | values')"
+			local reAllocEvent="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 196) | .raw.value | values')"
+			local pending="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 197) | .raw.value | values')"
+			local offlineUnc="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 198) | .raw.value | values')"
+			local crcErrors="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 199) | .raw.value | values')"
+			local seekErrorHealth="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 7) | .value | values')"
 
 
+			## Formatting
+			# Calculate capacity for user consumption
 			local capacityByte="$(echo "${hddInfoSmrt}" | jq -Mre '.user_capacity.bytes | values')"
 			: "${capacityByte:="0"}"
 
@@ -1163,21 +1176,6 @@ EOF
 			local capacityPre="$(bc <<< "scale=2; ${capacityByte} / (1e${capacityExp})" | head -c 4 | sed -e 's:\.$::')"
 			local capacity="[${capacityPre}${capacitySufx}]"
 
-
-			local temp="$(echo "${hddInfoSmrt}"| jq -Mre '.temperature.current | values')"
-			local onHours="$(echo "${hddInfoSmrt}" | jq -Mre '.power_on_time.hours | values')"
-			local startStop="$(echo "${hddInfoSmrt}" | jq -Mre '.power_cycle_count | values')"
-
-			# Available for most common drives
-			local reAlloc="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 5) | .raw.value | values')"
-			local spinRetry="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 10) | .raw.value | values')"
-			local reAllocEvent="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 196) | .raw.value | values')"
-			local pending="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 197) | .raw.value | values')"
-			local offlineUnc="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 198) | .raw.value | values')"
-			local crcErrors="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 199) | .raw.value | values')"
-			local seekErrorHealth="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 7) | .value | values')"
-
-
 			# Get more useful times from hours
 			local testAge=""
 			if [ ! -z "${lastTestHours}" ]; then
@@ -1404,10 +1402,10 @@ EOF
 			local runningNowTest="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '5,6,7,8,9')"
 			if [ "${runningNowTest}" = "Self test in progress ..." ]; then
 				lastTestHours="$(echo "${sasInfoSmrt}" | jq -Mre '.power_on_time.hours | values')"
-				lastTestStatus="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '12,13,14,15')"
+				lastTestStatus="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '12-15')"
 			else
 				lastTestHours="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '7')"
-				lastTestStatus="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '8,9,10,11')"
+				lastTestStatus="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '8-11')"
 			fi
 
 			# Mimic the true/false response expected from json in the future
@@ -1439,8 +1437,23 @@ EOF
 			if [ "${rpm:-0}" = "0" ]; then
 				rpm="SSD"
 			fi
+			local temp="$(echo "${sasInfoSmrt}" | jq -Mre '.temperature.current | values')"
+			local onHours="$(echo "${sasInfoSmrt}" | jq -Mre '.power_on_time.hours | values')"
 
+			# Available for most common drives
+			local scsiGrownDefectList="$(echo "${sasInfoSmrt}" | jq -Mre '.scsi_grown_defect_list | values')"
+			local uncorrectedReadErrors="$(echo "${sasInfoSmrt}" | jq -Mre '.read.total_uncorrected_errors | values')"
+			local uncorrectedWriteErrors="$(echo "${sasInfoSmrt}" | jq -Mre '.write.total_uncorrected_errors | values')"
+			local uncorrectedVerifyErrors="$(echo "${sasInfoSmrt}" | jq -Mre '.verify.total_uncorrected_errors | values')"
 
+			#FixMe: relies on non-json output
+			local nonMediumErrors="$(echo "${nonJsonSasInfoSmrt}" | grep "Non-medium" | tr -s " " | cut -d ' ' -sf '4')"
+			local accumStartStopCycles="$(echo "${nonJsonSasInfoSmrt}" | grep "Accumulated start-stop" | tr -s " " | cut -d ' ' -sf '4')"
+			local accumLoadUnloadCycles="$(echo "${nonJsonSasInfoSmrt}" | grep "Accumulated load-unload" | tr -s " " | cut -d ' ' -sf '4')"
+
+
+			## Formatting
+			# Calculate capacity for user consumption
 			local capacityByte="$(echo "${sasInfoSmrt}" | jq -Mre '.user_capacity.bytes | values')"
 			: "${capacityByte:="0"}"
 
@@ -1458,21 +1471,6 @@ EOF
 			local capacityPre="$(bc <<< "scale=2; ${capacityByte} / (1e${capacityExp})" | head -c 4 | sed -e 's:\.$::')"
 			local capacity="[${capacityPre}${capacitySufx}]"
 
-
-			local temp="$(echo "${sasInfoSmrt}" | jq -Mre '.temperature.current | values')"
-			local onHours="$(echo "${sasInfoSmrt}" | jq -Mre '.power_on_time.hours | values')"
-
-			# Available for most common drives
-			local scsiGrownDefectList="$(echo "${sasInfoSmrt}" | jq -Mre '.scsi_grown_defect_list | values')"
-			local uncorrectedReadErrors="$(echo "${sasInfoSmrt}" | jq -Mre '.read.total_uncorrected_errors | values')"
-			local uncorrectedWriteErrors="$(echo "${sasInfoSmrt}" | jq -Mre '.write.total_uncorrected_errors | values')"
-			local uncorrectedVerifyErrors="$(echo "${sasInfoSmrt}" | jq -Mre '.verify.total_uncorrected_errors | values')"
-
-			#FixMe: relies on non-json output
-			local nonMediumErrors="$(echo "${nonJsonSasInfoSmrt}" | grep "Non-medium" | tr -s " " | cut -d ' ' -sf '4')"
-			local accumStartStopCycles="$(echo "${nonJsonSasInfoSmrt}" | grep "Accumulated start-stop" | tr -s " " | cut -d ' ' -sf '4')"
-			local accumLoadUnloadCycles="$(echo "${nonJsonSasInfoSmrt}" | grep "Accumulated load-unload" | tr -s " " | cut -d ' ' -sf '4')"
-
 			# Get more useful times from hours
 			local testAge=""
 			if [ ! -z "${lastTestHours}" ]; then

From 0db2fddc4edee0a7788e9e67ee57f0913f425194 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 16 Jan 2023 20:08:47 -0500
Subject: [PATCH 122/160] Add support for per drive overrides.

---
 report.sh | 199 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 199 insertions(+)

diff --git a/report.sh b/report.sh
index 93f4d40..41f9a72 100755
--- a/report.sh
+++ b/report.sh
@@ -124,6 +124,10 @@ logfileLocation="/tmp"      # Directory in which to save TrueNAS log file. Can b
 logfileName="logfilename"                  # Log file name
 saveLogfile="true"                         # Change to "false" to delete the log file after creation
 
+##### Drive Overrides
+# In the form: declare -A _<serial>
+# And then for each override: _<serial>[<value>]="<adjustment>"
+
 
 
 EOF
@@ -598,6 +602,42 @@ EOF
 				local smartStatus="FAILED"
 			fi
 
+
+			## Make override adjustments
+			{
+			local serialMatch
+			# onHours
+			serialMatch="_${serial}[onHours]"
+			if [ ! -z "${!serialMatch}" ]; then
+				onHours="$(bc <<< "${onHours} ${!serialMatch}")"
+			fi
+
+			# mediaErrors
+			serialMatch="_${serial}[mediaErrors]"
+			if [ ! -z "${!serialMatch}" ]; then
+				mediaErrors="$(bc <<< "${mediaErrors} ${!serialMatch}")"
+			fi
+
+			# errorsLogs
+			serialMatch="_${serial}[errorsLogs]"
+			if [ ! -z "${!serialMatch}" ]; then
+				errorsLogs="$(bc <<< "${errorsLogs} ${!serialMatch}")"
+			fi
+
+			# critWarning
+			serialMatch="_${serial}[critWarning]"
+			if [ ! -z "${!serialMatch}" ]; then
+				critWarning="$(bc <<< "${critWarning} ${!serialMatch}")"
+			fi
+
+			# wearLeveling
+			serialMatch="_${serial}[wearLeveling]"
+			if [ ! -z "${!serialMatch}" ]; then
+				wearLeveling="$(bc <<< "${wearLeveling} ${!serialMatch}")"
+			fi
+			}
+
+
 			## Formatting
 			# Calculate capacity for user consumption
 			local capacityByte="$(echo "${nvmeSmarOut}" | jq -Mre '.user_capacity.bytes | values')"
@@ -865,6 +905,59 @@ EOF
 			fi
 
 
+			## Make override adjustments
+			{
+			local serialMatch
+			# lastTestHours
+			serialMatch="_${serial}[lastTestHours]"
+			if [ ! -z "${!serialMatch}" ]; then
+				lastTestHours="$(bc <<< "${lastTestHours} ${!serialMatch}")"
+			fi
+
+			# onHours
+			serialMatch="_${serial}[onHours]"
+			if [ ! -z "${!serialMatch}" ]; then
+				onHours="$(bc <<< "${onHours} ${!serialMatch}")"
+			fi
+
+			# reAlloc
+			serialMatch="_${serial}[reAlloc]"
+			if [ ! -z "${!serialMatch}" ]; then
+				reAlloc="$(bc <<< "${reAlloc} ${!serialMatch}")"
+			fi
+
+			# progFail
+			serialMatch="_${serial}[progFail]"
+			if [ ! -z "${!serialMatch}" ]; then
+				progFail="$(bc <<< "${progFail} ${!serialMatch}")"
+			fi
+
+			# eraseFail
+			serialMatch="_${serial}[eraseFail]"
+			if [ ! -z "${!serialMatch}" ]; then
+				eraseFail="$(bc <<< "${eraseFail} ${!serialMatch}")"
+			fi
+
+			# offlineUnc
+			serialMatch="_${serial}[offlineUnc]"
+			if [ ! -z "${!serialMatch}" ]; then
+				offlineUnc="$(bc <<< "${offlineUnc} ${!serialMatch}")"
+			fi
+
+			# crcErrors
+			serialMatch="_${serial}[crcErrors]"
+			if [ ! -z "${!serialMatch}" ]; then
+				crcErrors="$(bc <<< "${crcErrors} ${!serialMatch}")"
+			fi
+
+			# wearLeveling
+			serialMatch="_${serial}[wearLeveling]"
+			if [ ! -z "${!serialMatch}" ]; then
+				wearLeveling="$(bc <<< "${wearLeveling} ${!serialMatch}")"
+			fi
+			}
+
+
 			## Formatting
 			# Calculate capacity for user consumption
 			local capacityByte="$(echo "${ssdInfoSmrt}" | jq -Mre '.user_capacity.bytes | values')"
@@ -1157,6 +1250,65 @@ EOF
 			local seekErrorHealth="$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 7) | .value | values')"
 
 
+			## Make override adjustments
+			{
+			local serialMatch
+			# lastTestHours
+			serialMatch="_${serial}[lastTestHours]"
+			if [ ! -z "${!serialMatch}" ]; then
+				lastTestHours="$(bc <<< "${lastTestHours} ${!serialMatch}")"
+			fi
+
+			# onHours
+			serialMatch="_${serial}[onHours]"
+			if [ ! -z "${!serialMatch}" ]; then
+				onHours="$(bc <<< "${onHours} ${!serialMatch}")"
+			fi
+
+			# reAlloc
+			serialMatch="_${serial}[reAlloc]"
+			if [ ! -z "${!serialMatch}" ]; then
+				reAlloc="$(bc <<< "${reAlloc} ${!serialMatch}")"
+			fi
+
+			# spinRetry
+			serialMatch="_${serial}[spinRetry]"
+			if [ ! -z "${!serialMatch}" ]; then
+				spinRetry="$(bc <<< "${spinRetry} ${!serialMatch}")"
+			fi
+
+			# reAllocEvent
+			serialMatch="_${serial}[reAllocEvent]"
+			if [ ! -z "${!serialMatch}" ]; then
+				reAllocEvent="$(bc <<< "${reAllocEvent} ${!serialMatch}")"
+			fi
+
+			# pending
+			serialMatch="_${serial}[pending]"
+			if [ ! -z "${!serialMatch}" ]; then
+				pending="$(bc <<< "${pending} ${!serialMatch}")"
+			fi
+
+			# offlineUnc
+			serialMatch="_${serial}[offlineUnc]"
+			if [ ! -z "${!serialMatch}" ]; then
+				offlineUnc="$(bc <<< "${offlineUnc} ${!serialMatch}")"
+			fi
+
+			# crcErrors
+			serialMatch="_${serial}[crcErrors]"
+			if [ ! -z "${!serialMatch}" ]; then
+				crcErrors="$(bc <<< "${crcErrors} ${!serialMatch}")"
+			fi
+
+			# seekErrorHealth
+			serialMatch="_${serial}[seekErrorHealth]"
+			if [ ! -z "${!serialMatch}" ]; then
+				seekErrorHealth="$(bc <<< "${seekErrorHealth} ${!serialMatch}")"
+			fi
+			}
+
+
 			## Formatting
 			# Calculate capacity for user consumption
 			local capacityByte="$(echo "${hddInfoSmrt}" | jq -Mre '.user_capacity.bytes | values')"
@@ -1452,6 +1604,53 @@ EOF
 			local accumLoadUnloadCycles="$(echo "${nonJsonSasInfoSmrt}" | grep "Accumulated load-unload" | tr -s " " | cut -d ' ' -sf '4')"
 
 
+			## Make override adjustments
+			{
+			local serialMatch
+			# lastTestHours
+			serialMatch="_${serial}[lastTestHours]"
+			if [ ! -z "${!serialMatch}" ]; then
+				lastTestHours="$(bc <<< "${lastTestHours} ${!serialMatch}")"
+			fi
+
+			# onHours
+			serialMatch="_${serial}[onHours]"
+			if [ ! -z "${!serialMatch}" ]; then
+				onHours="$(bc <<< "${onHours} ${!serialMatch}")"
+			fi
+
+			# scsiGrownDefectList
+			serialMatch="_${serial}[scsiGrownDefectList]"
+			if [ ! -z "${!serialMatch}" ]; then
+				scsiGrownDefectList="$(bc <<< "${scsiGrownDefectList} ${!serialMatch}")"
+			fi
+
+			# uncorrectedReadErrors
+			serialMatch="_${serial}[uncorrectedReadErrors]"
+			if [ ! -z "${!serialMatch}" ]; then
+				uncorrectedReadErrors="$(bc <<< "${uncorrectedReadErrors} ${!serialMatch}")"
+			fi
+
+			# uncorrectedWriteErrors
+			serialMatch="_${serial}[uncorrectedWriteErrors]"
+			if [ ! -z "${!serialMatch}" ]; then
+				uncorrectedWriteErrors="$(bc <<< "${uncorrectedWriteErrors} ${!serialMatch}")"
+			fi
+
+			# uncorrectedVerifyErrors
+			serialMatch="_${serial}[uncorrectedVerifyErrors]"
+			if [ ! -z "${!serialMatch}" ]; then
+				uncorrectedVerifyErrors="$(bc <<< "${uncorrectedVerifyErrors} ${!serialMatch}")"
+			fi
+
+			# nonMediumErrors
+			serialMatch="_${serial}[nonMediumErrors]"
+			if [ ! -z "${!serialMatch}" ]; then
+				nonMediumErrors="$(bc <<< "${nonMediumErrors} ${!serialMatch}")"
+			fi
+			}
+
+
 			## Formatting
 			# Calculate capacity for user consumption
 			local capacityByte="$(echo "${sasInfoSmrt}" | jq -Mre '.user_capacity.bytes | values')"

From 39d1166e7c9a97a55aa4be0045bc170939cd1606 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 16 Jan 2023 20:10:21 -0500
Subject: [PATCH 123/160] Update release notes.

---
 README.md | 7 +++++++
 report.sh | 8 +++++++-
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/README.md b/README.md
index cc7c354..2a0c04d 100644
--- a/README.md
+++ b/README.md
@@ -42,6 +42,13 @@ Once you have updated the config file, click `Run Now` again to generate your fi
 
 **Changelog**
 
+*v1.8*  (dak180)
+  - Accommodate both SSD and HDD temp settings
+  - Keep SAS drives in their own section
+  - Improved support for SAS and NVMe
+  - Remove all awk
+  - Add support for per drive overrides
+
 *v1.7.5* (dak180)
  - Add initial support for SAS drives
 
diff --git a/report.sh b/report.sh
index 41f9a72..3244cb8 100755
--- a/report.sh
+++ b/report.sh
@@ -11,10 +11,16 @@
 ### At a minimum, enter email address and set defaultFile to 0 in the config file.
 ### Feel free to edit other user parameters as needed.
 
-### Current Version: v1.7.5
+### Current Version: v1.8
 ### https://github.com/dak180/FreeNAS-Report
 
 ### Changelog:
+# v1.8
+#   - Accommodate both SSD and HDD temp settings
+#   - Keep SAS drives in their own section
+#   - Improved support for SAS and NVMe
+#   - Remove all awk
+#   - Add support for per drive overrides
 # v1.7.5
 #   - Add initial support for SAS drives
 # v1.7

From 0fcd7f613e9199d40db9306454bec4645095b8d5 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Tue, 17 Jan 2023 09:57:46 -0500
Subject: [PATCH 124/160] Make sure to include the devstat log in the dumps.

---
 report.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/report.sh b/report.sh
index 3244cb8..7c253fe 100755
--- a/report.sh
+++ b/report.sh
@@ -1888,7 +1888,7 @@ function ReportUPS () {
 
 function DumpFiles () {
 	local filename="dumpfiles"
-    local dumpPath="/tmp/${filename}/"
+	local dumpPath="/tmp/${filename}/"
 	local tarfile="/tmp/${filename}.tgz"
 	local zfsVersion
 	local drive
@@ -1909,8 +1909,8 @@ function DumpFiles () {
 	# Dump drive data
 	{
 		for drive in "${drives[@]}"; do
-			infoSmrtJson="$(smartctl -AHijl xselftest,selftest --quietmode=noserial "/dev/${drive}")"
-			infoSmrt="$(smartctl -AHil error -l xselftest,selftest --quietmode=noserial "/dev/${drive}")"
+			infoSmrtJson="$(smartctl -AHijl xselftest,selftest --log="devstat" --quietmode=noserial "/dev/${drive}")"
+			infoSmrt="$(smartctl -AHil error -l xselftest,selftest --log="devstat" --quietmode=noserial "/dev/${drive}")"
 
 			echo "${infoSmrtJson}" > "${dumpPath}${drive}.json.txt"
 			echo "${infoSmrt}" > "${dumpPath}${drive}.txt"

From b689cb1a6c01ce048566d8e5ed2883b310e02542 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Tue, 17 Jan 2023 10:12:32 -0500
Subject: [PATCH 125/160] Another command to test.

---
 report.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/report.sh b/report.sh
index b3ab718..e03e069 100755
--- a/report.sh
+++ b/report.sh
@@ -1320,6 +1320,7 @@ if [ "${systemType}" = "BSD" ]; then
 	localDriveList="$(sysctl -n kern.disks | sed -e 's:nvd:nvme:g')"
 else
 	localDriveList="$(ls -l "/sys/block" | grep -v 'devices/virtual' | cut -d ' ' -f "9")"
+	# lsblk -n -l -o NAME -E PKNAME | tr '\n' ' '
 fi
 
 readarray -t "drives" <<< "$(for drive in ${localDriveList}; do

From 374b342899f9d1a28e55e53d98b7b4486f844066 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Wed, 18 Jan 2023 00:42:38 -0500
Subject: [PATCH 126/160] Grep out log preamble.

---
 report.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/report.sh b/report.sh
index 7c253fe..56210d5 100755
--- a/report.sh
+++ b/report.sh
@@ -2184,7 +2184,7 @@ done
 ### SMART status for each drive
 for drive in "${drives[@]}"; do
     smartOut="$(smartctl --json=u -i "/dev/${drive}")" # FixMe: smart support flag is not yet implemented in smartctl json output.
-    smartTestOut="$(smartctl -l xselftest,selftest "/dev/${drive}")"
+    smartTestOut="$(smartctl -l xselftest,selftest "/dev/${drive}" | grep -v 'SMART Extended Self-test')"
 
     if echo "${smartOut}" | grep "SMART support is:" | grep -q "Enabled"; then # FixMe: smart support flag is not yet implemented in smartctl json output.
         # Gather brand and serial number of each drive

From 9bd6ae958d04f7f32c19f55df25ea1da6f58aa4e Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Thu, 19 Jan 2023 23:56:04 -0500
Subject: [PATCH 127/160] List NVMe self tests.

Since NVMe test support in smartctl will require version 7.4 (not yet out) use the output from nvmecontrol in the meantime.
---
 report.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/report.sh b/report.sh
index 56210d5..920c996 100755
--- a/report.sh
+++ b/report.sh
@@ -2216,6 +2216,7 @@ for drive in "${drives[@]}"; do
 			# Create a simple header and drop the output of some basic smartctl commands
             echo '<b>########## SMART status report for '"${drive}"' drive ('"${brand}: ${serial}"') ##########</b>'
             smartctl -H -A -l error "/dev/${drive}"
+            nvmecontrol logpage -p 0x06 ${drive} | grep '\['
             echo '<br><br>'
 		} >> "${logfile}"
     fi

From cad19ced640b3bee732ad6ef302c15d55458ad30 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 6 Feb 2023 19:04:28 -0500
Subject: [PATCH 128/160] Remove the unused -o option from sendmail.

---
 report.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/report.sh b/report.sh
index 920c996..1e87a04 100755
--- a/report.sh
+++ b/report.sh
@@ -2238,7 +2238,7 @@ sed -i '' -e '/SMART Error Log Version/d' "${logfile}"
 )  >> "${logfile}"
 
 ### Send report
-sendmail -t -oi < "${logfile}"
+sendmail -ti < "${logfile}"
 if [ "${saveLogfile}" = "false" ]; then
     rm "${logfile}"
 fi

From 48076944f0053450ec4ed8202dd189983c720386 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 6 Feb 2023 19:21:42 -0500
Subject: [PATCH 129/160] Account for different `date` invocations.

---
 report.sh | 36 ++++++++++++++++++++++++++++++------
 1 file changed, 30 insertions(+), 6 deletions(-)

diff --git a/report.sh b/report.sh
index e03e069..7bb1ebc 100755
--- a/report.sh
+++ b/report.sh
@@ -136,7 +136,11 @@ function ConfigBackup () {
     # Set up file names, etc for later
     tarfile="/tmp/config_backup.tar.gz"
     fnconfigdest_version="$(< /etc/version sed -e 's:)::' -e 's:(::' -e 's: :-:' | tr -d '\n')"
-    fnconfigdest_date="$(date -r "${runDate}" '+%Y%m%d%H%M%S')"
+	if [ "${systemType}" = "BSD" ]; then
+		fnconfigdest_date="$(date -r "${runDate}" '+%Y%m%d%H%M%S')"
+	else
+		fnconfigdest_date="$(date -d "@${runDate}" '+%Y%m%d%H%M%S')"
+    fi
     filename="${fnconfigdest_date}_${fnconfigdest_version}"
 
     ### Test config integrity
@@ -315,7 +319,11 @@ function ZpoolSummary () {
 			else
 				scrubDate="$(echo "${statusOutput}" | grep "scan:" | awk '{print $15"-"$12"-"$13"_"$14}')"
 			fi
-			scrubTS="$(date -j -f '%Y-%b-%e_%H:%M:%S' "${scrubDate}" '+%s')"
+			if [ "${systemType}" = "BSD" ]; then
+				scrubTS="$(date -j -f '%Y-%b-%e_%H:%M:%S' "${scrubDate}" '+%s')"
+			else
+				scrubTS="$(date -d "${scrubDate}" '+%s')"
+			fi
 			currentTS="${runDate}"
 			scrubAge="$((((currentTS - scrubTS) + 43200) / 86400))"
 			if [ "${multiDay}" -ge 1 ] ; then
@@ -332,7 +340,11 @@ function ZpoolSummary () {
 
 			# Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
 			scrubDate="$(echo "${statusOutput}" | grep "scan:" | awk '{print $14"-"$11"-"$12"_"$13}')"
-			scrubTS="$(date -j -f '%Y-%b-%e_%H:%M:%S' "${scrubDate}" '+%s')"
+			if [ "${systemType}" = "BSD" ]; then
+				scrubTS="$(date -j -f '%Y-%b-%e_%H:%M:%S' "${scrubDate}" '+%s')"
+			else
+				scrubTS="$(date -d "${scrubDate}" '+%s')"
+			fi
 			currentTS="${runDate}"
 			scrubAge="$((((currentTS - scrubTS) + 43200) / 86400))"
 			scrubTime="$(echo "${statusOutput}" | grep "scan:" | awk '{print $5}')"
@@ -1309,8 +1321,16 @@ host="$(hostname -s)"
 fromEmail="$(sqlite3 /data/freenas-v1.db "select em_fromemail from system_email;")"
 fromName="$(sqlite3 /data/freenas-v1.db "select em_fromname from system_email;")"
 runDate="$(date '+%s')"
-logfile="${logfileLocation}/$(date -r "${runDate}" '+%Y%m%d%H%M%S')_${logfileName}.tmp"
-subject="Status Report and Configuration Backup for ${host} - $(date -r "${runDate}" '+%Y-%m-%d %H:%M')"
+if [ "${systemType}" = "BSD" ]; then
+	logfile="${logfileLocation}/$(date -r "${runDate}" '+%Y%m%d%H%M%S')_${logfileName}.tmp"
+else
+	logfile="${logfileLocation}/$(date -d "@${runDate}" '+%Y%m%d%H%M%S')_${logfileName}.tmp"
+fi
+if [ "${systemType}" = "BSD" ]; then
+	subject="Status Report and Configuration Backup for ${host} - $(date -r "${runDate}" '+%Y-%m-%d %H:%M')"
+else
+	subject="Status Report and Configuration Backup for ${host} - $(date -d "@${runDate}" '+%Y-%m-%d %H:%M')"
+fi
 boundary="$(dbus-uuidgen)"
 messageid="$(dbus-uuidgen)"
 
@@ -1368,7 +1388,11 @@ readarray -t "pools" <<< "$(zpool list -H -o name)"
     echo "Subject: ${subject}"
     echo "MIME-Version: 1.0"
     echo 'Content-Type: multipart/mixed; boundary="'"${boundary}"'"'
-    echo "Date: $(date -Rr "${runDate}")"
+    if [ "${systemType}" = "BSD" ]; then
+		echo "Date: $(date -Rr "${runDate}")"
+    else
+    	echo "Date: $(date -d "@${runDate}" '+%a, %d %b %Y %T %Z')"
+    fi
     echo "Message-Id: <${messageid}@${host}>"
 } > "${logfile}"
 

From fbe234aa5a02375ac77f1366c5e2f8c4740d0ebd Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Tue, 7 Feb 2023 08:58:23 -0500
Subject: [PATCH 130/160] debain date does not like _

---
 report.sh | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/report.sh b/report.sh
index 7bb1ebc..43e9b16 100755
--- a/report.sh
+++ b/report.sh
@@ -315,12 +315,12 @@ function ZpoolSummary () {
 
 			# Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
 			if [ "${multiDay}" -ge 1 ] ; then
-				scrubDate="$(echo "${statusOutput}" | grep "scan:" | awk '{print $17"-"$14"-"$15"_"$16}')"
+				scrubDate="$(echo "${statusOutput}" | grep "scan:" | awk '{print $17"-"$14"-"$15" "$16}')"
 			else
-				scrubDate="$(echo "${statusOutput}" | grep "scan:" | awk '{print $15"-"$12"-"$13"_"$14}')"
+				scrubDate="$(echo "${statusOutput}" | grep "scan:" | awk '{print $15"-"$12"-"$13" "$14}')"
 			fi
 			if [ "${systemType}" = "BSD" ]; then
-				scrubTS="$(date -j -f '%Y-%b-%e_%H:%M:%S' "${scrubDate}" '+%s')"
+				scrubTS="$(date -j -f '%Y-%b-%e %H:%M:%S' "${scrubDate}" '+%s')"
 			else
 				scrubTS="$(date -d "${scrubDate}" '+%s')"
 			fi
@@ -339,9 +339,9 @@ function ZpoolSummary () {
 			scrubErrors="$(echo "${statusOutput}" | grep "scan:" | awk '{print $7}')"
 
 			# Convert time/datestamp format presented by zpool status, compare to current date, calculate scrub age
-			scrubDate="$(echo "${statusOutput}" | grep "scan:" | awk '{print $14"-"$11"-"$12"_"$13}')"
+			scrubDate="$(echo "${statusOutput}" | grep "scan:" | awk '{print $14"-"$11"-"$12" "$13}')"
 			if [ "${systemType}" = "BSD" ]; then
-				scrubTS="$(date -j -f '%Y-%b-%e_%H:%M:%S' "${scrubDate}" '+%s')"
+				scrubTS="$(date -j -f '%Y-%b-%e %H:%M:%S' "${scrubDate}" '+%s')"
 			else
 				scrubTS="$(date -d "${scrubDate}" '+%s')"
 			fi

From 35a8830241d3f94647d57b21d10f2ff3adac136f Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Tue, 7 Feb 2023 10:10:32 -0500
Subject: [PATCH 131/160] Having a date field that takes almost anything is
 pain.

The keyword here here is almost and a lack of docs never helps.
---
 report.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/report.sh b/report.sh
index 1a0b11e..29727d5 100755
--- a/report.sh
+++ b/report.sh
@@ -369,11 +369,11 @@ EOF
 				scrubDuration="$(echo "${statusOutputLine}" | cut -d ' ' -f "6")"
 				scrubErrors="$(echo "${statusOutputLine}" | cut -d ' ' -f "8")"
 			fi
-			scrubDate="${scrubYear}-${scrubMonth}-${scrubDay} ${scrubTime}"
+			scrubDate="${scrubMonth} ${scrubDay} ${scrubYear} ${scrubTime}"
 
 
             if [ "${systemType}" = "BSD" ]; then
-                scrubTS="$(date -j -f '%Y-%b-%e %H:%M:%S' "${scrubDate}" '+%s')"
+                scrubTS="$(date -j -f '%b %e %Y %H:%M:%S' "${scrubDate}" '+%s')"
             else
                 scrubTS="$(date -d "${scrubDate}" '+%s')"
             fi
@@ -408,11 +408,11 @@ EOF
 				scrubDuration="$(echo "${statusOutputLine}" | cut -d ' ' -f "5")"
 				scrubErrors="$(echo "${statusOutputLine}" | cut -d ' ' -f "7")"
 			fi
-			scrubDate="${scrubYear}-${scrubMonth}-${scrubDay} ${scrubTime}"
+			scrubDate="${scrubMonth} ${scrubDay} ${scrubYear} ${scrubTime}"
 
 
             if [ "${systemType}" = "BSD" ]; then
-                scrubTS="$(date -j -f '%Y-%b-%e %H:%M:%S' "${scrubDate}" '+%s')"
+                scrubTS="$(date -j -f '%b %e %Y %H:%M:%S' "${scrubDate}" '+%s')"
             else
                 scrubTS="$(date -d "${scrubDate}" '+%s')"
             fi

From bbe80f6f19d845d71f9b0ddd36c05af26f9cb10b Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Tue, 7 Feb 2023 12:10:21 -0500
Subject: [PATCH 132/160] Better drive list for scale.

---
 report.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/report.sh b/report.sh
index 29727d5..783e499 100755
--- a/report.sh
+++ b/report.sh
@@ -2069,7 +2069,7 @@ messageid="$(dbus-uuidgen)"
 if [ "${systemType}" = "BSD" ]; then
 	localDriveList="$(sysctl -n kern.disks | sed -e 's:nvd:nvme:g')"
 else
-	localDriveList="$(ls -l "/sys/block" | grep -v 'devices/virtual' | cut -d ' ' -f "9")"
+	localDriveList="$(ls -l "/sys/block" | grep -v 'devices/virtual' | sed -e 's:[[:blank:]]\{1,\}: :g' | cut -d ' ' -f "9" | sed -e 's:n[0-9]\{1,\}$::g' | uniq )"
 	# lsblk -n -l -o NAME -E PKNAME | tr '\n' ' '
 fi
 

From 6df5ab0e04bed8532b721dd2ae1c246bf03f7992 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Tue, 7 Feb 2023 12:38:18 -0500
Subject: [PATCH 133/160] nvmecontrol is bsd only.

---
 report.sh | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/report.sh b/report.sh
index 783e499..86a4626 100755
--- a/report.sh
+++ b/report.sh
@@ -2015,6 +2015,7 @@ tee
 if [ "${systemType}" = "BSD" ]; then
 commands+=(
 glabel
+nvmecontrol
 )
 fi
 if [ "${configBackup}" = "true" ]  || [ "${fileDump}" = "1" ]; then
@@ -2258,7 +2259,10 @@ for drive in "${drives[@]}"; do
 			# Create a simple header and drop the output of some basic smartctl commands
             echo '<b>########## SMART status report for '"${drive}"' drive ('"${brand}: ${serial}"') ##########</b>'
             smartctl -H -A -l error "/dev/${drive}"
-            nvmecontrol logpage -p 0x06 ${drive} | grep '\['
+            # FixMe: bsd only; still waiting on suport for nvme tests in smartctl
+            if [ "${systemType}" = "BSD" ]; then
+				nvmecontrol logpage -p 0x06 ${drive} | grep '\['
+            fi
             echo '<br><br>'
 		} >> "${logfile}"
     fi

From 9b2900a63835ed12b3b3edb45bb67c686f983493 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Tue, 7 Feb 2023 13:40:04 -0500
Subject: [PATCH 134/160] md5sum and sha256sum are on both scale and core.

---
 report.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/report.sh b/report.sh
index 86a4626..fd86780 100755
--- a/report.sh
+++ b/report.sh
@@ -177,8 +177,8 @@ EOF
         # Config integrity check passed; copy config db, generate checksums, make .tar.gz archive
         sqlite3 "/data/freenas-v1.db" ".backup main /tmp/${filename}.db"
         cp -f "/data/pwenc_secret" "/tmp/"
-        md5 "/tmp/${filename}.db" > /tmp/config_backup.md5
-        sha256 "/tmp/${filename}.db" > /tmp/config_backup.sha256
+        md5sum -q "/tmp/${filename}.db" > /tmp/config_backup.md5
+        sha256sum -q "/tmp/${filename}.db" > /tmp/config_backup.sha256
         (
             cd "/tmp/" || exit;
             tar -czf "${tarfile}" "./${filename}.db" "./config_backup.md5" "./config_backup.sha256" "./pwenc_secret"
@@ -2022,8 +2022,8 @@ if [ "${configBackup}" = "true" ]  || [ "${fileDump}" = "1" ]; then
 commands+=(
 tar
 sqlite3
-md5
-sha256
+md5sum
+sha256sum
 base64
 )
 fi

From 2ab525ebe9d9be64f00c73b598103eb20b1764fd Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Tue, 7 Feb 2023 14:14:00 -0500
Subject: [PATCH 135/160] Get a more human readable status dump.

---
 report.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/report.sh b/report.sh
index fd86780..ad2306d 100755
--- a/report.sh
+++ b/report.sh
@@ -1916,7 +1916,7 @@ function DumpFiles () {
 	cp "${configFile}" "${dumpPath}"
 
 	# Dump zpool status
-	zpool status > "${dumpPath}${zfsVersion}.txt"
+	zpool status -Lv > "${dumpPath}${zfsVersion}.txt"
 
 	# Dump drive data
 	{

From 6b14d7a0fa772ef7b93eeab5d5112ecf0f28a59e Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Tue, 7 Feb 2023 19:55:55 -0500
Subject: [PATCH 136/160] 10^ is more portable than 1e.

---
 report.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/report.sh b/report.sh
index ad2306d..0058b20 100755
--- a/report.sh
+++ b/report.sh
@@ -672,7 +672,7 @@ EOF
 				local capacityExp="1"
 			fi
 
-			local capacityPre="$(bc <<< "scale=2; ${capacityByte} / (1e${capacityExp})" | head -c 4 | sed -e 's:\.$::')"
+			local capacityPre="$(bc <<< "scale=2; ${capacityByte} / (10^${capacityExp})" | head -c 4 | sed -e 's:\.$::')"
 			local capacity="[${capacityPre}${capacitySufx}]"
 
 			# Get more useful times from hours
@@ -992,7 +992,7 @@ EOF
 				local capacityExp="1"
 			fi
 
-			local capacityPre="$(bc <<< "scale=2; ${capacityByte} / (1e${capacityExp})" | head -c 4 | sed -e 's:\.$::')"
+			local capacityPre="$(bc <<< "scale=2; ${capacityByte} / (10^${capacityExp})" | head -c 4 | sed -e 's:\.$::')"
 			local capacity="[${capacityPre}${capacitySufx}]"
 
 			# Get more useful times from hours
@@ -1343,7 +1343,7 @@ EOF
 				local capacityExp="1"
 			fi
 
-			local capacityPre="$(bc <<< "scale=2; ${capacityByte} / (1e${capacityExp})" | head -c 4 | sed -e 's:\.$::')"
+			local capacityPre="$(bc <<< "scale=2; ${capacityByte} / (10^${capacityExp})" | head -c 4 | sed -e 's:\.$::')"
 			local capacity="[${capacityPre}${capacitySufx}]"
 
 			# Get more useful times from hours
@@ -1685,7 +1685,7 @@ EOF
 				local capacityExp="1"
 			fi
 
-			local capacityPre="$(bc <<< "scale=2; ${capacityByte} / (1e${capacityExp})" | head -c 4 | sed -e 's:\.$::')"
+			local capacityPre="$(bc <<< "scale=2; ${capacityByte} / (10^${capacityExp})" | head -c 4 | sed -e 's:\.$::')"
 			local capacity="[${capacityPre}${capacitySufx}]"
 
 			# Get more useful times from hours

From 7eb24063258c55f16a4a64bb9c421546a8570bd0 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Tue, 7 Feb 2023 20:14:14 -0500
Subject: [PATCH 137/160] -q does not work on debian.

---
 report.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/report.sh b/report.sh
index 0058b20..088fe68 100755
--- a/report.sh
+++ b/report.sh
@@ -177,8 +177,8 @@ EOF
         # Config integrity check passed; copy config db, generate checksums, make .tar.gz archive
         sqlite3 "/data/freenas-v1.db" ".backup main /tmp/${filename}.db"
         cp -f "/data/pwenc_secret" "/tmp/"
-        md5sum -q "/tmp/${filename}.db" > /tmp/config_backup.md5
-        sha256sum -q "/tmp/${filename}.db" > /tmp/config_backup.sha256
+        md5sum "/tmp/${filename}.db" > /tmp/config_backup.md5
+        sha256sum "/tmp/${filename}.db" > /tmp/config_backup.sha256
         (
             cd "/tmp/" || exit;
             tar -czf "${tarfile}" "./${filename}.db" "./config_backup.md5" "./config_backup.sha256" "./pwenc_secret"

From 7d0905ced99d8009ed01887fe2751f0b07623540 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Wed, 8 Feb 2023 00:03:20 -0500
Subject: [PATCH 138/160] Fix white space.

---
 report.sh | 316 +++++++++++++++++++++++++++---------------------------
 1 file changed, 158 insertions(+), 158 deletions(-)

diff --git a/report.sh b/report.sh
index 088fe68..d7fd98c 100755
--- a/report.sh
+++ b/report.sh
@@ -92,43 +92,43 @@ defaultFile="1"
 email="email@address.com"
 
 ### Global table colors
-okColor="#c9ffcc"       # Hex code for color to use in SMART Status column if drives pass (default is light green, #c9ffcc)
-warnColor="#ffd6d6"     # Hex code for WARN color (default is light red, #ffd6d6)
-critColor="#ff0000"     # Hex code for CRITICAL color (default is bright red, #ff0000)
-altColor="#f4f4f4"      # Table background alternates row colors between white and this color (default is light gray, #f4f4f4)
+okColor="#c9ffcc"	# Hex code for color to use in SMART Status column if drives pass (default is light green, #c9ffcc)
+warnColor="#ffd6d6"	# Hex code for WARN color (default is light red, #ffd6d6)
+critColor="#ff0000"	# Hex code for CRITICAL color (default is bright red, #ff0000)
+altColor="#f4f4f4"	# Table background alternates row colors between white and this color (default is light gray, #f4f4f4)
 
 ### zpool status summary table settings
-usedWarn="90"             # Pool used percentage for CRITICAL color to be used
-scrubAgeWarn="30"         # Maximum age (in days) of last pool scrub before CRITICAL color will be used
+usedWarn="90"			# Pool used percentage for CRITICAL color to be used
+scrubAgeWarn="30"		# Maximum age (in days) of last pool scrub before CRITICAL color will be used
 
 ### SMART status summary table settings
-includeSSD="true"       # Change to "true" to include SSDs in SMART status summary table; "false" to disable
-includeSAS="false"       # Change to "true" to include SAS drives in SMART status summary table; "false" to disable
-lifeRemainWarn="75"       # Life remaining in the SSD at which WARNING color will be used
-lifeRemainCrit="50"       # Life remaining in the SSD at which CRITICAL color will be used
-totalBWWarn="100"         # Total bytes written (in TB) to the SSD at which WARNING color will be used
-totalBWCrit="200"         # Total bytes written (in TB) to the SSD at which CRITICAL color will be used
-tempWarn="35"             # Drive temp (in C) at which WARNING color will be used
-tempCrit="40"             # Drive temp (in C) at which CRITICAL color will be used
-ssdTempWarn="40"          # SSD drive temp (in C) at which WARNING color will be used
-ssdTempCrit="45"          # SSD drive temp (in C) at which CRITICAL color will be used
-sectorsCrit="10"          # Number of sectors per drive with errors before CRITICAL color will be used
-testAgeWarn="5"           # Maximum age (in days) of last SMART test before CRITICAL color will be used
+includeSSD="true"		# Change to "true" to include SSDs in SMART status summary table; "false" to disable
+includeSAS="false"		# Change to "true" to include SAS drives in SMART status summary table; "false" to disable
+lifeRemainWarn="75"		# Life remaining in the SSD at which WARNING color will be used
+lifeRemainCrit="50"		# Life remaining in the SSD at which CRITICAL color will be used
+totalBWWarn="100"		# Total bytes written (in TB) to the SSD at which WARNING color will be used
+totalBWCrit="200"		# Total bytes written (in TB) to the SSD at which CRITICAL color will be used
+tempWarn="35"			# Drive temp (in C) at which WARNING color will be used
+tempCrit="40"			# Drive temp (in C) at which CRITICAL color will be used
+ssdTempWarn="40"		# SSD drive temp (in C) at which WARNING color will be used
+ssdTempCrit="45"		# SSD drive temp (in C) at which CRITICAL color will be used
+sectorsCrit="10"		# Number of sectors per drive with errors before CRITICAL color will be used
+testAgeWarn="5"			# Maximum age (in days) of last SMART test before CRITICAL color will be used
 powerTimeFormat="ymdh"  # Format for power-on hours string, valid options are "ymdh", "ymd", "ym", or "y" (year month day hour)
 
 ### TrueNAS config backup settings
-configBackup="false"     # Change to "false" to skip config backup (which renders next two options meaningless); "true" to keep config backups enabled
-emailBackup="false"     # Change to "true" to email TrueNAS config backup
-saveBackup="true"       # Change to "false" to delete TrueNAS config backup after mail is sent; "true" to keep it in dir below
-backupLocation="/root/backup"    # Directory in which to save TrueNAS config backups
+configBackup="false"			# Change to "false" to skip config backup (which renders next two options meaningless); "true" to keep config backups enabled
+emailBackup="false"				# Change to "true" to email TrueNAS config backup
+saveBackup="true"				# Change to "false" to delete TrueNAS config backup after mail is sent; "true" to keep it in dir below
+backupLocation="/root/backup"	# Directory in which to save TrueNAS config backups
 
 ### UPS status summary settings
-reportUPS="false"        # Change to "false" to skip reporting the status of the UPS
+reportUPS="false"			# Change to "false" to skip reporting the status of the UPS
 
 ### General script settings
-logfileLocation="/tmp"      # Directory in which to save TrueNAS log file. Can be set to /tmp.
-logfileName="logfilename"                  # Log file name
-saveLogfile="true"                         # Change to "false" to delete the log file after creation
+logfileLocation="/tmp"		# Directory in which to save TrueNAS log file. Can be set to /tmp.
+logfileName="logfilename"	# Log file name
+saveLogfile="true"			# Change to "false" to delete the log file after creation
 
 ##### Drive Overrides
 # In the form: declare -A _<serial>
@@ -142,27 +142,27 @@ EOF
 }
 
 function ConfigBackup () {
-    local tarfile
-    local fnconfigdest_version
-    local fnconfigdest_date
-    local filename
+	local tarfile
+	local fnconfigdest_version
+	local fnconfigdest_date
+	local filename
 
 
-    # Set up file names, etc for later
-    tarfile="/tmp/config_backup.tar.gz"
-    fnconfigdest_version="$(< /etc/version sed -e 's:)::' -e 's:(::' -e 's: :-:' | tr -d '\n')"
+	# Set up file names, etc for later
+	tarfile="/tmp/config_backup.tar.gz"
+	fnconfigdest_version="$(< /etc/version sed -e 's:)::' -e 's:(::' -e 's: :-:' | tr -d '\n')"
 	if [ "${systemType}" = "BSD" ]; then
 		fnconfigdest_date="$(date -r "${runDate}" '+%Y%m%d%H%M%S')"
 	else
 		fnconfigdest_date="$(date -d "@${runDate}" '+%Y%m%d%H%M%S')"
-    fi
-    filename="${fnconfigdest_date}_${fnconfigdest_version}"
+	fi
+	filename="${fnconfigdest_date}_${fnconfigdest_version}"
 
-    ### Test config integrity
-    if [ ! "$(sqlite3 "/data/freenas-v1.db" "pragma integrity_check;")" = "ok" ]; then
+	### Test config integrity
+	if [ ! "$(sqlite3 "/data/freenas-v1.db" "pragma integrity_check;")" = "ok" ]; then
 
-        # Config integrity check failed, set MIME content type to html and print warning
-        {
+		# Config integrity check failed, set MIME content type to html and print warning
+		{
 			tee <<- EOF
 				--${boundary}
 				Content-Transfer-Encoding: 8bit
@@ -172,18 +172,18 @@ function ConfigBackup () {
 				<b>You should correct this problem as soon as possible!</b>
 				<br>
 EOF
-        } >> "${logfile}"
-    else
-        # Config integrity check passed; copy config db, generate checksums, make .tar.gz archive
-        sqlite3 "/data/freenas-v1.db" ".backup main /tmp/${filename}.db"
-        cp -f "/data/pwenc_secret" "/tmp/"
-        md5sum "/tmp/${filename}.db" > /tmp/config_backup.md5
-        sha256sum "/tmp/${filename}.db" > /tmp/config_backup.sha256
-        (
-            cd "/tmp/" || exit;
-            tar -czf "${tarfile}" "./${filename}.db" "./config_backup.md5" "./config_backup.sha256" "./pwenc_secret"
-        )
-        {
+		} >> "${logfile}"
+	else
+		# Config integrity check passed; copy config db, generate checksums, make .tar.gz archive
+		sqlite3 "/data/freenas-v1.db" ".backup main /tmp/${filename}.db"
+		cp -f "/data/pwenc_secret" "/tmp/"
+		md5sum "/tmp/${filename}.db" > /tmp/config_backup.md5
+		sha256sum "/tmp/${filename}.db" > /tmp/config_backup.sha256
+		(
+			cd "/tmp/" || exit;
+			tar -czf "${tarfile}" "./${filename}.db" "./config_backup.md5" "./config_backup.sha256" "./pwenc_secret"
+		)
+		{
 			if [ "${emailBackup}" = "true" ]; then
 				# Write MIME section header for file attachment (encoded with base64)
 				tee <<- EOF
@@ -196,24 +196,24 @@ EOF
 				base64 "${tarfile}"
 			fi
 
-            # Write MIME section header for html content to come below
+			# Write MIME section header for html content to come below
 			tee <<- EOF
 				--${boundary}
 				Content-Transfer-Encoding: 8bit
 				Content-Type: text/html; charset="utf-8"
 
 EOF
-        } >> "${logfile}"
-
-        # If logfile saving is enabled, copy .tar.gz file to specified location before it (and everything else) is removed below
-        if [ "${saveBackup}" = "true" ]; then
-            cp "${tarfile}" "${backupLocation}/${filename}.tar.gz"
-        fi
-        rm "/tmp/${filename}.db"
-        rm "/tmp/config_backup.md5"
-        rm "/tmp/config_backup.sha256"
-        rm "${tarfile}"
-    fi
+		} >> "${logfile}"
+
+		# If logfile saving is enabled, copy .tar.gz file to specified location before it (and everything else) is removed below
+		if [ "${saveBackup}" = "true" ]; then
+			cp "${tarfile}" "${backupLocation}/${filename}.tar.gz"
+		fi
+		rm "/tmp/${filename}.db"
+		rm "/tmp/config_backup.md5"
+		rm "/tmp/config_backup.sha256"
+		rm "${tarfile}"
+	fi
 }
 
 function ZpoolSummary () {
@@ -372,12 +372,12 @@ EOF
 			scrubDate="${scrubMonth} ${scrubDay} ${scrubYear} ${scrubTime}"
 
 
-            if [ "${systemType}" = "BSD" ]; then
-                scrubTS="$(date -j -f '%b %e %Y %H:%M:%S' "${scrubDate}" '+%s')"
-            else
-                scrubTS="$(date -d "${scrubDate}" '+%s')"
-            fi
-            currentTS="${runDate}"
+			if [ "${systemType}" = "BSD" ]; then
+				scrubTS="$(date -j -f '%b %e %Y %H:%M:%S' "${scrubDate}" '+%s')"
+			else
+				scrubTS="$(date -d "${scrubDate}" '+%s')"
+			fi
+			currentTS="${runDate}"
 			scrubAge="$((((currentTS - scrubTS) + 43200) / 86400))"
 			}
 
@@ -411,11 +411,11 @@ EOF
 			scrubDate="${scrubMonth} ${scrubDay} ${scrubYear} ${scrubTime}"
 
 
-            if [ "${systemType}" = "BSD" ]; then
-                scrubTS="$(date -j -f '%b %e %Y %H:%M:%S' "${scrubDate}" '+%s')"
-            else
-                scrubTS="$(date -d "${scrubDate}" '+%s')"
-            fi
+			if [ "${systemType}" = "BSD" ]; then
+				scrubTS="$(date -j -f '%b %e %Y %H:%M:%S' "${scrubDate}" '+%s')"
+			else
+				scrubTS="$(date -d "${scrubDate}" '+%s')"
+			fi
 			currentTS="${runDate}"
 			scrubAge="$((((currentTS - scrubTS) + 43200) / 86400))"
 			}
@@ -859,11 +859,11 @@ EOF
 
 	local drive
 	local altRow="false"
-    for drive in "${drives[@]}"; do
+	for drive in "${drives[@]}"; do
 		local ssdInfoSmrt="$(smartctl -AHijl xselftest,selftest --log="devstat" "/dev/${drive}")"
-    	local rotTst="$(echo "${ssdInfoSmrt}" | jq -Mre '.rotation_rate | values')"
-    	local scsiTst="$(echo "${ssdInfoSmrt}" | jq -Mre '.device.type | values')"
-        if [ "${rotTst}" = "0" ] && [ ! "${scsiTst}" = "scsi" ]; then
+		local rotTst="$(echo "${ssdInfoSmrt}" | jq -Mre '.rotation_rate | values')"
+		local scsiTst="$(echo "${ssdInfoSmrt}" | jq -Mre '.device.type | values')"
+		if [ "${rotTst}" = "0" ] && [ ! "${scsiTst}" = "scsi" ]; then
 			# For each drive detected, run "smartctl -AHijl xselftest,selftest" and parse its output.
 			# Start by parsing out the variables used in other parts of the script.
 			# After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).
@@ -1150,7 +1150,7 @@ EOF
 			fi
 
 
-            {
+			{
 				# Row Output
 				tee <<- EOF
 					<tr style="background-color:${bgColor};">
@@ -1174,14 +1174,14 @@ EOF
 					<td style="text-align:center; background-color:${lastTestStatusColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${lastTestType:-"N/A"}</td>
 					</tr>
 EOF
-            } >> "${logfile}"
-        fi
-    done
-
-    # End SSD SMART summary table
-    {
-        echo '</table>'
-    } >> "${logfile}"
+			} >> "${logfile}"
+		fi
+	done
+
+	# End SSD SMART summary table
+	{
+		echo '</table>'
+	} >> "${logfile}"
 }
 
 # shellcheck disable=SC2155
@@ -1840,16 +1840,16 @@ EOF
 
 # shellcheck disable=SC2155
 function ReportUPS () {
-    # Set to a value greater than zero to include all available UPSC
-    # variables in the report:
+	# Set to a value greater than zero to include all available UPSC
+	# variables in the report:
 	local senddetail="0"
 	local ups
-    local upslist
+	local upslist
 
-    # Get a list of all ups devices installed on the system:
-    readarray -t "upslist" <<< "$(upsc -l "${host}")"
+	# Get a list of all ups devices installed on the system:
+	readarray -t "upslist" <<< "$(upsc -l "${host}")"
 
-    {
+	{
 		echo '<b>########## UPS status report ##########</b>'
 			for ups in "${upslist[@]}"; do
 
@@ -1893,9 +1893,9 @@ function ReportUPS () {
 					echo ""
 				fi
 			done
-    } >> "${logfile}"
+	} >> "${logfile}"
 
-    echo "<br><br>" >> "${logfile}"
+	echo "<br><br>" >> "${logfile}"
 }
 
 function DumpFiles () {
@@ -1951,7 +1951,7 @@ EOF
 			Content-Type: text/html; charset="utf-8"
 
 EOF
-    } >> "${logfile}"
+	} >> "${logfile}"
 
 }
 
@@ -2084,18 +2084,18 @@ done | tr ' ' '\n' | sort -V | sed '/^nvme/!H;//p;$!d;g;s:\n::')"
 
 # Toggles the 'ssdExist' flag to true if SSDs are detected in order to add the summary table
 if [ "${includeSSD}" = "true" ]; then
-    for drive in "${drives[@]}"; do
-        driveTypeExistSmartOutput="$(smartctl -ij "/dev/${drive}")"
-        if [ "$(echo "${driveTypeExistSmartOutput}" | jq -Mre '.rotation_rate | values')" = "0" ] && [ ! "$(echo "${driveTypeExistSmartOutput}" | jq -Mre '.device.type | values')" = "scsi" ]; then
-            ssdExist="true"
-            break
-        else
-            ssdExist="false"
-        fi
-    done
-    if echo "${drives[*]}" | grep -q "nvme"; then
-    	NVMeExist="true"
-    fi
+	for drive in "${drives[@]}"; do
+		driveTypeExistSmartOutput="$(smartctl -ij "/dev/${drive}")"
+		if [ "$(echo "${driveTypeExistSmartOutput}" | jq -Mre '.rotation_rate | values')" = "0" ] && [ ! "$(echo "${driveTypeExistSmartOutput}" | jq -Mre '.device.type | values')" = "scsi" ]; then
+			ssdExist="true"
+			break
+		else
+			ssdExist="false"
+		fi
+	done
+	if echo "${drives[*]}" | grep -q "nvme"; then
+		NVMeExist="true"
+	fi
 fi
 # Test to see if there are any HDDs
 for drive in "${drives[@]}"; do
@@ -2136,11 +2136,11 @@ tee <<- EOF
 	Content-Type: multipart/mixed; boundary="${boundary}"
 	Message-Id: <${messageid}@${host}>
 EOF
-    if [ "${systemType}" = "BSD" ]; then
+	if [ "${systemType}" = "BSD" ]; then
 		echo "Date: $(date -Rr "${runDate}")"
-    else
-    	echo "Date: $(date -d "@${runDate}" '+%a, %d %b %Y %T %Z')"
-    fi
+	else
+		echo "Date: $(date -d "@${runDate}" '+%a, %d %b %Y %T %Z')"
+	fi
 } > "${logfile}"
 
 
@@ -2152,15 +2152,15 @@ if [ "${fileDump}" = "1" ]; then
 elif [ "${configBackup}" = "true" ]; then
 	ConfigBackup
 else
-    # Config backup disabled; set up for html-type content
-    {
+	# Config backup disabled; set up for html-type content
+	{
 	tee <<- EOF
 		--${boundary}
 		Content-Transfer-Encoding: 8bit
 		Content-Type: text/html; charset="utf-8"
 
 EOF
-    } >> "${logfile}"
+	} >> "${logfile}"
 fi
 
 
@@ -2215,57 +2215,57 @@ fi
 
 ### Zpool status for each pool
 for pool in "${pools[@]}"; do
-    {
-        # Create a simple header and drop the output of zpool status -v
-        echo '<b>########## ZPool status report for '"${pool}"' ##########</b>'
-        zpool status -Lv "${pool}"
-        echo '<br><br>'
-    } >> "${logfile}"
+	{
+		# Create a simple header and drop the output of zpool status -v
+		echo '<b>########## ZPool status report for '"${pool}"' ##########</b>'
+		zpool status -Lv "${pool}"
+		echo '<br><br>'
+	} >> "${logfile}"
 done
 
 
 ### SMART status for each drive
 for drive in "${drives[@]}"; do
-    smartOut="$(smartctl --json=u -i "/dev/${drive}")" # FixMe: smart support flag is not yet implemented in smartctl json output.
-    smartTestOut="$(smartctl -l xselftest,selftest "/dev/${drive}" | grep -v 'SMART Extended Self-test')"
-
-    if echo "${smartOut}" | grep "SMART support is:" | grep -q "Enabled"; then # FixMe: smart support flag is not yet implemented in smartctl json output.
-        # Gather brand and serial number of each drive
-        brand="$(echo "${smartOut}" | jq -Mre '.model_family | values')"
-        if [ -z "${brand}" ]; then
-            brand="$(echo "${smartOut}" | jq -Mre '.model_name | values')";
-        fi
-        serial="$(echo "${smartOut}" | jq -Mre '.serial_number | values')"
-        {
-            # Create a simple header and drop the output of some basic smartctl commands
-            echo '<b>########## SMART status report for '"${drive}"' drive ('"${brand}: ${serial}"') ##########</b>'
-            smartctl -H -A -l error "/dev/${drive}"
-            echo "${smartTestOut}" | grep 'Num' | cut -c6- | head -1
-            echo "${smartTestOut}" | grep 'Extended' | cut -c6- | head -1
-            echo "${smartTestOut}" | grep 'Short' | cut -c6- | head -1
-            echo "${smartTestOut}" | grep 'Conveyance' | cut -c6- | head -1
-            echo '<br><br>'
-        } >> "${logfile}"
-
-    elif echo "${drive}" | grep -q "nvme"; then
-    	# NVMe drives are handled separately because self tests are not yet supported.
-        # Gather brand and serial number of each drive
+	smartOut="$(smartctl --json=u -i "/dev/${drive}")" # FixMe: smart support flag is not yet implemented in smartctl json output.
+	smartTestOut="$(smartctl -l xselftest,selftest "/dev/${drive}" | grep -v 'SMART Extended Self-test')"
+
+	if echo "${smartOut}" | grep "SMART support is:" | grep -q "Enabled"; then # FixMe: smart support flag is not yet implemented in smartctl json output.
+		# Gather brand and serial number of each drive
 		brand="$(echo "${smartOut}" | jq -Mre '.model_family | values')"
-        if [ -z "${brand}" ]; then
-            brand="$(echo "${smartOut}" | jq -Mre '.model_name | values')";
-        fi
+		if [ -z "${brand}" ]; then
+			brand="$(echo "${smartOut}" | jq -Mre '.model_name | values')";
+		fi
 		serial="$(echo "${smartOut}" | jq -Mre '.serial_number | values')"
 		{
 			# Create a simple header and drop the output of some basic smartctl commands
-            echo '<b>########## SMART status report for '"${drive}"' drive ('"${brand}: ${serial}"') ##########</b>'
-            smartctl -H -A -l error "/dev/${drive}"
-            # FixMe: bsd only; still waiting on suport for nvme tests in smartctl
-            if [ "${systemType}" = "BSD" ]; then
+			echo '<b>########## SMART status report for '"${drive}"' drive ('"${brand}: ${serial}"') ##########</b>'
+			smartctl -H -A -l error "/dev/${drive}"
+			echo "${smartTestOut}" | grep 'Num' | cut -c6- | head -1
+			echo "${smartTestOut}" | grep 'Extended' | cut -c6- | head -1
+			echo "${smartTestOut}" | grep 'Short' | cut -c6- | head -1
+			echo "${smartTestOut}" | grep 'Conveyance' | cut -c6- | head -1
+			echo '<br><br>'
+		} >> "${logfile}"
+
+	elif echo "${drive}" | grep -q "nvme"; then
+		# NVMe drives are handled separately because self tests are not yet supported.
+		# Gather brand and serial number of each drive
+		brand="$(echo "${smartOut}" | jq -Mre '.model_family | values')"
+		if [ -z "${brand}" ]; then
+			brand="$(echo "${smartOut}" | jq -Mre '.model_name | values')";
+		fi
+		serial="$(echo "${smartOut}" | jq -Mre '.serial_number | values')"
+		{
+			# Create a simple header and drop the output of some basic smartctl commands
+			echo '<b>########## SMART status report for '"${drive}"' drive ('"${brand}: ${serial}"') ##########</b>'
+			smartctl -H -A -l error "/dev/${drive}"
+			# FixMe: bsd only; still waiting on suport for nvme tests in smartctl
+			if [ "${systemType}" = "BSD" ]; then
 				nvmecontrol logpage -p 0x06 ${drive} | grep '\['
-            fi
-            echo '<br><br>'
+			fi
+			echo '<br><br>'
 		} >> "${logfile}"
-    fi
+	fi
 done
 
 # Remove some un-needed labels from the output
@@ -2290,12 +2290,12 @@ fi
 
 ### End details section, close MIME section
 (
-    echo '</pre>'
-    echo "--${boundary}--"
+	echo '</pre>'
+	echo "--${boundary}--"
 )  >> "${logfile}"
 
 ### Send report
 sendmail -ti < "${logfile}"
 if [ "${saveLogfile}" = "false" ]; then
-    rm "${logfile}"
+	rm "${logfile}"
 fi

From cb1e3933662ffb1ea9f8ad59681a6472dc68ea26 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sat, 4 Mar 2023 13:04:50 -0500
Subject: [PATCH 139/160] Fix version number.

---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 2a0c04d..c371c76 100644
--- a/README.md
+++ b/README.md
@@ -3,7 +3,7 @@ Original Script By: joeschmuck<br>
 Modified By: bidelu0hm, melp, fohlsso2, onlinepcwizard, ninpucho, isentropik, rotx, dak180<br>
 Last Edited By: dak180
 
-**Current Version: v1.7.5**
+**Current Version: v1.8**
 
 Preview of the output here: https://i.imgur.com/jKwraw4.png
 When a resilver is in progress: https://i.imgur.com/CUNUZ7r.png

From 41118723d5c8cc2cb8f21801f23e3a7e0a59968d Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sat, 4 Mar 2023 13:35:54 -0500
Subject: [PATCH 140/160] Use current names.

---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index c371c76..7667c83 100644
--- a/README.md
+++ b/README.md
@@ -23,7 +23,7 @@ Create a Cron Job with the following configuration:
 
 ```
 Description: Run Smart Report
-Command: /path/to/script/smartreport.sh -c /path/to/script/smartreport.conf
+Command: /path/to/script/report.sh -c /path/to/script/report.cfg
 Run as: root
 Schedule: Daily
 Hide Standard Output: **Checked**

From 49f487c57dc4ce8a0356b4cdc3207962ec495589 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sat, 4 Mar 2023 13:51:08 -0500
Subject: [PATCH 141/160] Account for NVMe drives not reporting temps.

---
 report.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/report.sh b/report.sh
index 1e87a04..8a9350a 100755
--- a/report.sh
+++ b/report.sh
@@ -700,9 +700,9 @@ EOF
 			fi
 
 			# Colorize temp
-			if [ "${temp}" -ge "${ssdTempCrit}" ]; then
+			if [ "${temp:=0}" -ge "${ssdTempCrit}" ]; then
 				local tempColor="${critColor}"
-			elif [ "${temp}" -ge "${ssdTempWarn}" ]; then
+			elif [ "${temp:=0}" -ge "${ssdTempWarn}" ]; then
 				local tempColor="${warnColor}"
 			else
 				local tempColor="${bgColor}"

From 7dbdf0d6edb8ccb7f4c6946064a77d09b643f67e Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sat, 4 Mar 2023 14:18:25 -0500
Subject: [PATCH 142/160] Try to handle more situations where we do not get
 data.

---
 report.sh | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/report.sh b/report.sh
index 8a9350a..fd8114f 100755
--- a/report.sh
+++ b/report.sh
@@ -739,7 +739,10 @@ EOF
 			fi
 
 			# Colorize Wear Leveling
-			if [ "${wearLeveling}" -le "${lifeRemainCrit}" ]; then
+			if [ -z "${wearLeveling}" ]; then
+				wearLeveling="N/A"
+				local wearLevelingColor="${bgColor}"
+			elif [ "${wearLeveling}" -le "${lifeRemainCrit}" ]; then
 				local wearLevelingColor="${critColor}"
 			elif [ "${wearLeveling}" -le "${lifeRemainWarn}" ]; then
 				local wearLevelingColor="${warnColor}"
@@ -774,7 +777,7 @@ EOF
 			fi
 
 			# Colorize test age
-			if [ "${testAge}" -gt "${testAgeWarn}" ]; then
+			if [ "${testAge:=0}" -gt "${testAgeWarn}" ]; then
 				local testAgeColor="${critColor}"
 			else
 				local testAgeColor="${bgColor}"
@@ -1039,7 +1042,7 @@ EOF
 			# Colorize Temp
 			if [ "${temp:="0"}" -ge "${ssdTempCrit}" ]; then
 				local tempColor="${critColor}"
-			elif [ "${temp}" -ge "${ssdTempWarn}" ]; then
+			elif [ "${temp:=0}" -ge "${ssdTempWarn}" ]; then
 				local tempColor="${warnColor}"
 			else
 				local tempColor="${bgColor}"
@@ -1390,7 +1393,7 @@ EOF
 			# Colorize Temp
 			if [ "${temp:="0"}" -ge "${tempCrit}" ]; then
 				local tempColor="${critColor}"
-			elif [ "${temp}" -ge "${tempWarn}" ]; then
+			elif [ "${temp:=0}" -ge "${tempWarn}" ]; then
 				local tempColor="${warnColor}"
 			else
 				local tempColor="${bgColor}"
@@ -1734,7 +1737,7 @@ EOF
 				# SAS SSD
 				if [ "${temp:="0"}" -ge "${ssdTempCrit}" ]; then
 					local tempColor="${critColor}"
-				elif [ "${temp}" -ge "${ssdTempWarn}" ]; then
+				elif [ "${temp:=0}" -ge "${ssdTempWarn}" ]; then
 					local tempColor="${warnColor}"
 				else
 					local tempColor="${bgColor}"
@@ -1743,7 +1746,7 @@ EOF
 				# SAS HDD
 				if [ "${temp:="0"}" -ge "${tempCrit}" ]; then
 					local tempColor="${critColor}"
-				elif [ "${temp}" -ge "${tempWarn}" ]; then
+				elif [ "${temp:=0}" -ge "${tempWarn}" ]; then
 					local tempColor="${warnColor}"
 				else
 					local tempColor="${bgColor}"

From bd072ace5c87df8d525fc2f5afdb11afb540ee48 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Tue, 7 Mar 2023 10:39:38 -0500
Subject: [PATCH 143/160] Minor edits.

Use current names.
---
 README.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index 7667c83..644c34e 100644
--- a/README.md
+++ b/README.md
@@ -33,9 +33,9 @@ Enabled: **Checked**
 
 Click `Submit` and then `Run Now`.
 
-A configuration file will be generated at `/path/to/script/smartreport.conf`
+A configuration file will be generated at `/path/to/script/report.cfg`
 
-**At a minimum, enter an email address for the report to be sent to and set `defaultFile` to 0 in the generated config file. Feel free to edit other user parameters as needed. Backup has been disabled by default so if it is required please set to true.**
+**At a minimum, enter an email address for the report to be sent to and set `defaultFile` to `0` in the generated config file. Feel free to edit other user parameters as needed. Backup has been disabled by default so if it is required please set to true.**
 
 Once you have updated the config file, click `Run Now` again to generate your first report.
 

From e86c4a55966b4dec7e0e3a6af210ac893d5d6108 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Tue, 14 Mar 2023 13:42:43 -0400
Subject: [PATCH 144/160] Support SAS drives that do not support json output
 better.

Also note drives that do not support test monitoring through smartctl.

Refs #20.
---
 report.sh | 95 +++++++++++++++++++++++++++++++++----------------------
 1 file changed, 58 insertions(+), 37 deletions(-)

diff --git a/report.sh b/report.sh
index fd8114f..1070a74 100755
--- a/report.sh
+++ b/report.sh
@@ -1558,30 +1558,35 @@ EOF
 				local lastTestStatus="$(echo "${sasInfoSmrt}" | jq -Mre '.ata_smart_self_test_log.standard.table[0].status.passed | values')"
 			fi
 
-			#FixMe: relies on non-json output
-			lastTestType="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '3,4')"
-			local runningNowTest="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '5,6,7,8,9')"
-			if [ "${runningNowTest}" = "Self test in progress ..." ]; then
-				lastTestHours="$(echo "${sasInfoSmrt}" | jq -Mre '.power_on_time.hours | values')"
-				lastTestStatus="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '12-15')"
-			else
-				lastTestHours="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '7')"
-				lastTestStatus="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '8-11')"
-			fi
-
-			# Mimic the true/false response expected from json in the future
-			if [ "${lastTestStatus}" = "- [- - -]" ]; then
-				lastTestStatus="true"
-			else
-				# Workaround for some drives that do not support self testing but still report a garbage self test log
-				# Set last test type to 'N/A' and last test hours to null "" in this case.  Do not colorize test status as a failure.
-				if [ "${lastTestType}" == "Default Self" ]; then
-					lastTestType="N/A"
+			# Try the non json output if we do not have a value
+			if [ -z "${lastTestType}" ]; then
+				local runningNowTest="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '5,6,7,8,9')"
+				lastTestType="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '3,4')"
+				# If test results are not reported warn
+				if [ -z "${lastTestType}" ]; then
+					lastTestType="N/A: testing not supported"
+					lastTestStatus="false"
 					lastTestHours=""
-					lastTestStatus="true"
+				# Try to pull the values out if they exist
+				elif [ "${runningNowTest}" = "Self test in progress ..." ]; then
+					lastTestHours="$(echo "${sasInfoSmrt}" | jq -Mre '.power_on_time.hours | values')"
+					lastTestStatus="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '12-15')"
 				else
-					lastTestStatus="false"
+					lastTestHours="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '7')"
+					lastTestStatus="$(echo "${nonJsonSasInfoSmrt}" | grep '# 1' | tr -s " " | cut -d ' ' -sf '8-11')"
 				fi
+				# Mimic the true/false response expected from json in the future
+				if [ "${lastTestStatus}" = "- [- - -]" ]; then
+					lastTestStatus="true"
+				fi
+			fi
+
+			# Workaround for some drives that do not support self testing but still report a garbage self test log
+			# Set last test type to 'N/A' and last test hours to null "" in this case.  Do not colorize test status as a failure.
+			if [ "${lastTestType}" == "Default Self" ]; then
+				lastTestType="N/A"
+				lastTestHours=""
+				lastTestStatus="true"
 			fi
 
 			# Available for any drive smartd knows about
@@ -1607,7 +1612,18 @@ EOF
 			local uncorrectedWriteErrors="$(echo "${sasInfoSmrt}" | jq -Mre '.write.total_uncorrected_errors | values')"
 			local uncorrectedVerifyErrors="$(echo "${sasInfoSmrt}" | jq -Mre '.verify.total_uncorrected_errors | values')"
 
-			#FixMe: relies on non-json output
+			# Try the non json output if we do not have a value
+			if [ -z "${uncorrectedReadErrors}" ]; then
+				uncorrectedReadErrors="$(echo "${nonJsonSasInfoSmrt}" | grep "read:" | tr -s " " | cut -d ' ' -sf '8')"
+			fi
+			if [ -z "${uncorrectedWriteErrors}" ]; then
+				uncorrectedWriteErrors="$(echo "${nonJsonSasInfoSmrt}" | grep "write:" | tr -s " " | cut -d ' ' -sf '8')"
+			fi
+			if [ -z "${uncorrectedVerifyErrors}" ]; then
+				uncorrectedVerifyErrors="$(echo "${nonJsonSasInfoSmrt}" | grep "verify:" | tr -s " " | cut -d ' ' -sf '8')"
+			fi
+
+			# FixMe: relies on non-json output
 			local nonMediumErrors="$(echo "${nonJsonSasInfoSmrt}" | grep "Non-medium" | tr -s " " | cut -d ' ' -sf '4')"
 			local accumStartStopCycles="$(echo "${nonJsonSasInfoSmrt}" | grep "Accumulated start-stop" | tr -s " " | cut -d ' ' -sf '4')"
 			local accumLoadUnloadCycles="$(echo "${nonJsonSasInfoSmrt}" | grep "Accumulated load-unload" | tr -s " " | cut -d ' ' -sf '4')"
@@ -1691,22 +1707,27 @@ EOF
 				fi
 			fi
 
-			local yrs="$(bc <<< "${onHours} / 8760")"
-			local mos="$(bc <<< "(${onHours} % 8760) / 730")"
-			local dys="$(bc <<< "((${onHours} % 8760) % 730) / 24")"
-			local hrs="$(bc <<< "((${onHours} % 8760) % 730) % 24")"
-
-			# Set Power-On Time format
-			if [ "${powerTimeFormat}" = "ymdh" ]; then
-				local onTime="${yrs}y ${mos}m ${dys}d ${hrs}h"
-			elif [ "${powerTimeFormat}" = "ymd" ]; then
-				local onTime="${yrs}y ${mos}m ${dys}d"
-			elif [ "${powerTimeFormat}" = "ym" ]; then
-				local onTime="${yrs}y ${mos}m"
-			elif [ "${powerTimeFormat}" = "y" ]; then
-				local onTime="${yrs}y"
+			# Handle power on time
+			if [ ! -z "${onHours}" ]; then
+				local yrs="$(bc <<< "${onHours} / 8760")"
+				local mos="$(bc <<< "(${onHours} % 8760) / 730")"
+				local dys="$(bc <<< "((${onHours} % 8760) % 730) / 24")"
+				local hrs="$(bc <<< "((${onHours} % 8760) % 730) % 24")"
+
+				# Set Power-On Time format
+				if [ "${powerTimeFormat}" = "ymdh" ]; then
+					local onTime="${yrs}y ${mos}m ${dys}d ${hrs}h"
+				elif [ "${powerTimeFormat}" = "ymd" ]; then
+					local onTime="${yrs}y ${mos}m ${dys}d"
+				elif [ "${powerTimeFormat}" = "ym" ]; then
+					local onTime="${yrs}y ${mos}m"
+				elif [ "${powerTimeFormat}" = "y" ]; then
+					local onTime="${yrs}y"
+				else
+					local onTime="${yrs}y ${mos}m ${dys}d ${hrs}h"
+				fi
 			else
-				local onTime="${yrs}y ${mos}m ${dys}d ${hrs}h"
+				local onTime="N/A: Drive not supported by smartctl"
 			fi
 
 			# Set the row background color

From b4026d9d2b16a086ec5447a6fb77dca47c5f1a6e Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Tue, 14 Mar 2023 19:17:57 -0400
Subject: [PATCH 145/160] Do not permanently set unknown values.

---
 report.sh | 80 +++++++++++++++++++++++++++----------------------------
 1 file changed, 40 insertions(+), 40 deletions(-)

diff --git a/report.sh b/report.sh
index 1070a74..6f1f057 100755
--- a/report.sh
+++ b/report.sh
@@ -700,9 +700,9 @@ EOF
 			fi
 
 			# Colorize temp
-			if [ "${temp:=0}" -ge "${ssdTempCrit}" ]; then
+			if [ "${temp:="0"}" -ge "${ssdTempCrit}" ]; then
 				local tempColor="${critColor}"
-			elif [ "${temp:=0}" -ge "${ssdTempWarn}" ]; then
+			elif [ "${temp:="0"}" -ge "${ssdTempWarn}" ]; then
 				local tempColor="${warnColor}"
 			else
 				local tempColor="${bgColor}"
@@ -714,7 +714,7 @@ EOF
 			fi
 
 			# Colorize log errors
-			if [ "${errorsLogs:=0}" -gt "${sectorsCrit}" ]; then
+			if [ "${errorsLogs:-"0"}" -gt "${sectorsCrit}" ]; then
 				local errorsLogsColor="${critColor}"
 			elif [ ! "${errorsLogs}" = "0" ]; then
 				local errorsLogsColor="${warnColor}"
@@ -723,7 +723,7 @@ EOF
 			fi
 
 			# Colorize warnings
-			if [ "${critWarning:=0}" -gt "${sectorsCrit}" ]; then
+			if [ "${critWarning:-"0"}" -gt "${sectorsCrit}" ]; then
 				local critWarningColor="${critColor}"
 			elif [ ! "${critWarning}" = "0" ]; then
 				local critWarningColor="${warnColor}"
@@ -777,7 +777,7 @@ EOF
 			fi
 
 			# Colorize test age
-			if [ "${testAge:=0}" -gt "${testAgeWarn}" ]; then
+			if [ "${testAge:-"0"}" -gt "${testAgeWarn}" ]; then
 				local testAgeColor="${critColor}"
 			else
 				local testAgeColor="${bgColor}"
@@ -1042,7 +1042,7 @@ EOF
 			# Colorize Temp
 			if [ "${temp:="0"}" -ge "${ssdTempCrit}" ]; then
 				local tempColor="${critColor}"
-			elif [ "${temp:=0}" -ge "${ssdTempWarn}" ]; then
+			elif [ "${temp:="0"}" -ge "${ssdTempWarn}" ]; then
 				local tempColor="${warnColor}"
 			else
 				local tempColor="${bgColor}"
@@ -1054,7 +1054,7 @@ EOF
 			fi
 
 			# Colorize Sector Errors
-			if [ "${reAlloc:=0}" -gt "${sectorsCrit}" ]; then
+			if [ "${reAlloc:-"0"}" -gt "${sectorsCrit}" ]; then
 				local reAllocColor="${critColor}"
 			elif [ ! "${reAlloc}" = "0" ]; then
 				local reAllocColor="${warnColor}"
@@ -1063,7 +1063,7 @@ EOF
 			fi
 
 			# Colorize Program Fail
-			if [ "${progFail:=0}" -gt "${sectorsCrit}" ]; then
+			if [ "${progFail:-"0"}" -gt "${sectorsCrit}" ]; then
 				local progFailColor="${critColor}"
 			elif [ ! "${progFail}" = "0" ]; then
 				local progFailColor="${warnColor}"
@@ -1072,7 +1072,7 @@ EOF
 			fi
 
 			# Colorize Erase Fail
-			if [ "${eraseFail:=0}" -gt "${sectorsCrit}" ]; then
+			if [ "${eraseFail:-"0"}" -gt "${sectorsCrit}" ]; then
 				local eraseFailColor="${critColor}"
 			elif [ ! "${eraseFail}" = "0" ]; then
 				local eraseFailColor="${warnColor}"
@@ -1081,7 +1081,7 @@ EOF
 			fi
 
 			# Colorize Offline Uncorrectable
-			if [ "${offlineUnc:=0}" -gt "${sectorsCrit}" ]; then
+			if [ "${offlineUnc:-"0"}" -gt "${sectorsCrit}" ]; then
 				local offlineUncColor="${critColor}"
 			elif [ ! "${offlineUnc}" = "0" ]; then
 				local offlineUncColor="${warnColor}"
@@ -1090,7 +1090,7 @@ EOF
 			fi
 
 			# Colorize CRC Errors
-			if [ ! "${crcErrors:=0}" = "0" ]; then
+			if [ ! "${crcErrors:-"0"}" = "0" ]; then
 				local crcErrorsColor="${warnColor}"
 			else
 				local crcErrorsColor="${bgColor}"
@@ -1134,7 +1134,7 @@ EOF
 			fi
 
 			# Colorize test age
-			if [ "${testAge:-0}" -gt "${testAgeWarn}" ]; then
+			if [ "${testAge:-"0"}" -gt "${testAgeWarn}" ]; then
 				local testAgeColor="${critColor}"
 			else
 				local testAgeColor="${bgColor}"
@@ -1216,7 +1216,7 @@ EOF
 		if [ -z "${rotTst}" ] && [ ! -z "$(echo "${hddInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[]? | select(.name == "Spin_Up_Time") | .id | values')" ]; then
 			rotTst="N/R"
 		fi
-		if [ ! "${rotTst:="0"}" = "0" ] && [ ! "${scsiTst}" = "scsi" ]; then
+		if [ ! "${rotTst:-"0"}" = "0" ] && [ ! "${scsiTst}" = "scsi" ]; then
 			# For each drive detected, run "smartctl -AHijl xselftest,selftest" and parse its output.
 			# After parsing the output, compute other values (last test's age, on time in YY-MM-DD-HH).
 			# After these computations, determine the row's background color (alternating as above, subbing in other colors from the palate as needed).
@@ -1393,7 +1393,7 @@ EOF
 			# Colorize Temp
 			if [ "${temp:="0"}" -ge "${tempCrit}" ]; then
 				local tempColor="${critColor}"
-			elif [ "${temp:=0}" -ge "${tempWarn}" ]; then
+			elif [ "${temp:="0"}" -ge "${tempWarn}" ]; then
 				local tempColor="${warnColor}"
 			else
 				local tempColor="${bgColor}"
@@ -1405,14 +1405,14 @@ EOF
 			fi
 
 			# Colorize Spin Retry Errors
-			if [ ! "${spinRetry:=0}" = "0" ]; then
+			if [ ! "${spinRetry:-"0"}" = "0" ]; then
 				local spinRetryColor="${warnColor}"
 			else
 				local spinRetryColor="${bgColor}"
 			fi
 
 			# Colorize Sector Errors
-			if [ "${reAlloc:=0}" -gt "${sectorsCrit}" ]; then
+			if [ "${reAlloc:-"0"}" -gt "${sectorsCrit}" ]; then
 				local reAllocColor="${critColor}"
 			elif [ ! "${reAlloc}" = "0" ]; then
 				local reAllocColor="${warnColor}"
@@ -1421,14 +1421,14 @@ EOF
 			fi
 
 			# Colorize Sector Event Errors
-			if [ ! "${reAllocEvent:=0}" = "0" ]; then
+			if [ ! "${reAllocEvent:-"0"}" = "0" ]; then
 				local reAllocEventColor="${warnColor}"
 			else
 				local reAllocEventColor="${bgColor}"
 			fi
 
 			# Colorize Pending Sector
-			if [ "${pending:=0}" -gt "${sectorsCrit}" ]; then
+			if [ "${pending:-"0"}" -gt "${sectorsCrit}" ]; then
 				local pendingColor="${critColor}"
 			elif [ ! "${offlineUnc}" = "0" ]; then
 				local pendingColor="${warnColor}"
@@ -1437,7 +1437,7 @@ EOF
 			fi
 
 			# Colorize Offline Uncorrectable
-			if [ "${offlineUnc:=0}" -gt "${sectorsCrit}" ]; then
+			if [ "${offlineUnc:-"0"}" -gt "${sectorsCrit}" ]; then
 				local offlineUncColor="${critColor}"
 			elif [ ! "${offlineUnc}" = "0" ]; then
 				local offlineUncColor="${warnColor}"
@@ -1446,21 +1446,21 @@ EOF
 			fi
 
 			# Colorize CRC Errors
-			if [ ! "${crcErrors:=0}" = "0" ]; then
+			if [ ! "${crcErrors:-"0"}" = "0" ]; then
 				local crcErrorsColor="${warnColor}"
 			else
 				local crcErrorsColor="${bgColor}"
 			fi
 
 			# Colorize Seek Error
-			if [ "${seekErrorHealth:=0}" -lt "100" ]; then
+			if [ "${seekErrorHealth:-"0"}" -lt "100" ]; then
 				local seekErrorHealthColor="${warnColor}"
 			else
 				local seekErrorHealthColor="${bgColor}"
 			fi
 
 			# Colorize test age
-			if [ "${testAge:-0}" -gt "${testAgeWarn}" ]; then
+			if [ "${testAge:-"0"}" -gt "${testAgeWarn}" ]; then
 				local testAgeColor="${critColor}"
 			else
 				local testAgeColor="${bgColor}"
@@ -1600,7 +1600,7 @@ EOF
 			local serial="$(echo "${sasInfoSmrt}" | jq -Mre '.serial_number | values')"
 			local rpm="$(echo "${sasInfoSmrt}" | jq -Mre '.rotation_rate | values')"
 			# SAS drives may be SSDs or HDDs
-			if [ "${rpm:-0}" = "0" ]; then
+			if [ "${rpm:-"0"}" = "0" ]; then
 				rpm="SSD"
 			fi
 			local temp="$(echo "${sasInfoSmrt}" | jq -Mre '.temperature.current | values')"
@@ -1623,7 +1623,7 @@ EOF
 				uncorrectedVerifyErrors="$(echo "${nonJsonSasInfoSmrt}" | grep "verify:" | tr -s " " | cut -d ' ' -sf '8')"
 			fi
 
-			# FixMe: relies on non-json output
+			# FixMe: relies entirely on non-json output
 			local nonMediumErrors="$(echo "${nonJsonSasInfoSmrt}" | grep "Non-medium" | tr -s " " | cut -d ' ' -sf '4')"
 			local accumStartStopCycles="$(echo "${nonJsonSasInfoSmrt}" | grep "Accumulated start-stop" | tr -s " " | cut -d ' ' -sf '4')"
 			local accumLoadUnloadCycles="$(echo "${nonJsonSasInfoSmrt}" | grep "Accumulated load-unload" | tr -s " " | cut -d ' ' -sf '4')"
@@ -1758,7 +1758,7 @@ EOF
 				# SAS SSD
 				if [ "${temp:="0"}" -ge "${ssdTempCrit}" ]; then
 					local tempColor="${critColor}"
-				elif [ "${temp:=0}" -ge "${ssdTempWarn}" ]; then
+				elif [ "${temp:="0"}" -ge "${ssdTempWarn}" ]; then
 					local tempColor="${warnColor}"
 				else
 					local tempColor="${bgColor}"
@@ -1767,7 +1767,7 @@ EOF
 				# SAS HDD
 				if [ "${temp:="0"}" -ge "${tempCrit}" ]; then
 					local tempColor="${critColor}"
-				elif [ "${temp:=0}" -ge "${tempWarn}" ]; then
+				elif [ "${temp:="0"}" -ge "${tempWarn}" ]; then
 					local tempColor="${warnColor}"
 				else
 					local tempColor="${bgColor}"
@@ -1780,37 +1780,37 @@ EOF
 			fi
 
 			# Colorize scsi Grown Defect List Errors
-			if [ "${scsiGrownDefectList:=0}" -gt "${sectorsCrit}" ]; then
+			if [ "${scsiGrownDefectList:-"0"}" -gt "${sectorsCrit}" ]; then
 				local scsiGrownDefectListColor="${critColor}"
-			elif [ ! "${scsiGrownDefectList}" = "0" ]; then
+			elif [ ! "${scsiGrownDefectList:-"0"}" = "0" ]; then
 				local scsiGrownDefectListColor="${warnColor}"
 			else
 				local scsiGrownDefectListColor="${bgColor}"
 			fi
 
 			# Colorize Read Errors
-			if [ ! "${uncorrectedReadErrors:=0}" = "0" ]; then
+			if [ ! "${uncorrectedReadErrors:-"0"}" = "0" ]; then
 				local uncorrectedReadErrorsColor="${warnColor}"
 			else
 				local uncorrectedReadErrorsColor="${bgColor}"
 			fi
 
 			# Colorize Write Errors
-			if [ ! "${uncorrectedWriteErrors:=0}" = "0" ]; then
+			if [ ! "${uncorrectedWriteErrors:-"0"}" = "0" ]; then
 				local uncorrectedWriteErrorsColor="${warnColor}"
 			else
 				local uncorrectedWriteErrorsColor="${bgColor}"
 			fi
 
 			# Colorize Verify Errors
-			if [ ! "${uncorrectedVerifyErrors:=0}" = "0" ]; then
+			if [ ! "${uncorrectedVerifyErrors:-"0"}" = "0" ]; then
 				local uncorrectedVerifyErrorsColor="${warnColor}"
 			else
 				local uncorrectedVerifyErrorsColor="${bgColor}"
 			fi
 
 			# Colorize test age
-			if [ "${testAge:-0}" -gt "${testAgeWarn}" ]; then
+			if [ "${testAge:-"0"}" -gt "${testAgeWarn}" ]; then
 				local testAgeColor="${critColor}"
 			else
 				local testAgeColor="${bgColor}"
@@ -1825,16 +1825,16 @@ EOF
 					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${serial}</td>
 					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${rpm}</td>
 					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${capacity}</td>
-					<td style="text-align:center; background-color:${smartStatusColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${smartStatus}</td>
+					<td style="text-align:center; background-color:${smartStatusColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${smartStatus:-"N/A"}</td>
 					<td style="text-align:center; background-color:${tempColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${temp}</td>
 					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${onTime}</td>
-					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${accumStartStopCycles}</td>
-					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${accumLoadUnloadCycles}</td>
-					<td style="text-align:center; background-color:${scsiGrownDefectListColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${scsiGrownDefectList}</td>
-					<td style="text-align:center; background-color:${uncorrectedReadErrorsColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${uncorrectedReadErrors}</td>
-					<td style="text-align:center; background-color:${uncorrectedWriteErrorsColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${uncorrectedWriteErrors}</td>
-					<td style="text-align:center; background-color:${uncorrectedVerifyErrorsColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${uncorrectedVerifyErrors}</td>
-					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${nonMediumErrors}</td>
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${accumStartStopCycles:-"N/A"}</td>
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${accumLoadUnloadCycles:-"N/A"}</td>
+					<td style="text-align:center; background-color:${scsiGrownDefectListColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${scsiGrownDefectList:-"N/A"}</td>
+					<td style="text-align:center; background-color:${uncorrectedReadErrorsColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${uncorrectedReadErrors:-"N/A"}</td>
+					<td style="text-align:center; background-color:${uncorrectedWriteErrorsColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${uncorrectedWriteErrors:-"N/A"}</td>
+					<td style="text-align:center; background-color:${uncorrectedVerifyErrorsColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${uncorrectedVerifyErrors:-"N/A"}</td>
+					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${nonMediumErrors:-"N/A"}</td>
 					<td style="text-align:center; background-color:${testAgeColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${testAge:-"N/A"}</td>
 					<td style="text-align:center; background-color:${lastTestStatusColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${lastTestType:-"N/A"}</td>
 					</tr>

From 1e520333d5982484c381727d635bc4a3f3e9ceca Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 19 Mar 2023 20:03:25 -0400
Subject: [PATCH 146/160] Fix nvme drive numbers.

---
 report.sh | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/report.sh b/report.sh
index 6f1f057..721e79f 100755
--- a/report.sh
+++ b/report.sh
@@ -751,7 +751,7 @@ EOF
 			fi
 
 			# Colorize & derive write stats
-			local totalBW="$(bc <<< "scale=1; (${totalLBA} * ${sectorSize}) / (1000^3)" | sed -e 's:^\.:0.:')"
+			local totalBW="$(bc <<< "scale=1; (${totalLBA} * ${sectorSize}) / (1000^4)" | sed -e 's:^\.:0.:')"
 			if (( $(bc -l <<< "${totalBW} > ${totalBWCrit}") )); then
 				local totalBWColor="${critColor}"
 			elif (( $(bc -l <<< "${totalBW} > ${totalBWWarn}") )); then
@@ -766,7 +766,7 @@ EOF
 			fi
 			# Try to not divide by zero
 			if [ ! "0" = "$(bc <<< "scale=1; ${onHours} / 24")" ]; then
-				local bwPerDay="$(bc <<< "scale=1; (((${totalLBA} * ${sectorSize}) / (1000^3)) * 1000) / (${onHours} / 24)" | sed -e 's:^\.:0.:')"
+				local bwPerDay="$(bc <<< "scale=1; (((${totalLBA} * ${sectorSize}) / (1000^4)) * 1000) / (${onHours} / 24)" | sed -e 's:^\.:0.:')"
 				if [ "${bwPerDay}" = "0.0" ]; then
 					bwPerDay="N/A"
 				else
@@ -1601,7 +1601,8 @@ EOF
 			local rpm="$(echo "${sasInfoSmrt}" | jq -Mre '.rotation_rate | values')"
 			# SAS drives may be SSDs or HDDs
 			if [ "${rpm:-"0"}" = "0" ]; then
-				rpm="SSD"
+				local percentUsed="$(echo "${sasInfoSmrt}" | jq -Mre '.scsi_percentage_used_endurance_indicator | values')"
+				rpm="SSD "
 			fi
 			local temp="$(echo "${sasInfoSmrt}" | jq -Mre '.temperature.current | values')"
 			local onHours="$(echo "${sasInfoSmrt}" | jq -Mre '.power_on_time.hours | values')"

From acbbfb4ce56a363f4e113a549481fc31ca19f5c5 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 19 Mar 2023 20:34:37 -0400
Subject: [PATCH 147/160] Really fix nvme drive numbers.

512 because apparently the NVMe spec uses magic numbers.
---
 report.sh | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/report.sh b/report.sh
index 721e79f..9553654 100755
--- a/report.sh
+++ b/report.sh
@@ -751,7 +751,8 @@ EOF
 			fi
 
 			# Colorize & derive write stats
-			local totalBW="$(bc <<< "scale=1; (${totalLBA} * ${sectorSize}) / (1000^4)" | sed -e 's:^\.:0.:')"
+			# 512 because apparently the NVMe spec uses magic numbers
+			local totalBW="$(bc <<< "scale=1; (${totalLBA} * 512) / (1000^3)" | sed -e 's:^\.:0.:')"
 			if (( $(bc -l <<< "${totalBW} > ${totalBWCrit}") )); then
 				local totalBWColor="${critColor}"
 			elif (( $(bc -l <<< "${totalBW} > ${totalBWWarn}") )); then
@@ -765,8 +766,9 @@ EOF
 				totalBW="${totalBW}TB"
 			fi
 			# Try to not divide by zero
+			# 512 because apparently the NVMe spec uses magic numbers
 			if [ ! "0" = "$(bc <<< "scale=1; ${onHours} / 24")" ]; then
-				local bwPerDay="$(bc <<< "scale=1; (((${totalLBA} * ${sectorSize}) / (1000^4)) * 1000) / (${onHours} / 24)" | sed -e 's:^\.:0.:')"
+				local bwPerDay="$(bc <<< "scale=1; (((${totalLBA} * 512) / (1000^3)) * 1000) / (${onHours} / 24)" | sed -e 's:^\.:0.:')"
 				if [ "${bwPerDay}" = "0.0" ]; then
 					bwPerDay="N/A"
 				else

From 43447d16782349873cc70fb53e5c9de2022221da Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 19 Mar 2023 22:02:39 -0400
Subject: [PATCH 148/160] Fallback for apple SSDs that do not have a stats page

---
 report.sh | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/report.sh b/report.sh
index 9553654..40fbf6a 100755
--- a/report.sh
+++ b/report.sh
@@ -911,6 +911,9 @@ EOF
 			# Get LBA written from the stats page for data written
 			if [ ! -z "$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_device_statistics.pages[0] | values')" ]; then
 				local totalLBA="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_device_statistics.pages[0].table[] | select(.name == "Logical Sectors Written") | .value | values')"
+			elif [ "$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 175) | .name | values')" = "Host_Writes_MiB" ]; then
+				# Fallback for apple SSDs that do not have a stats page
+				local totalLBA="$(bc <<< "($(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 175) | .raw.value | values') * (1024^2) / ${sectorSize})")"
 			else
 				local totalLBA="0"
 			fi
@@ -1058,7 +1061,7 @@ EOF
 			# Colorize Sector Errors
 			if [ "${reAlloc:-"0"}" -gt "${sectorsCrit}" ]; then
 				local reAllocColor="${critColor}"
-			elif [ ! "${reAlloc}" = "0" ]; then
+			elif [ ! "${reAlloc}" = "0" ] && [ ! -z "${reAlloc}" ]; then
 				local reAllocColor="${warnColor}"
 			else
 				local reAllocColor="${bgColor}"
@@ -1067,7 +1070,7 @@ EOF
 			# Colorize Program Fail
 			if [ "${progFail:-"0"}" -gt "${sectorsCrit}" ]; then
 				local progFailColor="${critColor}"
-			elif [ ! "${progFail}" = "0" ]; then
+			elif [ ! "${progFail}" = "0" ] && [ ! -z "${progFail}" ]; then
 				local progFailColor="${warnColor}"
 			else
 				local progFailColor="${bgColor}"
@@ -1076,7 +1079,7 @@ EOF
 			# Colorize Erase Fail
 			if [ "${eraseFail:-"0"}" -gt "${sectorsCrit}" ]; then
 				local eraseFailColor="${critColor}"
-			elif [ ! "${eraseFail}" = "0" ]; then
+			elif [ ! "${eraseFail}" = "0" ] && [ ! -z "${eraseFail}" ]; then
 				local eraseFailColor="${warnColor}"
 			else
 				local eraseFailColor="${bgColor}"
@@ -1085,7 +1088,7 @@ EOF
 			# Colorize Offline Uncorrectable
 			if [ "${offlineUnc:-"0"}" -gt "${sectorsCrit}" ]; then
 				local offlineUncColor="${critColor}"
-			elif [ ! "${offlineUnc}" = "0" ]; then
+			elif [ ! "${offlineUnc}" = "0" ] && [ ! -z "${offlineUnc}" ]; then
 				local offlineUncColor="${warnColor}"
 			else
 				local offlineUncColor="${bgColor}"
@@ -1155,12 +1158,12 @@ EOF
 					<td style="text-align:center; background-color:${tempColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${temp}</td>
 					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${onTime}</td>
 					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${startStop}</td>
-					<td style="text-align:center; background-color:${reAllocColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${reAlloc}</td>
-					<td style="text-align:center; background-color:${progFailColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${progFail}</td>
-					<td style="text-align:center; background-color:${eraseFailColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${eraseFail}</td>
-					<td style="text-align:center; background-color:${offlineUncColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${offlineUnc}</td>
-					<td style="text-align:center; background-color:${crcErrorsColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${crcErrors}</td>
-					<td style="text-align:center; background-color:${wearLevelingColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${wearLeveling:=N/A}%</td>
+					<td style="text-align:center; background-color:${reAllocColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${reAlloc:-N/A}</td>
+					<td style="text-align:center; background-color:${progFailColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${progFail:-N/A}</td>
+					<td style="text-align:center; background-color:${eraseFailColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${eraseFail:-N/A}</td>
+					<td style="text-align:center; background-color:${offlineUncColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${offlineUnc:-N/A}</td>
+					<td style="text-align:center; background-color:${crcErrorsColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${crcErrors:-N/A}</td>
+					<td style="text-align:center; background-color:${wearLevelingColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${wearLeveling:-N/A}%</td>
 					<td style="text-align:center; background-color:${totalBWColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${totalBW}</td>
 					<td style="text-align:center; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${bwPerDay}</td>
 					<td style="text-align:center; background-color:${testAgeColor}; height:25px; border:1px solid black; border-collapse:collapse; font-family:courier;">${testAge:-"N/A"}</td>

From b414aa281d54fb9f80da17aec16ad89b04e7ed1a Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 17 Apr 2023 13:24:40 -0400
Subject: [PATCH 149/160] Add a custom message for a missing `bc`.

---
 report.sh | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/report.sh b/report.sh
index d7fd98c..9c4814e 100755
--- a/report.sh
+++ b/report.sh
@@ -2035,6 +2035,9 @@ fi
 for command in "${commands[@]}"; do
 	if ! type "${command}" &> /dev/null; then
 		echo "${command} is missing, please install" >&2
+		if [ "${command}" = "bc" ]; then
+			echo "If you are on scale see https://ixsystems.atlassian.net/browse/NAS-115175 and https://github.com/dak180/FreeNAS-Report/pull/6#issuecomment-1422618352 for updates on when bc will be included in scale and how to add it in the meantime (this will need to be redone each upgrade)." >&2
+		fi
 		exit 100
 	fi
 done

From fa363908ba1d77577df5b0e1b2890487be862148 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Tue, 25 Apr 2023 11:11:10 -0400
Subject: [PATCH 150/160] Normalize white space before comparing.

Fixes #21.
---
 report.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/report.sh b/report.sh
index 862d87c..e7d62f9 100755
--- a/report.sh
+++ b/report.sh
@@ -2108,7 +2108,7 @@ else
 fi
 
 readarray -t "drives" <<< "$(for drive in ${localDriveList}; do
-	if smartctl -i "/dev/${drive}" | grep -q "SMART support is: Enabled"; then
+	if smartctl -i "/dev/${drive}" | sed -e 's:[[:blank:]]\{1,\}: :g' | grep -q "SMART support is: Enabled"; then
 		printf "%s " "${drive}"
 	elif echo "${drive}" | grep -q "nvme"; then
 		printf "%s " "${drive}"

From 0e9fd81a1e82d483e7e04f6105535e3c538ed3a1 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Tue, 25 Apr 2023 11:12:05 -0400
Subject: [PATCH 151/160] Fallback for seagate SSDs that do not have a stats
 page.

Refs #21.
---
 report.sh | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/report.sh b/report.sh
index e7d62f9..9b0f040 100755
--- a/report.sh
+++ b/report.sh
@@ -926,6 +926,9 @@ EOF
 			elif [ "$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 175) | .name | values')" = "Host_Writes_MiB" ]; then
 				# Fallback for apple SSDs that do not have a stats page
 				local totalLBA="$(bc <<< "($(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 175) | .raw.value | values') * (1024^2) / ${sectorSize})")"
+			elif [ "$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 241) | .name | values')" = "Total_LBAs_Written" ]; then
+				# Fallback for seagate SSDs that do not have a stats page
+				local totalLBA="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 241)"
 			else
 				local totalLBA="0"
 			fi

From d78d46137a1e4da53c002bfa392f3b608888dc6a Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Tue, 16 May 2023 11:22:31 -0400
Subject: [PATCH 152/160] Use single quotes where doubles are unnecessary.

Refs #22.
---
 report.sh | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/report.sh b/report.sh
index 9b0f040..c1994eb 100755
--- a/report.sh
+++ b/report.sh
@@ -1908,7 +1908,7 @@ function ReportUPS () {
 					echo "Real Power: ${ups_realpower}W"
 				fi
 				if [ ! -z "${ups_realpowernominal}" ]; then
-					echo "Real Power: ${ups_realpowernominal}W (nominal)"
+					echo "Real Power: ${ups_realpowernominal}W" '(nominal)'
 				fi
 				if [ ! -z "${ups_inputvoltage}" ]; then
 					echo "Input Voltage: ${ups_inputvoltage}V"
@@ -1928,7 +1928,7 @@ function ReportUPS () {
 			done
 	} >> "${logfile}"
 
-	echo "<br><br>" >> "${logfile}"
+	echo '<br><br>' >> "${logfile}"
 }
 
 function DumpFiles () {
@@ -2069,7 +2069,7 @@ for command in "${commands[@]}"; do
 	if ! type "${command}" &> /dev/null; then
 		echo "${command} is missing, please install" >&2
 		if [ "${command}" = "bc" ]; then
-			echo "If you are on scale see https://ixsystems.atlassian.net/browse/NAS-115175 and https://github.com/dak180/FreeNAS-Report/pull/6#issuecomment-1422618352 for updates on when bc will be included in scale and how to add it in the meantime (this will need to be redone each upgrade)." >&2
+			echo 'If you are on scale see https://ixsystems.atlassian.net/browse/NAS-115175 and https://github.com/dak180/FreeNAS-Report/pull/6#issuecomment-1422618352 for updates on when bc will be included in scale and how to add it in the meantime (this will need to be redone each upgrade).' >&2
 		fi
 		exit 100
 	fi
@@ -2085,8 +2085,8 @@ fi
 
 ###### Auto-generated Parameters
 host="$(hostname -s)"
-fromEmail="$(sqlite3 /data/freenas-v1.db "select em_fromemail from system_email;")"
-fromName="$(sqlite3 /data/freenas-v1.db "select em_fromname from system_email;")"
+fromEmail="$(sqlite3 /data/freenas-v1.db 'select em_fromemail from system_email;')"
+fromName="$(sqlite3 /data/freenas-v1.db 'select em_fromname from system_email;')"
 runDate="$(date '+%s')"
 if [ "${systemType}" = "BSD" ]; then
 	logfile="${logfileLocation}/$(date -r "${runDate}" '+%Y%m%d%H%M%S')_${logfileName}.tmp"

From 0a026cf9e98827646dbcd512b2fee0a51ba5ac67 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Tue, 16 May 2023 12:04:59 -0400
Subject: [PATCH 153/160] Fix quote.

Refs #22.
---
 report.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/report.sh b/report.sh
index c1994eb..806ee61 100755
--- a/report.sh
+++ b/report.sh
@@ -928,7 +928,7 @@ EOF
 				local totalLBA="$(bc <<< "($(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 175) | .raw.value | values') * (1024^2) / ${sectorSize})")"
 			elif [ "$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 241) | .name | values')" = "Total_LBAs_Written" ]; then
 				# Fallback for seagate SSDs that do not have a stats page
-				local totalLBA="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 241)"
+				local totalLBA="$(echo "${ssdInfoSmrt}" | jq -Mre '.ata_smart_attributes.table[] | select(.id == 241)')"
 			else
 				local totalLBA="0"
 			fi

From 25f35b1a69cb2e3e9a22e675d9197402dfacb286 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Tue, 16 May 2023 16:31:47 -0400
Subject: [PATCH 154/160] Make sure command are checked where required.

---
 report.sh | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/report.sh b/report.sh
index 806ee61..e980970 100755
--- a/report.sh
+++ b/report.sh
@@ -2044,6 +2044,7 @@ tail
 sendmail
 sort
 tee
+sqlite3
 )
 if [ "${systemType}" = "BSD" ]; then
 commands+=(
@@ -2051,12 +2052,15 @@ glabel
 nvmecontrol
 )
 fi
-if [ "${configBackup}" = "true" ]  || [ "${fileDump}" = "1" ]; then
+if [ "${configBackup}" = "true" ]; then
 commands+=(
-tar
-sqlite3
 md5sum
 sha256sum
+)
+fi
+if [ "${configBackup}" = "true" ]  || [ "${fileDump}" = "1" ]; then
+commands+=(
+tar
 base64
 )
 fi

From 30c92ee0b26062d9e49f85b60fb345194e44abf5 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Tue, 16 May 2023 18:19:17 -0400
Subject: [PATCH 155/160] Try to restore compatibility with TrueNAS 12.

Refs #23.
---
 report.sh | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/report.sh b/report.sh
index e980970..e517bd1 100755
--- a/report.sh
+++ b/report.sh
@@ -177,8 +177,16 @@ EOF
 		# Config integrity check passed; copy config db, generate checksums, make .tar.gz archive
 		sqlite3 "/data/freenas-v1.db" ".backup main /tmp/${filename}.db"
 		cp -f "/data/pwenc_secret" "/tmp/"
-		md5sum "/tmp/${filename}.db" > /tmp/config_backup.md5
-		sha256sum "/tmp/${filename}.db" > /tmp/config_backup.sha256
+		if [ ! -z "${MD5SUM}" ]; then
+			${MD5SUM} "/tmp/${filename}.db" > /tmp/config_backup.md5
+		else
+			md5sum "/tmp/${filename}.db" > /tmp/config_backup.md5
+		fi
+		if [ ! -z "${SHA256SUM}" ]; then
+			${SHA256SUM} "/tmp/${filename}.db" > /tmp/config_backup.sha256
+		else
+			sha256sum "/tmp/${filename}.db" > /tmp/config_backup.sha256
+		fi
 		(
 			cd "/tmp/" || exit;
 			tar -czf "${tarfile}" "./${filename}.db" "./config_backup.md5" "./config_backup.sha256" "./pwenc_secret"
@@ -2071,6 +2079,14 @@ upsc
 fi
 for command in "${commands[@]}"; do
 	if ! type "${command}" &> /dev/null; then
+		if [ "${command}" = "md5sum" ] && type "md5" &> /dev/null; then
+			MD5SUM="md5"
+			continue
+		fi
+		if [ "${command}" = "sha256sum" ] && type "sha256" &> /dev/null; then
+			SHA256SUM="sha256"
+			continue
+		fi
 		echo "${command} is missing, please install" >&2
 		if [ "${command}" = "bc" ]; then
 			echo 'If you are on scale see https://ixsystems.atlassian.net/browse/NAS-115175 and https://github.com/dak180/FreeNAS-Report/pull/6#issuecomment-1422618352 for updates on when bc will be included in scale and how to add it in the meantime (this will need to be redone each upgrade).' >&2

From 4b5c3e25b3726c5456576a0a8bbf835703c8f5f7 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Tue, 16 May 2023 20:11:41 -0400
Subject: [PATCH 156/160] Mitigate serial numbers with chars that cannot be
 used in bash vars.

Refs #23.
---
 report.sh | 75 ++++++++++++++++++++++++++++++++++---------------------
 1 file changed, 46 insertions(+), 29 deletions(-)

diff --git a/report.sh b/report.sh
index e517bd1..6cd1cde 100755
--- a/report.sh
+++ b/report.sh
@@ -133,6 +133,7 @@ saveLogfile="true"			# Change to "false" to delete the log file after creation
 ##### Drive Overrides
 # In the form: declare -A _<serial>
 # And then for each override: _<serial>[<value>]="<adjustment>"
+# Replace any - with _ in the serial.
 
 
 
@@ -631,33 +632,37 @@ EOF
 
 			## Make override adjustments
 			{
+			local serialClean
 			local serialMatch
+
+			serialClean="$(sed -e 's:-:_:' <<< "${serial}")"
+
 			# onHours
-			serialMatch="_${serial}[onHours]"
+			serialMatch="_${serialClean}[onHours]"
 			if [ ! -z "${!serialMatch}" ]; then
 				onHours="$(bc <<< "${onHours} ${!serialMatch}")"
 			fi
 
 			# mediaErrors
-			serialMatch="_${serial}[mediaErrors]"
+			serialMatch="_${serialClean}[mediaErrors]"
 			if [ ! -z "${!serialMatch}" ]; then
 				mediaErrors="$(bc <<< "${mediaErrors} ${!serialMatch}")"
 			fi
 
 			# errorsLogs
-			serialMatch="_${serial}[errorsLogs]"
+			serialMatch="_${serialClean}[errorsLogs]"
 			if [ ! -z "${!serialMatch}" ]; then
 				errorsLogs="$(bc <<< "${errorsLogs} ${!serialMatch}")"
 			fi
 
 			# critWarning
-			serialMatch="_${serial}[critWarning]"
+			serialMatch="_${serialClean}[critWarning]"
 			if [ ! -z "${!serialMatch}" ]; then
 				critWarning="$(bc <<< "${critWarning} ${!serialMatch}")"
 			fi
 
 			# wearLeveling
-			serialMatch="_${serial}[wearLeveling]"
+			serialMatch="_${serialClean}[wearLeveling]"
 			if [ ! -z "${!serialMatch}" ]; then
 				wearLeveling="$(bc <<< "${wearLeveling} ${!serialMatch}")"
 			fi
@@ -944,51 +949,55 @@ EOF
 
 			## Make override adjustments
 			{
+			local serialClean
 			local serialMatch
+
+			serialClean="$(sed -e 's:-:_:' <<< "${serial}")"
+
 			# lastTestHours
-			serialMatch="_${serial}[lastTestHours]"
+			serialMatch="_${serialClean}[lastTestHours]"
 			if [ ! -z "${!serialMatch}" ]; then
 				lastTestHours="$(bc <<< "${lastTestHours} ${!serialMatch}")"
 			fi
 
 			# onHours
-			serialMatch="_${serial}[onHours]"
+			serialMatch="_${serialClean}[onHours]"
 			if [ ! -z "${!serialMatch}" ]; then
 				onHours="$(bc <<< "${onHours} ${!serialMatch}")"
 			fi
 
 			# reAlloc
-			serialMatch="_${serial}[reAlloc]"
+			serialMatch="_${serialClean}[reAlloc]"
 			if [ ! -z "${!serialMatch}" ]; then
 				reAlloc="$(bc <<< "${reAlloc} ${!serialMatch}")"
 			fi
 
 			# progFail
-			serialMatch="_${serial}[progFail]"
+			serialMatch="_${serialClean}[progFail]"
 			if [ ! -z "${!serialMatch}" ]; then
 				progFail="$(bc <<< "${progFail} ${!serialMatch}")"
 			fi
 
 			# eraseFail
-			serialMatch="_${serial}[eraseFail]"
+			serialMatch="_${serialClean}[eraseFail]"
 			if [ ! -z "${!serialMatch}" ]; then
 				eraseFail="$(bc <<< "${eraseFail} ${!serialMatch}")"
 			fi
 
 			# offlineUnc
-			serialMatch="_${serial}[offlineUnc]"
+			serialMatch="_${serialClean}[offlineUnc]"
 			if [ ! -z "${!serialMatch}" ]; then
 				offlineUnc="$(bc <<< "${offlineUnc} ${!serialMatch}")"
 			fi
 
 			# crcErrors
-			serialMatch="_${serial}[crcErrors]"
+			serialMatch="_${serialClean}[crcErrors]"
 			if [ ! -z "${!serialMatch}" ]; then
 				crcErrors="$(bc <<< "${crcErrors} ${!serialMatch}")"
 			fi
 
 			# wearLeveling
-			serialMatch="_${serial}[wearLeveling]"
+			serialMatch="_${serialClean}[wearLeveling]"
 			if [ ! -z "${!serialMatch}" ]; then
 				wearLeveling="$(bc <<< "${wearLeveling} ${!serialMatch}")"
 			fi
@@ -1289,57 +1298,61 @@ EOF
 
 			## Make override adjustments
 			{
+			local serialClean
 			local serialMatch
+
+			serialClean="$(sed -e 's:-:_:' <<< "${serial}")"
+
 			# lastTestHours
-			serialMatch="_${serial}[lastTestHours]"
+			serialMatch="_${serialClean}[lastTestHours]"
 			if [ ! -z "${!serialMatch}" ]; then
 				lastTestHours="$(bc <<< "${lastTestHours} ${!serialMatch}")"
 			fi
 
 			# onHours
-			serialMatch="_${serial}[onHours]"
+			serialMatch="_${serialClean}[onHours]"
 			if [ ! -z "${!serialMatch}" ]; then
 				onHours="$(bc <<< "${onHours} ${!serialMatch}")"
 			fi
 
 			# reAlloc
-			serialMatch="_${serial}[reAlloc]"
+			serialMatch="_${serialClean}[reAlloc]"
 			if [ ! -z "${!serialMatch}" ]; then
 				reAlloc="$(bc <<< "${reAlloc} ${!serialMatch}")"
 			fi
 
 			# spinRetry
-			serialMatch="_${serial}[spinRetry]"
+			serialMatch="_${serialClean}[spinRetry]"
 			if [ ! -z "${!serialMatch}" ]; then
 				spinRetry="$(bc <<< "${spinRetry} ${!serialMatch}")"
 			fi
 
 			# reAllocEvent
-			serialMatch="_${serial}[reAllocEvent]"
+			serialMatch="_${serialClean}[reAllocEvent]"
 			if [ ! -z "${!serialMatch}" ]; then
 				reAllocEvent="$(bc <<< "${reAllocEvent} ${!serialMatch}")"
 			fi
 
 			# pending
-			serialMatch="_${serial}[pending]"
+			serialMatch="_${serialClean}[pending]"
 			if [ ! -z "${!serialMatch}" ]; then
 				pending="$(bc <<< "${pending} ${!serialMatch}")"
 			fi
 
 			# offlineUnc
-			serialMatch="_${serial}[offlineUnc]"
+			serialMatch="_${serialClean}[offlineUnc]"
 			if [ ! -z "${!serialMatch}" ]; then
 				offlineUnc="$(bc <<< "${offlineUnc} ${!serialMatch}")"
 			fi
 
 			# crcErrors
-			serialMatch="_${serial}[crcErrors]"
+			serialMatch="_${serialClean}[crcErrors]"
 			if [ ! -z "${!serialMatch}" ]; then
 				crcErrors="$(bc <<< "${crcErrors} ${!serialMatch}")"
 			fi
 
 			# seekErrorHealth
-			serialMatch="_${serial}[seekErrorHealth]"
+			serialMatch="_${serialClean}[seekErrorHealth]"
 			if [ ! -z "${!serialMatch}" ]; then
 				seekErrorHealth="$(bc <<< "${seekErrorHealth} ${!serialMatch}")"
 			fi
@@ -1660,45 +1673,49 @@ EOF
 
 			## Make override adjustments
 			{
+			local serialClean
 			local serialMatch
+
+			serialClean="$(sed -e 's:-:_:' <<< "${serial}")"
+
 			# lastTestHours
-			serialMatch="_${serial}[lastTestHours]"
+			serialMatch="_${serialClean}[lastTestHours]"
 			if [ ! -z "${!serialMatch}" ]; then
 				lastTestHours="$(bc <<< "${lastTestHours} ${!serialMatch}")"
 			fi
 
 			# onHours
-			serialMatch="_${serial}[onHours]"
+			serialMatch="_${serialClean}[onHours]"
 			if [ ! -z "${!serialMatch}" ]; then
 				onHours="$(bc <<< "${onHours} ${!serialMatch}")"
 			fi
 
 			# scsiGrownDefectList
-			serialMatch="_${serial}[scsiGrownDefectList]"
+			serialMatch="_${serialClean}[scsiGrownDefectList]"
 			if [ ! -z "${!serialMatch}" ]; then
 				scsiGrownDefectList="$(bc <<< "${scsiGrownDefectList} ${!serialMatch}")"
 			fi
 
 			# uncorrectedReadErrors
-			serialMatch="_${serial}[uncorrectedReadErrors]"
+			serialMatch="_${serialClean}[uncorrectedReadErrors]"
 			if [ ! -z "${!serialMatch}" ]; then
 				uncorrectedReadErrors="$(bc <<< "${uncorrectedReadErrors} ${!serialMatch}")"
 			fi
 
 			# uncorrectedWriteErrors
-			serialMatch="_${serial}[uncorrectedWriteErrors]"
+			serialMatch="_${serialClean}[uncorrectedWriteErrors]"
 			if [ ! -z "${!serialMatch}" ]; then
 				uncorrectedWriteErrors="$(bc <<< "${uncorrectedWriteErrors} ${!serialMatch}")"
 			fi
 
 			# uncorrectedVerifyErrors
-			serialMatch="_${serial}[uncorrectedVerifyErrors]"
+			serialMatch="_${serialClean}[uncorrectedVerifyErrors]"
 			if [ ! -z "${!serialMatch}" ]; then
 				uncorrectedVerifyErrors="$(bc <<< "${uncorrectedVerifyErrors} ${!serialMatch}")"
 			fi
 
 			# nonMediumErrors
-			serialMatch="_${serial}[nonMediumErrors]"
+			serialMatch="_${serialClean}[nonMediumErrors]"
 			if [ ! -z "${!serialMatch}" ]; then
 				nonMediumErrors="$(bc <<< "${nonMediumErrors} ${!serialMatch}")"
 			fi

From 782c4f1c7766d9c5e283be591557739fa78143e3 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Wed, 17 May 2023 11:36:53 -0400
Subject: [PATCH 157/160] Mitigate serial numbers with chars that cannot be
 used in bash vars more comprehensively.

Refs #23.
---
 report.sh | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/report.sh b/report.sh
index 6cd1cde..0fc3b22 100755
--- a/report.sh
+++ b/report.sh
@@ -133,7 +133,7 @@ saveLogfile="true"			# Change to "false" to delete the log file after creation
 ##### Drive Overrides
 # In the form: declare -A _<serial>
 # And then for each override: _<serial>[<value>]="<adjustment>"
-# Replace any - with _ in the serial.
+# Replace any non ascii alphanumeric characters with _ in the serial.
 
 
 
@@ -635,7 +635,7 @@ EOF
 			local serialClean
 			local serialMatch
 
-			serialClean="$(sed -e 's:-:_:' <<< "${serial}")"
+			serialClean="$(sed -e 's|[^[:alnum:]]|_|g' <<< "${serial}")"
 
 			# onHours
 			serialMatch="_${serialClean}[onHours]"
@@ -952,7 +952,7 @@ EOF
 			local serialClean
 			local serialMatch
 
-			serialClean="$(sed -e 's:-:_:' <<< "${serial}")"
+			serialClean="$(sed -e 's|[^[:alnum:]]|_|g' <<< "${serial}")"
 
 			# lastTestHours
 			serialMatch="_${serialClean}[lastTestHours]"
@@ -1301,7 +1301,7 @@ EOF
 			local serialClean
 			local serialMatch
 
-			serialClean="$(sed -e 's:-:_:' <<< "${serial}")"
+			serialClean="$(sed -e 's|[^[:alnum:]]|_|g' <<< "${serial}")"
 
 			# lastTestHours
 			serialMatch="_${serialClean}[lastTestHours]"
@@ -1676,7 +1676,7 @@ EOF
 			local serialClean
 			local serialMatch
 
-			serialClean="$(sed -e 's:-:_:' <<< "${serial}")"
+			serialClean="$(sed -e 's|[^[:alnum:]]|_|g' <<< "${serial}")"
 
 			# lastTestHours
 			serialMatch="_${serialClean}[lastTestHours]"

From 379d336ade2f6283ce24201e4031a9417f0fbdf4 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Wed, 17 May 2023 23:19:39 -0400
Subject: [PATCH 158/160] Create the backup location if it does not already
 exist.

Fix #23.
---
 report.sh | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/report.sh b/report.sh
index 0fc3b22..a2ad4ae 100755
--- a/report.sh
+++ b/report.sh
@@ -216,6 +216,9 @@ EOF
 
 		# If logfile saving is enabled, copy .tar.gz file to specified location before it (and everything else) is removed below
 		if [ "${saveBackup}" = "true" ]; then
+			if [ ! -d "backupLocation/" ]; then
+				mkdir -p "${backupLocation}/"
+			fi
 			cp "${tarfile}" "${backupLocation}/${filename}.tar.gz"
 		fi
 		rm "/tmp/${filename}.db"

From 7492cba0d8d17e832e4c2db4ccbe57951736c82a Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Sun, 21 May 2023 20:53:17 -0400
Subject: [PATCH 159/160] Add a sort for linux that will work with more than 24
 drives.

---
 report.sh | 25 ++++++++++++++++++-------
 1 file changed, 18 insertions(+), 7 deletions(-)

diff --git a/report.sh b/report.sh
index a2ad4ae..428cf0b 100755
--- a/report.sh
+++ b/report.sh
@@ -2150,13 +2150,24 @@ else
 	# lsblk -n -l -o NAME -E PKNAME | tr '\n' ' '
 fi
 
-readarray -t "drives" <<< "$(for drive in ${localDriveList}; do
-	if smartctl -i "/dev/${drive}" | sed -e 's:[[:blank:]]\{1,\}: :g' | grep -q "SMART support is: Enabled"; then
-		printf "%s " "${drive}"
-	elif echo "${drive}" | grep -q "nvme"; then
-		printf "%s " "${drive}"
-	fi
-done | tr ' ' '\n' | sort -V | sed '/^nvme/!H;//p;$!d;g;s:\n::')"
+if [ "${systemType}" = "BSD" ]; then
+	# This sort breaks on linux when going to four leter drive ids: "sdab"; it works fine for bsd's numbered drive ids though.
+	readarray -t "drives" <<< "$(for drive in ${localDriveList}; do
+		if smartctl -i "/dev/${drive}" | sed -e 's:[[:blank:]]\{1,\}: :g' | grep -q "SMART support is: Enabled"; then
+			printf "%s\n" "${drive}"
+		elif echo "${drive}" | grep -q "nvme"; then
+			printf "%s\n" "${drive}"
+		fi
+	done | sort -V | sed '/^nvme/!H;//p;$!d;g;s:\n::')"
+else
+	readarray -t "drives" <<< "$(for drive in ${localDriveList}; do
+		if smartctl -i "/dev/${drive}" | sed -e 's:[[:blank:]]\{1,\}: :g' | grep -q "SMART support is: Enabled"; then
+			printf "%s\n" "${#drive} ${drive}"
+		elif echo "${drive}" | grep -q "nvme"; then
+			printf "%s\n" "${#drive} ${drive}"
+		fi
+	done | sort -Vbk 1 -k 2 | cut -d ' ' -f 2 | sed '/^nvme/!H;//p;$!d;g;s:\n::')"
+fi
 
 # Toggles the 'ssdExist' flag to true if SSDs are detected in order to add the summary table
 if [ "${includeSSD}" = "true" ]; then

From 1eb4c042e318d9c04c7be41e61cf4e86afd7eef0 Mon Sep 17 00:00:00 2001
From: dak180 <dak180@users.sourceforge.net>
Date: Mon, 26 Jun 2023 14:23:56 -0400
Subject: [PATCH 160/160] Allow use of `$(dirname "${configFile}")/usr/bin/`
 for `bc`.

This should survive updates.

Refs #6.
---
 report.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/report.sh b/report.sh
index 428cf0b..5fa4ca8 100755
--- a/report.sh
+++ b/report.sh
@@ -2054,7 +2054,7 @@ if [[ "$(uname -mrs)" =~ .*"BSD".* ]]; then
 fi
 
 # Check if needed software is installed.
-PATH="${PATH}:/usr/local/sbin:/usr/local/bin"
+PATH="${PATH}:/usr/local/sbin:/usr/local/bin:$(dirname "${configFile}")/usr/bin/"
 commands=(
 hostname
 date
@@ -2109,7 +2109,7 @@ for command in "${commands[@]}"; do
 		fi
 		echo "${command} is missing, please install" >&2
 		if [ "${command}" = "bc" ]; then
-			echo 'If you are on scale see https://ixsystems.atlassian.net/browse/NAS-115175 and https://github.com/dak180/FreeNAS-Report/pull/6#issuecomment-1422618352 for updates on when bc will be included in scale and how to add it in the meantime (this will need to be redone each upgrade).' >&2
+			echo "If you are on scale see https://ixsystems.atlassian.net/browse/NAS-115175 and https://github.com/dak180/FreeNAS-Report/pull/6#issuecomment-1422618352 for updates on when bc will be included in scale and how to add it in the meantime (this will need to be redone each upgrade or you could put it in: $(dirname "${configFile}")/usr/bin/)." >&2
 		fi
 		exit 100
 	fi
@@ -2348,7 +2348,7 @@ for drive in "${drives[@]}"; do
 			smartctl -H -A -l error "/dev/${drive}"
 			# FixMe: bsd only; still waiting on suport for nvme tests in smartctl
 			if [ "${systemType}" = "BSD" ]; then
-				nvmecontrol logpage -p 0x06 ${drive} | grep '\['
+				nvmecontrol logpage -p 0x06 "${drive}" | grep '\['
 			fi
 			echo '<br><br>'
 		} >> "${logfile}"