atls: add handshake timeout to aTLS servers and clients #1255
+52
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgerdev
force-pushed
the
burgerdev/atls-server-timeout
branch
from
b764797 to
96dd4ac
Compare
burgerdev
force-pushed
the
burgerdev/atls-server-timeout
branch
from
96dd4ac to
a0a4e2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is factored out from #1244. We want to explicitly configure timeouts on the server side that are smaller than on the client side, otherwise the client will only ever see a connection timeout, which can mean a lot of things. If the server times out, the client will now receive a TLS error 80, which can then be diagnosed with the documentation from #1245.
Contrary to the documentation, I found that
MinConnectionTimeoutis rather aConnectionTimeoutthat will be applied to the TCP+TLS connection.