Raise exception for invalid card details (#134)

Co-authored-by: Taimoor Ahmed <taimoor.ahmed@A006-00933.local>
edly-io · Aug 2, 2023 · 10a1455 · 10a1455
1 parent 87490ee
commit 10a1455
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 2 deletions.
diff --git a/ecommerce/extensions/payment/processors/authorizenet.py b/ecommerce/extensions/payment/processors/authorizenet.py
@@ -14,7 +14,7 @@
 )
 from authorizenet.constants import constants
 from django.urls import reverse
-from oscar.apps.payment.exceptions import GatewayError
+from oscar.apps.payment.exceptions import GatewayError, TransactionDeclined
 from oscar.core.loading import get_class, get_model
 
 from ecommerce.core.url_utils import get_ecommerce_url
@@ -469,13 +469,31 @@ def get_transaction_parameters(self, basket, request=None, **kwargs):
                     if hasattr(response.transactionResponse, 'errors'):
                         logger.info('Error Code:  %s' % str(response.transactionResponse.errors.error[0].errorCode))
                         logger.info('Error Message: %s' % response.transactionResponse.errors.error[0].errorText)
+                        self.handle_processor_response(response, basket)
+                        raise TransactionDeclined(
+                            'Payment error: {}'.format(
+                                response.transactionResponse.errors.error[0].errorText
+                            )
+                        )
             else:
                 if hasattr(response, 'transactionResponse') and hasattr(response.transactionResponse, 'errors'):
                     logger.info('Error Code: %s' % str(response.transactionResponse.errors.error[0].errorCode))
                     logger.info('Error Message: %s' % response.transactionResponse.errors.error[0].errorText)
+                    self.handle_processor_response(response, basket)
+                    raise TransactionDeclined(
+                            'Payment error: {}'.format(
+                                response.transactionResponse.errors.error[0].errorText
+                            )
+                        )
                 else:
                     logger.info('Error Code: %s' % response.messages.message[0]['code'].text)
                     logger.info('Error Message: %s' % response.messages.message[0]['text'].text)
+                    self.handle_processor_response(response, basket)
+                    raise TransactionDeclined(
+                            'Payment Gateway error: {}'.format(
+                                response.messages.message[0]['text'].text
+                            )
+                        )
 
         return response
 

diff --git a/ecommerce/extensions/payment/views/authorizenet.py b/ecommerce/extensions/payment/views/authorizenet.py
@@ -13,6 +13,7 @@
 from django.utils.decorators import method_decorator
 from django.views.decorators.csrf import csrf_exempt
 from oscar.apps.partner import strategy
+from oscar.apps.payment.exceptions import TransactionDeclined
 from oscar.core.loading import get_class, get_model
 from rest_framework.views import APIView
 
@@ -267,6 +268,18 @@ class AuthorizenetClientView(EdxOrderPlacementMixin, BasePaymentSubmitView):
     def payment_processor(self):
         return AuthorizenetClient(self.request.site)
 
+    def post(self, request):  # pylint: disable=unused-argument
+        form_kwargs = self.get_form_kwargs()
+        form = self.form_class(**form_kwargs)
+
+        try:
+            if form.is_valid():
+                return self.form_valid(form)
+        except (TransactionDeclined) as exp:
+            return HttpResponse('Transcaction was declined due to {}'.format(str(exp)), status=400)
+
+        return self.form_invalid(form)
+
     def form_valid(self, form):
         form_data = form.cleaned_data
         basket = form_data['basket']

diff --git a/ecommerce/static/js/payment_processors/authorizenet.js b/ecommerce/static/js/payment_processors/authorizenet.js
@@ -25,10 +25,12 @@ define([
             $cardCode.attr('required', true);
             $expiryMonth.attr('required', true);
             $expiryYear.attr('required', true);
+            $expiryMonth.attr('maxLength', 2);
+            $expiryYear.attr('maxLength', 2);
 
             $cardNumber.keyup(function () {
                 $('.help-block-card').html('');
-                if (!CreditCardUtils.isValidCardNumber($cardNumber.val())) {
+                if ($cardNumber.val() !== '' && !CreditCardUtils.isValidCardNumber($cardNumber.val())) {
                     $('.help-block-card').css('color', 'red').html('*Invalid Card Number');
                 }
             });