Skip to content

Commit

Permalink
Fixing 500 error on dev due to Site Config validation funtion (#125)
Browse files Browse the repository at this point in the history
  • Loading branch information
madnihamza1841 authored Feb 23, 2023
1 parent 50c6ca2 commit b2412cc
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions ecommerce/extensions/edly_ecommerce_app/api/v1/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
validate_site_configurations,
get_payment_processors_names,
get_payments_site_configuration,
validate_site_configurations,
validate_site_configurations_for_self_service_api,
validate_site_theme,
)
from ecommerce.extensions.edly_ecommerce_app.permissions import CanAccessSiteCreation
Expand Down Expand Up @@ -232,7 +232,7 @@ def post(self, request):
if not ecom_data and not site_theme:
return Response('Invalid payload.', status=status.HTTP_400_BAD_REQUEST)

validations_messages = validate_site_configurations(ecom_data)
validations_messages = validate_site_configurations_for_self_service_api(ecom_data)
validations_messages += validate_site_theme(site_theme)

if validations_messages:
Expand Down
10 changes: 5 additions & 5 deletions ecommerce/extensions/edly_ecommerce_app/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -271,16 +271,16 @@ def validate_django_settings_overrides(request_data):
return validation_messages


def validate_site_configurations(request_data):
def validate_site_configurations_for_self_service_api(request_data):
"""
Validates the allowed Site COnfigurations.
Validates the allowed Site Configurations.
Arguments:
request_data (dict): Request data passed for site config.
Returns:
validation_messages (list): Invalid fields information.
"""
validation_messages = []

Expand All @@ -302,12 +302,12 @@ def validate_site_theme(site_theme):
Returns:
validation_messages (list): Invalid fields information.
"""
validation_messages = []
if site_theme and site_theme not in getattr(settings, 'ALLOWED_SITE_THEMES', []):
validation_messages.append(dict(field='{} is not allowed in Site Themes'.format(site_theme)))

return validation_messages


Expand Down

0 comments on commit b2412cc

Please sign in to comment.