Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding suggested function name changes #96

Closed
wants to merge 2 commits into from
Closed

Adding suggested function name changes #96

wants to merge 2 commits into from

Conversation

KingYamato
Copy link

@KingYamato KingYamato commented Dec 11, 2019 •
edited by kevinlul
Loading

For #90

@kevinlul kevinlul added the draft label Dec 11, 2019
@edo9300
Copy link
Owner

edo9300 commented Dec 11, 2019 •
edited
Loading

Keep the naming convention consistent with the other functions: Card_HasAttackedDirectly->card_has_attacked_directly, etc.

kevinlul
kevinlul approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@kevinlul kevinlul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to update the script repositories accordingly. Thanks for following through!

@kevinlul
Copy link
Contributor

Branch imported as rename-lua

@kevinlul kevinlul closed this Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinlul kevinlul kevinlul approved these changes

Assignees
No one assigned
Labels
draft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KingYamato @edo9300 @kevinlul