Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove external clients api package #238

Closed
wants to merge 1 commit into from

Conversation

Ang-m4
Copy link
Contributor

@Ang-m4 Ang-m4 commented Feb 11, 2025

Description

This PR removes the deprecated api_clients package, which has been replaced by the updated external_api_clients package. The changes include revising and sorting import statements and deleting the outdated package.

Testing

SMS Vendors

I sent an SMS to check if the service was available. Although I didn't receive the expected response, the 401 status code is enough proof that it's working.

sms_vendor_test_eox_nelp

Copy link

This PR exceeds the recommended size of 1000 lines. Check if you are NOT addressing multiple issues with one PR. If is not the case continue the review process.

@Ang-m4 Ang-m4 force-pushed the afg/remove-nelc-api-clients branch from 8f3be39 to 13342a5 Compare February 11, 2025 17:16
Copy link

This PR exceeds the recommended size of 1000 lines. Check if you are NOT addressing multiple issues with one PR. If is not the case continue the review process.

1 similar comment
Copy link

This PR exceeds the recommended size of 1000 lines. Check if you are NOT addressing multiple issues with one PR. If is not the case continue the review process.

@Ang-m4 Ang-m4 marked this pull request as ready for review February 11, 2025 17:48
@Ang-m4 Ang-m4 force-pushed the afg/remove-nelc-api-clients branch from b0f7a72 to 95138dc Compare February 11, 2025 17:52
Copy link

This PR exceeds the recommended size of 1000 lines. Check if you are NOT addressing multiple issues with one PR. If is not the case continue the review process.

@Ang-m4
Copy link
Contributor Author

Ang-m4 commented Feb 14, 2025

Since the changes in this PR exceed the recommended size of 1000 lines, I decided to split it into several smaller PRs that will be submitted soon. Additionally, I noticed an issue with the person_engine client package that needed to be addressed first.

@Ang-m4 Ang-m4 closed this Feb 14, 2025
@Ang-m4 Ang-m4 deleted the afg/remove-nelc-api-clients branch February 14, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant