Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused auth client package #242

Conversation

Ang-m4
Copy link
Contributor

@Ang-m4 Ang-m4 commented Feb 14, 2025

Description

This PR removes the unused authenticators module from the deprecated api_clients package.

@Ang-m4 Ang-m4 marked this pull request as ready for review February 14, 2025 16:07
@Ang-m4 Ang-m4 requested a review from johanseto February 14, 2025 16:07
Copy link
Collaborator

@andrey-canon andrey-canon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folder is still there, please remove it
image

@Ang-m4
Copy link
Contributor Author

Ang-m4 commented Feb 24, 2025

All set! The folder was already removed from the repository, but since Git does not track empty folders, it might still exist locally on your filesystem.

image

@Ang-m4 Ang-m4 requested a review from andrey-canon February 24, 2025 13:48
Copy link
Collaborator

@andrey-canon andrey-canon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ang-m4 Ang-m4 merged commit eec6905 into afg/certificates-api-client-removal Feb 24, 2025
7 checks passed
@Ang-m4 Ang-m4 deleted the afg/api-clients-auth-package-removal branch February 24, 2025 19:34
Ang-m4 added a commit that referenced this pull request Feb 24, 2025
Ang-m4 added a commit that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants