Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update futurex api client package #247

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

Ang-m4
Copy link
Contributor

@Ang-m4 Ang-m4 commented Feb 14, 2025

Description

This PR removes the unused futurex module from the deprecated api_clients package.

Changes

I just deleted the unused modules and test, and change the necessary imports to the updated external_api_clients package.

@github-actions github-actions bot added test size/m m lines label labels Feb 14, 2025
@Ang-m4 Ang-m4 marked this pull request as ready for review February 14, 2025 19:35
@Ang-m4 Ang-m4 requested a review from johanseto February 14, 2025 19:35
Copy link
Collaborator

@andrey-canon andrey-canon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ang-m4 Ang-m4 force-pushed the afg/sms-vendor-removal branch from aa6d6a1 to 615c962 Compare February 24, 2025 14:13
Base automatically changed from afg/sms-vendor-removal to master February 24, 2025 19:38
@Ang-m4 Ang-m4 force-pushed the afg/futurex-api-client-removal branch from da38721 to 1405c02 Compare February 24, 2025 20:09
@Ang-m4
Copy link
Contributor Author

Ang-m4 commented Feb 24, 2025

I updated the commit message adding some minor changes.
The enrollment_progress method was renamed to send_enrollment_progress.

@Ang-m4 Ang-m4 merged commit 21d574a into master Feb 24, 2025
7 checks passed
@Ang-m4 Ang-m4 deleted the afg/futurex-api-client-removal branch February 24, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/m m lines label test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants