fix: update sms vendor api client package #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eox_nelp/signals/tasks.py
Outdated
| @@ -61,7 +61,7 @@ def _post_futurex_progress(data): | |||
| data (dict): dict to send to futurex enrollment-progress path. | |||
| """ | |||
| api_client = FuturexApiClient() | |||
| response = api_client.enrollment_progress(data) | |||
| response = api_client.enrollment_progress(data) # pylint: disable=no-member | |||
There was a problem hiding this comment.
Why are you changing this line ?
There was a problem hiding this comment.
That line was changed because at some cases the GitHub checks as well as the local quality tests kept failing showing the Pylint no-member error.
Seems now that its not necessary.
There was a problem hiding this comment.
I have tested the quality tests and if I remove this changes the result is the same, please revert this
Ang-m4
force-pushed
the
afg/sms-vendor-removal
branch
from
aa6d6a1 to
615c962
Compare
|
I updated the commit message as it now reflects the changes intention. |
johanseto
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I removed the unused
sms_vendormodule from the deprecatedapi_clientspackage. imports were updated.Testing
I sent an SMS to check if the service was available. Although I didn't receive the expected response, the 401 status code is enough proof that it's working.