Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add beforeSend to RUM init #33

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Conversation

jsnwesson
Copy link
Member

@jsnwesson jsnwesson commented Jul 16, 2024

This PR is to resolve an issue posted in edx-arch-experiment. The goal is to allow for MFEs to edit or customize their event attributes before sending them to Datadog, so a suggested solution was to use the built-in beforeSend method from Datadog (documentation).

An example of how this is being used can be found in an edx-internal PR for Profile MFE that aims to clean usernames from the URL strings.

This PR also allows for the beforeSend method to be used more generally across all MFEs if desired.

@jsnwesson jsnwesson force-pushed the jwesson/content-group-rum-routes branch from cc9fc4e to deebed0 Compare July 16, 2024 20:07
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (edit: with a small nit/suggestion)! Though I defer to your team as final reviewer :)

Co-authored-by: Adam Stankiewicz <agstanki@gmail.com>
@jsnwesson jsnwesson force-pushed the jwesson/content-group-rum-routes branch from 689276a to 6ec7e31 Compare July 16, 2024 21:22
@jsnwesson jsnwesson merged commit 1c8ea2f into master Jul 17, 2024
5 checks passed
@jsnwesson jsnwesson deleted the jwesson/content-group-rum-routes branch July 17, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants