Send scan code on key down instead of key up

[dgrilawidbanana]

This feels more natural to me.

[eeriemyxi]

Can you try:

    loop = asyncio.get_running_loop()
    last_scan_code = None

    while True:
        try:
            event = await loop.run_in_executor(None, keyboard.read_event)
        except RuntimeError:
            await asyncio.sleep(0.1)
            continue

        log.debug("Got event: %s", event)

        if event.event_type is keyboard.KEY_UP:
            last_scan_code = None
            continue
        
        if event.scan_code == last_scan_code:
            continue
       
        last_scan_code = event.scan_code

        log.debug(f"Sending {event.scan_code=} from {event=}")
        await websocket.send(str(event.scan_code))

... And see if it works the same. I've checked the source code of keyboard and it sends either UP or DOWN event. So the first clause of the elif statement is redundant.

[eeriemyxi]

Ah, I never noticed that I made the listener not do their job properly. Now that I see, the same issue is in the Linux listener as well; I guess I'll patch that one when I am free.

[dgrilawidbanana]

I added if event.event_type is not keyboard.KEY_DOWN in imitation of the original, which used if event.event_type is not keyboard.KEY_UP instead of if event.event_type is keyboard.KEY_DOWN. If you'd like, I can move it to the second operand of and, so it will sometimes be short circuited and affect performance less. As it is impossible for both if statements to be executed, there is no difference between two if statements and an elif statement. Using elif is, to me, more readable and makes more sense. The else statement, however, is redundant.

[eeriemyxi]

I've used the style presented here throughout rest of the code, doing it in another style here brings inconsistency. If you reproduce the same behaviour in your tests, I'd appreciate if you make a commit copying that style (I'm fine with doing it myself if necessary.)