Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier #38

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Prettier #38

merged 2 commits into from
Oct 23, 2024

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Oct 9, 2024

There is no consistency here (but now there is)

CHANGELOG.md Outdated
* `decorator-transforms`
* [#35](https://github.com/ef4/decorator-transforms/pull/35) Remove unintentional change that was part of #33 ([@ef4](https://github.com/ef4))

- `decorator-transforms`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably wouldn't have prettier apply to the changelog since it's auto-generated 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rogerroger.gif

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@NullVoxPopuli
Copy link
Contributor Author

lockfile ... absent? wat

@NullVoxPopuli
Copy link
Contributor Author

NullVoxPopuli commented Oct 23, 2024

ah, there is no pnpm version enforcement / guidance
Hopefully fixes: #39

Add some ignores and revert the CHANGELOG fixes

eh

ye
@ef4 ef4 merged commit 61207bc into ef4:main Oct 23, 2024
2 checks passed
@NullVoxPopuli NullVoxPopuli deleted the prettier branch October 23, 2024 23:13
@github-actions github-actions bot mentioned this pull request Nov 1, 2024
@ef4 ef4 added the internal label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants