Re-add browser support via removing tsup #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
Nov 5, 2024
|
|
||
| // TS can't find declarations for this package (there aren't any) | ||
| // @ts-ignore | ||
| import decoratorSyntax from '@babel/plugin-syntax-decorators'; |
There was a problem hiding this comment.
the "fix" is actually just being less weird 🎉
NullVoxPopuli
changed the title
NullVoxPopuli
changed the title
NullVoxPopuli
commented
Nov 5, 2024
There was a problem hiding this comment.
changed because vite-plugin-dts uses this file to determine how to format the output types, and I didn't want to change the package.json#exports
NullVoxPopuli
commented
Nov 5, 2024
| @@ -0,0 +1,14 @@ | |||
| { | |||
There was a problem hiding this comment.
old tsconfig.json copied here for swc-register to use
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related discussion:
Manual Testing (all successes):
pnpm testpnpm dev:browser(orpnpm vite) -- see output as in Don't use node APIs (require) #37