Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon fails to handle missing srcset #344

Closed
Volbla opened this issue Jan 14, 2024 · 1 comment
Closed

Addon fails to handle missing srcset #344

Volbla opened this issue Jan 14, 2024 · 1 comment
Labels

Comments

@Volbla
Copy link

Volbla commented Jan 14, 2024

Image picka used to work on fantia.jp. One day it suddenly stopped working and just showed a popup message: "a is undefined", but it only happens on some pages. I think the problem is when a source-tag doesn't have a srcset property.

Steps to reproduce the behavior:

  1. Go to fantia.jp Content Warning: Contains adult content, although it is mostly censored if you're not logged in.
  2. On the main page and users search pages the addon works fine. (searching requries login)
  3. On the posts search page, user frontpages /fanclubs/1234, user galleries /fanclubs/1234/posts and individual posts /posts/1234 i get the error popup and the picker window never opens.

I decided to poke around in the debugger and it seems like the issue is elements missing the expected properties. The first i noticed was srcset, which apparently can happen if the image hasn't loaded in yet or if it's a censored low-res thumbnail, html examples. If it's the former, the addon starts working again if i first scroll down to load the missing images.

There might also be an issue with trying to get the .alt of a picture element.

@Volbla Volbla added the bug label Jan 14, 2024
@eight04
Copy link
Owner

eight04 commented Aug 12, 2024

Do you use Chrome? Might be fixed in #351

@eight04 eight04 closed this as completed Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants