Skip to content

Commit 09e8d44

Browse files
store more as dense chunks
1 parent e4c08e1 commit 09e8d44

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/DistributedNDArray.hxx

+2-1
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,8 @@ void DistributedNDArray<T, dims, DenseT, SparseT, SerializerT>::WriteChunk(const
104104
std::size_t num_elems = chunk.volume();
105105

106106
// pays off to store as sparse chunk
107-
std::size_t sparse_vs_dense_expense_ratio = 3; // sparse storage is approximately 3x as expensive as dense storage per nonzero element
107+
// std::size_t sparse_vs_dense_expense_ratio = 3; // when only counting storage space: sparse storage is approximately 3x as expensive as dense storage per nonzero element
108+
std::size_t sparse_vs_dense_expense_ratio = 20; // when also counting complexity of deserializing + rebuilding a dense chunk
108109
if(sparse_vs_dense_expense_ratio * num_nonzero_elems < num_elems) {
109110

110111
std::cout << "going to sparsify" << std::endl;

0 commit comments

Comments
 (0)