Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump System.Diagnostics.PerformanceCounter to 8.0 #2357

Closed
tomap opened this issue May 21, 2024 · 2 comments
Closed

Bump System.Diagnostics.PerformanceCounter to 8.0 #2357

tomap opened this issue May 21, 2024 · 2 comments
Labels

Comments

@tomap
Copy link

tomap commented May 21, 2024

In the last version of Elastic.Apm, you are using System.Diagnostics.PerformanceCounter version 6.0.1

If you were to bump it to version 8.0.0, you'd also bump System.Configuration.ConfigurationManager
which has one less dependency: it does not include a reference to System.Security.Permissions
see:
https://www.nuget.org/packages/System.Configuration.ConfigurationManager/7.0.0#dependencies-body-tab
vs
https://www.nuget.org/packages/System.Configuration.ConfigurationManager/#dependencies-body-tab

It would make Elastic.Apm lighter

Thank you

@tomap tomap added the enhancement New feature or request label May 21, 2024
@thompson-tomo
Copy link
Contributor

@tomap i have already gone and implemented a nicer solution via https://github.com/elastic/apm-agent-dotnet/pull/2308/files which will be in the next release. That MR has eliminated the need for a number of dependencies on the newer TFM'S.

@tomap
Copy link
Author

tomap commented May 28, 2024

Awesome! Thank you

@tomap tomap closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants