Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid profiler method integrations #2349

Merged
merged 1 commit into from
May 13, 2024

Conversation

stevejgordon
Copy link
Contributor

In a default .NET Framework ASP.NET app, when adding the profiler auto-instrumentation, the profiler logs report:

[ERROR] No rejit method found for target: System.Data.SqlClient.SqlCommand.ExecuteNonQuery
[ERROR] No rejit method found for target: System.Data.SqlClient.SqlCommand.ExecuteScalar

On review, this is due to the instrumentation attempting to locate overloads of these methods accepting CommandBehavior. The only library where these seem to apply is System.Data.SQLite.

@stevejgordon stevejgordon force-pushed the fix-profiler-integrations branch from da3858d to ad11508 Compare May 13, 2024 09:22
@stevejgordon stevejgordon force-pushed the fix-profiler-integrations branch from ad11508 to 20d49af Compare May 13, 2024 10:06
@gregkalapos gregkalapos self-requested a review May 13, 2024 12:54
Copy link
Contributor

@gregkalapos gregkalapos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stevejgordon stevejgordon merged commit aaa175f into main May 13, 2024
11 checks passed
@stevejgordon stevejgordon deleted the fix-profiler-integrations branch May 13, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants