Skip to content

Commit ccefb5f

Browse files
committed
test(tedious): stop testing some older tedious versions with Node.js 14
This was necessitated by a transitive dep of tedious breaking support for Node.js versions earlier than 16. Closes: #3926
1 parent 539c315 commit ccefb5f

File tree

2 files changed

+15
-8
lines changed

2 files changed

+15
-8
lines changed

.tav.yml

+11-4
Original file line numberDiff line numberDiff line change
@@ -325,12 +325,19 @@ tedious:
325325
- versions: '11.0.0 || 11.8.0' # first and last subset of '11.x'
326326
node: '>=10.17.0'
327327
commands: node test/instrumentation/modules/tedious.test.js
328-
# first and last majors subset of '12.x || 13.x || 14.x'
328+
# First and last majors subset of '12.x || 13.x || 14.x'.
329+
# These advertise a min-supported Node.js version of 12.3.0. However,
330+
# as of @azure/core-rest-pipeline@1.15.0 they effectively have a
331+
# min-working Node.js of >=16 (possibly >=18).
329332
- versions: '12.0.0 || 12.3.0 || 13.0.0 || 13.2.0 || 14.0.0 || 14.7.0 || >14.7.0 <15'
330-
node: '>=12.3.0'
333+
node: '>=16'
331334
commands: node test/instrumentation/modules/tedious.test.js
332-
- versions: '15.0.0 || 15.1.3 || >15.1.3 <16' # first and last majors subset of '15.x'
333-
node: '>=14'
335+
# First and last majors subset of '15.x'.
336+
# These advertise a min-supported Node.js version of 14. However,
337+
# as of @azure/core-rest-pipeline@1.15.0 they effectively have a
338+
# min-working Node.js of >=16 (possibly >=18).
339+
- versions: '15.0.0 || 15.1.3 || >15.1.3 <16'
340+
node: '>=16'
334341
commands: node test/instrumentation/modules/tedious.test.js
335342
- versions: '16.0.0 || 16.1.0 || >16.1.0 <17' # first and last majors subset of '16.x'
336343
node: '>=16'

test/instrumentation/modules/tedious.test.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@ const tediousVer =
2525
const semver = require('semver');
2626
if (
2727
(semver.gte(tediousVer, '17.0.0') && semver.lt(process.version, '18.0.0')) ||
28-
(semver.gte(tediousVer, '16.0.0') && semver.lt(process.version, '16.0.0')) ||
29-
(semver.gte(tediousVer, '15.0.0') && semver.lt(process.version, '14.0.0')) ||
30-
(semver.gte(tediousVer, '12.0.0') && semver.lt(process.version, '12.3.0')) ||
31-
(semver.gte(tediousVer, '11.0.0') && semver.lt(process.version, '10.17.0'))
28+
// tedious@11 and later depend on @azure/identity v1 or v2. As of
29+
// @azure/core-rest-pipeline@1.15.0 (a dep of @azure/identity), support for
30+
// Node.js <16 has been broken.
31+
(semver.gte(tediousVer, '11.0.0') && semver.lt(process.version, '16.0.0'))
3232
) {
3333
console.log(
3434
`# SKIP tedious@${tediousVer} does not support node ${process.version}`,

0 commit comments

Comments
 (0)