-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add kafkajs instrumentation #3786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. I am sorry for taking so long to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/test tav kafkajs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of nits.
test/instrumentation/modules/kafkajs/fixtures/use-kafkajs-each-message.js
Outdated
Show resolved
Hide resolved
I see that this MR is already at the final stage, isn't it? Thanks for your efforts for shipping such a valuable changes. |
Co-authored-by: Trent Mick <trent.mick@elastic.co>
Co-authored-by: Trent Mick <trent.mick@elastic.co>
@trentm I've also updated the test expectations for the latest changes in span names. Now tests are green :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/test tav kafkajs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Nice work.
PR to add
kafkajs
instrumentation. Summary of additionsinstrument
send
&sendBatch
methods ofkafkajs producers
instruments
eachMessage
ofkafkajs consumers
trace_id
if traceparent present in message headersinstruments
eachBatch
ofkafkajs consumers
links
if traceparent present in message headersCloses: #2905
Checklist