Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(tedious): stop testing some older tedious versions with Node.js 14 #3927

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

trentm
Copy link
Member

@trentm trentm commented Mar 21, 2024

This was necessitated by a transitive dep of tedious breaking support
for Node.js versions earlier than 16.

Closes: #3926

This was necessitated by a transitive dep of tedious breaking support
for Node.js versions earlier than 16.

Closes: #3926
@trentm trentm requested a review from david-luna March 21, 2024 17:04
@trentm trentm self-assigned this Mar 21, 2024
@david-luna
Copy link
Member

@trentm do you think it would make sense to merge/simplify the ranges?

  • versions <13 could be merged and set `node: >=14.0.0``
  • is there any specific reason to test latest-majors including x.0.0 versions? Could this be simplified to latest-majors or latest-minors?

Copy link
Member

@david-luna david-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test tav tedious

david-luna
david-luna previously approved these changes Mar 21, 2024
@trentm
Copy link
Member Author

trentm commented Mar 21, 2024

do you think it would make sense to merge/simplify the ranges?
...

Merging ranges and using "latest-majors" sounds good to me. Done in commit ea6013c
After that change, here are the current tedious versions that will be tested for node 14, 16, and 18:

% TAV=tedious node14 ./node_modules/.bin/tav --verbose --dry-run | rg matching
-- 1 package versions matching filter: 11.8.0
-- 10 package versions matching filter: 1.15.0, 2.7.1, 3.0.1, 4.2.0, 5.0.3, 6.7.1, 7.0.0, 8.3.1, 9.2.3, 10.0.0

% TAV=tedious node16 ./node_modules/.bin/tav --verbose --dry-run | rg matching
-- 5 package versions matching filter: 12.3.0, 13.2.0, 14.7.0, 15.1.3, 16.7.1
-- 1 package versions matching filter: 11.8.0
-- 10 package versions matching filter: 1.15.0, 2.7.1, 3.0.1, 4.2.0, 5.0.3, 6.7.1, 7.0.0, 8.3.1, 9.2.3, 10.0.0

% TAV=tedious node18 ./node_modules/.bin/tav --verbose --dry-run | rg matching
-- 2 package versions matching filter: 17.0.0, 18.1.0
-- 5 package versions matching filter: 12.3.0, 13.2.0, 14.7.0, 15.1.3, 16.7.1
-- 1 package versions matching filter: 11.8.0
-- 10 package versions matching filter: 1.15.0, 2.7.1, 3.0.1, 4.2.0, 5.0.3, 6.7.1, 7.0.0, 8.3.1, 9.2.3, 10.0.0

Copy link
Member Author

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test tav tedious

@trentm trentm requested a review from david-luna March 21, 2024 23:13
@trentm trentm merged commit a7c9201 into main Mar 22, 2024
23 checks passed
@trentm trentm deleted the trentm/tav-tedious-workaround branch March 22, 2024 15:36
PeterEinberger pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
…14 (elastic#3927)

This was necessitated by a transitive dep of tedious (`@azure/core-rest-pipeline`)
breaking support for Node.js versions earlier than 16.

Closes: elastic#3926
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TAV failing for tedious@15.1.3
2 participants