Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): ensure our npm options are used during make-distribution #3969

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

trentm
Copy link
Member

@trentm trentm commented Apr 11, 2024

Fixes: #3968


  • Once this is in, then move the v4.5.1 tag to that commit and ensure the release works.

@trentm trentm requested a review from david-luna April 11, 2024 18:59
@trentm trentm self-assigned this Apr 11, 2024
@trentm trentm mentioned this pull request Apr 11, 2024
@trentm trentm merged commit 1bdb233 into main Apr 11, 2024
18 checks passed
@trentm trentm deleted the trentm/release-fix-make-dist branch April 11, 2024 22:53
@trentm
Copy link
Member Author

trentm commented Apr 11, 2024

  • Once this is in, then move the v4.5.1 tag to that commit and ensure the release works.

Or not:

% git push origin :v4.5.1
remote: error: GH006: Protected tag update failed for refs/tags/v4.5.1.
remote: error: You're not authorized to delete a protected tag
To github.com:elastic/apm-agent-nodejs.git
 ! [remote rejected]   v4.5.1 (protected tag hook declined)
error: failed to push some refs to 'github.com:elastic/apm-agent-nodejs.git'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release fails in make-distribution.sh step
2 participants